ilyena_sylph: (Dreamwidth "d", rainbow-colored by Sophie) (Dreamwidth)
[personal profile] ilyena_sylph
Hey everyone!

Somehow we looked around at it had been an entire year since we did a code tour. What the heck even is time?

This is... not great, so here I am trying to write one for everything that's been done in the last year. Strap in, things might get a bit exciting!

Not every change is live right at this moment, but will be soon (hopefully)!

lots and lots of fixed problems! )

56 total issues resolved
Contributors: [github.com profile] alierak, [github.com profile] belatedly, [github.com profile] chebegeek, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] pauamma
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)
[personal profile] momijizukamori
Quick code tour, all of which is now live on the site!

I apologize in advance for the less-clever-than-usual categories )

46 total issues resolved (plus some duplicates closed)
Contributors: [github.com profile] alierak, [github.com profile] cmho, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] rahaeli
kareila: "Mom, I'm hungry." "Hush, I'm coding. You ate yesterday." (coding)
[personal profile] kareila
Coming soon... to a web site near you... very near... here, in fact. Right here in front of you. This is the site. The one that you're reading right now. Yes, you! Here is your personal guide to our last month's worth of code changes, which should be going live sometime in the next few days.

Step right this way... )

89 total issues resolved
Contributors: [github.com profile] alierak, [github.com profile] cmho, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] pauamma, [github.com profile] zorkian
ilyena_sylph: (Dreamwidth "d", rainbow-colored by Sophie) (Dreamwidth)
[personal profile] ilyena_sylph
Hello Interwebs!

It is time for a code tour again, and I'm the fool that volunteered to do it! (I'm pretty sure the devs would almost prefer I didn't, because I have to ask so many questions, but it's kind of fun anyway. Part of the time, I even learn things!)

Our amazing devs have been hard at work to make things better for everyone, here are some of the recent/upcoming changes for your perusal!

so many fixes! )


58 total issues resolved
Contributors: [github.com profile] alierak, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] rahaeli, all of whom are awesome.

And warmest of welcomes to new contributor [github.com profile] cmho!!! Thank you for the fixes!
ilyena_sylph: (Dreamwidth "d", rainbow-colored by Sophie) (Dreamwidth)
[personal profile] ilyena_sylph
Wait, what, a Code Tour? The last was only last month three months ago. What is happening?!

A lot, actually! Some old hands and some new people have been very busy about making things better! Soon (hopefully) all of this will go live and things will be even better around here!

bug fixes, code machete, site improvemets and cruft banishing below )


32 total issues resolved
Contributors: [github.com profile] Vivtek, [github.com profile] alansill, [github.com profile] alierak, [github.com profile] chebegeek, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] rahaeli, [github.com profile] zorkian

To the people who actually do the work, if I got anything wrong after all the help, please let me know and I'll edit!
kareila: Rosie the Riveter "We Can Do It!" with a DW swirl (dw)
[personal profile] kareila
Yes, I know we just did one three hours two weeks ago, but all these changes are already live on the site, Skipper! Let's get cracking!

Read more... )

21 total issues resolved
Contributors: [github.com profile] alierak, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] zorkian
azurelunatic: Dreamwidth is powered by [disco ball] (dw disco)
[personal profile] azurelunatic
Today we have 26 closed issues, most of which are improvements that were pushed live a few hours back. The 2022-01-01 to 2022-05-07 code tour will also be live now.


Issue 145: Add site scheme name as a body tag class (pull request) (nonfree pull request)
Category: Fun Browser Tricks, Accessibility, User scripts
Patch by: [github.com profile] momijizukamori
Description: This makes it easier for folks who like to modify their browser's display of websites to make site-skinned Dreamwidth pages do interesting and/or accessibility-customized stuff.

Issue 686: Add 'Indexed' style by wiring
Category: Closed but not done, Tidying Extremely Old Issues
Patch by: n/a
Description: This style was withdrawn (maker was still working on it, may have submitted it through another ticket when finished)

Issue 689: Add 'Suit Yourself' style by flamingchemist
Category: Closed but not done, Tidying Extremely Old Issues
Patch by: n/a
Description: Momiji was going through and found that some crucial components to add this just weren't there.

Issue 1856: CSS in Tabula Rasa overrides height attribute in IMG tag
Category: Rendered Obsolete, Tidying Extremely Old Issues
Patch by: n/a
Description: Momiji says: "We've updated the code handling image resizing in entries and comments, so I'm going to close this as any current issues are most likely something exciting and new."

Issue 1890: issues with various site elements on Windows phone
Category: Rendered Obsolete, Seven Years Is Basically Dead in Electronics Years, Tidying Extremely Old Issues
Patch by: n/a
Description: When someone with a Windows phone has a problem with this again, these issues can be revisited.


Allowing Embeds:
[github.com profile] chebegeek went on an allow-embed spree! Thank you! Here are some of the results.

Peertube on stopthatimp.net: domain no longer hosting
Allowed: Blogtalk, Podomatic, Streamable, getyarn.io, Smugmug, MSNBC, Reddit

8 Embed tickets )


Issue 2711: update Github user profile icon to HTTPS (pull request)
Category: HTTPS everywhere
Patch by: [github.com profile] RMHolsen
Description: The SSL proxy will now do the right thing with Github's little site icon.

Issue 2887: allow <details> and <summary> elements in comments (pull request)
Category: Spoiler handling, HTML5 my beloved, Overenthusiastic HTML cleaner
Patch by: [github.com profile] momijizukamori
Description:
HOLY WOW THIS WORKS IN COMMENTS NOW The DW/LJ/spoiler cut has been amazing for entries since it came out on LJ, and HTML5 only recently (oh myyyy, HTML5 has been around for how many years???) -- anyway, it caught up, and it's been available to use in entries in addition to the venerable cut. But comments have not been able to use it! (Because the HTML cleaner is extremely suspicious of anything that could possibly used for evil. Because it's better from a security standpoint to disallow first and ask questions later.) And okay so people have found some BALLER ways to hide spoilers in comments and honestly I'm in awe, but this is the way that HTML 5 wants you to do it:
<details>
<summary>Spoiler warning</summary>
Spoiler details go here! Go wild!!!! IT'S LIVE NOW!!!!!!
</details>
This HTML 5 syntax can be used in comments for spoilers, games, sensitive content, or whatever now.

Issue 2902: the password length in the "change email" form needs to be larger
Category: Making things make sense, 72 is bigger than 50
Patch by: [personal profile] zorkian, possibly dev-on-prod
Description: Dreamwidth allows quite a bit of annoyance to anyone who might want to crack your passwords. (Usually the value to a hacker of any random person's online presence is your good search engine reputation, and they can sell your login to spammers who dearly want search engines to pick up their bad links.) It would also be good to be able to change your stale or potentially compromised password to something of an equally obnoxious length, but prior to the new year's code push, the maximum the form allowed was 50 characters, instead of 72 like it ought to have been. Please look into using a password manager, which will remember unique and random character passwords for all of your logins, in a way that storing them in your brain maybe won't.

Issue 2949: convert /manage/banusers to TT (pull request)
Category: The Great Template Toolkit Conversion, Resisting the urge for a complete rewrite
Patch by: [github.com profile] momijizukamori
Description: Yet another page converted away from Brad's Markup Language. Momiji says: "Part of the ongoing crusade eliminate BML from the codebase! One page down, many more to go..."
[staff profile] mark says: "Woo! Thank you! Every time I review one of these, I have these itches to rewrite the Perl so it's more modern and cleaner... but then I realize that would make this project take 10x as long. Soooo nope. Discretion is the better part of valor or something."
[staff profile] denise says: "Only one endless modernization project that everybody hates at a time, Mark."
It's not that we hate it as such, but sometimes things move or look different and generally that's no fun even when it's attached to necessary fixes.

Issue 2951: Fix send-email working on dreamhacks (pull request)
Category: Developers need love too, A Strongly Worded Letter to Cloudflare
Patch by: [github.com profile] momijizukamori
Description: Momiji says: "When we moved email notifications to AWS, we accidentally broke email sending from DreamHacks, because the AWS mailer uses some options sendmail on the hack box does not. This now checks if those options are set before trying to use them, and skipping them if not."

Issue 2952: Add a link for Discord to contrib docs (pull request)
Category: The Wheel of Time turns, Discord, dev communications
Patch by: [github.com profile] momijizukamori
Description: Momiji says: "We moved to using Discord for dev communication rather than IRC, but this was not linked anywhere helpful in the repo itself. This has now been fixed!"
One of the hard problems in online communication is moderation and platform management. IRC in particular is hard to keep as open to new people looking for a little help with development, while still keeping out the people who would prefer to fill it with rude appendages and worse. It also helps to have a platform that people are comfortable using. And these days the sweet spot seems to be Discord.

Issue 2953: Convert /tools pages to TT (pull request)
Category: The Great Template Toolkit Conversion
Patch by: [github.com profile] momijizukamori
Description: See a BML page, fix a BML page.

Issue 2958: <details>/<summary> tags have no styling in sitescheme
Category: CSS hijinks, HTML5 my beloved
Patch by: [github.com profile] momijizukamori
Description: The little sideways triangle that accompanies a cut tag also accompanies the <details> tag, except the CSS was taking that away on site themed pages. Momiji: "Which is very silly in this case, and once I'm sure it won't make other bits of the site layout go haywire I'm gonna see about fixing that."

Issue 2959: Restore ability to apply user CSS to siteschemes (pull request)
Category: Accessibility, Fun Browser Tricks, Technically it's "site skin" but it was site scheme on LJ soooooo...
Patch by: [github.com profile] momijizukamori
Description: Adds a class to body tags for Tropospherical Red & Purple, on Foundation pages. Or, if you were trying to use a userscript and it was failing on some pages for no good reason, try again?

Issue 2964: Don't override browser display for details and summary (pull request)
Category: #2958, Browser hijinks, HTML5 my beloved
Patch by: [github.com profile] momijizukamori
Description: Momiji says: "The details HTML element is basically a nice little native expand/collapse that allows you to hide and unhide blocks of text. By default, browsers usually style it with a little arrow at the side to indicate that it can be expanded and collapsed. We, however, had some CSS fixes for old browsers (IE and very old versions of Firefox) that didn't support this newer element - which were probably added when those browsers weren't super old and it was actually a good idea - that caused the arrow to vanish entirely for all browsers. Very silly. Now that we are in the future, those workarounds can be removed!"

Issue 2965: Protected foundation (pull request)
Category: The Great De-BML-ening, Foundation
Patch by: [github.com profile] momijizukamori
Description: Momiji says: "More dragging of pages into the 21st century! Note: this does move OpenID login one click away on the page - this choice was made to better match the regular login modal, to make the design more visually balanced, and because the standalone OpenID page has a better explanation of what OpenID is and how to use it."

Issue 2970: Add Beta flag for new inbox redesign (pull request)
Category: Beta Testing, Inbox Update
Patch by: [github.com profile] momijizukamori
Description: Momiji says: "After we accidentally pushed the inbox update live without planning to, and got a bunch of feedback, we realized we uhhhh should probably make it a beta, until we get all the bugs ironed out, as it's a pretty major rewrite of the code."
Here's the [site community profile] dw_maintenance entry: Switching to hCaptcha + Beta Inbox available
Beta features page

Issue 2978: Tweaks to the new inbox design (pull request)
Category: Beta Testing, Inbox Update
Patch by: [github.com profile] momijizukamori
Description: Round one of tweaks to the new inbox design, based on user feedback!
  • Unread items are now expanded by default
  • Fixed bad word-wrapping settings
  • Added a touch of margin to timestamps so they don't run up right against subject lines
  • Added the 'unsent' filter view back in.
  • Add controls back to the bottom of the message list



26 total issues resolved
Contributors: [github.com profile] RMHolsen, [github.com profile] chebegeek, [github.com profile] momijizukamori, [personal profile] zorkian
azurelunatic: DW: my eloquence cannot be captured in 140 chars (eloquence)
[personal profile] azurelunatic
There was speculation about a code push, and that means it's code tour time! Most of these should be live with the next code push, and some of them (wording update ones) will already be live.

Issue 2627: Updating LJXMLRPC URL references to use HTTPS (pull request)
and
Issue 2900: Update Insanejournal URLs to use HTTPS
Category: importer, crossposter, sheeps should not be on fire
Patch by: [personal profile] batrachian
Description: [personal profile] batrachian says: makes importer and crossposter work for InsaneJournal again.
Azz adds: Previously, IJ wasn't using https, and we didn't expect https when importing or crossposting. Then they started using https, and the importer and the crossposter made noises of deep confusion and went off to pine for the fjords instead of importing or crossposting. Now they know what to do with https, and crossposting and importing to IJ can resume.

Issue 2853: Convert inbox to TT (pull request)
Category: back end with a few front end flourishes, BML Must Die!
Patch by: [github.com profile] momijizukamori
Description: Brad, in his dorm room, came up with a language for building webpages called BML, which translates to "Better Markup Language" if you asked him, and "Brad's Markup Language" if you asked anyone else. It was visionary ... for 1999. Since that time, some better tools for the same purpose have happened. Template Toolkit (TT) is one of those. So Momiji ripped out the BML and rebuilt the inbox page and fixed some form handling on the way. It should now play a little nicer with future upgrades, and it has CSS.

Issue 2899: Encoding issue in Icons API (pull request)
Category: WTF-8, API
Patch by: [github.com profile] momijizukamori, reported by [github.com profile] bcholmes
Description: If you noticed some weird characters when you retrieved your icons via the API, with garbled and incorrect characters instead of a single quote mark, this should fix the incorrect encoding.

Issue 2911: possible drag-and-drop breakage in /file/new (pull request)
Category: Un-confusing the browser
Patch by: [github.com profile] momijizukamori
Description: Momiji says: We had code that tried to detect if you were on a mobile device, and hide the drop target on the image upload page, because mobile OSes generally do not support drag-and-drop of files into another application. However, the main way to try to detect this is checking for support of touch APIs and 1) this is not all that reliable (which is common for feature detection) and 2) most desktop OSes now support touchscreens as well, which meant that the drop target wasn't showing up even on non-touchscreen devices in some browsers. So that detection went away - so you may see the drop target in some instances where you can't actually drag and drop files, but this is on the whole less annoying that not having it when you can.

Issue 2912: update copyright footer for 2022
Category: The Wheel of Time turns, and ages come and pass, leaving memories that become legend.
Update by: [github.com profile] zorkian
Description: It's no longer 2021, and the copyright footer now reflects that.

Issue 2913: Don't warn about unclosed <li> tags (pull request)
Category: YOU CAN'T TELL ME WHAT TO DO!
Patch by: [github.com profile] momijizukamori
Description: Momiji says: Did you know you don't have to close <li> tags in some circumstances under the HTML 4 and HTML 5 specs? I didn't! And neither did the HTML cleaner, which meant that the changes put in in #2885 to keep you from posting bad HTML would keep you from posting unclosed <li> tags, too. The cleaner is now aware of this and will no longer you stop you.

Issue 2918: remove error log method calls (pull request)
Category: backend
Patch by: [github.com profile] kareila
Description: [github.com profile] kareila says: Fixes some backend cleanup that was causing an obscure error to appear in some rare cases.

Issue 2919: Cache API keys for faster lookup (pull request)
Category: API, database go ZOOM!
Patch by: [github.com profile] momijizukamori
Description: Momiji says: A while ago, we added API keys! These have to be sent with every API request - right now, there's not a lot you can do with the API, so there isn't many of those, but in the future, this will hopefully increase. Right now, the server has to check the database every time to see if an API key is valid. Checking the database is expensive in terms of time and resources, so we ideally want to reduce the number of times that happens. This change makes the server cache successful key lookups, so if you make a bunch of API requests in a row, it will 'remember' the key after the first one and not have to check the database.

Issue 2922: FAQ44 slightly misleading
Category: Documentation, making things make sense
Update by: [github.com profile] rahaeli, reported by [github.com profile] pauamma
Description: The FAQ title didn't mention Dreamwidth-specific tags when it should have.

Issue 2924: Properly scope entry/icon page pagination (pull request)
Category: when the backend attacks the frontend, BML Must Die! and this is why
Patch by: [github.com profile] momijizukamori
Description: Momiji says: When we made the pagination in the updated site-styled journal entries look nice and fancy, we... accidentally make it look wonky everywhere else. Which is not a lot of places, and thus why nobody noticed, but we should fix it! This properly scopes the new pagination to only happen in the spots that use the new code.

Issue 2927: Fix issue where content-importer worker did not exit on error as intended (pull request)
and
Issue 2928: Fix another way content-importer workers can fail to exit (pull request)
Category: backend, importer, a small but ominous grinding noise
Patch by: [github.com profile] alierak
Description: If something goes terribly wrong with the process that's supposed to be working on someone's import, it should either gracefully (or gracelessly) exit. That is working better now.

Issue 2930: Clear "request" cache of db handles in imports (pull request)
Category: importer, MySQL moved your cheese
Patch by: [github.com profile] alierak
Description: You know how sometimes you get up from your chair to look at something and then you stand there for a while and then you go to sit back down and it turns out someone has moved it and you fall backwards and bang your tailbone? No? Okay, maybe that's only Mr. Horrible. Anyway, [github.com profile] alierak says long-running imports should no longer fail with a "MySQL server has gone away" error.

Issue 2935: membership setting choice in /communities/new not respected (pull request)
Category: community management, typo patrol, when the front end attacks!
Patch by: [github.com profile] alierak
Description: A typo caused the community creation process to ignore the setting for "by invitation only". This makes sure that newly created communities will have the correct settings.

Issue 2940: "credit fix" wording next to support answers
Category: Technical Support, frontend, making things make sense
Update by: [github.com profile] rahaeli, report by [github.com profile] pauamma
Description: This text was only ever visible to users who could approve answers to Support questions, but now the link to approve a specific answer has text that makes more sense.

Issue 2949: convert /manage/banusers to TT (pull request)
Category: backend, BML Must Die!
Patch by: [github.com profile] momijizukamori
Description: Momiji says: Part of the ongoing crusade eliminate BML from the codebase! One page down, many more to go...


17 total issues resolved

Contributors: [github.com profile] alierak, [github.com profile] kareila, [github.com profile] momijizukamori, [personal profile] batrachian, [github.com profile] rahaeli, [github.com profile] zorkian

Additional bug reporters: [github.com profile] bcholmes, [github.com profile] pauamma
kareila: Rosie the Riveter "We Can Do It!" with a DW swirl (dw)
[personal profile] kareila
Most of these are live as of tonight, we think?

Issue 1118: Make the redirect from http -> https permanent
Category: HTTPS Everywhere v2, Cleaning house
Description: The sitewide change from HTTP to HTTPS has been permanent since, like, 2018, but we missed closing this issue from three years prior, reminding us to do it someday. Someday came, and went, and is now a fond memory.

Issue 1822: '0000-00-00' is no longer a valid default value for MySQL DATETIME fields as of Ubuntu 16.04 LTS
Category: Cleaning house, Appeasing the elder gods of open source
Description: This hasn't entirely been fixed yet for reals, but we opened #2856 for general discussion of this and other related problems on more recent versions of Ubuntu, so we're retiring this particular discussion thread.

Issue 2129: two minor issues with mod hat HTML (pull request) (nonfree pull request)
Category: Site beautification, Fancy hats
Patch by: [github.com profile] momijizukamori
Description: Some CSS tweaks to adjust the display of mod hats on comments that use them! This is the tiny icon that appears next to your username if you post a comment with the "Admin Post" tickybox checked under More Options.

Issue 2380: Typos in https://www.dreamwidth.org/manage/settings/?cat=shortcuts
Category: Cleaning house, Devs tpye gud
Description: This separately annoyed two people enough to open an issue, but it's only broken once, so the duplicate got closed. It can now be found in #2891 if anyone wants to actually do the thing!

Issue 2563: Advanced:Layers doesn't show the names of custom layers in the create theme drop down (pull request)
Category: Bug-squashing, Find the missing string
Patch by: [github.com profile] momijizukamori
Description: When the advanced style customization pages were converted away from BML, one of the dropdown menus couldn't figure out who moved its cheese. The cheese is now properly located.

Issue 2627: update AO3 user links to use HTTPS (pull request)
Category: Modernization, other sites use HTTPS too
Patch by: [github.com profile] woggy
Description: This updates the boilerplate code that generates userhead links for all non-DW sites to use HTTPS.

Issue 2817: move some functions from ljlib into an LJ::Utils module (pull request)
Category: Code tidying, Making devs' lives easier
Patch by: [github.com profile] martindemello
Description: The ljlib.pl file is the beating heart of the legacy LiveJournal code, and as such contains a ton of both absolutely vital site functions and poorly organized cruft. This moves some ljlib utility functions into a new, separate module named LJ::Utils.

Issue 2825: Icon browser: save some space on mobile, re-fix message body focus (pull request)
Category: Site beautification, Small screens deserve love too
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Two small fixes for the icon browser. 1. Save a bit of space on mobile by stashing the display options behind a handy toggle button. 2. In comment forms, focus the message body after dismissing the icon browser."

Issue 2852: convert /support/see_request (pull request)
Category: Modernization, BML MUST DIE
Patch by: [github.com profile] kareila
Description: The code underlying the support/see_request page has now been converted to our more modern page format, but all the functionality should be the same.

Issue 2857: Admin rename override tools are busted
Category: Cleaning house, How do computers even work any way
Description: We thought we broke something, but we didn't. Nothing to see here.

Issue 2859: Reconcile icon select component with beta entry page (pull request)
Category: Bug-squashing, Enforcing consistency with an iron fist
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Fixed a bug where the beta create entries page wasn't properly saving the icon you chose. We recently started handling the icon menu more consistently, and one place that used it still really wanted to do things differently."

Issue 2861: converted profile page breaks with >1000 subscriptions? (pull request)
Category: Bug-squashing, Template Toolkit is finicky
Patch by: [github.com profile] kareila
Description: An infinite loop with a vaguely defined exit condition was being terminated prematurely by the Template Toolkit interpreter, so we now use a very large finite loop instead.

Issue 2862: Fix non-integer comparison warning in icon components (pull request)
Category: Code tidying, Template Toolkit is finicky
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Something internal didn't like the way some of our code was arranged, so it started complaining and annoying the devs. (It was still doing the correct thing for users, we think, but it didn't like it.)"

Issue 2863: Fixes for S2 pagination (pull request) (nonfree pull request)
Category: Site beautification, Modernization
Patch by: [github.com profile] momijizukamori
Description: Display fixes for pagination links in site views, which looked particularly wonky on pages converted to use the more modern display code.

Issue 2867: Keep gap after entry/comment content consistent (pull request)
Category: Site beautification, Enforcing consistency with an iron fist
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Comments and entries that were written in Markdown had an extra little gap at the bottom when compared to content that was written in casual HTML. Now fixed in most places... but since this is a CSS thing and each journal style has its own CSS, some journal styles might still have the extra gap."

Issue 2868: Chrome (and Firefox) changed default Referrer-Policy, made login/out redirects glitchy (pull request)
Category: Modernization, How do computers even work any way
Patch by: [github.com profile] rshatch
Description: Ruth says: "When we switched to more modern site pages, we started using the HTTP Referer header to redirect users back to the page they were originally on when they made the login/logout request. Recent updates in both Chrome and Firefox have started placing restrictions on reading the Referer header, for security reasons, with the result that users weren't getting sent back to the page they had come from properly. After some back-and-forth, we decided the nicest solution was to explicitly set the return location (which, incidentally, is more or less what the older BML pages did)."

Issue 2871: Have /data/edges return an error if accessed without first logging in (pull request)
Category: Obscure backend voodoo, Papers Please
Patch by: [github.com profile] kareila
Description: This is a rarely used API endpoint with the potential to slow down the site for everyone if a badly behaved program accesses it repeatedly. To reduce the likelihood of abuse, only return the requested data if the user is logged in.

Issue 2872: run tidyall on master (pull request)
Category: Code tidying, Mark is developing in prod again
Patch by: [github.com profile] kareila
Description: Fix minor whitespace issues that cause the tidy CI tests to fail. Nothing here that affects users on the site.

Issue 2873: Add PR template explaining the CODE TOUR: line (pull request)
Category: Making devs' lives easier, Document your changes
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Meta: encourage devs to leave hints for whoever writes the next code tour post! When devs submit code, they include a description of what they did... but it's intended for other developers on the same project, so it can often be opaque even to devs that work on other code. This just adds a reminder to also include a brief summary for non-devs in there." In other words, this adds helpful boilerplate text to the form that devs see when they submit a pull request on Github.

Issue 2874: remove paragraph tags from explanatory CSS comments (pull request)
Category: Bug-squashing, the CSS parser is finicky
Patch by: [github.com profile] kareila
Description: The fix from #2867 included some CSS comments that contained a paragraph tag, to explain the impact of the change. Unfortunately, our less-than-ideal CSS parser choked on rendering CSS that appeared to contain HTML tags. This rewrites the comments to avoid the problem.

Issue 2875: fix styleinfo_privs usage for varying argument types in different contexts (pull request)
Category: Bug-squashing, Obscure backend voodoo
Patch by: [github.com profile] kareila
Description: The /admin/styleinfo page was inaccessible due to a code glitch, which this fixes.

Issue 2877: cleanup from latest changes (pull request)
Category: Bug-squashing, Mark is developing in prod again
Patch by: [github.com profile] kareila
Description: Two small backend fixes. Nothing here that affects users on the site.

Issue 2878: Possible issues from antique modernizr (pull request)
Category: Bug-squashing, Modernization
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Some Chrome users saw weird behavior with the interface for adding tags, in the beta "create entries" page -- the "x" button for removing a tag was replaced with a text label. This was because some browsers are now TOO MODERN for the javascript library we were using to test whether your browser was modern enough to show certain things." So we are now using a newer version of the library.

Issue 2879: Knock it off with the Foundation table styles (pull request)
Category: Site beautification, Modernization
Patch by: [github.com profile] nfagerlund
Description: Nick says: "The new site skins were adding too much style juice to tables in entries and comments. (Messing with font/background colors, adding unexpected amounts of padding, etc.) Now they're not. Hopefully."

Issue 2881: Fix some random invalid CSS (pull request)
Category: Code tidying, Making devs' lives easier
Patch by: [github.com profile] nfagerlund
Description: Nick says: "Some very old CSS files had invalid junk code left in them." Referring to other files that don't actually exist is not generally helpful.

Issue 2885: Add errors for bad markup to beta create page (pull request)
Category: NEW FEATURES, Know before you post
Patch by: [github.com profile] momijizukamori
Description: Momiji says: "Previously, if you had bad markup in an entry, you wouldn't find out until after you had already posted the entry and said bad markup was potentially on display for the world to see. Now the beta create page will give you the error before the post is saved, so you can preemptively fix it (note: this doesn't catch all bad markup - but it gets the most common cases)."

Issue 2908: Search by multiple interests no longer works
Category: Cleaning house, How do computers even work any way
Description: We thought we broke something, but we didn't. Nothing to see here.


27 total issues resolved
Contributors: [github.com profile] kareila, [github.com profile] martindemello, [github.com profile] momijizukamori, [github.com profile] nfagerlund, [github.com profile] rshatch, [github.com profile] woggy
roadrunnertwice: Yoshimori from Kekkaishi, with his beverage of choice. (Coffee milk (Kekkaishi))
[personal profile] roadrunnertwice

Hello, it's time for another code tour! This is mostly stuff that isn't live yet, but will arrive in the next code push.

Contents: a whole bunch of Stuff )

sporky_rat: A Dreamsheep dreaming of DW Support (_support)
[personal profile] sporky_rat
There was SO MUCH CODE CONVERSION oh my gosh. [personal profile] kareila finished a knitting project and didn't pick up another one so CODE MACHETE TIME. [personal profile] roadrunnertwice is still working on the spite-fueled redesign (also less DRAMATIC WOODCHUCK now).
80 issues, thirteen pages in the notepad before putting in the information. HAIL THE DEVS.

hang on your shoes folks, where we're going we don't need roads!...we do need seatbelts though )

80 total issues resolved
Contributors: [github.com profile] kaberett, [github.com profile] kareila, [github.com profile] martindemello, [github.com profile] momijizukamori, [github.com profile] nfagerlund

That's all for me today, make sure to thank your devs!
sporky_rat: XKCD's Internet Map showing Dreamwidth, with a Dreamwidth D Spiral. Text:  'This is my home'. (dreamwidth)
[personal profile] sporky_rat
Holy flying carp there’s been a lot going on since the end of April. Bringing code into the Century of the Fruitbat, making things a lot less Eldritch Horror Under the Hood, some Stylin’, and last but certainly not least, User Functionality! (Plus some bonus TEAMWORK)

Hands in feet in don’t stare into the laser LET’S GO

much modernization. such future. wow! )

49 total issues resolved, HAIL CONTRIBUTORS
Contributors: [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] nfagerlund, [github.com profile] rshatch, [github.com profile] zorkian


Dunno when this will all go live, but it will be announced in [site community profile] dw_maintenance before the code is pushed and afterwards.
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
[staff profile] mark

Continuing on from the last code tour!

Hi all, some changes coming your way -- figured I'd make the noise!

SOME NOISE OF KEYBOARDS )

Cool beans, that's what I've got for now! Bye bye!

ilyena_sylph: (Dreamwidth "d", rainbow-colored by Sophie) (Dreamwidth)
[personal profile] ilyena_sylph
Hi, y'all! I'm Yena, and I haven't done one of these in a very long time. Matter of fact, I would have thrown up my hands after about ten minutes trying if [personal profile] roadrunnertwice hadn't said 'I can help sort some of this stuff into categories that go together instead of it being all over the place' and answered about 5 million questions. I swear this has gotten harder since the last time I did it.

But anyway! Here's the stuff that's been going on in the Eldritch Depths of the codebase that should hopefully make things even better than they already are around here!

I'm not sure when it's going to get pushed live, but this's what's on its way!

strap in! )

35 total issues resolved
Contributors: [github.com profile] kareila, [github.com profile] nfagerlund, [github.com profile] rshatch, [github.com profile] zorkian
roadrunnertwice: Yoshimori from Kekkaishi, with his beverage of choice. (Coffee milk (Kekkaishi))
[personal profile] roadrunnertwice

Okay my buds, strap in: we edited some code on Dreamwidth dot org this summer.

All of these changes are live on the site now! Themes this time around: Actual cash money, more messing with the reply forms, style fixes, at-mentions, and a few general-purpose bug fixes and cleanups.

Read more (a LOT more) )

And that's a wrap!!!

58 total issues and/or pull requests resolved

Contributors: [github.com profile] zorkian, [github.com profile] nfagerlund, [github.com profile] rshatch, [github.com profile] wohali, [github.com profile] rahaeli, [github.com profile] kareila, [github.com profile] alierak

roadrunnertwice: Dee perpetrates some Mess. (Arts and crafts (Little Dee))
[personal profile] roadrunnertwice

Hello! Time for another code tour.

Most of the changes from this tour and the last one aren't live on the site yet, but will be soon.

Read more... )

13 total issues resolved
Contributors: [github.com profile] nfagerlund, [github.com profile] rshatch, [github.com profile] zorkian

roadrunnertwice: Two fir trees in bright sunlight. (Portland - Farragut)
[personal profile] roadrunnertwice
Looks like it was kind of a busy month, so... time for a code tour! (First ever from yours truly. Content note: includes some explanatory GIFs.)

Most of these changes are scheduled for Soon, but a few of the smaller ones are already live on the site. Themes this month: Improvements to mobile, code cleanups, fixes for bugs that snuck in during recent work, and the ongoing march of TT-ification.

Read more... )

31 total issues resolved
Contributors: [github.com profile] alexwlchan, [github.com profile] kareila, [github.com profile] momijizukamori, [github.com profile] nfagerlund, [github.com profile] rshatch, [github.com profile] zorkian
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)
[personal profile] momijizukamori
So it's been a while!

All aboard the code tour train, choo choo! )
28 total issues resolved
Contributors: [github.com profile] Darael, [personal profile] allen, [github.com profile] alierak, [github.com profile] kaberett, [github.com profile] nfagerlund, [github.com profile] rahaeli, [github.com profile] rshatch, [github.com profile] srukle, [github.com profile] wahiaronkwas, [github.com profile] zorkian - welcome back to a few old faces, and a special shout-out to [github.com profile] nfagerlund for their first contribution!
kaberett: A sleeping koalasheep (Avatar: the Last Airbender), with the dreamwidth logo above. (dreamkoalasheep)
[personal profile] kaberett
Tiiiiiiiiiiny code tour!

Read more... )


3 total issues resolved
Contributors: [github.com profile] kareila, [github.com profile] rshatch, [github.com profile] swaldman3

Profile

dw_dev: The word "develop" using the Swirly D logo.  (Default)
Dreamwidth Open Source Development

June 2025

S M T W T F S
1234567
89101112 1314
15161718192021
22232425262728
2930     

Syndicate

RSS Atom

Most Popular Tags

Style Credit

Expand Cut Tags

No cut tags
Page generated Jun. 16th, 2025 05:18 pm
Powered by Dreamwidth Studios