Most of these are live as of tonight, we think?
Issue 1118: Make the redirect from http -> https permanent
Category: HTTPS Everywhere v2, Cleaning house
Description: The sitewide change from HTTP to HTTPS has been permanent since, like, 2018, but we missed closing this issue from three years prior, reminding us to do it someday. Someday came, and went, and is now a fond memory.
Issue 1822: '0000-00-00' is no longer a valid default value for MySQL DATETIME fields as of Ubuntu 16.04 LTS
Category: Cleaning house, Appeasing the elder gods of open source
Description: This hasn't entirely been fixed yet for reals, but we opened
#2856 for general discussion of this and other related problems on more recent versions of Ubuntu, so we're retiring this particular discussion thread.
Issue 2129: two minor issues with mod hat HTML (
pull request) (
nonfree pull request)
Category: Site beautification, Fancy hats
Patch by:
momijizukamoriDescription: Some CSS tweaks to adjust the display of mod hats on comments that use them! This is the tiny icon that appears next to your username if you post a comment with the "Admin Post" tickybox checked under More Options.
Issue 2380: Typos in
https://www.dreamwidth.org/manage/settings/?cat=shortcutsCategory: Cleaning house, Devs tpye gud
Description: This separately annoyed two people enough to open an issue, but it's only broken once, so the duplicate got closed. It can now be found in
#2891 if anyone wants to actually do the thing!
Issue 2563: Advanced:Layers doesn't show the names of custom layers in the create theme drop down (
pull request)
Category: Bug-squashing, Find the missing string
Patch by:
momijizukamoriDescription: When the advanced style customization pages were converted away from BML, one of the dropdown menus couldn't figure out who moved its cheese. The cheese is now properly located.
Issue 2627: update AO3 user links to use HTTPS (
pull request)
Category: Modernization, other sites use HTTPS too
Patch by:
woggyDescription: This updates the boilerplate code that generates userhead links for all non-DW sites to use HTTPS.
Issue 2817: move some functions from ljlib into an LJ::Utils module (
pull request)
Category: Code tidying, Making devs' lives easier
Patch by:
martindemelloDescription: The ljlib.pl file is the beating heart of the legacy LiveJournal code, and as such contains a ton of both absolutely vital site functions and poorly organized cruft. This moves some ljlib utility functions into a new, separate module named LJ::Utils.
Issue 2825: Icon browser: save some space on mobile, re-fix message body focus (
pull request)
Category: Site beautification, Small screens deserve love too
Patch by:
nfagerlundDescription: Nick says: "Two small fixes for the icon browser. 1. Save a bit of space on mobile by stashing the display options behind a handy toggle button. 2. In comment forms, focus the message body after dismissing the icon browser."
Issue 2852: convert /support/see_request (
pull request)
Category: Modernization, BML MUST DIE
Patch by:
kareilaDescription: The code underlying the support/see_request page has now been converted to our more modern page format, but all the functionality should be the same.
Issue 2857: Admin rename override tools are busted
Category: Cleaning house, How do computers even work any way
Description: We thought we broke something, but we didn't. Nothing to see here.
Issue 2859: Reconcile icon select component with beta entry page (
pull request)
Category: Bug-squashing, Enforcing consistency with an iron fist
Patch by:
nfagerlundDescription: Nick says: "Fixed a bug where the beta create entries page wasn't properly saving the icon you chose. We recently started handling the icon menu more consistently, and one place that used it still really wanted to do things differently."
Issue 2861: converted profile page breaks with >1000 subscriptions? (
pull request)
Category: Bug-squashing, Template Toolkit is finicky
Patch by:
kareilaDescription: An infinite loop with a vaguely defined exit condition was being terminated prematurely by the Template Toolkit interpreter, so we now use a very large finite loop instead.
Issue 2862: Fix non-integer comparison warning in icon components (
pull request)
Category: Code tidying, Template Toolkit is finicky
Patch by:
nfagerlundDescription: Nick says: "Something internal didn't like the way some of our code was arranged, so it started complaining and annoying the devs. (It was still doing the correct thing for users, we think, but it didn't
like it.)"
Issue 2863: Fixes for S2 pagination (
pull request) (
nonfree pull request)
Category: Site beautification, Modernization
Patch by:
momijizukamoriDescription: Display fixes for pagination links in site views, which looked particularly wonky on pages converted to use the more modern display code.
Issue 2867: Keep gap after entry/comment content consistent (
pull request)
Category: Site beautification, Enforcing consistency with an iron fist
Patch by:
nfagerlundDescription: Nick says: "Comments and entries that were written in Markdown had an extra little gap at the bottom when compared to content that was written in casual HTML. Now fixed in
most places... but since this is a CSS thing and each journal style has its own CSS, some journal styles might still have the extra gap."
Issue 2868: Chrome (and Firefox) changed default Referrer-Policy, made login/out redirects glitchy (
pull request)
Category: Modernization, How do computers even work any way
Patch by:
rshatchDescription: Ruth says: "When we switched to more modern site pages, we started using the HTTP Referer header to redirect users back to the page they were originally on when they made the login/logout request. Recent updates in both Chrome and Firefox have started placing restrictions on reading the Referer header, for security reasons, with the result that users weren't getting sent back to the page they had come from properly. After some back-and-forth, we decided the nicest solution was to explicitly set the return location (which, incidentally, is more or less what the older BML pages did)."
Issue 2871: Have /data/edges return an error if accessed without first logging in (
pull request)
Category: Obscure backend voodoo, Papers Please
Patch by:
kareilaDescription: This is a rarely used API endpoint with the potential to slow down the site for everyone if a badly behaved program accesses it repeatedly. To reduce the likelihood of abuse, only return the requested data if the user is logged in.
Issue 2872: run tidyall on master (
pull request)
Category: Code tidying, Mark is developing in prod again
Patch by:
kareilaDescription: Fix minor whitespace issues that cause the tidy CI tests to fail. Nothing here that affects users on the site.
Issue 2873: Add PR template explaining the CODE TOUR: line (
pull request)
Category: Making devs' lives easier, Document your changes
Patch by:
nfagerlundDescription: Nick says: "Meta: encourage devs to leave hints for whoever writes the next code tour post! When devs submit code, they include a description of what they did... but it's intended for other developers on the same project, so it can often be opaque even to devs that work on other code. This just adds a reminder to also include a brief summary for non-devs in there." In other words, this adds helpful boilerplate text to the form that devs see when they submit a pull request on Github.
Issue 2874: remove paragraph tags from explanatory CSS comments (
pull request)
Category: Bug-squashing, the CSS parser is finicky
Patch by:
kareilaDescription: The fix from
#2867 included some CSS comments that contained a paragraph tag, to explain the impact of the change. Unfortunately, our less-than-ideal CSS parser choked on rendering CSS that appeared to contain HTML tags. This rewrites the comments to avoid the problem.
Issue 2875: fix styleinfo_privs usage for varying argument types in different contexts (
pull request)
Category: Bug-squashing, Obscure backend voodoo
Patch by:
kareilaDescription: The /admin/styleinfo page was inaccessible due to a code glitch, which this fixes.
Issue 2877: cleanup from latest changes (
pull request)
Category: Bug-squashing, Mark is developing in prod again
Patch by:
kareilaDescription: Two small backend fixes. Nothing here that affects users on the site.
Issue 2878: Possible issues from antique modernizr (
pull request)
Category: Bug-squashing, Modernization
Patch by:
nfagerlundDescription: Nick says: "Some Chrome users saw weird behavior with the interface for adding tags, in the beta "create entries" page -- the "x" button for removing a tag was replaced with a text label. This was because some browsers are now TOO MODERN for the javascript library we were using to test whether your browser was modern enough to show certain things." So we are now using a newer version of the library.
Issue 2879: Knock it off with the Foundation table styles (
pull request)
Category: Site beautification, Modernization
Patch by:
nfagerlundDescription: Nick says: "The new site skins were adding
too much style juice to tables in entries and comments. (Messing with font/background colors, adding unexpected amounts of padding, etc.) Now they're not. Hopefully."
Issue 2881: Fix some random invalid CSS (
pull request)
Category: Code tidying, Making devs' lives easier
Patch by:
nfagerlundDescription: Nick says: "Some very old CSS files had invalid junk code left in them." Referring to other files that don't actually exist is not generally helpful.
Issue 2885: Add errors for bad markup to beta create page (
pull request)
Category: NEW FEATURES, Know before you post
Patch by:
momijizukamoriDescription: Momiji says: "Previously, if you had bad markup in an entry, you wouldn't find out until after you had already posted the entry and said bad markup was potentially on display for the world to see. Now the beta create page will give you the error before the post is saved, so you can preemptively fix it (note: this doesn't catch
all bad markup - but it gets the most common cases)."
Issue 2908: Search by multiple interests no longer works
Category: Cleaning house, How do computers even work any way
Description: We thought we broke something, but we didn't. Nothing to see here.
27 total issues resolved
Contributors:
kareila,
martindemello,
momijizukamori,
nfagerlund,
rshatch,
woggy