21 April - 18 June 2020 code tour! BEEP BEEP

[sporky_rat]

Holy flying carp there’s been a lot going on since the end of April. Bringing code into the Century of the Fruitbat, making things a lot less Eldritch Horror Under the Hood, some Stylin’, and last but certainly not least, User Functionality! (Plus some bonus TEAMWORK)

Hands in feet in don’t stare into the laser LET’S GO



Issue 132: Add base font size for journal pages (entry, reply) (pull request) (nonfree pull request)
Category: User functionality, bringing code into the century of the fruitbat
Patch by: nfagerlund
Description: Journal pages didn’t have a base font size. roadrunnertwice decided this was Wrong and fixed it. Thanks, roadrunnertwice!

Issue 134: remove deadphrased string from index.bml.text.local (pull request) (nonfree pull request)
Category: BML Code Machete
Patch by: kareila
Description: It’s kareila. Code machete for bml! CODE MACHETE

Issue 135: clean up DW::Hooks::CreditCard (pull request) (nonfree pull request)
Category: Code Machete
Patch by: kareila
Description: That’s a really nice code machete there, kareila. Grudge match against bml!

Issue 2350: Fix change_journal_type console command (pull request)
Category: Password Safety Squad, bringing code into the century of the fruitbat
Patch by: kareila
Description: USED TO, when you changed a community journal to a personal journal, passwords and emails were copied over. How passwords were accessed in the database has changed so kareila went into the code and taught the process how to be much safer.

Issue 2464: Move or remove orphan .bml.text files (pull request)
Category: Code machete
Patch by: kareila
Description: Keeping that code machete sharp with some removal of orphan bml

Issue 2530: /admin/propedit needs better error checking for "user does not exist" other than just throwing a perl warning (pull request)
Category: User functionality
Patch by: kareila
Description: So Rah ran into this problem where she was looking for someone, forgot a part of the name, got some really unhelpful error message and realized ‘hey, a check to see if this username exists would be super helpful about now’ and then it was done. Because when Rah says something is super unhelpful, it’s seriously unhelpful.

Issue 2551: Comment preview page: Use a normal reply form, maybe stop being a page
Category: bringing code into the century of the fruitbat, spite-fueled redesign
Patch by: nfagerlund
Description: So roadrunnertwice has this grudge against unusable entry pages, comment forms and generally old code that could be modernized and made so much easier to upkeep and use. This brought the comment reply preview more in line with the rest of the pages so it can benefit from future improvements in usability.

Issue 2572: Error loop when commenting as OpenID user while logged in as site user
Category: Weird Bugs
Patch by: nfagerlund
Description: roadrunnertwice found a bug. roadrunnertwice fixed the bug.

Issue 2606: Fix crossposter, maybe (pull request)
Category: Crossposter, bringing code into the century of the fruitbat
Patch by: nfagerlund
Description: Markdown on crossposted entries got broken with the fix of another issue, however, roadrunnertwice decided that the code was in need of some serious updating anyway and went at it. Markdown and other crossposter specific cleaning should work now.

Issue 2611: Hide zoom cursors for images that can't be zoomed
Category: saving the RPers, SQUISH related
Patch by: nfagerlund
Description: Images got the ability to click-to-zoom! …..some images didn’t get squished, so they don’t need the click to zoom. This excludes those images that didn’t get squished. (SQUISH)

Issue 2617: DW can't run on dreamhacks anymore due to SQS requirement
Category: bringing code into the century of the fruitbat
Patch by: zorkian
Description: Dreamhacks fixed via a different issue!

Issue 2623: Catch some remaining MD5 gunk (pull request)
Category: Code Machete
Patch by: nfagerlund and zorkian
Description: kareila loaned roadrunnertwice and mark her code machete. Mmm, clean shiny code machete.

Issue 2624: Initial pass at TOTP (2fa) (pull request)
Category: bringing code into the century of the fruitbat, password safety squad, building foundations for a better tomorrow
Patch by: zorkian
Description: The foundations are there for permitting two factor authorization (2fa)! (Seriously, go take a look at the issue, there’s even screen caps of what it might look like!)

Issue 2626: Add password 'peppering' (pull request)
Category: password safety squad
Patch by: zorkian
Description: If someone, somehow (this is not a challenge! Do not accept this non-existent challenge!!!), got into the database where passwords are recognized, they’d have to figure out the various encryption keys of salt and pepper now to get useful data.

Issue 2629: "entered account name but posted anonymously" error with saved passwords in browser (pull request)
Category: old browser support can bring you weird bugs
Patch by: nfagerlund
Description: There was a work around in the comment log in form that would keep your information from wiping as soon as you clicked a different ticky….for like, Netscape 3.0. It was affecting more modern browsers and has been dealt with.

Issue 2631: Icon drop-down menu needs to html-escape icon names, etc. (pull request)
Category: code machete
Patch by: nfagerlund
Description: Icon dropdown is supposed to be clean and easy free, and somehow it did weird things with html. Now it doesn’t.

Issue 2632: LJ::ljuser and LJ::User::ljuser_display mutate their opts hashref (pull request)
Category: bringing code into the century of the fruitbat
Patch by: nfagerlund
Description: Names that were struck-through would bleed into the names below them. NOT what we’d like.

Issue 2636: s2foundation: Fix duplicate "Thread" link in comment footer (pull request)
Category: code machete
Patch by: nfagerlund
Description: There were duplicate thread links. Not good in sewing, coding, or weaving. Bye bye!

Issue 2637: old RTE not working for people after code push
Category: the blessed rte,
Patch by: holy flying batman, carp, like, all the devs and some sp0rt people, okay, but mostly alierak
Description: During the last code push, a bad copy of a file got cached by the server and after some Heroic Work, this got deleted and refreshed. (hold on just a little while longer, rte, then you can ride off into the sunset)

Issue 2639: failing tests, Apr 2020 edition (pull request)
Category: bringing code into the century of the fruitbat, building foundations for a better tomorrow
Patch by: kareila
Description: Basically….this is all the rubbish and broken stuff that came up when kareila ran the test suite. A list of things to repair or machete with failing tests.

Issue 2640: new comment form icon browser has disrupted keyboard shortcuts (pull request)
Category: icon browser, bringing code into the century of the fruitbat, spite-fueled redesign
Patch by: nfagerlund
Description: More of roadrunnertwice ‘s spite-fueled redesign of the icon browser and comment reply form. Brought the keyboard shortcuts back, made it look sleek and useful (go see the issue, there’s PHOTOS)

Issue 2641: improvements to bin/checkconfig.pl (pull request)
Category: building foundations for a better tomorrow, Perl clutching
Patch by: kareila
Description: The config checker was blissfully unaware of what real Perl looked like, apparently, since it would tell you that gibberish was Perl as well as actual Perl. The checker has been properly educated now.

Issue 2644: Rehabilitate Lynx site skin's foundation version (pull request)
Category: user functionality, Stylin’, spite-fueled redesign
Patch by: nfagerlund
Description: Lynx is the style that’s pretty much ‘web brutalist’ (thanks, roadrunnertwice, for the term!) that’s also known as the ‘light style’ or the mobile style. It wasn’t light or useful due to code updating and Lynx not getting updated to go with it. Now Lynx is much less clunky and badly styled.

Issue 2645: change default journal style on new installations (pull request)
Category: Stylin’, building foundations for a better tomorrow
Patch by: kareila
Description: New journals had a default styles that was in the dw-nonfree code section, didn’t support the newer features available in other styles, and wasn’t exactly neutral. Now it’s dw-free based, includes the newer features, and is pretty decently neutral!

Issue 2646: Pull talkpost_do (reply error, preview) into s2foundation beta (pull request)
Category: thousand yard stare, building foundations for better tomorrow, preview hasn’t been touched in at least a decade, spite-fueled redesign
Patch by: nfagerlund and momijizukamori
Description: momijizukamori got the thing out of BML. roadrunnertwice got it to work in the s2foundation.

Issue 2647: Fix embarrassing `ml` mistake (pull request)
Category: this is not the mistake you’re looking for
Patch by: nfagerlund
Description: Accidental removal of entire filter, it has been put back now.

Issue 2650: The Squash, Part 3 (Save the RP Museboard Artisans) (pull request)
Category: save the rp’ers, SQUISH related
Patch by: nfagerlund
Description: REJOICE for the code for images will no longer do evil things to images inside tables (and other bits of obvious code).


This whole section here is all taking pages from bml to a modern language and making it possible to do cool and interesting things to them later!
Issue 2654: Convert importer and misc tools (pull request)
Patch by: rshatch
Issue 2660: finish converting OpenID pages to TT (pull request)
Patch by: kareila
Issue 2661: Convert faqsearch and faqbrowse to Foundation/TT (pull request)
Patch by: momijizukamori
Issue 2668: convert /admin/invite pages to TT (pull request)
Patch by: kareila
Issue 2671: convert admin/pay pages to TT (pull request)
Patch by: kareila
Issue 2679: convert /admin/sysban (pull request)
Patch by: kareila


Issue 2656: require minimum version 0.015 of Params::Classify (pull request)
Category: Perl clutching
Patch by: kareila
Description: Perl was keeping Apache from running. NO MORE

Issue 2659: Investigate bizarre test behavior (pull request)
Category: Code machete
Patch by: nfagerlund
Description: roadrunnertwice coudn’t get tests to work, but after doing some burnt earth tactics with the code machete, tests are okay again.

Issue 2664: Add inline session messages (pull request)
Category: user functionality, Stylin’
Patch by: momijizukamori
Description: Session warnings! Any site page! No more going to one page with one message on it! EFFICIENCY.

Issue 133: Add styling and block for session messages (pull request) (nonfree pull request)
Category: Stylin’
Patch by: momijizukamori
Description: The session messages weren’t stylin’ enough. momijizukamori thought they needed more flair. This happened. Never doubt momijizukamori ‘s dedication to Style.

Issue 2666: Prevent infinite loop in htmlcleaner (pull request)
Category: Under the hood
Patch by: alierak and nfagerlund
Description: There was a loop, Alierak got it, Nick shaped it up a bit more, it became a new issue that Kareila got and merged together.

Issue 2667: Fix drifting talkform in Drifting (pull request)
Category: Stylin’
Patch by: nfagerlund
Description: Drifting had some major issues with things floating away. They’ve been anchored.

Issue 2669: Prevent infinite loop in htmlcleaner, belt + suspenders version (pull request)
Category: TEAMWORK, under the hood
Patch by: kareila, alierak, nfagerlund
Description: This merged the fixes for the HMTL cleaner loop into one sleek bit.

Issue 2670: fix tidy failures (pull request)
Category: clean up
Patch by: kareila
Description: The experimental fixes to the mail workers got un-tidied ( kareila’s words!) and re-tidied

Issue 2681: Userpics without keywords aren't displaying right in content (pull request)
Category: icon browser, old bug
Patch by: nfagerlund
Description: Somehow Nick finds all the old weird icon bugs and fixes them. I wonder how. O.O

Issue 2687: Tweak `mention` scanning regexps to fix end-of-sentence bug (pull request)
Category: user functionality
Patch by: nfagerlund
Description: @ mentions work again!

Issue 2688: Fix some trivial detritus from the talkpost PR (pull request)
Category: preview hasn’t been touched in a decade, building foundations for a better tomorrow
Patch by: nfagerlund
Description: Little bit of tidying up of the talkpost pull request.

Issue 2689: Fix failing comment-create.t (pull request)
Category: TEAMWORK
Patch by: nfagerlund
Description: Comment creation wasn’t working right, now it is.

Issue 2694: pin JSON::Validator@3.25 (pull request)
Category: code we need
Patch by: kareila
Description: Keeps the json validation version we’re using the same.

Issue 2698: Always display beta features in a consistent order (pull request)
Category: user functionality
Patch by: nfagerlund
Description: The list of current betas kept reorganizing themselves and it was driving a lot of people A Bit Off. This resorts them to their IDs rather than the time they started. Mmm, order imposed on chaos.


49 total issues resolved, HAIL CONTRIBUTORS
Contributors: kareila, momijizukamori, nfagerlund, rshatch, zorkian


Dunno when this will all go live, but it will be announced in dw_maintenance before the code is pushed and afterwards.

Comments

[cesy]

Yay code!

[azurelunatic]

Hooray!

[kaberett]

oh good grief THANK YOU sporken you are AMAZING

[sporky_rat]

nine pages
We have had some BUSY devs.

[runpunkrun]

I'm so excited that I'll soon be able put @ mentions at the end of a sentence and finish it with a period and not ruin everything!

As always, this code tour is both entertaining and informative. Thank you!

[sporky_rat]

I try! Thank you!

[delosharriman]

I have to commend you on the Sailor V icon there.

Forget Sailor Moon Crystal, all I want is a Codename Sailor V anime…

[kareila]

LOL @ Perl clutching 😆

[sporky_rat]

It was apt and funny.

[alexseanchai]

🎉

[sporky_rat]

It was so much more brain work than the work I was getting paid for AND it got me through the last ten minutes of work. :D

[brainwane]

Thanks! What's a session message?

[sporky_rat]

Oh, crap, did I leave that out?

this adds the ability for the backend to show success and error messages on any site page, instead of making you click through a page with a single message on it. according to the person who did the fix.
(I swear I thought I put that in there!)

[dewline]

That looks...thorough.

[sporky_rat]

Best part about the code tour is seeing what all is getting worked on!

(It's really the best.)

[dewline]

As someone whose coding days - except for static website maintance on my home page - are well behind me...well, this is probably more than I'd be able to handle.

[delight]

This is the most entertaining code your I've ever read, I think.

[bemused_writer]

It all sounds very exciting, but the ones I'm most excited about might be the base font size on journals, comment preview, and the maybe cross-posting fix. One thing I've always noticed with cross-posting is that it doesn't seem to like exceptionally long posts.

At any rate, thank you for the hard work! This was a fun and informative read. ^^

[sporky_rat]

If I remember correctly, the character length in other journal site posts isn't as long as the one Dreamwidth has?

(Yup, I dug around and this is a thing: 'The post limit has been increased to 300,000 characters (including spaces) and the comment limit has been increased to 16,000 characters (including spaces).')

[bemused_writer]

Ahh, you're completely correct! I had no idea. XD I just tested posting something directly to LJ and no luck at all. My posts are too big... In that case, I am grateful to DW for allowing these giant posts of mine!

[sporky_rat]

I thought it was in one of the 'this is what we've changed from LJ' faqs, but it looks like it's not.

I'll poke one of the faq editor people.

[archangelbeth]

These descriptions are a delight. Spite-fueled redesign makes me gleeful.

[mark]

Me too, honestly.

[cpthorn]

Yay, that's a lot of great stuff, thank you devs!

[silverflight8]

I do enjoy the category names, lol

[sporky_rat]

The three that are my favorite are, 'password safety squad', 'thousand yard stare', and 'Perl clutching'.

It's one of the most fun bits.

[falkner]

Thanks to all the devs for their hard work!

[darjeeling]

"category: saving the RPers"

ILU GUYS

[witchka]

"spite-fueled redesign" is such a mood.

Thanks for all the work and notes. <3

[kate_nepveu]

this was wonderfully entertaining and informative, thank you!