Code Tour (2022-05-07 to 2022-10-08)

[azurelunatic]

Today we have 26 closed issues, most of which are improvements that were pushed live a few hours back. The 2022-01-01 to 2022-05-07 code tour will also be live now.


Issue 145: Add site scheme name as a body tag class (pull request) (nonfree pull request)
Category: Fun Browser Tricks, Accessibility, User scripts
Patch by: momijizukamori
Description: This makes it easier for folks who like to modify their browser's display of websites to make site-skinned Dreamwidth pages do interesting and/or accessibility-customized stuff.

Issue 686: Add 'Indexed' style by wiring
Category: Closed but not done, Tidying Extremely Old Issues
Patch by: n/a
Description: This style was withdrawn (maker was still working on it, may have submitted it through another ticket when finished)

Issue 689: Add 'Suit Yourself' style by flamingchemist
Category: Closed but not done, Tidying Extremely Old Issues
Patch by: n/a
Description: Momiji was going through and found that some crucial components to add this just weren't there.

Issue 1856: CSS in Tabula Rasa overrides height attribute in IMG tag
Category: Rendered Obsolete, Tidying Extremely Old Issues
Patch by: n/a
Description: Momiji says: "We've updated the code handling image resizing in entries and comments, so I'm going to close this as any current issues are most likely something exciting and new."

Issue 1890: issues with various site elements on Windows phone
Category: Rendered Obsolete, Seven Years Is Basically Dead in Electronics Years, Tidying Extremely Old Issues
Patch by: n/a
Description: When someone with a Windows phone has a problem with this again, these issues can be revisited.


Allowing Embeds:
chebegeek went on an allow-embed spree! Thank you! Here are some of the results.

Peertube on stopthatimp.net: domain no longer hosting
Allowed: Blogtalk, Podomatic, Streamable, getyarn.io, Smugmug, MSNBC, Reddit

Issue 2450: whitelist embeds from peertube?
Category: Rendered Obsolete, Bitrot
Patch by: n/a
Description: This particular vid site doesn't seem to be there anymore. :\

Issue 2453: whitelist embeds from blogtalk (pull request)
Category: Allow-listing Embeds
Patch by: chebegeek
Description: Completed!

Issue 2649: add Podomatic to embed whitelist (pull request)
Category: Allow-listing Embeds
Patch by: chebegeek
Description: Completed!

Issue 2720: add getyarn.io to embed whitelist
Category: Your Patch Is In Another Castle Ticket
Patch by:
Description: Resolved in #2977

Issue 2884: streamable.com whitelist pattern needs updating
Category: Your Patch Is In Another Castle Ticket
Patch by: #2977
Description: Streamable's embed pattern is different than previously thought. Another chebegeek production.

Issue 2895: add Smugmug to embed whitelist
Category:
Patch by:
Description: Patch, ticket #2977, yadda yadda

Issue 2896: add MSNBC to embed whitelist
Category:Your Patch Is In Another Castle Ticket, Rachel my beloved
Patch by: ticket #2977
Description: Now you can see Rachel Maddow's expression of sheer glee at explaining some wacky wonky topic from sources other than YouTube.

Issue 2903: add Reddit to embed whitelist
Category: Completed in #2977
Patch by:
Description: Yup



Issue 2711: update Github user profile icon to HTTPS (pull request)
Category: HTTPS everywhere
Patch by: RMHolsen
Description: The SSL proxy will now do the right thing with Github's little site icon.

Issue 2887: allow <details> and <summary> elements in comments (pull request)
Category: Spoiler handling, HTML5 my beloved, Overenthusiastic HTML cleaner
Patch by: momijizukamori
Description:

HOLY WOW THIS WORKS IN COMMENTS NOW

The DW/LJ/spoiler cut has been amazing for entries since it came out on LJ, and HTML5 only recently (oh myyyy, HTML5 has been around for how many years???) -- anyway, it caught up, and it's been available to use in entries in addition to the venerable cut. But comments have not been able to use it! (Because the HTML cleaner is extremely suspicious of anything that could possibly used for evil. Because it's better from a security standpoint to disallow first and ask questions later.) And okay so people have found some BALLER ways to hide spoilers in comments and honestly I'm in awe, but this is the way that HTML 5 wants you to do it:
<details>
<summary>Spoiler warning</summary>
Spoiler details go here! Go wild!!!! IT'S LIVE NOW!!!!!!
</details>

This HTML 5 syntax can be used in comments for spoilers, games, sensitive content, or whatever now.

Issue 2902: the password length in the "change email" form needs to be larger
Category: Making things make sense, 72 is bigger than 50
Patch by: zorkian, possibly dev-on-prod
Description: Dreamwidth allows quite a bit of annoyance to anyone who might want to crack your passwords. (Usually the value to a hacker of any random person's online presence is your good search engine reputation, and they can sell your login to spammers who dearly want search engines to pick up their bad links.) It would also be good to be able to change your stale or potentially compromised password to something of an equally obnoxious length, but prior to the new year's code push, the maximum the form allowed was 50 characters, instead of 72 like it ought to have been. Please look into using a password manager, which will remember unique and random character passwords for all of your logins, in a way that storing them in your brain maybe won't.

Issue 2949: convert /manage/banusers to TT (pull request)
Category: The Great Template Toolkit Conversion, Resisting the urge for a complete rewrite
Patch by: momijizukamori
Description: Yet another page converted away from Brad's Markup Language. Momiji says: "Part of the ongoing crusade eliminate BML from the codebase! One page down, many more to go..."
mark says: "Woo! Thank you! Every time I review one of these, I have these itches to rewrite the Perl so it's more modern and cleaner... but then I realize that would make this project take 10x as long. Soooo nope. Discretion is the better part of valor or something."
denise says: "Only one endless modernization project that everybody hates at a time, Mark."
It's not that we hate it as such, but sometimes things move or look different and generally that's no fun even when it's attached to necessary fixes.

Issue 2951: Fix send-email working on dreamhacks (pull request)
Category: Developers need love too, A Strongly Worded Letter to Cloudflare
Patch by: momijizukamori
Description: Momiji says: "When we moved email notifications to AWS, we accidentally broke email sending from DreamHacks, because the AWS mailer uses some options sendmail on the hack box does not. This now checks if those options are set before trying to use them, and skipping them if not."

Issue 2952: Add a link for Discord to contrib docs (pull request)
Category: The Wheel of Time turns, Discord, dev communications
Patch by: momijizukamori
Description: Momiji says: "We moved to using Discord for dev communication rather than IRC, but this was not linked anywhere helpful in the repo itself. This has now been fixed!"
One of the hard problems in online communication is moderation and platform management. IRC in particular is hard to keep as open to new people looking for a little help with development, while still keeping out the people who would prefer to fill it with rude appendages and worse. It also helps to have a platform that people are comfortable using. And these days the sweet spot seems to be Discord.

Issue 2953: Convert /tools pages to TT (pull request)
Category: The Great Template Toolkit Conversion
Patch by: momijizukamori
Description: See a BML page, fix a BML page.

Issue 2958: <details>/<summary> tags have no styling in sitescheme
Category: CSS hijinks, HTML5 my beloved
Patch by: momijizukamori
Description: The little sideways triangle that accompanies a cut tag also accompanies the <details> tag, except the CSS was taking that away on site themed pages. Momiji: "Which is very silly in this case, and once I'm sure it won't make other bits of the site layout go haywire I'm gonna see about fixing that."

Issue 2959: Restore ability to apply user CSS to siteschemes (pull request)
Category: Accessibility, Fun Browser Tricks, Technically it's "site skin" but it was site scheme on LJ soooooo...
Patch by: momijizukamori
Description: Adds a class to body tags for Tropospherical Red & Purple, on Foundation pages. Or, if you were trying to use a userscript and it was failing on some pages for no good reason, try again?

Issue 2964: Don't override browser display for details and summary (pull request)
Category: #2958, Browser hijinks, HTML5 my beloved
Patch by: momijizukamori
Description: Momiji says: "The details HTML element is basically a nice little native expand/collapse that allows you to hide and unhide blocks of text. By default, browsers usually style it with a little arrow at the side to indicate that it can be expanded and collapsed. We, however, had some CSS fixes for old browsers (IE and very old versions of Firefox) that didn't support this newer element - which were probably added when those browsers weren't super old and it was actually a good idea - that caused the arrow to vanish entirely for all browsers. Very silly. Now that we are in the future, those workarounds can be removed!"

Issue 2965: Protected foundation (pull request)
Category: The Great De-BML-ening, Foundation
Patch by: momijizukamori
Description: Momiji says: "More dragging of pages into the 21st century! Note: this does move OpenID login one click away on the page - this choice was made to better match the regular login modal, to make the design more visually balanced, and because the standalone OpenID page has a better explanation of what OpenID is and how to use it."

Issue 2970: Add Beta flag for new inbox redesign (pull request)
Category: Beta Testing, Inbox Update
Patch by: momijizukamori
Description: Momiji says: "After we accidentally pushed the inbox update live without planning to, and got a bunch of feedback, we realized we uhhhh should probably make it a beta, until we get all the bugs ironed out, as it's a pretty major rewrite of the code."
Here's the dw_maintenance entry: Switching to hCaptcha + Beta Inbox available
Beta features page

Issue 2978: Tweaks to the new inbox design (pull request)
Category: Beta Testing, Inbox Update
Patch by: momijizukamori
Description: Round one of tweaks to the new inbox design, based on user feedback!

• Unread items are now expanded by default
  
• Fixed bad word-wrapping settings
  
• Added a touch of margin to timestamps so they don't run up right against subject lines
  
• Added the 'unsent' filter view back in.
  
• Add controls back to the bottom of the message list

26 total issues resolved
Contributors: RMHolsen, chebegeek, momijizukamori, zorkian

Comments

[momijizukamori]

2965 isn't actually merged yet, I realized after open it that another branch had gotten mixed in *g*

Also I think 2959 won't make the existing userscript work again, but it will make other scripts and user css that relied on it work again!

[alexseanchai]

\o/

[falena]

I, er, understand very little of these updates, but I just want to thank all the contributors working on DW!

[silveradept]

Most of the things in a code tour amount to "The DW codebase is old enough to drink, and we are trying to make it less a project that started in someone's dorm room and more a place that acknowledges and takes advantage of programming and user practices in the current year wherever we can."

[falena]

Hehehe, thanks for the explanation. I am kind of thick, someone else just posted about it and kindly explained that issue 2887 means we can do cuts in the comments as well! That is something I can definitely be excited about, other than in the general sense that seeing people actually working on DW always makes me, I mean. <3

[silveradept]

DW loves having people actively working on it, and would love to have more people actively working on it, both in code and non-code ways.

Being able to do cuts in comments is a very nice thing. I'll bet the RP accounts will really appreciate it.

[ladyasul]

I made a sound when I read that first item on the list. THANK YOU! :D

you guys are seriously the best. I'd ask you to stop hogging all the awesome. but I enjoy seeing what you do with it. ;)

(moved my list of Stuff I Noticed to the post in dw_beta....)

[brainwane]

Great to read this! Thanks for the reminder to use the details and summary tags in posts where appropriate and for the opportunity to use then in comments! I need to look up whether/how to use them in Markdown....

When someone with a Windows phone has a problem with this again, these issues can be revisited.

What a blast from the past!

[bluedreaming]

So excited that < details > etc. now works in comments!

[pauamma]

Re 2949, sometimes conversion takes a giant leap from "rah, in her home office, making do with raw SQL" to TT+Foundation, without even pausing to glare at BML.

[mark]

Even better! :)

[yuuago]

I'm so excited about the addition of cuts that work in comments. This is great.

Thanks to everyone for all the hard work!

[muccamukk]

This is all fantastic! I love the spoiler cut, and the inbox looks so much nicer now (had turned off the beta, but I have it on again).

[silveradept]

Silly question being asked in public: now that the parser can do cuts the HTML5 way in comments as well as posts, will the custom <cut> tag be moving in the direction of becoming a <details>/<summary> combination?

[kareila]

We will always have to support the old cut syntax for backwards compatibility / LJ import reasons. In fact, <cut> is just <lj-cut> with a more generic tag name.

Theoretically the HTML generated by the tag could be changed to something more modern, but in my experience, Dreamwidth users don't like it when the way their content is displayed changes in a way that they can't control, regardless of the purported benefits of that change.

[azurelunatic]

The big difference is that <cut> opens on full entry view, and <details> stays closed until acted on. So that would be a pretty major behavior change.

[silveradept]

All very good reasons to continue supporting the current behavior, even as new things come into the toolbox. Thank you both for answering.

[thistleingrey]

This is an amazing list--thank you to each of the contributors!

[runpunkrun]

Thanks for all the hard work everybody! I'm excited about the details/summary tags working in comments now.

Sprinkling magnetic confetti all over the living room because

[jesse_the_k]

2887 is my jam!

Very excited to try out an inbox that uses the whole screen width!

(magnetic because I can wave my magnetic wand and pick 'em all up again)

Re: Sprinkling magnetic confetti all over the living room because

[mark]

Very smart, that magnetic confetti!

[runpunkrun]

Ohhh, but question: How well do the details/summary tags work with screen readers? I don't want to recommend its use in the comm I moderate if it's not accessible.

[bemused_writer]

Love reading these updates! Also excited to see more embedding options. (^^)