dw_dev | 18 June - 18 July 2020 code tour! HANG ON TO YOUR TIARAS

There was SO MUCH CODE CONVERSION oh my gosh.

kareila finished a knitting project and didn't pick up another one so CODE MACHETE TIME.

roadrunnertwice is still working on the spite-fueled redesign (also less DRAMATIC WOODCHUCK now).
80 issues, thirteen pages in the notepad before putting in the information. HAIL THE DEVS.

Issue 137: Replace tint and shade with mix (pull request) (nonfree pull request)
Issue 2741: SCSS: Replace tint and shade with mix (pull request)
Category: stylin’, is CSS anything but style?, bringing code into the century of the fruitbat, code machete, quote from the dev
Patch by:

nfagerlund
Description: We had some old, crusty code. It was fixed

roadrunnertwice says this: ‘Some of our CSS is written as SCSS, because that helps save devs' time. Some of that SCSS also happened to rely on weird non-standard extensions that were only available in one SCSS compiler tool, so we changed those bits to make them work with all normal SCSS compilers.’

Issue 1044: Convert BML files under htdocs/admin (pull request)
Category: KAREILA STOMP, building foundations for a better tomorrow
Patch by:

kareila
Description: Brad’s Markup Lanague is GOING AWAY.

Issue 1841: suggested improvement for /admin/priv: include packages in dropdown (pull request)
Category: bringing code into the century of the fruitbat, functionality
Patch by:

kareila
Description: Long ago and far away,

rahaeli created packages on Another Social Media Site and now it’s useful for us in dealing with privileges.

Issue 1997: add Medium to profile other-sites block
Category: user functionality, talking to other people
Patch by:

kareila and A GHOST (seriously, who were you? Thank you!)
Description: Added Medium to the other sites bit in the profile.

Issue 2160: DW::User::trustmask prints useless stack trace in server logs
Category: weird bug connects to weirder bug
Patch by:

kareila
Description: Useless information was being printed when people needed to find out how something was broken. NOT ANYMORE!

Issue 2293: document new config parameter ALL_TRAFFIC_IS_SSL
Category: bringing code into the century of the fruitbat
Patch by:

kareila ?
Description: We don’t support unsecure pages. Unsecure is a one way trip to hacky land and we don’t do that here.

Issue 2326: Manage Subscription Filters: extra (blank) entry in dropdown (pull request)
Category: code machete
Patch by:

kareila
Description: Subscriptions would give you an extra blank space. We aren’t Taylor Swift, we don’t need blank spaces.

Issue 2350: Prevent personal account from being converted to a community if it still administers other communities? (pull request)
Category: save the rp’ers
Patch by:

kareila
Description: Somehow we close our eyes - and you can no longer convert your personal journal to a community if that journal admins communities.

Issue 2354: Add Insanejournal to Other Sites in profile
Category: talking to other people, user functionality
Patch by:

kareila
Description: What it says on the tin.

Issue 2359: can't load next page of text results from /support/history (pull request)
Category: helping support
Patch by:

kareila
Description: I don’t know about the rest of the Support Volunteers, but I use the absolute mess out of the support history page because I can crib from other people’s much better answers. (Now you know the secret of support!) This fixed an issue that was not showing support history.

Issue 2365: Autoformat post-by-email using markdown
Category: posting in new and quite interesting ways, bringing code to the century of the fruitbat, mark it on down here
Patch by:

nfagerlund
Description: All post by email will be automatically formatted with markdown!

Issue 2374: more suggestions for "Other Sites" list on user profile
Category: talking to other people, user functionality
Patch by:

kareila
Description: A whole swath of new other sites will be available to add to your profile!

Issue 2385: investigate possibility of excluding "!markdown" formatting marker from content search for "markdown"
Category: user functonality, mark it on down here
Patch by:

kareila
Description:

kareila fixed the issue where ‘markdown’ would show the formatting marker in the search. Not as intended, fixed now!

Issue 2419: make markdown indicator case-insensitive (pull request)
Category: mark it on down here
Patch by:

kareila
Description: Anyone else not pay attention to stuff and type !MARKDOWN because why not? And it not work? FIXED

Issue 2421: Most form fields have "Dramatic Woodchuck" zoom on mobile (pull request)
Category: DRAMATIC WOODCHUCK, SQUISH, spite-fueled redesign, the last great woodchuck hunt
Patch by:

nfagerlund
Description: As much as we all like the DRAMATIC WOODCHUCK, it shouldn’t happen while journaling. It won’t now.

Issue 2481: Remove spellcheck support (pull request)
Category: bringing code to the century of the fruitbat
Patch by:

kareila
Description: Ding dong, spell check is gone.

Issue 2488: FAQ 103 is missing the textarea tag
Category: user functionality, non scripta non est
Patch by:

kaberett
Description: Fixed some tags in the FAQ.

Issue 2534:

user expansion should be disabled in rss reeds
Category: communication, talking to other sites
Patch by:

nfagerlund
Description: RSS will no longer act weird with @ user names.

Issue 2565: Pagination in Manage Comments under workas malformed (pull request)
Category: user functionality
Patch by:

kareila
Description: Anyone else think

kareila got bored? No? Just me? ANYWAY the pagination for your manage comments page is now fixed.

Issue 2573: Enable markdown in comment forms (pull request)
Category: spite-fueled redesign, mark it on down here, posting in new and quite interesting ways, quote from the dev
Patch by:

nfagerlund
Description: “On the beta create entries page and in all comment forms, you can now pick your preferred style of text formatting. CHOOSE YOUR FIGHTER: Casual HTML (the classic default), Markdown (the new challenger), or raw HTML (secret boss).
Also, all email posts and email comments now default to Markdown, but you can switch them to casual HTML by including a post-format: html header.”

Issue 2582: shop/receipt page has no window title (pull request)
Category: user functionality
Patch by:

kareila
Description: It’s easier to shop if you know what it’s saying.

Issue 2585: Profile page "other sites" lists obsolete Google Talk
Category: code machete, lamented google products
Patch by:

kareila
Description: Anyone else miss Google Talk? It’s obsolete enough to no longer be on your profile.

Issue 2591: extend banning functionality to cover community invites (pull request)
Category: no means no, user functionality
Patch by:

kareila
Description: When you ban someone, it should cover all communication. Now it does.

Issue 2592: fix username swap bug with tokens owned by different accounts (pull request)
Category: user functionality, save the rp’ers
Patch by:

kareila
Description: There was some weirdness with the username swapping and uh, now it’s supposed to work right.

Issue 2593: update Other Sites icon for Twitter (pull request)
Category: user functionality, talking to other people
Patch by:

kareila
Description: Twitter updated their icon, so we updated here for them.

Issue 2602: Replace opt-in s2foundation beta with opt-out nos2foundation beta (pull request)
Issue 2608: Nail down formatting dialects and `editor` prop
Category: spite-fueled redesign, quote from the dev
Patch by:

nfagerlund
Description: “We've been running a beta test of some updates to the site-skin comment pages, the "more options" reply form, the icon browser, and the site-skin icon list pages. After helpful feedback from our testers, those changes are ready for prime-time... WE THINK.
All users will now get the updated pages and components by default, but if anything's too broken to use, you can go to the beta features page and disable it. But if you do, PLEASE REPORT THE BUG YOU'RE HAVING A PROBLEM WITH by commenting in

dw_beta. The ability to revert these updates is only temporary, and we'll remove it as soon as we think we've fixed all major bugs with them.”

Issue 2618: when trying to delete a community, the user account is deleted instead (pull request)
Category: user functionality
Patch by:

kareila
Description: Some clarity for when you’re about to delete a community

Issue 2653: Header display turds in foundationized tropo (pull request) (nonfree pull request)
Category: stylin’, quote from the dev
Patch by:

nfagerlund
Description: “In the foundation versions of the tropo skins, the menu highlight colors were wrong. Plus Tropo Purple had a weird display glitch (extra spiral) on mobile. Both fixed.”

Issue 2690: Userview adminpages (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description:

kareila has been very busy, and now there are pages that are easier to work with.

Issue 2693: hush warnings in /support/faqbrowse (pull request)
Category: building foundations for a better tomorrow, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: Bugs in the support! NO - oh wait, there comes

kareila with the bug stomper.

Issue 2696: convert /admin/faq pages to TT/Foundation (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: So much code conversion.

Issue 2698: Always display beta features in a consistent order (pull request)
Category: things either exist or they don’t
Patch by:

nfagerlund
Description: No longer will the beta features escape into chaos!

Issue 2699: TT conversion of shop pages, part 1 (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: Changed up old payment code

Issue 2700: convert /lostinfo (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: If you pay attention to the lost info page, the code has been updated.

Issue 2701: convert /site/index (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: someone find

kareila a good knitting thing, wow (I tease, I tease!). So much conversion of code.

Issue 2702: Fix misaligned site logo (pull request)
Issue 2747: Site skin comments: set vertical-align: middle on icon links (pull request)
Category: quote from the dev, stylin’
Patch by:

nfagerlund
Description: “Two minor CSS tweaks to compensate for an earlier CSS tweak in the "updated stuff" beta.”

Issue 2704: convert remaining stats pages (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: Code Conversion!

Issue 2705: convert /moodlist (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: Code Conversion!

Issue 2706: Machete common code 🔪 (pull request)
Category: code machete
Patch by:

kareila
Description: Good bye, dusty code!

Issue 2707: Test html cleaner (pull request)
Category: user functionality, building foundations for a better tomorrow, bringing code to the century of the fruitbat
Patch by:

martindemello
Description: Good bye, BML!

Issue 2709: test html cleaner with minimal external dependencies (pull request)
Category: user functionality, building foundations for a better tomorrow, bringing code to the century of the fruitbat
Patch by:

martindemello
Description: Good bye, BML!

Issue 2714: Remove extra .columns div in faqsearch (pull request)
Category: non scripta non est, quote from the dev
Patch by:

nfagerlund
Description: “We updated the FAQ search page, and the new version had a visual glitch in some browsers.”

Issue 2715: convert /admin/priv (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: CODE CONVERSION

Issue 2716: Align external user icons the same way as site user icons (pull request)
Category: stylin’, quote from the dev
Patch by:

nfagerlund
Description: “User icons for sites other than Dreamwidth looked weirdly misaligned sometimes.”

Issue 2717: possibly wrong redirect after posting from new comment preview when viewing a single thread (pull request)
Category: spite-fueled redesign, quote from the dev
Patch by:

nfagerlund
Description: “If you post a comment while viewing a specific thread of a comment page, we try to return you to that exact same thread view after you post.
Well, sorta! We weren't doing it very consistently. Only the quick-reply could reliably do it. But due to a quirk of the old preview page, the preview form could ALSO send you back to the right place, IF you previewed from the quick-reply. (If you clicked "more options" and THEN previewed, you were out of luck.)
The new comment preview page didn't inherit that quirk, so preview started sending you back to the default comment view for that entry. People noticed that and (very politely!) asked for the old behavior back, and THAT'S when we noticed how wildly inconsistent the "return to thread" behavior was. So this time we finished the job, and now commenting will ALWAYS try to return you to your original thread view, no matter whether you're quick-replying, previewing, "more options"-ing, editing a comment, or opening the reply link in a new tab.”

Issue 2719: convert statushistory.bml and userlog.bml (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: CODE CONVERSION

Issue 2721: New spam report for spam admins: "comment in" (submitting user) (pull request)
Category: spamhammer, helping Spam Team
Patch by:

kareila
Description: Helping out the Spam Team

Issue 2722: jQ expects absolute protocol links, page prints relative protocol links (pull request)
Category: technical terms, quote from the dev
Patch by:

kareila
Description: “At some point we told LJ::S2::Image_std to start printing relative protocol links, but the JSON generated by talkscreen.bml for use by jquery.commentmanage.js was still using links that included the protocol, which meant that this.element.find('img[src="'+newData.oldimage+'"]') would never get a match, and so whenever you clicked on an icon for freezing/unfreezing or screening/unscreening a comment, the icon link would be replaced by a text link instead of another icon link.”

Issue 2728: make lastmodtime in FAQ preview look more like in LJ::Faq->load (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: Date now matches the format of the finished FAQ during preview. (Well, pretty close match, anyway)

Issue 2729: convert /admin/translate pages (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: CODE CONVERSION

Issue 2730: Properly pass authas html for importer index page (pull request)
Category: the importer (dun dun dun)
Patch by:

momijizukamori
Description: Authorization issues should be a little less of a thing?

Issue 2735: new comment preview form doesn't include "admin post" metadata when previewing (pull request)
Category: spite-fueled redesign, quote from the dev
Patch by:

nfagerlund
Description: “Missed a spot on the new comment preview page!”

Issue 2738: fix Sphinx comment jobs (pull request)
Category: quote from the dev
Patch by:

kareila
Description: “When the comment construction path was recently refactored, we missed a step and ended up submitting requests for Sphinx to reindex edited comment text without submitting the ID for finding the comment in the database, which is an unhappy outcome for all involved. This updates the job arguments to be valid again.”

Issue 2739: reports of CAPTCHA response of '0' being falsely marked as no response when commenting (pull request)
Category: captchas (dun dun dun)
Patch by:

kareila
Description: Captchas should accept 0 again!

Issue 2740: In build_static.sh, check for proper Compass version (pull request)
Category: site functionality, quote from the dev, complaining PROPERLY
Patch by:

nfagerlund
Description: “A while back we upgraded a tool we use for deploying the site, but forgot to change the thing that complains if you don't have a new enough version installed. Now it complains properly.”

Issue 2742: Improve robustness of concat_res and cachebuster params (pull request)
Category: preemptive bug fixing, PRANKING, quote from the dev
Patch by:

nfagerlund
Description: “Pre-emptive fixes for bugs we haven't technically caused yet. The (weird, outdated) thing we use to bundle JavaScript and CSS files together can flip out and break things under certain conditions.

roadrunnertwice was doing a bunch of research on some things that were guaranteed to cause those conditions, and got pranked extremely hard.

Issue 2743: LJ::OpenID::consumer can't handle Hash::MultiValue inputs (pull request)
Category: it can’t HANDLE the HASH, bring it gravy, KAREILA UNSTOMP
Patch by:

kareila
Description: This was Never Broken. You see Nothing.

Issue 2744: Add /dev/formats page (pull request)
Category: building foundations for better tomorrows, future digital archeologists thank you, quote from the dev, bringing code to the century of the fruitbat
Patch by:

nfagerlund
Description: “The implementation of markup type switching is more complicated under the hood than it might seem, because we were trying to set ourselves up well for the next decade without mangling the last decade-worth of content.
The way we decided to do this was by keeping multiple versions of the different formats and remembering which version each post used; when we want to change how Markdown works, we can call it "Markdown 2," update the UI to use that, and leave all existing content totally unaffected.
People writing future API clients or doing interesting automated stuff with email posts might need to know about all those historical formats, so now there's a special documentation page with auto-generated info about them.”

Issue 2745: Lay some mojibake traps around the inbox and front page (pull request)
Category: i’ll get you my pretty and your little bug too!, quote from the dev
Patch by:

nfagerlund
Description: “Russian and Ukrainian users keep encountering broken text on the home page and on SOME views of the inbox, but NOT anywhere else on the site. None of the devs have ever been able to reproduce this, and it's incredibly aggravating. So we've put some logging in place to shout very loudly whenever someone trips the bug, and hopefully we can learn more about what's causing the problem that way.”

Issue 2748: convert /extcss/index.bml to DW/Controller/CSSProxy.pm (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: CODE CONVERSION

Issue 2749: Fix link colors in `th` elements that occur in a `tbody` (pull request)
Category: we did not become one with the box, quote from the dev, stylin’
Patch by:

nfagerlund
Description: “We updated the page for managing community membership, and it made user links go into stealth mode (white-on-white). But now, ❗️ (guard alert sound effect from Metal Gear Solid)”

Issue 2750: migrate export_do.bml and export_comments.bml to DW/Controller/Export.pm (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP
Patch by:

kareila
Description: CODE CONVERSION

Issue 2755: Icon page pagination links look wonky in s2foundation beta (pull request)
Category: stylin’, quote from the dev
Patch by:

nfagerlund
Description: “In the "updated stuff" beta, page-switching links (when there's too many comments or icons for one page) got smushed onto one line.”

Issue 2759: Fix comment-eating form_auth expiry bug (pull request)
Category: comments, code eating bug, quote from the dev, no longer NOPE
Patch by:

nfagerlund
Description: “We refactored a bunch of the code that handles comments. The only real visible part of that was the new comment preview page, but it also touched a lot of weird internal stuff.
One of the things our comment forms include is an expiring consistency check; this helps make it harder for nefarious sites to spoof our comment forms, but it also sometimes causes comments to fail if a page has been open for a really long time. The old comment code had a special case for those failures, so it could rebuild the comment form and let you try again without losing your comment text. We accidentally missed this during the refactor, so we were giving stale forms an unhelpful "NOPE." Now that's fixed, so we can handle stale forms gracefully again.”

Issue 2762: hitting a bml link for a converted legacy page doesn't get redirected? (pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP, 404 nevermore
Patch by:

kareila
Description: Hitting the bml page now directs you to the new page.

Issue 2764: LJ::HELPURL links need to be updated to remove .bml suffixes (pull request) (nonfree pull request)
Category: building foundations for better tomorrows, bringing code into the century of the fruitbat, KAREILA STOMP, code machete
Patch by:

kareila
Description: CODE CONVERSION

Issue 2768: Improve display of polls (pull request)
Category: spite-fueled redesign, did not rewrite the universe, saving the rp’ers.
Patch by:

nfagerlund
Description:

roadrunnertwice looked at the poll code, spread some salt, rang some bells, should work much better on mobile now.

Issue 2769: remove useless widget SettingProdDisplay.pm 🔪 (pull request)
Category: CODE MACHETE
Patch by:

kareila
Description: removing old code

Issue 2771: Fix extra-fluffy inbox comment notifications (pull request)
Category: removing extraneous spaces, mark it on down there
Patch by:

nfagerlund
Description: No more extra line spaces in the inbox

Issue 2772: Tests: Pin (some)

_mention tests to latest format versions (pull request)
Category: cassandra passes through town, building foundations for better tomorrows, mark it on down there
Patch by:

nfagerlund
Description: Markdown, new versions, testing.

80 total issues resolved
Contributors:

kaberett,

kareila,

martindemello,

momijizukamori,

nfagerlund

That's all for me today, make sure to thank your devs!

Flat | Top-Level Comments Only

Minor errata:

Issue 2385: investigate possibility of excluding "!markdown" formatting marker from content search for "markdown"

That one's actually closed without doing anything -- kareila investigated, and the list of Stuff that should be excluded from search is much longer than just that, so we need some kind of broader fix, which will be a different ticket.

Issue 2707 and 2709: test html cleaner with minimal external dependencies

A new contributor (!!!) made it so certain tests can check the specific thing they're trying to check without needing to load basically the entire site. This is only of use to other devs, but it's nice.

Edited (can't @ from inside a raw-code tag, oops) 2020-07-21 19:10 (UTC)

Oh, also, in case anyone here is affected by the OpenID login page being temporarily broken: OpenID folks can still log in via the "more options" comment form! Just set the user type to OpenID and tick the login box, and preview a comment; that should log you in and you can continue as normal.

OMG WHAT LOL

Thank you for the workaround - I will need to channel that into support.

Yeah, Controller::Talk (and talkpost_do.bml before it) has a totally parallel implementation of login. 😭🤣😎

I think there's probably a legit good reason for it, since it needs to like hold onto the comment POST form while building previews or regenerating the comment form for errors and the like. And the heavy lifting is mostly handled by user-object functions or whatever. STILL THO???

Actually, something I noticed after going back to think about your PR is that the talkpost version of OID login doesn't actually pass the $get_args to the OID consumer constructor; it leaves that blank and just gets the defaults from the wrapper it's calling. Do you know what's even in those args? I didn't dig deep enough to figure it out.

Off the top of my head, no idea. I was more focused on taking the bits out of BML than figuring out what the bits did.

Yeah, that’s where I was at too — openid seems like a fairly deep rodent hole.

Yay code!

Minor nitpick for #2585: technically Google Talk is still on your profile, we just renamed it to Google Hangouts and updated the icon.

Noting this for future...

I am happy for Medium, InsaneJournal, Patreon, Pillowfort, Wattpad, and Reddit users who want to add links to their accounts on those platforms to "Other Sites" in their profiles!

I am happy for people who want to use Markdown in comment forms!

And I'm grateful for all of this work. Thank you, developers!