![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
roadrunnertwice) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
dw_dev2020-08-14 02:36 pm
Code Tour: July 18 to August 13, 2020
Hello, it's time for another code tour! This is mostly stuff that isn't live yet, but will arrive in the next code push.
Stuff to Make the Updated Comment Pages Better
RECAP: Our goal with the updated comment pages is to:
- Mostly reproduce the look and feel of the old comment pages...
- ...but make their implementation more maintainable, repairable, and consistent...
- ...and also make the site work better on mobile.
We're not changing things because we hate the layout of the living room, we're changing them because the floor joists are rotten. It's just that getting the living room looking the same afterwards can take a little bit of time.
Pull request 2790: Tweaks for Foundationized entry pages
Category: Visual bugs, the updated comment pages
Patch by: ![[github.com profile]](https://www.dreamwidth.org/img/profile_icons/github.png){kind=icon}
momijizukamori
Description: A small pile of visual tweaks, in our ongoing effort to make the new site skin comment pages look as much like the old ones as is practical.
Nonfree Pull request 140: S2pagination
Category: Visual bugs, the updated comment pages
Patch by: rshatch
Description: The page-switching links didn't quite look right in the updated comment pages.
Nonfree Pull request 139: Swap Tropo Purple primary and accent colors, to be slightly less neon
Category: Visual bugs, the updated comment pages
Patch by: momijizukamori
Description: The new version of Tropo Purple was too rowdy.
Issue 2777: Form for mass action on comments less subtle in s2foundation beta
Pull request 2778: Tidy up some s2foundation form controls
Category: Visual bugs, the comment page updates
Patch by: nfagerlund
Reported by: kareila
Description: New site skins: making a button look less "‼️", and tidying up dropdown controls a bit.
Pull request 2811: Site skin comments: Attempt to fix the wooz
Nonfree Pull request 141: Tropos: reduce background brightness
Category: The comment page updates
Patch by: nfagerlund
Description: On the updated comment pages, some photosensitive users reported weird migraine or vertigo issues. We're adjusting the spacing and width of some page elements in an attempt to NOT DO THAT. (Also: making the background darker on the default site skins. The background color actually didn't change, but people are widely reporting that it LOOKS brighter. We're unable to determine why they're seeing that, but we ARE able to darken it a tiny bit more.)
Pull request 2810: Various new site skin fixes
Issue 2793: Different fix for comment subject height shenanigans
Category: Visual bugs, the comment page updates
Patch by: nfagerlund
Reported by: kareila
Description: A small pile of visual tweaks, in our ongoing effort to make the new site skin comment pages look as much like the old ones as is practical.
BML -> TT Conversion Stuff
Pull request 2781: groundwork for profile conversion
Pull request 2796: convert /profile from BML to TT
Category: TT conversion
Patch by: kareila
Description: Converts the user profile pages to use modern templates instead of BML. This shouldn't result in any visible changes, since it left the styling alone. (Soon, though.)
THAT SAID, this is kind of a huge deal; profiles were one of the biggest and nastiest of the remaining BML pages.
Pull request 2816: convert /support/submit to Foundation
Category: Visual improvements
Patch by: kareila
Description: Updates the support ticket submission page to the new site skin styles.
Pull request 2808: fix missing strings from converting /shop/receipt to TT
Category: Cleanup
Patch by: kareila
Description: Fixed some stuff that got missed while updating a page to a newer code style.
Miscellaneous Stuff
Issue 2785: Community import still busted
Pull request 2786: [#2785] fix community import error
Category: Plain bugs
Patch by: kareila
Reported by: rahaeli
Description: The option to import to/from a community broke, and jobs were failing with a "You must be logged in to a personal account (not OpenID) in order to import content into it" error. Should be fixed now.
Issue 1663: Beta Icon Browser: Organize by Keyword instead of Upload Order
Pull request 2825: Icon browser revisions
Category: Icon browser, the comment page updates
Patch by: nfagerlund
Reported by: kaberett
Description: Yes. YES. You can finally choose to sort icons by keyword in the icon browser.
This item also includes some other changes for the icon browser:
- No text means no text. Got rid of the keyword menu that appeared under the selected icon in no-text mode. If you want to select a specific keyword for an icon with multiple keywords, enable yes-text mode.
- One-click operation. No more "select" button, just click the icon or keyword you want.
- Minor layout tidying.
Pull request 2733: Comment preview: Display toggleable truncated parent above preview
Category: New features, comment preview
Patch by: nfagerlund
Description: We replaced the comment preview a few code pushes ago with a better implementation, which means it's now possible to make other improvements to it. (The old version was completely unrepairable.) So here's another improvement: we now display the entry/comment you're replying to above the preview, which is where you'd expect it to be based on how comment threads are usually laid out. We truncate it to make sure your preview stays above the fold, but you can expand it to read the whole thing if you want.
(If JavaScript is disabled, the context goes below the preview like it always has, because otherwise there was no way to keep your preview above the fold.)
Issue 2797: Visually signpost the "do more shit" link on mobile menu
Pull request 2799: [#2797] add arrow glyph to username mobile menu link
Category: Visual improvements
Patch by: kareila
Reported by: rahaeli
Description: On mobile, the new-style site skins put the logout, inbox, etc. links behind a tap on the username on the left hand side of the menu bar. But it wasn't really clear that it was a menu of actions, so we added a double-arrow (») to show that it's not just a link.
Issue 2821: feeds with YouTube embeds have invalid site-embed errors
Pull request 2823: Fix embeds in feed content
Category: Plain bugs
Patch by: nfagerlund
Reported by: kareila
Description: Embedded media in feed accounts stopped working, due to a bug introduced in the markup formats work. Fixed.
Issue 2819: s2foundation breaks javascript on core1 styles
Pull request 2820: Re-enable javascript in core1 with s2foundation features
Category: Plain bugs, styles, the comment page updates
Patch by: nfagerlund
Description: Our built-in JavaScript stopped working in journal views for journals that use a "core1" journal style, which are usually old custom styles that were ported from LJ or IJ.
The bug is now fixed, but because of how basic core1 is, it's not necessarily fixed for all core1 journal styles. After the next code push: If you use a custom core1 style that overrides the Page::print() function, you must update your style to call $this->print_script_tags(); right before closing the <body> tag. (You can't do this until the next code push, because the function you need to call doesn't exist in core1 itself yet.)
If you don't want to deal with this type of breakage in the future, consider switching to a core2-based style that looks similar to your old one. Core1 is deprecated; you should expect occasional weirdness from it, and it will never support all of the features our modern style system supports.
Pull request 2813: Restore space between body and crosspost footer
Category: Plain bugs
Patch by: nfagerlund
Description: When you crosspost to LJ or another LJ-like site, we add a footer at the bottom to link back to the original post. There's supposed to be some line breaks before that footer, but they went away; now they're back.
Pull request 2802: Fix mobile blowouts on Drifting
Category: Visual bugs, styles
Patch by: nfagerlund
Description: The "Drifting" layout behaved real badly when viewing entries or comments with over-wide content on mobile.
Issue 2791: entry preview uses wrong alert-box class
Pull request 2805: [#2791] siteskin entry preview tweaks
Category: Visual bugs
Patch by: kareila
Reported by: rahaeli
Description: When previewing an entry in the beta create entries page, the "this is only a preview, your entry has not been saved" alert box at the bottom of the preview window used the wrong styling.
Issue 2177: improve no-such-user 404
Pull request 2814: use more sitescheme error templates
Category: Better failures
Patch by: kareila
Reported by: rahaeli
Description: This improved some error pages to be more informative and less gross-looking.
Pull request 2826: remove ineffective editjournal feature action:saveunsuspend
Category: Code machete
Patch by: kareila
Description: There was a useless "Save and Request Unsuspension" button on /editjournal, which was maybe part of a feature someone had started but not finished at the time that Dreamwidth's code forked from LiveJournal's.
Pull request 2774: give all cookies the secure attribute on HTTPS sites
Category: Modernization
Patch by: kareila
Description: The major browsers are in the process of changing their default behavior for cookies, so sites need to update what their cookies say to compensate. This does that. (Dreamwidth uses cookies to keep you logged in, and to recognize that you're logged in no matter whose journal you're currently viewing or commenting on.)
Stuff No One's Going to Notice
Pull request 2788: fix double escaping of file contents in /admin/fileedit
Category: Plain bugs, TT conversion
Patch by: kareila
Description: This fixes a bug that crept into an admin page during conversion, which had no effect on normal users.
Pull request 2818: test commafy without ljlib
Category: Cleanup
Patch by: martindemello
Description: This has no real effect on users. Our tests have a tendency to load the entire universe in order to test one tiny, isolated behavior; this updates some tests so they don't have to do that.
Issue 2779: uninitialized value warning generated by profile.js when viewing logged-out profile
Pull request 2800: [#2779] fix uninitialized value warning when viewing logged-out profile
Category: Cleanup
Patch by: kareila and nfagerlund
Description: This has no real effect on users, but was greatly annoying the devs.
Pull request 2809: more misc. cleanup
Category: Cleanup
Patch by: kareila
Description: This has no real effect on users.
Pull request 2641: improvements to bin/checkconfig.pl
Pull request 2789: second try for improvements to bin/checkconfig.pl
Category: Dev tooling
Patch by: kareila
Description: This has no real effect on users. It improves some tools we use for making sure a dev server is set up correctly.
Pull request 2773: misc. small cleanup fixes for July 2020
Category: Cleanup
Patch by: kareila
Description: This has no real effect on users.
Pull request 2780: Remove ancient JS function that always returns before doing anything
Category: Code machete
Patch by: nfagerlund
Description: 🔪
Pull request 2776: Misc: Silence some warnings
Category: Cleanup
Patch by: nfagerlund
Description: This has no real effect on users.
Pull request 2775: Make CleanHTML rely on DW::Formats for defaults/aliases
Category: Cleanup
Patch by: nfagerlund
Description: This has no real effect on users. Combining some duplicated code.
Pull request 2783: remove unused module cgi-bin/LJ/Setting/Bio.pm
Category: Code machete
Patch by: kareila
Description: 🔪
no subject
Thanks!
no subject
no subject
no subject
🐟
no subject
no subject
no subject
no subject
no subject
If it's one of the built-in layouts, those are all core2.
If it's a custom layout, go to advanced customization/your layers. Every journal style is made up of multiple "layers," and all of the layers that make up the currently activated style are highlighted in a different color.
So, find the "layout" layer for your current theme and see what layer it says it's a "child" of. Core2 layouts say "Child of layer 550: Dreamwidth S2 Core, v2". So, I think core1 layouts would say the same thing except "v1". (I haven't gone to check the actual string it uses.)
no subject