Code Tour (2023-07-28 to 2023-11-22)

[momijizukamori]

Quick code tour, all of which is now live on the site!

Issue 2163: Support more sizes of bandcamp embeds (pull request)
Category: whitelist ALL the things
Patch by: kareila
Description: kareila: "more accurate sizing of embed codes from other sites."

Issue 2315: support notifications not stopped when recipient loses access to private cat (pull request)
Category: admin, the perpetual march of progress
Patch by: kareila
Description: kareila: "the de-BML-ifying continues." This time, with a small security fix to boot - users with access to private support categories and email notifications for them turned on would still get the emails after losing access to the category (and then couldn't turn them off!).

Issue 2798: Foundation login form needs to grab keyboard focus? (pull request)
Category: a11y, 🐛
Patch by: momijizukamori
Description: We discovered some issues with the login modal in Foundation pages that made them difficult to use via keyboard navigation. These have now been fixed!

Issue 2932: allow fields in currents module to be cleared on edit (pull request)
Category: 🐛
Patch by: kareila
Description: kareila: "fixes a glitch with the beta entry form where fields in the Currents module couldn't be edited to be blank after being saved with a non-blank value."

Issue 3029: Allow adding more than one of the same type of site to the 'other services' (pull request)
Category: the perpetual march of progress
Patch by: kareila
Description: kareila: "This rewrites the "Other Sites" section of /manage/profile to allow for specifying more than one account per service type." Now if you have two ao3 accounts you want to link in the 'Other Sites' section of the profile, you can!

Issue 3038: Add syntax highlighting to the Custom CSS field (pull request)
Category: 🌈 styles!
Patch by: cmho
Description: cmho: "Adds magical syntax highlighting to the Custom CSS field, so it's a little easier to work on code!"

Issue 3060: add link to user's journal to text-only emails about access/subscription removal (pull request)
Category: Reducing confusion
Patch by: cmho
Description: cmho: "If you're receiving notification emails for when someone has unsubscribed or removed their access, the emails will now give a link to the other user's journal to remind you who they are."

Issue 3065: Directory search: remove "age" as a search option (pull request)
Category: code machete, the perpetual march of progress
Patch by: cmho
Description: cmho: "Removes search-by-age in the directory, because that's a weird holdover from the LJ days that we don't actually want on account of That's Weird."

Issue 3077: blacklist tags from tag cloud on /latest (pull request)
Category: spam-whacking, admin
Patch by: kareila
Description: Adds an admin-editable list of tags which are automatically blacklisted from /latest, because some of our more prolific spammers were getting spam tags in there, and they weren't dropping off again quickly.

Issue 3083: record information about expired sysbans for certain sysban types (pull request)
Category: spam-whacking, admin
Patch by: kareila
Description: There are some types of IP system bans where we start with temporary bans, and escalate to more permanent ones if the problem traffic continues - however, it wasn't possible to quickly look up expired bans on an IP. Now it is!

Issue 3086: Fix overflow of some HTML elements from /latest entries (pull request)
Category: 🐛
Patch by: cmho
Description: cmho: "Some HTML elements were picking up site style CSS due to overly-broad style scoping which led to some elements appearing wildly outside of the container, so this anchors absolutely-positioned items to the entry itself and also narrows the scope of some site styles in the Tropospherical layouts."

Issue 3109: write FAQ for "why don't you have a mobile app"
Category: admin, docs docs docs, reducing confusion
Patch by: rahaeli
Description:rahaeli: "The news post comments made it clear not enough people know why we don't have one!" It is now available here.

Issue 3140: fix list display issue in tropo nav menu (pull request)
Category: a11y, 🐛
Patch by: kareila
Description: kareila: "fixes a user-reported display issue with the tropo hover menu."

Issue 3163: /journals API routes (pull request)
Category: API 2.0, the perpetual march of progress
Patch by: momijizukamori
Description: Adds routes to the new API to get and edit journal accesslists and tags.

Issue 3183: Convert Homepage to Foundation/TT (pull request)
Category: the perpetual march of progress
Patch by: momijizukamori
Description: More modernization! This time, the homepage, both logged in and logged out.

Issue 3192: OpenID login panel is illegible in Gradation (pull request)
Issue 3243: Make OpenID login page look better in Gradation (pull request)
Category: a11y
Patch by: momijizukamori
Description: Making things a little nicer to look at.

Issue 3211: FAQ 90 will need to be updated after the next code push
Category: docs docs docs
Patch by: kareila
Description: We made some changes to one of the settings pages, and the FAQs needed to be updated to match!

Issue 3213: profile icon github.png is invisible on black background (pull request)
Category: a11y
Patch by: cmho
Description: cmho: "Adds a white fill to the cat part of the octocat, because on darkmode we don't actually want the github icon to be as visible as a black cat skittering around in the dark."

Issue 3216: allow embeds from mega.nz (pull request)
Category: whitelist ALL the things
Patch by: cmho
Description: cmho: "Whitelists embeds from Mega.nz."

Issue 3231: Fix tests (pull request)
Category: dev life, 🐛
Patch by: kareila
Description: kareila: "the automated test suite got cranky again."

Issue 3233: convert /manage/invites (pull request)
Category: the perpetual march of progress
Patch by: kareila
Description: "convert /manage/invites to Foundation, plus a few other minor tweaks."

Issue 3236: convert htdocs/index.bml to Foundation (pull request)
Category: the perpetual march of progress
Patch by: kareila
Description: kareila: "This is separate from the main homepage conversion project. In fact this page won't even display unless the dw-nonfree portion of the code is deactivated."

Issue 3241: New Inbox Updates - pagination and row styling (pull request)
Issue 3242: Inbox jul 23 (pull request)
Issue 3303: Inbox - read styling, no-JS fix, and imageshrink (pull request)
Category: the perpetual march of progress
Patch by: momijizukamori
Description: Assorted bugfixes for the new inbox page!

Issue 3254: Feed accounts unable to post (pull request)
Category: 🐛
Patch by: kareila
Description: kareila: "As we anticipated, the change to require a confirmed email when posting had unforeseen consequences. This fix will allow feed accounts to update again."

Issue 3257: arguments to notify_administrator_add are backwards (pull request)
Category: 🐛
Patch by: kareila
Description: kareila: "notify the recipient of the invite, not the sender."

Issue 3258: quick update widget on logged-in homepage defaults to alphabetically-first journal (pull request)
Category: 🐛
Patch by: kareila
Description: kareila: "the default selection in the quick update widget on the logged in home page should be the user's personal journal, not the journal that comes alphabetically first in the list."

Issue 3247: add removed strings to deadphrases (pull request)
Issue 3259: translation string cleanup A-F (pull request)
Issue 3284: translation string cleanup G-J plus restore local community strings (pull request)
Category: code machete, 🧹
Patch by: kareila
Description: Cleaning up unused stuff in the translation system.

Issue 3261: July cleanup (pull request)
Category: 🧹
Patch by: kareila
Description: Doing a bit of code-tidying.

Issue 3262: Community import fails due to unconfirmed email address (pull request)
Category: 🐛
Patch by: alierak
Description: alierak: "Recent change to require a confirmed email address before posting broke community imports."

Issue 3264: Remove page unload handlers for drafts (pull request)
Category: the perpetual march of progress
Patch by: momijizukamori
Description: The drafts autosave on the new entry page had a function to try and do a last-ditch save when the page was unloaded (ie, closed), but it turns out this is very hard to detect and also caused a confusing race issue where it would save a post as a draft after it had been posted (and thus cleared from drafts)

Issue 3267: convert /search to Foundation (pull request)
Category: the perpetual march of progress
Patch by: kareila
Description: kareila: "modernize page styling for journal search.

I was increasingly annoyed by how hard it was to read this page on my phone screen, and then embarrassed to realize that I had already converted it to TT 8 years ago and just skipped the Foundation step. So here is my atonement."

Issue 3268: fix coment -> comment typos (pull request)
Category: 🐛
Patch by: kareila
Description: kareila: "A user pointed out that a text string on the search page had misspelled comment as "coment". I did a source grep for the typo and found that the text with the misspelling was hardcoded and couldn't be fixed via the translation system.

So this fixes that, but for extra credit it also fixes another text match for "coment" that showed up in the CSS rules included in the headsup layout file."

Issue 3273: Don't allow public access list creation via API (pull request)
Category: 🐛, API 2.0
Patch by: momijizukamori
Description: Access lists and reading lists use the same backend representation, so it's possible to mark an access list as 'public' in code (because you can make reading lists public), but it's a bad idea and we don't let you do it through the site, so the API shouldn't let you do it either.

Issue 3280: Use dependency reqs from branch being built, not main (pull request)
Category: dev life
Patch by: momijizukamori
Description: Makes it possible to test things that require system library updates on Canary.

Issue 3291: Fix discrepency between what the wizard says fields do and what they actually do (pull request)
Category: 🐛, 🌈 styles!
Patch by: momijizukamori
Description: In the theme customization settings, there are two text fields you can customize: 'Text to leave a comment' and 'Text to leave a comment from your Reading page'. Contrary to what one would expect, the later text field is used for the link to leave comments EVERYWHERE that isn't a single entry view. This has been fixed, and the 'Text to leave a comment from your Reading page' is used on the Reading page, and, for paid accounts, the Network page (which is basically an extended Reading page), and the other reply text is used everywhere else.

Issue 3298: canary has defaulted to dw-free logged in homepage (pull request)
Category: the perpetual march of progress,
Patch by: momijizukamori
Description: There are two different versions of the homepage, one generic one for anyone using the codebase, and one specific to DW. The DW one is supposed to override the generic one, but it turns out that it is... not, after we converted both of them. This moves the DW-specific one so that it takes precedence

Issue 3299: Icon module on beta entries page shows 'Browse' button for free users (pull request)
Issue 3309: create entries beta: icon choice not autosaved
Issue 3310: create entries beta: finish integrating sticky entries (pull request)
Category: 🐛
Patch by: momijizukamori
Description: An assortment of bugfixes for the new entry page.

Issue 3312: Re-add editjoural.bml strings for now (pull request)
Issue 3313: Remove a bunch of strings from local deadphrases (pull request)
Category: 🐛, reverse code machete
Patch by: momijizukamori
Description: Accidentally removed some text strings that were still in use (for now........)


46 total issues resolved (plus some duplicates closed)
Contributors: alierak, cmho, kareila, momijizukamori, rahaeli

Comments

[senmut]

I want to say a BIG THANK YOU to all of you that do SO MUCH work to keep our Home looking and working right!

[momijizukamori]

You're welcome! It's our home too, really :)

[yuuago]

Thanks for the hard work!

[muccamukk]

Thanks for fixing the weird draft auto-save glitch. I thought I was losing my mind. "Did I post that? I thought I posted that!"

[cesy]

Me too

[kore]

OMFG I was getting the same thing and my memory is for shit, so I was like "???"

[momijizukamori]

Honestly I felt that way trying to debug this, other people were getting it semi-frequently but I didn't hit it once no matter what I did. It took someone with server log access going through and noticing there was a call to the draft save URL after the post URL.

[bluedreaming]

Thank you! The search page is so nice now (the type-in field overflows a bit to the right but small potatoes; it’s such an improvement!)

[momijizukamori]

If you can grab a screenshot, I can maybe toss it at some of our newer people who might like some low-hanging fruit to pick off.

[bluedreaming]

Sure! I’m on iOS 15.8 Safari running Canary

[momijizukamori]

Thanks! I'll pass that along as bug-bait ;)

[bluedreaming]

Awesome!

[azurelunatic]

Thank you everyone, and cmho in particular. I've been waiting for that link in the de-access/unsubscribe for a while!

[vriddy]

Thank you!!

[jjhunter]

Thank you for your efforts!

It's been a while since I've read one of these updates, the category tags always delight me.

[momijizukamori]

Same! I wish mine were a little cleverer this go around, but I wanted to get this up and perfect is the enemy of done, etc.

[batrachian]

yay code tour!

[teres]

Thanks so much for doing all this! It's really nice to have the homepage back (I'm using Canary), having the "Browse" button fixed is nice, too, and the search page now looks much more modern and consistent!

I love that you can also put in these fixes, even though they're not related to the modernisation effort. Dreamwidth looks better by the month, honestly.