just sit right back and you'll hear a code tour (2022-10-09 to 2022-10-22)

[kareila]

Yes, I know we just did one three hours two weeks ago, but all these changes are already live on the site, Skipper! Let's get cracking!


Issue 967: Convert login.tt to use Foundation (pull request)
Issue 968: Convert protected.tt to use Foundation (pull request)
Category: Foundation Conversion
Patch by: momijizukamori
Description: Foundation is the newer, more mobile-friendly styling for site pages. This updates some forms around logging in and viewing protected content to use the newer styles.

Issue 1866: fix up /tools/tellafriend (pull request)
Category: Brad, in his dorm room, with BML
Patch by: kareila
Description: The tellafriend page is a relic of LiveJournal days that badly needs some updating. Some of those updates have now been done! More are still needed.

Issue 2248: Ubuntu 17.10, or one of the package versions associated with it, breaks Dreamwidth
Category: bookkeeping, the left hand not knowing what the right hand is doing
Description: Work was done elsewhere to address these problems, and a comment was made to close the issue, but it wasn't actually closed until now.

Issue 2600: TaskQueue: to replace TheSchwartz (pull request)
Category: crimes against Git repositories
Patch by: zorkian
Description: This showed up as being newly resolved when Mark deleted his 'oopsqs' branch. The TaskQueue code has been live for a few years now. Nobody else understands how or why this works, but that's okay.

Issue 2905: First clause of last sentence of FAQ 216 is misleading verging on incorrect
Category: What do we say to the God of Death?
Description: The FAQ describes what we want the code to do. The code has a different agenda. We have another issue open (#2822) to make the code behave better at some point in the future! But not today.

Issue 2960: login redirect problem with URL-escaped characters (pull request)
Category: wheels within wheels
Patch by: kareila
Description: A thing was happening where if you logged in or out using the form on the control strip, the redirect back to the page you were on didn't work, because the page data was sealed inside of two envelopes, and the web server was only opening one of them. So now we only use one envelope. Smart!

Issue 2969: manage/logins breaks on lookup of expunged user (pull request)
Category: obscure admin page bugs
Patch by: kareila
Description: A tool that our site admins use to look up certain user info would break if the user being looked up was purged from the site, because databases go off and sulk when asked about things that don't exist. Now we politely check before asking.

Issue 2972: FAQ 51 wording nits
Issue 2973: Missing "all lowercase" mention and misleading mixed-case interest examples in FAQ 14
Category: consistency is a hobgoblin
Description: No patches here, but I did edit the FAQs as requested.

Issue 2978: Tweaks to the new inbox design (pull request)
Issue 2981: Inbox tweaks round 2 (pull request)
Issue 2983: Third round of beta inbox tweaks (pull request)
Category: dragging our site kicking and screaming into the future
Patch by: momijizukamori
Description: If you haven't visited dw_beta lately, there's an opt-in to test Momiji's inbox redesign! These changes incorporate beta user feedback and make the behavior of the page line up better with expectations.

Issue 2982: Make it possible to ban from communities again (pull request)
Category: page conversion bugs escaping into the wild
Patch by: momijizukamori
Description: When we convert pages from BML to mode modern code, we sometimes introduce bugs that aren't caught in testing. In this case, trying to use /manage/banusers as a community was acting on the journal of the logged-in user instead. The identity crisis has now been resolved.

Issue 2984: redirect hostnames with underscores before they reach apache (pull request)
Category: proper punctuation is also a hobgoblin, just do the thing!
Patch by: alierak
Description: We've long supported the feature where if you try to visit a link with an underscore in it, such as dw_dev.dreamwidth.org, you get redirected to dw-dev.dreamwidth.org, because we know what you meant, and yes it's frustrating that account names require underscores but URLs require hyphens. Unfortunately, a recent server upgrade removed that feature, so we had to figure out how to allow it again.

Issue 2986: add script dump-profile-editors.pl and associated hook (pull request)
Category: LEEROY JENKINS!
Patch by: kareila
Description: alierak and I had been periodically reviewing server logs for evidence of accounts being used by spammers. Mark recently (for very fine reasons) blew up the server logs, so this is a different way to get the same information for review purposes.

Issue 2988: usability tweaks for build-static.sh (pull request)
Category: devs doing dev things
Patch by: kareila
Description: This is a script that site admins have to run whenever CSS or JS files get updated on the site. These are just some minor changes to make it a bit more well behaved.

Issue 2989: update AnniversaryPromotion for 2022 (pull request)
Category: I know, I know, it's not even Halloween yet!
Patch by: kareila
Description: We frequently engage in a mad scramble on Nov 30 to make sure the bonus point promo in the shop is ready to activate. By preparing it ahead of time, I'm giving a holiday gift to our future selves.

Issue 2990: /tools/tellafriend is using the wrong template (pull request)
Issue 2994: a couple more tiny tweaks to tellafriend (pull request)
Category: page conversion bugs escaping into the wild
Patch by: kareila
Description: Another case of a converted page that wasn't tested before deployment, in this case because it wasn't even supposed to be here today, but it's behaving properly now.

Issue 2992: add ext/dw-nonfree/htdocs/stc/css to .gitignore (pull request)
Category: Git makes hobgoblins look positively lovely by comparison honestly
Patch by: kareila
Description: The dw-nonfree and dw-free repositories got merged, but they still have separate static build directories! This makes sure we're ignoring both of them, not just the obvious top-level one.

21 total issues resolved
Contributors: alierak, kareila, momijizukamori, zorkian

Comments

[brainwane]

Congrats and thank you!