Testers needed for Exciting Things
Sep. 4th, 2012 10:37 pm![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
So I'm working on Bug 647 AKA the 'kill talkread/talkpost with fire' bug. It is probably 99% done! Yaaaaaaaay, etc. It's at the point now where I need testers. Lots and lots of testers, because talkread gets hit a lot, and there's lots of little unusual cases I know I won't think of. So! First and foremost, I'm going to try and keep it live on my DreamHack, and any site-schemed entry or reply page can access it by adding '?fallback=s2' to the end of the URL.
exor674 said she would try to keep it live on her dev env too, for people to look at.
However, we're both working on other bugs too, so we may have to take our branches off live to work on other things. If you want to put the code on your own (git-enabled) dev environment, here's how:
1) Make sure your environment is up to date - the instructions for that are here. Both dw-free and dw-nonfree should be up to date.
2) Make a new branch off of your dw-free develop branch and switch to it.
3) Pull my remote branch by running this: 'git pull https://github.com/momijizukamori/dw-free.git nuketalkread' It'll ask you for a merge commit message - put in whatever.
3) Make a new branch off the dw-nonfree development branch and switch to it.
4) Pull the second remote branch: 'git pull https://github.com/momijizukamori/dw-nonfree.git nuketalkread'
5) Run '$LJHOME/bin/upgrading/update-db.pl --run --populate' to update the database with the new siteviews style.
Now you can use ?fallback=s2 on your pages too! So you can flip back and forth between the old bml view, and the S2 view, and tell me what's different/broken. I haven't actually tested this on comms at all, as I mostly use my Hack for style updates and thus have very little data in terms of entries/comments/users to test this on. Feel free to leave comments here about changes you find that need fixing! And seriously, beat on this thing - this is a page I don't want to fail on live.
Things I already know about:
-All subject lines in comments and entries are linked (it's a core2 issue, we're debating on fix vs leaving it)
-Screened comment count won't show up (again, core2, I'm working on that)
-Metadata on entries that have them have a slightly different alignment (approved change)
-The reply page for replying to comments shows when the comment you're replying to was posted (approved change)
-there's a little bit of space between the bottom of user icons and the bottom of the comment header (not sure how to fix without making the header fixed height, which causes bigger problems elsewhere)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
However, we're both working on other bugs too, so we may have to take our branches off live to work on other things. If you want to put the code on your own (git-enabled) dev environment, here's how:
1) Make sure your environment is up to date - the instructions for that are here. Both dw-free and dw-nonfree should be up to date.
2) Make a new branch off of your dw-free develop branch and switch to it.
3) Pull my remote branch by running this: 'git pull https://github.com/momijizukamori/dw-free.git nuketalkread' It'll ask you for a merge commit message - put in whatever.
3) Make a new branch off the dw-nonfree development branch and switch to it.
4) Pull the second remote branch: 'git pull https://github.com/momijizukamori/dw-nonfree.git nuketalkread'
5) Run '$LJHOME/bin/upgrading/update-db.pl --run --populate' to update the database with the new siteviews style.
Now you can use ?fallback=s2 on your pages too! So you can flip back and forth between the old bml view, and the S2 view, and tell me what's different/broken. I haven't actually tested this on comms at all, as I mostly use my Hack for style updates and thus have very little data in terms of entries/comments/users to test this on. Feel free to leave comments here about changes you find that need fixing! And seriously, beat on this thing - this is a page I don't want to fail on live.
Things I already know about:
-All subject lines in comments and entries are linked (it's a core2 issue, we're debating on fix vs leaving it)
-Screened comment count won't show up (again, core2, I'm working on that)
-Metadata on entries that have them have a slightly different alignment (approved change)
-The reply page for replying to comments shows when the comment you're replying to was posted (approved change)
-there's a little bit of space between the bottom of user icons and the bottom of the comment header (not sure how to fix without making the header fixed height, which causes bigger problems elsewhere)