Code tour, 8/10-8/16

[denise]

We resolved 15 bugs, all of which were resolved FIXED. (Although the numbers look like it was a slow week in development-land, many of these fixes are things I've been wanting for a really long time...)

All of these will be live on the site as of tomorrow night's code push. You may also want to review the past few weeks' code tours to see what else is going live tomorrow -- it's going to be a huge code push.

( Code tour, 8/10-8/16 )

Code on 32 bit arch (and other stuff).

[scsi]

Hi everyone! I'm Frank and I'm in charge of the DJ code upgrade from old LJ -> DW. If you get tired of my dev posting just holler and I'll move everything over to zilla. Yes, I am the guy who started/ran-forever DeadJournal.

I just got a snapshot of the old DJ database up and runnning on the DW code. Ran update-db.pl (that script gives me heartburn like you would never believe). All db modifications/changes and theme population etc ran without error.

This is a standard debian etch install. Nothing special about it.

Going to a journal brings up the journal/theme/userpic/etc (hooray). However clicking to view comments gives me a 500 error with the following in the error log:

[Mon Aug 17 21:49:44 2009] [error] [client 10.172.20.254] Invalid type 'Q' in pack at /home/dj/cgi-bin/LJ/Entry.pm line 1492.\n, referer: http://scsi.dj.dmz.vadept.com/

Line 1492 (when Columbus sailed the ocean blue, or mid-way through get_log2_row) reads:

# note: this cannot distinguish between security == private and security == usemask with allowmask == 0 (no groups)
# both should have the same display behavior, but we don't store the security value in memcache
$row = pack("NNNQN", $item->{'posterid'}, $eventtime, $logtime, $sec,
$item->{'ditemid'});

As far as I can read, Q is 64-bit arch only, which my test server is not. http://perldoc.perl.org/functions/pack.html

Changing that Q to an N makes it work (although it doesn't bring up any titles in the comments, and the update-db.pl script was complaining about unknown table logsubject2) however it makes apache segfault almost continuously.

This "Q" pack is in multiple places in Entry.pm from posting to viewing, etc. Maybe a config option for 64 vs 32 bit archs? Am I in left field?