Jan. 11th, 2013

fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu
I started with a desire to document how to submit changes to a release branch, and somehow ended up trying to figure out how we could organize the wiki to make it easy for us to figure out what we have and what we need.

Please read and comment on my entry in dw-wiki. I'm locking comments here so we can centralize all discussion in one place.
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu
I keep tripping over $r which is from DW::Request->get, and is a DW::Request object $r which is an actual Apache2::RequestRec object -- the two are used in similar contexts and often have similarly named methods, but then you'll run into a method which behaves a a bit differently from one to the other and spend two hours debugging a completely unrelated thing.

We're trying to move away from Apache2::RequestRec objects and converting them into DW::Request where needed. How about we rename the old $r to $apache_r, and keep the new $r the same, so it's obvious at a glance which is which?

ETA: I've gone ahead and done just that for https://github.com/dreamwidth/dw-free/pull/211

Profile

dw_dev: The word "develop" using the Swirly D logo.  (Default)
Dreamwidth Open Source Development

June 2025

S M T W T F S
1234567
89101112 1314
15161718192021
22232425262728
2930     

Most Popular Tags

Style Credit

Expand Cut Tags

No cut tags
Page generated Jul. 4th, 2025 12:53 am
Powered by Dreamwidth Studios