Code Tour, 2010 May 12 - 2010 June 06

[azurelunatic]

Hi! I'm azurelunatic, and I am hosting your code tour today. (zarhooie would have done this, but she was at an SJ Tucker concert.) I learned my lesson last code tour, when I did it all by hand, so fu very kindly ran foxfirefey's code tour template generator for me.

Thank you to all the developers, reviewers, designers, support people who helped with the bug reporting, dw_suggestions folks, plus other assorted volunteers and the ever-lovely Cheering Auxiliary for making this release possible.

This tour has 50 patches; today's release includes some from May 11th's code tour also. This tour features work from (in no exact precedence) fu, ninetydegrees, exor674, kareila, alierak (with bonus hardware-wrangling), foxfirefey, yvi, denise, allen (bringing the very excellent link-to-offsite-crossposts, in addition to last time's expand-cut-on-reading-page), and (returning developer from last year) kaisa, with bonus review action and coaching from mark. This also introduces new developers edgeraven and poulpette. (Now with corrected developer history status courtesy denise!) There are some special guest appearances from wisest_owl and colleagues at LiveJournal. dancing_serpent, sarken, and edgeraven have created some lovely new themes.




Bug 1080: Better import logging/error message passthrough
Category: Importer
Patch by: fu
Description: The importer was giving occasional errors like "Unknown status update"; now it should actually tell you what it's doing and what went wrong (or right). (If you do get "Unknown status update" messages on your import after this, ping Support so the devs can take a gander.)


Bug 2562: Allow to redo entry-icon mapping when reimporting
Category: Importer
Patch by: fu
Description: If there were errors with icons on your imported entries (wrong icon for that entry), or if you imported when you didn't have all your icons and now you do, re-importing should make all the icons behave properly again.


Bug 2666: LJ Crosspost fails on first attempt
Category: Crossposter
Patch by: exor674
Description: There was an error (behind the scenes; the crosspost seemed to go through after a while) on crossposting to LJ if the password wasn't saved. This fixes that.


Bug 2071: Sunday Morning: modules incorrectly displayed when moved to header
Category: Style System
Patch by: ninetydegrees
Description: Some sidebar modules were acting weird if the journal owner tried to stuff them in the header. This makes them either work all right there, or not be able to be stuffed there.


Bug 2638: Redundant semi-colon in Transmogrified
Category: Style System
Patch by: fu
Description: Depending on where it is, a stray semi-colon in code can ruin someone's whole day. Dreamwidth: making people's days better, one redundant semi-colon at a time.


Bug 2639: Crossposted entries on the same page as entries with accented characters, mangles these characters
Category: Journal contents
Patch by: fu
Description: Crossposted entries should be playing nicely with accented characters now.


Bug 2270: Prohibit Conditional Declarations (backend cleanup)
Category: Misc Backend
Patch by: exor674, with a bunch more work involving kareila, alierak, and fu.
Description: kareila explains: "Take my advice: don't combine "my" statements and postfix conditionals. Ever. [...] The manifestation of this particular bug was to cause the $foo variable to be referenced in global scope if the conditional was false. In that situation, the assigned value would persist across execution threads, such that if two people in a row had a true $baz, the second user would see the first user's value of $foo. Even with use warnings and use strict in effect, Perl apparently thinks this is perfectly fine." Ouch. Nice teamwork!


Bug 2662: Documentation for metadata in core2 doesn't mention xpost
Category: Style System, the little things that bother us
Patch by: fu
Description: "xpost" is a valid piece of metadata for entries, and now the core2 documentation tells other devs this. Hooray!


Bug 2626: Dreamhack box needs rebooting
Category: Hardware, devs with Dreamhacks need love
Hard rebooted by: alierak
Description: From time to time, a box running a bunch of instances of Apache may become a little unstable if steps aren't taken to conserve RAM. Steps are being taken, but the machine needed a reboot.


Bug 2633: Need to email users with a link to the receipt of their orders
Category: Misc UI/Frontend
Patch by: fu
Description: Sends an email when you buy something for someone else, and includes a link to your receipt to the email you get when you buy something for yourself.


Bug 2616: Entry management links display outside of the entry when comments are disabled
Category: Style System
Patch by: poulpette; congratulations on first commit!
Description: In the Modular, Fluid Measure, Crossroads, and Base styles, if comments were disabled, entry management links were displayed outside of the entry. Fixes this.


Bug 2625: Typo in Dreamhack Getting Started note
Category: Server documentation, devs with Dreamhacks need love
Patch by: ninetydegrees
Description: A misleading typo in the wiki, now corrected!


Bug 2525: Entry body being run through the HTML cleaner even if we're only interested in the subject
Category: Misc Backend
Patch by: fu
Description: Improving back-end performance. This makes the HTML cleaner more efficient when it doesn't have to handle the whole entry.


Bug 823: Update viewer_is for access/subscribe instead (S2.pm)
Category: Style System
Patch by: foxfirefey
Description: Style-system backend changes to make it possible for the style system to know whether the viewer has access, is subscribed, or is the administrator of a community. (Now, for some styles that take advantage of this!)


Bug 2630: missing semicolon in easyread/layout.s2
Category: Style System
Patch by: yvi
Description: Backend. A missing semicolon can screw up someone's entire day as much as a double one can.


Bug 2607: mobile settings page/email post settings don't indicate it's a paid feature
Category: Misc UI/Frontend
Patch by: denise
Description: It's better practice to say "Hey, if you upgrade, you can use this feature" than it is to show a page with a disabled form element to free users without explaining why they can't use it.


Bug 2622: Inbox does not show any error messages when trying to get the list of items errors
Category: Inbox/Notifications
Patch by: fu
Description: There were some unenlightening "No Messages" moments in the inbox when error messages should have displayed instead.


Bug 2628: Remove repeated WHERE
Category: Journal contents
Patch by: wisest_owl; modified for Dreamwidth by fu
Description: There was some SQL ugliness on the back end. Found and fixed by LiveJournal staff, and adopted here as well.


Bug 1027: Community invitation in inbox shows redundant 'Join Community' post-join
Category: Inbox/Notifications
Patch by: kareila
Description: Avoid showing "join community" link in inbox notifications if you're already a member.


Bug 2528: link to dw merch in shop menu
Category: Frontend, buy fun swag to support the site
Patch by: kareila
Description: Gee, it would sure be nice if the shop linked to the Dreamwidth Zazzle page (home of the Ridiculously Overpriced Fundraising Sticker and more!)


Bug 1475: Make a search module for S2
Category: Style System
Patch by: foxfirefey and work from ninetydegrees and fu
Description: Site search module for S2.

SITE SEARCH MODULE FOR S2.

You can put a search module in your style now. (There has been some gleeful shrieking about this, why do you ask?)


Bug 2615: update privacy policy
Category: Site Administration, transparency
Patch by: denise
Description: Explaining straight out when and why staff might access user accounts, rather than having that information scattered throughout. "Account Contents" section inserted, "last updated" date changed.


Bug 2571: Long entry titles push usernames to the right in Fluid Measure (Chrome)
Category: Style System
Patch by: poulpette
Description: Fixing a display bug in style Fluid Measure, when viewed in the Chrome browser. (If you've Fluid Measure, Chrome, and a Mac, and there are suddenly problems with long entry titles and usernames, hit up Support.)


Bug 2612: Bases layout does not show the entry poster name on community recent entries
Category: Style System
Patch by: yvi
Description: What it says on the tin. Allows for viewing the entry creator name in communities' recent entries when viewing in Bases.


Bug 2508: Site Map needs better link to Shop
Category: Misc UI/Frontend
Patch by: ninetydegrees and kareila
Description: Sometimes you want to upgrade your account, sometimes you want to buy things for other people. Link to shop clarified.


Bug 681: comment preview with spellcheck shows raw html
Category: Misc UI/Frontend, the little things that bug us
Patch by: kareila, with some work by fu
Description: It's not the spellchecker's job to check for clean HTML, and thus comment preview with spellcheck should show you an actual preview, not all your HTML laid bare.


Bug 2593: Allow members to subscribe to all comments in a community
Category: Communities
Patch by: ninetydegrees
Description: Given a paid community, members should be able to track all comments (that they have access to) in that community. Saves the user having to track every single entry as it is posted as previously necessary.


Bug 2649: Trying to XPost with save password off results in Invalid Password error.
Category: Crossposter, devs with Dreamhacks need love
Patch by: exor674
Description: Some old code in development environments was causing a weird invalid password error.


Bug 1513: Adding Calendar Function To Site Menu
Category: Misc UI/Frontend
Patch by: kareila
Description: Add an Archive (calendar view) link to the site's Read menu.


Bug 2643: sync dw-nonfree/etc/config-local.pl with dw-free/doc/config-local.pl.txt
Category: Misc Backend
Patch by: kareila
Description: fu explains, which is good, because I was lost: "sync up the actual default config file for Dreamwidth development (dw-nonfree/etc/config-local.pl) with the sample config file (dw-free/doc/config-local.pl.txt)"


Bug 361: Disable/remove "Comment" button when user isn't allowed to comment
Category: Misc UI/Frontend, little things that make sense
Patch by: kareila, based in part on changes from LiveJournal.
Description: Disable the "quick reply" comment form if you are not allowed to comment on a particular journal. Redirects to the full comment form with an error message.


Bug 2604: many tests in t/ fail due to missing Google::Checkout modules on server
Category: Misc Backend, things that bug us
Patch by: kareila
Description: Some of the "is this all ok?" tests look for the Google::Checkout module, which we're not using anymore. The tests will pass, though there will still be warnings.


Bug 182: Rip off name transition change for recentactions and actionhistory
Category: Misc Backend, fetch the code-machetes
Patch by: kareila
Description: Clearing out code that doesn't apply to us. Clone sites using code prior to LiveJournal's changeset r6045 (2006) will have to upgrade to a more recent LiveJournal installation first if they wish to switch to Dreamwidth code.


Bug 2115: fix t/console-tags.t
Category: Misc Backend
Patch by: yvi and kareila
Description: Fixing tests for ... something having to do with tagging. *handwavy* Not user-facing.


Bug 1546: investigate LJ::Cache, remove?
Category: Misc Backend, fetch the code-machetes
Patch by: kareila
Description: More unused code, gone!


Bug 2531: Edit tags page should not mention crosspost for non-crossposted/community posts
Category: Misc UI/Frontend
Patch by: kareila
Description: If an entry wasn't crossposted, don't warn you about crosspost tag settings when editing the tags. I remember when this bug was filed, as it had irritated both yvi and me within the same ~15 minute span, and she filed it first.


Bug 1679: Split context hover menu option
Category: Misc UI/Frontend
Patch by: yvi
Description: Perhaps you like the contextual hover menu, but would prefer to see the icon's description instead of the blasted menu when you hover over a userpic. Or perhaps you're fine with the menu on userpics, but don't want to see it on the userhead. Or you would prefer it both places? Or neither? Whichever way, there's an option for you.


Bug 1883: deal with "Use community userpics instead of poster's userpic"
Category: Style System
Patch by: kareila, with some S2-fu by fu
Description: If you prefer to see the community's icon instead of the user's icon, when reading your reading page (particularly useful when you have a zillion communities where people use eyesporking icons), you're in luck.


Bug 2353: Link to dw_codesharing on the "create account" page
Category: Invite codes
Patch by: ninetydegrees
Description: Explain on the front page where to go to get your hot fresh codes (hint: dw_codesharing).


Bug 1279: add number of accounts to admin/invites/requests.bml
Category: Site Administration, making denise's life easier
Patch by: kareila
Description: On the administrative page for viewing requests for invite codes, show the number of personal and community accounts registered to the email address of the requesting account.


Bug 1588: 24-hr Time Display Option
Category: Journal contents
Patch by: yvi
Description: Perhaps you would prefer to view entries and comments with 24-hour time, instead of 12-hour time?


Bug 1392: Memcache domain mapping
Category: Misc Backend
Original patch by: wisest_owl, initially codemerged by denise, more extensive adaptation by exor674.
Description: When the user has mapped their domain to their journal, take advantage of some hot hot memcache action to save our servers some work.


Bug 2509: Feeds with EUC-JP encoding can't be parsed
Category: Misc Backend
Patch by: kaisa
Description: Feeds with Japanese characters using a certain encoding couldn't be parsed on Dreamwidth before this.


Bug 2361: Links to cross-posted entries
Category: Crossposter
Patch by: allen, with some last-minute fixy by exor674
Description: Wouldn't it be great to have a link to the remote entries when you crosspost, particularly if there are comments over there? Turn it on in your settings by clicking the "Change" link for each configured external account, and ticking the "Display Cross Post Links" setting.


Bug 1888: padding/margin for modules in header and footer
Category: Style System
Patch by: ninetydegrees
Description: Adding padding to modules so they won't look weird when they're in the header and footer, for a couple styles.


Bug 2635: Transmogrified: implement two-columns-left layout
Category: Style System
Patch by: ninetydegrees
Description: If you'd prefer Transmogrified with a two-columns-left option, you're in luck.


Bug 2472: Option to Choose Placement of Metadata
Category: Style System
Patch by: ninetydegrees
Description: If you'd prefer to read with mood, music, location, and such at the top of the entry, rather than at the bottom, you're in luck.



Bug 2448: Themes: Seven Themes (Blanket)
Category: Style System
Patch by: ninetydegrees; themes by dancing_serpent and sarken
Description: Seven new themes for Blanket.

Forest:


Green:


Islands & Cities:


Jewels:


Kings & Runaways


Ocean:


Shallows:



Bug 2663: Drab/Brittle
Category: Style System
Patch by: edgeraven
Description: New theme for Brittle: Drab:



Bug 2650: Barnhouse (Brittle)
Category: Style System
Patch by: edgeraven
Description: New them for Brittle: Barnhouse:

Comments

Bug 2562

[juniperphoenix]

What do I need to reimport in order to take advantage of this: icons or entries?

(And wow, what an impressive batch of updates! I am loving the cut-tag expander and the ability to link to crossposted entries.)

Re: Bug 2562

[afuna]

Entries! (You'll see a checkbox within the entries section, so it should be obvious what to do once you try to reimport *g*)

Re: Bug 2562

[juniperphoenix]

Awesome, thanks!

Re: Bug 2562

[denise]

I am pretty sure that you should re-import both, but I'm not 100% positive. *g*

(Ha! Or, fu schools me. It's a good thing we pay her to have a brain so I don't have to...)

[denise]

Also, kaisa isn't new, but edgeraven is! (kaisa had a few patches last year.) I believe poulpette was officially welcomed in the news post last week, but I don't think her patches have hit a code tour yet, so yay :)

[azurelunatic]

Corrected, thank you!

[afuna]

Oooh long code tour is long. Thank you Azz!

[exor674]

p.s. Bug 2270 was mostly kareila, not me -- only got assigned to me in the end for a few final things

[alierak]

Well, you did tell us what the problem was in the first place :)

[ninetydegrees]

Oh! Including the theme previews is such an awesome idea! Great tour!

[brownbetty]

Dear bugfixes #681 and #2361,

You are hot throbbing sex on toast. Please, do this all the time.

V. Appreciatively,

Betty

[cheyinka]

Oo, Bug 681's fixed-ness makes me happy!

For 1679, maybe it should say "Nothing" or "Nowhere" rather than "Never"? Currently it says "Show the contextual menu when you hover over: Icons" (good), "when you hover over: Userhead" (good), "when you hover over: Both" (good), "when you hover over: Never" (strange)

[alierak]

or None or Neither?

[cheyinka]

None or Neither works too!

[snarp]

2361 = <3 <3 <3.

[lo_rez]

Wow!

[cesy]

2593 makes me so, so happy. Do I owe anyone points for that?

[yvi]

It#s not on my sheet, so nope.

[trinity_clare]

Bug 2635: Transmogrified: implement two-columns-left layout

Wait, really? Really really? This makes me so happy I'm actually having trouble comprehending it. Wow. *dances*

[valentinite]

Split context hover menu option YAAAAAAY.

[wendelah1]

I did have icon errors. Do I need to re-import my journal? Or just the icons?

[azurelunatic]

Fu says entries: there will be a checkbox.