mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] dw_dev2009-07-09 04:16 pm
Entry tags:

Committers: crediting commits

Just like we attribute each commit to the person who submitted it, if it's a codemerge from LJ or some other site, it is required that we annotate that in the commit.

"Patch from LiveJournal."

That sort of thing. Please remember to do this, and if you haven't done it anywhere, it'd be great if you could go back and edit the changelog posts to include this note.

Thanks!
janinedog: (Default)

[personal profile] janinedog 2009-07-10 12:09 am (UTC)(link)
What if it's a merge from LJ with edits from someone on the DW side? Do we just say that? Though then we lose the cool auto-user tag thing.

Though now I'm thinking that maybe your "Patch from LiveJournal." thing wasn't meant as a replacement for the "Patch by [person]." line, but instead it goes in the message above that line. Is that right?
Edited 2009-07-10 00:10 (UTC)