Committers: crediting commits

[mark]

Just like we attribute each commit to the person who submitted it, if it's a codemerge from LJ or some other site, it is required that we annotate that in the commit.

"Patch from LiveJournal."

That sort of thing. Please remember to do this, and if you haven't done it anywhere, it'd be great if you could go back and edit the changelog posts to include this note.

Thanks!

Comments

[janinedog]

What if it's a merge from LJ with edits from someone on the DW side? Do we just say that? Though then we lose the cool auto-user tag thing.

Though now I'm thinking that maybe your "Patch from LiveJournal." thing wasn't meant as a replacement for the "Patch by [person]." line, but instead it goes in the message above that line. Is that right?

[afuna]

I'll go back and edit the "codemerge" comments on my changelog entries to explicitly mention LJ. But I have the same question as janinedog -- is this meant to replace the "Patch by denise." bit, or is this meant to be in addition to?

[mark]

If someone puts together a patch that's a codemerge, we shouldn't be saying "patch by so-and-so" since they didn't author the code. If you really want, you could say something like,

"Patch originally from LiveJournal, packaged for Dreamwidth by denise."

That way it's clear that it was from one place and someone else just did the work to make it fit into DW. Make sense?

[afuna]

Lots, thanks!