denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
Denise ([staff profile] denise) wrote in [site community profile] dw_dev2009-07-07 02:14 am
Entry tags:

Code Tour

This was a pretty active development week, and since [staff profile] mark is going to be doing this week's weekly update, and because our last one was a while back, I have time to instead do a Changelog Explained. :)

We resolved 66 items this week, with 57 of them being resolved/fixed (as opposed to duplicates, invalid, or things we won't fix because they're deliberate). Of those, 7 were meta-bugs that had been open for a while that we resolved this week because we considered them "done enough" and all the remaining things to do already had bugs open for them, and 3 were resolved a while ago and just not properly closed.

Here is a tour of the remaining fixes, big and small. :) They'll all be live at the next code push.



Bug 186: Fix link to memcache key list in htdocs/admin/memcache_view.bml
Category: Documentation
Patch by: [staff profile] denise
Description: This changes a link on one of the admin pages to the Dreamwidth code repository instead of the LiveJournal code repository.

Bug 313: refreshing Inbox page doesn't clear checked "check all" checkbox if not all items acted on
Category: Bugfix
Patch by: [personal profile] afuna
Description: This fixes a bug with the inbox: if you selected the "check all" checkbox and refreshed the page, or unchecked just one item, deleted all checked items, then refreshed the page, the "check all" checkbox was still checked after the refresh. This patch fixes it so that both a page refresh and a completed action clears the "check all" checkbox. (This one's been annoying me on LJ for years.)

Bug 340: suspended journals shouldn't display adult content check
Category: Bugfix
Patches by: [personal profile] afuna and [personal profile] exor674
Description: This fix changes around the logic for displaying a journal a little so that the check for whether a journal is suspended or deleted appears before the adult content check, thus preventing a silly situation where someone could be asked to confirm that they wanted to see adult content only to click through and find that the journal was deleted. (If you click through to that bug, blame [personal profile] afuna for the earworm in the comments.)

Bug 399: Changes to multicvs.conf can leave files lying around
Category: Developer tools
Patch by: [personal profile] sophie
Description: This improves one of the scripts that programmers use to keep their local copy of the code up-to-date.

Bug 401: Keep S2 layer editor window cursor in same place when compiling
Category: Bugfix
Patch by: LiveJournal
Description: This merges in a bugfix from LiveJournal, improving the S2 layer editor so a save & compile doesn't lose cursor focus.

Bug 480: Add optional 'reason I am deleting my journal'
Category: Improvement
Patch by: [staff profile] denise
Description: This adds a "reason I'm deleting my journal" to the journal deletion workflow, which will display on both the deleted journal and the profile. This way, if you're deleting your journal for a exam week to keep you focused on your studies, you won't get 200 "are you okay?" emails!

Bug 518: Add missing $EMBED_MODULE_DOMAIN to configuration
Category: Code documentation
Patch by: [personal profile] afuna
Description: This patch adds a configuration variable to the example configurations that come with the code, so people who are using Dreamwidth code to run a site will know that they can set it.

Bug 586: alias ?format=light to ?style=light
Category: Usability improvement
Patch by: [personal profile] yvi
Description: This patch makes it so that both ?format=light and ?style=light both work to get the stripped-down light-mode style, for consistency's sake. Now you won't have to remember that it's ?style=mine but ?format=light.

Bug 587: Missing configuration variable $LJ::LAST_FM_USER_URL
Category: Code cleanup
Patch by: [personal profile] rho
Description: Due to the way that the feature works on LiveJournal, the last.fm username on the profile was programmed as a variable, not as a static link to your profile on last.fm. (At least, we think that's the rason why. We're not entirely certain.) This patch changes it so that the profile URL is decreed in the code instead of needing a config variable.

Bug 681: cmment preview with spellcheck shows raw html
Category: Bugfix
Patch by: [personal profile] afuna
Description: This cleans up the comment preview window a little bit so that it uses the same behavior as previewing entries.

Bug 702: Fix tab ordering on changeemail.bml
Category: Usability bugfix
Patch by: [staff profile] denise
Description: This patch adds in tab index values for the page where you change your email address, making those fields accessible via keyboard and improving the usability for screenreader users.

Bug 709: Unescape %xx sequences in OpenID URLs for human display
Category: Bugfix
Patch by: LiveJournal
Description: This patch merges in a bugfix from LiveJournal, improving the way that OpenID URLS are displayed. (Previously, any high-bit characters were shown as their control sequences, not the characters themselves.)

Bug 747: Manage circle sometimes displays table headers for empty table
Category: Cleanup
Patch by: [personal profile] ysobel
Description: This patch fixes up a situation where the Manage Circle page would show a table header row for an empty table by moving the code that generates the header row to a different place.

Bug 776: Double heading when talkpost_do.bml errors
Category: Site copy cleanup
Patch by: [staff profile] denise
Description: Fixes a case where certain errors posting comments would result in a double header, with "Error" printed twice.

Bug 778: Pass link to register.bml to poll.error.notvalidated
Category: Site copy cleanup
Patch by: [staff profile] denise
Description: This patch changes an instance of 'Dreamwidth' being hard-coded in the site copy to instead use the site name variable from config files, so other sites using the Dreamwidth code will automatically have that bit of copy show their local site name instead of 'Dreamwidth'.

Bug 872: Remove ljtalk-gm warnings on production servers
Category: Cleanup
Patch by: LiveJournal
Description: This patch merges in a fix from LiveJournal to prevent error messages from appearing in the webserver logs where they shouldn't.

Bug 929: Protect Gearman workers against task fatal errors
Category: Bugfix
Patch by: LiveJournal
Description: This patch is a bugfix for Gearman, which is the utility that schedules and performs asynchronous tasks (things that can be initiated by the user, but don't need to be done right now).

Bug 933: clarify why "collapse content" options are greyed-out
Category: Usability improvement
Patch by: [staff profile] denise
Description: On the Display tab of your Manage Settings page, you have the option to set the "collapse content" settings to collapse nothing, collapse things marked NSFW and things marked 18+, or only collapse things marked 18+. However, if you haven't set an age, the setting can't be changed. This isn't a problem for logged-in users, because they specify an age on account creation, but OpenID users don't, so it can be confusing for them to not know why that option isn't available. This patch adds a descriptive line saying "to change this option, you must set your birthdate first".

Bug 936: site="dreamwidth.org" in user tag parsed as unknown external site
Category: Cleanup
Patch by: [personal profile] yvi
Description: You've probably noticed that if you add 'dreamwidth.org' in your <user name> tags, like <user name=denise site=dreamwidth.org>, the user head that shows is the generic "unknown external site" userhead (with the lock on it), not the one that should be used for that account. This patch fixes that two ways: it makes it so that using the site name in a <user name> tag isn't parsed as an external site, and it makes it so if other people are using the Dreamwidth code, Dreamwidth is a recognized external site.

Bug 937: default value for custom filter text exceeds maxlength in Transmogrified
Category: Style system
Patch by: [staff profile] denise
Description: This patch increases the maximum length of the custom names that can be used for custom filters in the customization wizard.

Bug 955: crossposter showing multiple checkboxes unnecessarily
Category: Bugfix
Patch by: [personal profile] kareila
Description: This patch fixes up the user interface for crossposting on update.bml so that the checkboxes make a lot more sense now.

Bug 956: customisable crossposting text and links
Category: Feature improvement
Patch by: [staff profile] denise
Description: This patch lets you define your own custom footer for crossposted entries, as well as picking when to show the footer on the remote site: always, never, or only when comments are disabled on the remote site.

Bug 997: Core 2: comment and entry links need class on first item
Category: Style system
Patch by: [personal profile] laitaine
Description: This adds an additional CSS class to the first item in every interaction or management list, making it easier for designers to style them using CSS.

Bug 1052: Rewrite OpenID validation email
Category: Usability improvement
Patch by: [staff profile] denise
Description: This patch changes it so that OpenID accounts setting their email address for the first time get a different email than the email that gets sent out when you change your email address, to make it clearer that you've added an email address for the first time instead of changing an existing email address.

Bug 1164: Separate "who can see command help" from "who can use command" on admin command reference
Category: Usability improvement
Patch by: [staff profile] denise
Description: This changes the Admin Console reference to list all commands, not just the ones that you have the credentials to run or access. For usability purposes, commands you can't use are greyed out and indented, as well as displaying "You aren't authorized to use this command", to make it easy to see what you can and can't do.

Bug 1167: crossposter: /update.bml checkboxes end up in wrong state
Category: Bugfix
Patch by: [personal profile] kareila
Description: This fixes a bunch of different problems with spellchecking, crossposting, and altlogin (the "work as different user" option) on update.bml to prevent various settings from getting clobbered when you switch around.

Bug 1185: email posting to access filters doesn't work
Category: Bugfix
Patch by: [personal profile] kareila
Description: This fixes a bug with post-by-email to allow for email posting to custom access filters. (It was somehow overlooked in the conversion of 'friends' to access/subscription.)

Bug 1255: Some settings text too dark in Gradation
Category: Bugfix
Patch by: [staff profile] denise
Description: This patch changes the Gradation site scheme so that the Manage Settings page isn't black-text-on-dark-grey-background.

Bug 1257: Add total number of tags
Category: Usability improvement
Patch by: [personal profile] kareila
Description: This patch adds the number of tags that you have for your account to the Manage Tags page.

Bug 1271: OpenID with https gets extra http:// in journal profile
Category: Bugfix
Patch by: [personal profile] afuna
Description: This patch fixes a bug with OpenID accounts where the website URL was listed incorrectly on the Profile if the URL was https:// instead of http://.

Bug 1275: Trying to set up crossposting to an Unknown site fails to crosspost
Category: Bugfix
Patch by: [personal profile] afuna
Description: This patch corrects crossposting to unknown sites (sites that don't have an entry in the drop-down) so that it will work properly now. :)

Bug 1285: sysban by IP not blocking IPs
Category: Bugfix
Patch by: [personal profile] alierak
Description: This patch cleans up a bunch of the logic around the routines that block certain IPs from accessing the site, which we found weren't working when we tried to block some spammers and it didn't work.

Bug 1302: Document userprops
Category: Code documentation
Patch by: [staff profile] denise
Description: 'Patch' is a bit of misnomer, since this was documented on the Wiki, but still! This documents all of the things that can be set by the 'set' command in the Admin Console, as part of our efforts to move those settings out of the Admin Console and into the Manage Settings page.

Bug 1310: Display issues with entry preview
Category: Bugfix
Patch by: [personal profile] kareila
Description: This fixes some problems with entry display in the entry preview screen: tags weren't being added, and the tracking icon was wrong.

Bug 1313: When using /update (instead of /update.bml), autosave no longer works
Category: Bugfix
Patch by: [personal profile] sophie
Description: A while back, we changed it so that you don't need the .bml on the end of URLs, so things like dreamwidth.org/update work just as well as dreamwidth.org/update.bml. When we did that, the referer checking for update.bml's autosave function broke, so if you were using /update instead of /update.bml, autosave was broken. This patch not only fixes it, it fixes referer checking in general so it won't be a problem anywhere else.

Bug 1322: missing break between misspelled word and suggested fixes
Category: Display bugfix
Patch by: [staff profile] denise
Description: This patch adds some spacing in spellcheck results to make them easier to read.

Bug 1338: htdocs/stc/404.css needs to be reviewed and trimmed or discarded.
Category: Code cleanup
Patch by: [staff profile] denise
Description: This patch gets rid of an unused file.

Bug 1339: Trying to preview an entry for a journal which uses site scheme entry pages is broken
Category: Bugfix
Patch by: [personal profile] afuna
Description: This patch fixes entry previews for accounts that have custom comment pages turned off, so now it displays in the actual site scheme instead of in light mode.

Bug 1342: transmogrified: left-justified icon overlaps username in ?replyto format
Category: Display bugfix
Patch by: [personal profile] afuna
Description: This patch fixes some display issues with the Transmogrified layout.

Bug 1349: Navigation breaks in communities
Category: Bugfix
Patch by: [personal profile] kareila
Description: This fixes the previous and next links in communities with member-locked entries.

Bug 1356: Add link-to-me module on profile
Category: Improvement
Patch by: [staff profile] denise
Description: This adds a module at the bottom of the account profile containing copy-and-pasteable code to link to the account both on Dreamwidth and on other sites. That way, you don't have to remember the syntax to link to people elsewhere; you just have to click through to their profile.

Bug 1357: Viewing entries moderation queue doesn't display non-whitelisted videos
Category: Bugfix
Patch by: LiveJournal
Description: This fixes a bug where embedded videos weren't being displayed on entries in a community moderation queue.

Bug 1358: strip use of background images/positioning in comment content
Category: Bugfix
Patch by: [staff profile] denise
Description: This patch prohibits a trolling technique where people were posting comments with large images absolutely positioned, rendering the entire page unreadable. It strips the use of 'height' and 'margin' attributes in comment content.

Bug 1362: If journal title == user name, name doesn't display on profile
Category: Display bugfix
Patch by: [personal profile] kareila
Description: If the journal title (set as part of your journal style) and the user's name (set as part of your profile) are the same, the line for "Name: [user name]" does not display in the About section of the user's profile. This patch fixes it.

Bug 1367: replace unused 'StyleAlwaysMine' setting with wholly different NCTalkLinks setting
Category: Usability improvement
Patch by: [staff profile] denise
Description: This patch replaces the "view everything in your style" setting on the profile, which has been greyed-out since inception because we utterly hated LJ's implementation of it and are going to be rewriting it entirely, with the old "add ?nc=XX to the end of entry links" setting. When active, it adds ?nc=17 (for instance) to the end of read links on your reading page, and the number goes up as the comment count goes up, making it easier for you to see if an entry has new comments. (We'll be cleaning up the existing layouts to make sure that the visited and unvisited links are different colors.)

Bug 1370: can't reply to PM sent to self
Category: Bugfix
Patch by: [personal profile] afuna
Description: This fixes a bug with replying to private messages sent to yourself (in case you want to leave yourself notes, etc).

Bug 1373: Yahoo online indicator on profile doesn't work
Category: Display bugfix
Patch by: [personal profile] sophie
Description: This patch fixes the URL of the image for the online/offline indicator for Yahoo Messenger on users' profiles.
msilverstar: (leaf)

[personal profile] msilverstar 2009-07-07 03:48 pm (UTC)(link)
Great list of solid code changes! I'm sure my blockquote in preview problem is now fixed, and a lot of other ones too. Impressive!