Code tour, 11 August to 24 August.

[ex_rising236]

Goooooood morning Dreamwidth! So, I'm rising, and for what it's worth this is the first time that I'm ever doing this. Nonetheless, bear with me, and we'll get this show on the road. Beneath the cut you will find two game wardens, seven hunters, and a cow …

Actually, we have thirty-eight, no wait forty-four forty-six bugs, some of which from suggestions, some of which are bugs, and a few themes in the code tour today. Patches and patches and patches galore! And of course as usual be aware that not all of these are live as of yet, however. Remember, keep your mouse inside the window at all times, and don't touch the exhibits as the ride commences!


Bug 3803: CAPTCHA text in input field invisible in Gradation
Category: Misc UI/Frontend
Patch by: ninetydegrees
Description: Being able to actually see text you type is good. It's even more important if that's a CAPTCHA field, and so! Fixing places where the foreground and background colours are the same? Shiny.

Bug 2826: Add note when banning user
Category: Circle/Relationships
Suggested by: sofiaviolet
Patch by: kareila
Description: Particularly useful for things such as communities, allows there to be note text when banning a user that can be used for reasons or something like that.

Bug 3801: Friendly 'protected content' message: broken URLs when coming from custom comment pages
Category: Misc UI/Frontend
Patch by: fu
Description: Unbreaking URLs for the circumstances where they broke. Less broken URLs is a good thing.

Bug 3301: Account Settings/Display/Site Scheme: add preview pics
Category: Site Layout/Navigation
Suggested by: ninetydegrees
Patch by: fu
Description: Preview pictures so that you can see/get an idea of what a site scheme looks like before you choose it, which is very shiny, useful, pretty, and other descriptive adjectives implying good.

Bug 3695: RTE/Chrome: usernames for external sites aren't recognized as valid
Category: Misc UI/Frontend
Patch by: fu
Description: Makes the RTE play in the same sandbox as Chrome without them trying to be mean to each other, when they'd otherwise been arguing about whether usernames for external sites would be done correctly. Playing nice is far, far better.

Bug 3416: Suspended entry link has 'here' as link text
Category: Misc UI/Frontend
Description: Slight fix in site copy on a suspended entry so that the text for a link isn't just an utterly and entirely not-descriptive, not helpful 'here'.

Bug 3156: Two bugs with editicons, possibly both site copy
Category: Misc UI/Frontend
Patch by: denise
Description: Manage icons, version something point something point something else again. Now more informative with additional explanation text in the site copy, and fewer redundant redundancies!

Bug 3072: Fix overlapping of footer on mood page in Gradation
Category: Misc UI/Frontend
Description: Something was broken, theoretically, but then no one could reproduce it, therefore at some point it obviously got fixed in between, and therefore it's no longer a bug. Hulk smash invisible bug.

Bug 3828: /cgi-bin/DW/Controller/Legal.pm should register "/legal/index" not "/legal"
Category: Routing/TT
Patch by: fu
Description: (So long 404 message, it's been good to know you, so long …) Slight fix allows multiple options and less breaky.

Bug 3777: Email address reset does not work
Category: Unknown
Patch by: fu
Description: Fixing the part about the admin tools to reset email addresses, because the string that was generated was missing something or other. Hulk smash bug.

Bug 3317: enforce limits on number of users that can be watched or trusted
Category: Circle/Relationships
Patch by: kareila
Description: Limits are good. Limits that explain themselves with appropriate error messages when the limit has been reached are so much better.

Bug 3829: Crossposter problem: remote name change
Category: User documentation
Patch by: denise
Description: And now, we have an explanation in docs that if you change your username on another site, you're going to have to change your settings in the crossposter. Clarity is important.

Bug 3825: missing space when inviting someone
Category: Invite codes
Patch by: denise
Description: Really, just what it said. There was somewhere missing a space, and now the space is there. Like magic. Or wait, no, just a patch, but …

Bug 3810: What is a community?
Category: User documentation
Patch by: denise
Description: Moooore documentation, this time explaining communities, which is really, really quite shiny and awesome. Once again, clarity is awesome, documentation is awesome, et cetera.

Bug 3835: DNS needed for new Dreamhack server
Category: Configuration
Patch by: mark
Description: DNS stuff. For Dreamhacks, which are awesome and spiffy, and well, yes. Technical mumbo-jumbo that makes URLs work is how I typically think of it, buuut.

Bug 1571: Comment parameter to journal entry views
Category: Journal contents
Patch by: kareila
Description: Pretty nifty filtering idea here to have it possible to view comments by type by adding whatever with the specifics to the end of the URL for an entry. So, screened, frozen, and so forth.

Bug 2348: Spam Reports: mode=view should have link to journal of suspected spammer
Category: Site Administration
Suggested by: azurelunatic
Patch by: denise
Description: Improvements for the anti-spam team interface thingamajig so that they can more easily go to the journal/openID account of someone who is a suspected spammer.

Bug 2133: Class names with "eval" unusable in CSS
Category: Style System
Patch by: rb
Description: CSS stuff adding an additional class so that users who have something in their name that would otherwise invalidate the CSS and make things look really not right no longer do so. Less breaking things? And more fun.

Bug 733: Extend DW::External::User to discover account type and save it
Category: Misc Backend
Patch by: kareila
Description: Automatically finding out what the account type of a journal is from LJ or LJ based sites with the user name code, so now the code should know if you're linking to a community on LJ or a user, et cetera.

Bug 777: Pass sitename to various translation strings
Category: English-Stripping
Patch by: kareila
Description: Using a string rather than having the sitename specified hard coded. Code cleanup!

Bug 3497: Improve UI for commenting when not logged in
Category: OpenID
Patch by: denise
Description: Change in the text to make it more obvious that on entries where it is enabled, OpenID actually is an option, rather than confusing buttons that are greyed out and possibly confusing. (Oh wait am I being redundant again. Confusion is bad, though!)

Bug 3826: typo in userproplist.opt_show_captcha_to prettyname
Category: Misc Backend
Patch by: denise
Description: Hulk smash typo bugs. Um. Typos are bad?

Bug 3827: remove references to LJ::Setting::FacebookBeacon
Category: Misc Backend
Patch by: denise
Description: Removing a reference/setting/something to another something that doesn't exist. Clean up, clean up … (Yes, I'll shut up now, before everyone else gets earwormed with that too. Don't shoot me or anything, I've been babysitting a small child, it's stuck in my head.)

Bug 3516: Use correct column name in LJ::User->alloc_user_counter
Category: Misc Backend
Patch by: original patch by andy, denise
Description: LJ fixed an error in their SQL. In other words, too technical for me to understand beyond the explanation I've been told, but.

Bug 3830: proplists.dat out of order
Category: Misc Backend
Patch by: denise
Description: And these are the times where the alphabet song comes in useful. Something starting with 'user' does not get sorted in with things starting with 'log'. At least, not unless the alphabet's been turned upside down and twisted inside out and who knows what. In any case, this put it back where it was supposed to be.

Bug 3817: can't parse "ascii" encoding (really?!?)
Category: Feeds
Patch by: denise
Description: Makes ascii work. Instead of dying on some sort of bad encoding message. Things that work are shiny.

Bug 3456: Move "delete this comment" link in entry notifications
Category: Inbox/Notifications
Suggested by: florentinescot
Patch by: ninetydegrees
Description: Reordering links in comment notification emails, so that it's less possible to accidentally delete comments. Better usability.

Bug 3079: Make LJ::User->nodb_err spit out more error info
Category: Site Administration
Patch by: original patch by gariev, denise
Description: A codemerge from LJ. Don't ask me what it does beyond the name of the patch, I really honest to whatever is out there don't know.

Bug 3834: clean old redirects out of redirects.dat
Category: Misc Backend
Patch by: denise
Description: There were redirects to versions of pages that had been around when the dinosaurs walked the earth. There are no dinosaurs walking around anymore and we didn't need the redirects either. Is that a tiny little meteor I see?

Bug 2950: remove secret question
Category: Registration
Patch by: denise
Description: There are no secret questions. This is not the secret question you're looking for, and if you really insist, the answer is … no, really, we aren't using the secret questions or anything, and so this patch removed a reference to them in the code that had been missed before.

Bug 2194: Option for admin tool to email when adding paid time
Category: Payments
Suggested by: cesy
Patch by: denise
Description: Gives administrators an option to email users when extending paid time via the admin tool or other such things in cases where they wouldn't otherwise be emailed, therefore making their lives easier, therefore making everyone else's lives easier.

Bug 3602: remove feed accounts from "recently created" on stats page
Category: Misc UI/Frontend
Patch by: denise
Description: Feed accounts will no longer show up in the 'new accounts' section, which goes right along with them not showing up in 'recently active'. Which is good.

Bug 3704: Paletteable: 10 themes by rising
Category: Style System
Patch by: ninetydegrees
Description: … I made shiny themes for Paletteable in pretty colours a while ago, and then, they got committed. Pretty colours make me happy. And happy is good.

Bug 1286: create community landing page
Category: Unknown
Suggested by: skud
Patch by: denise
Description: Improvement and creation of the community landing page. skud and cesy put work into this and provided the idea and what the actual content of things that should be on the page, and it's thanks to them that the new page is so shiny. However, the new page is not live yet as of writing the code tour, and so if you click through you'll only see the old one. The new one will be live after the next code push.

Bug 3874: Misc warnings in logs related to uninitialized variables when posting a comment
Category: Misc Backend
Patch by: fu
Description: Make logs that were noisy for site admins stop complaining quite so much. Less noisy complaining things that aren't complaining for actual reasons makes for happier site admins, makes for happier users. Oh yes it does.

Bug 2028: Add comment image to RSS feed
Category: APIs: RPC/XML/Flat
Suggested by: zvi
Patch by: denise
Description: The "there are [#image] comments on this entry" from crossposts now also shows up for people reading via RSS feeds so they can see if there are comments and the original comment thread where they should be interacting with people. Thusly encouraging them to click over to the original entry.

Bug 3272: Polls - change your vote AJAX
Category: Site Layout/Navigation
Suggested by: kyrielle
Patch by: yvi
Description: Now that we don't have to open a new page to vote in a poll, the logical next step: not having to open a new page to change vote once we have already voted. Shiny, shiny AJAX.

Bug 3788: configs need tweaking to produce desired maxcomments effect
Category: Configuration
Patch by: kareila
Description: A bit of code tweaking so that the actual maximum number of comments on any given entry is, in fact, 10000, and 5000 before CAPTCHA. Something in the config was making this not behave correctly before.

Bug 3802: Long entries get truncated silently
Category: Journal contents
Patch by: fu
Description: Entries have length limits for both bytes and characters (as some non-English and special characters are more than one byte), and when entries hit the byte limit, they would get an error. However, other long entries would end up getting silently truncated with no error message whatsoever, and now there will be an error message. And then it won't end up with posting supposedly epic fic of doom, only to find out that it truncates at the middle of chapter five, section two, right when it's getti—

Bug 3867: "Detailed results visible to: None" is not quite truthful
Category: Journal contents
Suggested by: sophie
Patch by: ninetydegrees
Description: Accuracy in text! Now if someone has set detailed results viewable to only them, it will show up as 'just creator' and not 'none' and then it will be less not really quite truthful and more easily understood.

Bug 3823: remove bad password checks elsewhere on site
Category: Misc Backend
Patch by: ninetydegrees
Description: Since the password check is already there at log in, the rest of these are not the password check you were looking for (and redundancy causes redundancy and removing redundancy (which is bad) is therefore good, and I could keep on the repetitive thread for a while).

Bug 2600: Mark your answer in answered polls
Category: Misc UI/Frontend
Suggested by: yvi
Patch by: yvi
Description: Along the entire making polls shinier, polls are now shinier. You'll be able to see your own answers in the results view, with less steps along the way in the case that you forgot which option you clicked ticky on or something like that.

Bug 3895: Mention Account Type for Communities on Account Settings
Category: Communities
Suggested by: ninetydegrees
Patch by: ninetydegrees
Description: Account settings now mentions the account type for communities just like it would for personal journals. Useful and good and shiny.

Bug 3890: Feeds: provide link to feed account when account already exists
Category: Feeds
Suggested by: ninetydegrees
Patch by: yvi
Description: Adds a link to a feed account, so that if you go and try to create a feed account that already exists, you can now navigate to it from the error page instead of just sitting there going 'bwuh but I want to subscribe to the feed!' and making sadfaces. No more sadface.

Bug 1777: Error pages for security and tags
Category: Misc UI/Frontend
Patch by: fu
Description: The ugly error pages go to the land of error page rejects, never to be seen or heard from again … in this case, it just goes to a different mode and gives a list of tags if there's no tag specified in the URL.

Bug 3836: hello-world div ID
Category: Misc UI/Frontend
Patch by: rb
Description: Statistics = lies. Statistics ≠ hello-world. But in this case, it's just getting named statistics, so that it's obvious what it's actually for.

Alright, can I blink yet? I swear, this code tour was trying to imitate a rabbit crossed with a Weeping Angel, every time I turned around it did that sneaky adding on more bugs while you weren't looking, or something. Don't blink, they'll multiply. And then they'll take over.

Anyway, that's the end of this code tour, ladies and gentlemen and beings of other various denominations that don't fit into typical categories. Thank you for obeying the safety protocols, you may now depart the ride by clicking the comment button at the bottom of the entry. Please check the aisles to make sure that you take all of your personal belongings with you as you leave, and remember, whatever you do, don't blink.

Comments

[voldsom]

I blinked.

I'm always impressed by the amount of work that goes on here, and the attention to the smaller details.

[vass]

Bonus points for the Tom Lehrer reference! ♥

[ex_rising236]

I really just couldn't resist. It felt so perfect with the entire "this many bugs" thing. :D

[azurelunatic]

I've been wanting 733 for a long time! Thank you very very much, kareila; I see from the bug that it took a lot of doing.

On 3079, the bug on LJ was by gariev.

[ex_rising236]

Thanks, will edit the credit for that!

[kareila]

I had a little party on IRC when it closed, yes.

[sophie]

In case anybody's wondering: The new community landing page hasn't yet gone live, so right now if you click the link you'll only see the old one. The new one has things like a list of recently created communities and a list of recently active communities!

[ex_rising236]

Thanks! Have edited the section for that bug to specifically reflect that that one isn't live as-of-writing, so that people know why they don't see it if they click through. I just kind of linked it as a matter of habit, overall.

[feathertail]

Entertaining and considerate of those of us who don't identify as human! So long as we don't blink o_o;

[sofiaviolet]

Yay, one of my suggestions got coded! :D

[afuna]

Yes! I love the idea so much \o/

[jeshyr]

*excessive happy dancing*