is this a bug, or is this something busted on my 'hack?

[denise]

While working tonight, I noticed that something may have broken comment email notification. I'm not getting any notifications of comments made to any journal (even when I was getting those notifications before -- that is, it's not a problem with the ESN workers not running) and in my Apache logs, whenever a comment is posted, I get:


Use of uninitialized value in substr at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 1282.
Use of uninitialized value in string ne at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3513.
Use of uninitialized value in string ne at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3513.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3520.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3520.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3520.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3668.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3668.
Use of uninitialized value in substr at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 1282.


Did we break something, or did I break my 'hack somehow? *g* (I'm using the most recent code, I swear!)

Comments

[alierak]

Glancing at changesets not live on the production site, I think it might be this one:

http://hg.dwscoalition.org/dw-free/rev/40cdb938430c

I would guess that maybe that patch was too strict about checking for explicit subscriptions.

[alierak]

Of course, that's a total guess and was the only one I ran across that looked related to comment notifications.

[kareila]

... Except I think that patch /is/ live on prod.

[alierak]

Oh well, I guess I fail at understanding code-status.html.

[kareila]

Mark told me years ago that code-status often lies, even when it's not borked.