is this a bug, or is this something busted on my 'hack?

[denise]

While working tonight, I noticed that something may have broken comment email notification. I'm not getting any notifications of comments made to any journal (even when I was getting those notifications before -- that is, it's not a problem with the ESN workers not running) and in my Apache logs, whenever a comment is posted, I get:


Use of uninitialized value in substr at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 1282.
Use of uninitialized value in string ne at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3513.
Use of uninitialized value in string ne at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3513.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3520.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3520.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3520.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3668.
Use of uninitialized value in string eq at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 3668.
Use of uninitialized value in substr at /dreamhack/home/8083-rahaeli/dw/cgi-bin/LJ/Talk.pm line 1282.


Did we break something, or did I break my 'hack somehow? *g* (I'm using the most recent code, I swear!)

Comments

Clarification

[ninetydegrees]

Same here.

Edit: I do get notifications, though. My error_log tells me the first error message appeared in March. The other ones seem more recent.

[alierak]

Glancing at changesets not live on the production site, I think it might be this one:

http://hg.dwscoalition.org/dw-free/rev/40cdb938430c

I would guess that maybe that patch was too strict about checking for explicit subscriptions.

[alierak]

Of course, that's a total guess and was the only one I ran across that looked related to comment notifications.

[kareila]

... Except I think that patch /is/ live on prod.

[alierak]

Oh well, I guess I fail at understanding code-status.html.

[kareila]

Mark told me years ago that code-status often lies, even when it's not borked.

[kareila]

The errors related to lines 3513, 3520 and 3668 are (I think) safely disregarded. I can reproduce them several revisions back; these sorts of equality test warnings are really common whenever a function returns "undef" when a string is expected. We've been fixing these warnings for a while, but it's hard to catch them all.

The substr errors appear to be related to icons stored in blobcache instead of mogilefs. I haven't been able to reproduce because I use mogilefs for my icons. But again, not likely related to the problem at hand.

That said, I'm not getting comment emails from my dreamhack either, but I'm not sure I was before. I did get an account expiration email when I turned on my workers for the first time in a while, so I know email notifications aren't completely broken.

[fu]

Thank you for the comment! The blobcache thing was a big help; I'd have taken a lot longer to figure out to turn off mogilefs otherwise.

[fu]

Hm, I definitely still get notifications; I just tried on my dev server(on the latest code)

PS. opened a bug for the warnings and resolved it: http://bugs.dwscoalition.org/show_bug.cgi?id=3874

[denise]

bah. I wonder what I did to my 'hack, then. (I swear I was on uncustomized code when I was having the problem.)

Thanks for checking, at least!

[kareila]

Do you get other types of notifications from your hack? Like lost password, or added paid time?

Also, check Notification Settings on your hack account and make sure you have the email tickies checked. (Mine were turned off! Super genius.)

[denise]

Yes, I do get other types of mail, and yes, I do have the email tickies checked! I'll try poking at it a bit more; maybe it's somehow gotten set wrong at the backend or something.