Code Tour, 2011-05-09 through 2011-05-18

[dreamatdrew]

Hey there, Dreamers.
Yes, I know, I'm late.

Ya know, I had a witty and amusing intro planned here, but then things went screwy and, well, yeah. So, without further ado, I give you A Code Tour!!!

We've got 36 bugs to go through, so lets get cracking.

Bug 3662: Embedding is broken (gives a 'no configured vhost' error)
Category: Frontend
Patch by: mark
Description: Two for One:
Geeky Description: Mark decided to move a few secondary services (like our bug tracker, and the source code repository) to a different host. Everybody kinda forgot that embedded stuff was getting run through that server to make it less likely to be exploitable. We caught it, updated the DNS entries, and all is well with the world again.

Not as geeky description: the guy who was doing embeds changed his phone number, and we had to get the new one handed out to everyone.

Bug 3663: Non-JS files in different res_groups may be included multiple times on the same page
Category: Misc Backend
Patch by: fu
Description: The server was sending certain bits of stuff more than once, because it was writing down the list of things it already sent on the wrong post-it. It has now been given an industrial-sized white board.

Bug 3670: Quick tweak: Use jQuery's document.ready function instead of DW.whenPageLoaded
Category: Modernization
Patch by: fu
Description: Much like there is more than one way to skin a cat, there is more than one way to get stuff to be done once a page is finished loading. Using jQuery's version of the cat-skinner Page Done trigger means less code. So, we switched to jQuery's version.

Bug 3671: Make an extract params method available to jQuery files
Category: Modernization
Patch by: fu
Description: This lets the nifty jQuery stuff that Fu has been working so hard on see the stuff after the '?' in that URL up there. Assuming there is stuff after the '?'. I think. Maybe. It COULD be how we deploy the death-ray.

Bug 2507: Contextual hover menu doesn't work on jquerified pages
Category: Misc UI/Frontend
Patch by: fu
Description: More jQuery loveliness. So, the code was written to make the hovery-bits work. But nobody told the server. The server has now been informed.

Bug 2691: viewing detailed poll answers after expanding cut
Category: Misc UI/Frontend
Patch by: fu
Description: This bug is cake, and the cake is a lie, because Bug 3660 (listed later) just kinda made it go away.

Bug 2139: allow AJAX unscreen/freeze of comments that have been expanded
Category: Misc UI/Frontend
Suggested by: kaigou
Patch by: fu
Description: The Screen/Unscreen/Freeze buttons are handled by AJAX. If you tried to use them on a comment that you expanded, you got redirected to a confirm page, instead of the "oh look, it's just done" handling with unexpanded comments. They should work the same now.

Bug 3672: jQuerify media embed expansion
Category: Journal contents
Patch by: fu
Description: More of the jQuery-ification of Dreamwidth.

Bug 3660: jQuerify polls
Category: Style System
Patch by: fu
Description: More of the jQuery-ification of Dreamwidth.

Bug 3604: Move ::CutExpand controller to ::Controller::RPC namespace
Category: APIs: RPC/XML/Flat
Patch by: exor674
Description: Code cleanup and organization. Nothing to see here. Move along...

Bug 3661: negative "load tags" result is not cached, results in large amount of queries
Category: Misc Backend
Patch by: exor674
Description: When you read someone's journal, one of the things that gets checked for is the list of tags. If the journal you were reading did not have any tags defined, the code kept checking the database, a rather expensive process. It has now been informed that checking once is enough, and to stop badgering the database.

Bug 3659: /icons needs don't-index metatags if user has turned them on
Category: Journal contents
Patch by: ninetydegrees
Description: There's a switch that tells search engines to ignore a page. The /icons pages were not flipping that switch if you had the relevant settings enabled. The switch is there now.

Bug 3649: Practicality: 12 themes
Category: Style System
Patch by: ninetydegrees
Description: New themes.
We have 10 from timeasmymeasure, previews of which are available at http://dreamscapes.dreamwidth.org/56329.html and http://dreamscapes.dreamwidth.org/57649.html .
And 2 more from nornoriel (their first contribution), with previews available at http://dreamscapes.dreamwidth.org/56975.html .
(Yeah, I admit it, I suck at describing themes. But I gave you pretties to look at?)


Bug 3665: Drifting: 4 themes
Category: Style System
Patch by: ninetydegrees
Description: More themes. We have 4 from timeasmymeasure, previews of which are available at http://dreamscapes.dreamwidth.org/57149.html .

Bug 3648: Compartmentalize: 3 themes
Category: Style System
Patch by: ninetydegrees
Description: Even more themes. This time, 2 from forthwritten, with previews at at http://dreamscapes.dreamwidth.org/57149.html .
And another one from nornoriel, with preview at http://dreamscapes.dreamwidth.org/56975.html .

Bug 3678: Brittle & Crossroads: 4 themes
Category: Style System
Patch by: ninetydegrees
Description: Oh god, even MORE themes.
For brittle, rising gives us Blue Days (http://dreamscapes.dreamwidth.org/57984.html), and dancing_serpent gives us Dried Flowers (http://dreamscapes.dreamwidth.org/58268.html).
And nornoriel, the busy lil bee, gives us two more for Crossroads (http://dreamscapes.dreamwidth.org/56975.html).

Bug 2766: "Edit" on Select Journal Style does not work in all use-cases
Category: Misc UI/Frontend, also, Accessibility
Patch by: fu
Description: If, for some reason, you had CSS disabled, and went to the Customize your style page, the "edit" link didn't do nuffin. Now, it puts you in the box you wanna edit.

Bug 3646: Add Option to Transfer Points to Give a Gift Page
Category: Payments
Patch by: fu
Description: Lets say you bought a bazillion DW points. And now, you have a friend who you would like to gift points to. Now you can transfer some of the ones you have lying around, instead of having to decide what gift your friend is getting, or buying more points directly for them.

Bug 3621: Select Style: Page Setup doesn't update itself when you switch styles
Category: Misc UI/Frontend
Patch by: fu
Description: This makes the layout chooser (number of sidebars, etc thingy at the bottom of http://www.dreamwidth.org/customize) update after you choose a new theme. Less confusion is good.

Bug 3368: Move S2 backend to create URLs with create_url
Category: S2 Backend
Patch by: fu
Description: The Cleanupification of the DW code. S2 was hand-making the urls it uses, when there's a high-end press-a-button-and-done url maker right over there in the corner. S2 has been informed to use the tools.

Bug 2698: html modifying cut displays as text when ajax expander used
Category: Misc UI/Frontend
Patch by: fu
Description: This makes the nifty "expand cuts on reading page" thingy ignore the html that could make bad things happen when you wrap a cut-tag in, say, italics so that the entire content of the cut doesn't show up in italic when it shouldn't.

Bug 2688: Investigate all third-party modules we are overriding
Category: Misc Backend
Patch by: fu
Description: Even more of the cleanupification of DW. There were things which we said we needed to run DW, but we were'nt actually using them, or we were overriding everything that those bits supplied. This chunks some of the ballast overboard.

Bug 3250: show # of participants in poll before voting
Category: Journal contents
Patch by: fu
Description: Now you can see how many people have voted in a poll already, before you even vote.

Bug 3664: LJ::User::country_of_remote_ip not used anywhere
Category: Misc Backend
Patch by: fu
Description: Even more of the cleanupification of DW. This was at one point used for QOTD stuff. We don't do QOTD stuff. This makes it go buhbie.

Bug 3201: Quick Reply in site scheme not working in Opera
Category: Browser Issues
Patch by: fu
Description: Apparently, Opera doesn't like sitescheme Quick Replys. This is actualy fixed with the jQuerification stuff. If you are using Opera, and have an issue with Quick Reply, check out the beta features page.

Bug 2290: Move /interface/flat into DW::Routing
Category: APIs: RPC/XML/Flat
Patch by: fu
Description: Code was in wrong file. Code now in right file. Code monkey can find easier now. Code monkey now has more time for frito hunting.

Bug 1489: Tropo standout boxes use tables
Category: Modernization
Patch by: fu... Maybe
Description: OK, really, we're not sure when or how this got fixed, but it did. fu suspects TT fixed it.

Bug 2819: Customize Journal Style: turn sidebar subsections into links
Category: S2 Backend
Suggested by: ninetydegrees
Patch by: fu
Description: To quote the lovely ninetydegrees, "...why something which is in the sidebar and
looks like a link isn't a link?" Yeah, less confusion is good.

Bug 2877: identify deleted replies to journal
Category: Inbox/Notifications
Suggested by: kaigou
Patch by: fu
Description: Seeing a message like "deleted reply for [journalname]" in the inbox is not so helpful. When? What? How? Is that a moon? Now, the inbox will give you a bit more information on the when and where bit. As to "how" and other lunacy, you're on your own still.

Bug 3666: Paletteable: 4 themes
Category: Style System
Patch by: ninetydegrees
Description: ZOMG MORE THEMES. This time, we get 4 from timeasmymeasure. See http://dreamscapes.dreamwidth.org/57553.html for previews.

Bug 3680: Ugly error when trying to view the threadroot in a deleted entry or with a nonexistent comment
and
Bug 3229: Can't call method "url" on an undefined value at cgi-bin/LJ/Comment.pm line 242 in logs
Category: Journal contents
Patch by: fu
Description: The code gets confused when it tells you to go somewhere that doesn't exist. Now it's less geeky about telling you what's wrong.

Bug 2284: make fileedit/support-currentproblems recognize user tags
Category: Site Administration
Patch by: fu
Description: The place that current problems are put for support wanted a different set of tags for marking users. denise shouldn't have to remember two different sets of tags, so fu made it understand the tags we all know and love.

Bug 3681: Lacking membership translation strings in /manage/circle/edit
Category: Circle/Relationships
Patch by: fu
Description: The server didn't know how to tell you that you are or are not a member. It now knows the words.

Bug 3215: Comment Pages account setting: description is slightly inexact
Category: User documentation
Patch by: fu
Description: More "Teaching DW how to say what it means and mean what it says".

Bug 3683: JS for /manage/subscriptions/filters broken
Category: Misc UI/Frontend, Even fu makes a mistake now and then.
Patch by: fu
Description: Seriously, we love fu. But fu is not perfect. To quote her: "accidentally deleted a line I shouldn't have. one sec." We love her anyway.



That's it for this time around. Be good, or at least good at it, Dreamers...

Comments

[musyc]

*frolics around in the new themes* COLORS COLORS COLORS COLORS!

Yay for the other stuff, of course, but it all hurts my head, so I call it magic and move on. Themes, I get. XD *FROLICS!*

[cesy]

I love seeing so many new themes coming through.

[marahmarie]

OK. I have to hand it to you, Drew: I actually understood what this code tour was about, as opposed to my usual, "Well, yeah, I kinda get what it is they're sayin'" reaction - can you do them all from now on?

[dreamatdrew]

Um.... Wow. Thanks.
As far as Drew The Code Tour Guy goes. I suggest you tell/ask/bribe denise on that one, for we must all bow to our benevolent dictator. I dun have a problem doing them, but, well, yeah....

[marahmarie]

Yeah, I know, rotation is the norm. :)

[jss]

(Your link in 3621 points to www.dreamwidht.org, which is probably not what you want. You probably want to fix the transposition of the T and H there.)

[dreamatdrew]

*hides*
Sadly, I make that typo EVERY TIME I type dreamwidth. IDEK. Thought I'd caught em all tho. Thanks!