Code Tour, April 24-May 8

[ursamajor]

Hi there, dweeple, driving the Code Tour bus again this week. We've got a first-time patch from metawidget \o/, as well as patches from anarres, denise, foxfirefey, kareila, ninetydegrees, pauamma, yvi, and a whopping 14 patches from fu!



Bug 3598: PM subject unreasonably large
Category: Inbox/Notifications
Patch by: fu
Description: denise tells the story so well:

I didn't notice until I accidentally pasted the contents of my clipboard
(around 2000 characters) into the inbox subject field and the form accepted it!

It should probably be capped at about 150 characters or so.

So the subject field for private messages has been capped at 255 characters. Longer than a tweet, shorter than a Dreamwidth comment.

Bug 2279: Tiny inefficiency in the content importer, remap_user_friend
Category: Importer
Patch by: fu
Description: On the off-chance that Dreamwidth can't figure out the actual address for an OpenID user, it should not proceed with things like importing their comments. This rule has been implemented.

Bug 3630: Thread expander not working when files are concatenated
Category: Misc UI/Frontend
Patch by: fu
Description: For speed reasons, Dreamwidth compiles all requests for stylesheets and "external" JavaScripts into one. However, comment threads were being prevented from expanding because not all the files were being loaded properly.

Bug 3627: Anonymous poll counting doesn't match up when user skips a poll answer
Category: Misc Backend
Patch by: fu
Description: If you have a poll that asks:

1. Do you live in the US?
2. Do you spell it "color" or "colour"?

and you have anonymous respondents for that poll, you can now see that "Anonymous #1 said 'yes' and 'color'; Anonymous #2 skipped question 1, but responded 'colour' for question 2."

Bug 3632: texttool.pl dumptext puts /foo.tt.stringname into en.dat instead of /foo.tt.text
Category: Misc Backend
Patch by: fu
Description: Text strings for Dreamwidth are stored in two places: "general" for text that is used quite frequently, and "specific" for text that is only used on a specific page. With the transition from BML (the template language LiveJournal was written in) to TT (a more widely used template language), all of the text was being put in the "general" area; this has been corrected.


Bug 3634: Quick Reply in site scheme swallows up all click events
Category: Misc UI/Frontend
Patch by: fu
Description: In site scheme pages, when you click open a Quick Reply, other links would stop working, even if you decide you don't want to finish your Quick Reply. This makes the other links work again.

Bug 1553: Dump existing dw.org text strings and check into cvs
Category: Frontend
Patch by: fu
Description: Text strings were being stored in a not-so-useful place for people running their own Dreamwidth servers (in the database, rather than in the code). They are now stored in a more useful place.

Bug 3637: (jQuery beta) "No JQuery" error on siteschemed reply pages
Category: Misc UI/Frontend
Patch by: fu
Description: For those of you who've opted in to beta testing, you're now taking advantage of the spiffy jQuery libraries. (The jQuery libraries make repetitive/frequently-used functions easily available to coders, and will make development easier in general in the long run.)

Bug 3636: fix cut-tag control module in Sunday Morning and Transmogrified
Category: Style System
Patch by: fu
Description: The "cut-tag" control module is supposed to show up in the sidebar if you enable it. For people using the Sunday Morning and Transmogrified styles, it was showing up near the header. Whoopsies. :)

Bug 3596: Missing space when several status/content warning notices displayed on user profile
Category: Misc UI/Frontend
Patch by: fu
Description: Fixing a teeny typo in site text when combining notices (such as a notice about the journal being in Memorial status and the journal content being labeled as "mature").

Bug 3561: atom-post.t should be skipped if memcache servers don't respond
Category: Misc Backend
Patch by: kareila
Description: On the test server, one of the tests needed some expansion on how it worked, as well as some explanatory text along the lines of "This test is being skipped because FOO."

Bug 3495: Add "icon scaling" to customize options
Category: Style System
Suggested by: chaosraven
Patch by: ninetydegrees
Description: A new option was added to let you choose whether usericons in your journal style displayed at full size, 75%, or 50%. (Some styles forced them smaller, and the only way to change that was by overriding with custom CSS.)

Bug 3629: Double check Colorside archive entry title links
Category: Style System
Patch by: ninetydegrees
Description: In the "Colorside" style, entry title links became invisible because one of the custom color slots was being ignored. This has been fixed.

Bug 3640: canceling filter rename changes name to 'null'
Category: Misc UI/Frontend
Patch by: yvi
Description: When managing subscription filters, canceling a filter rename actually renamed the filter to "null," rather than canceling the rename altogether.

Bug 3639: remove dwisbroken@dwscoalition.org from 404s
Category: Frontend
Patch by: ninetydegrees
Description: Dreamwidth's error message for "Page Not Found" used to tell people to send Dreamwidth an email to say that something's missing; it now links to the DW Twitter to check for known issues instead.

Bug 2951: Tweak bar graphs generated by DW::Graphs
Category: Misc Backend
Patch by: anarres
Description: Various improvements to the automatically-generated bar graphs in polls.

Bug 3645: FAQ #87 doesn't mention twitter.com
Category: User documentation
Patch by: denise
Description: http://www.dreamwidth.org/support/faqbrowse?faqid=87 now mentions that you can type <user=ursamajor site=twitter.com> and the results will be ursamajor.

Bug 3647: Need to record previous expiration of a now-seed-account
Category: Payments
Patch by: fu
Description: People who bought seed accounts may have paid time they want to transfer to somebody else; this keeps track of the original expiration date of said paid time.

Bug 3652: Finduser console command sometimes doesn't show the payments status line
Category: Site Administration
Patch by: fu
Description: For administrative purposes, site admins can look at information for a given user, such as how many invite codes they have remaining, is their journal free/paid/premium paid/seed, if they have paid time when does it expire, etc. If a user had no invite codes remaining, the paid journal status/date wouldn't display to site admins.

Bug 3633: get out of beta
Category: Frontend
Patch by: ninetydegrees
Description: HEY OMG YOU GUYS WE ARE OUT OF BETA AND HAVE A NICE SHINY BETALESS LOGO TO SHOW FOR IT

Bug 841: Clear up directory.bml
Category: Misc UI/Frontend
Patch by: kareila
Description: Oldest bug fixed this week! Three-digit bugs are getting fewer and further between \o/ Basically, there were multiple directory pages with nifty functions, but it was hard to remember which directory page had which specific nifty function. kareila cleaned ALL THE THINGS, and there is now one directory page with all the useful nifty functions.

Bug 3067: Skittlish Dreams & Refried Tablet: icon overlaps text if font is small enough
Category: Style System
Patch by: ninetydegrees
Description: For the Skittlish Dreams and Refried Tablet styles, when the font size was set too small, it overlapped the usericon. Appropriate margins have been added to prevent this.

Bug 3651: Update pauamma's email address in author sections
Category: Unknown
Patch by: pauamma
Description: Updating pauamma's contact information in the code, so that people who run their own Dreamwidth servers can contact him with questions and be sure that email gets to him. Huzzah!

Bug 3277: Allow customized Reading Page subtitles
Category: Style System
Suggested by: dchan
Patch by: metawidget
Description: Ooh, I like this one, and it's also by a new-to-Dreamwidth coder; welcome, metawidget! When you have custom subtitles set for your journal, they show up as subtitles on your reading page, too. For example, my journal is titled "bear", and subtitled "(ˈɜːsə ˈmeɪdʒə)"; my reading page is titled "an unprintable combination of the sacred and the profane." But there wasn't a separate subtitle for the reading page, so "(ˈɜːsə ˈmeɪdʒə)" gets reused as the reading page subtitle. This patch creates a separate field for a reading page subtitle, so that people who want their reading page subtitle to be different from their journal page subtitle can do so. In metawidget's words, this is what will now happen:

Reading Page Properties assigned: Display:
--------------------------------- --------
Title filled, subtitle filled RP title, RP subtitle
Title filled, subtitle unfilled RP title, no subtitle
Title unfilled, subtitle filled Journal title, RP subtitle
Title unfilled, subtitle unfilled Journal title, journal subtitle

Bug 2718: Move manage/subscriptions/user.bml to use "tracking"
Category: Modernization
Patch by: ninetydegrees
Description: "Subscribing" and "subscriptions" were formerly used to describe both the act of adding a journal to your reading page, and the act of requesting to be notified in your inbox when something occurred (such as somebody commenting to a specific entry). This was reflected in the page addresses, so behaviors having to do with the latter are now referred to (and addressed as) "tracking." Behaviors having to do with the former, such as editing your subscription/reading filters, remain in "subscriptions." Hooray, clarification!

Bug 3654: Remove JournalFen as an import/crosspost source.
Category: Misc UI/Frontend
Patch by: fu
Description: Unfortunately, JournalFen has some bugs in their code that prevent Dreamwidth from being able to either import entries from JournalFen, or to crosspost entries to JournalFen. fu made a widget that will let Dreamwidth admins easily and temporarily disable importing/crossposting from specific websites. This will also let Dreamwidth admins be able to respond more quickly in cases like the LiveJournal DDOSes last month - since we can now shut off imports/crossposting more easily, this will help remove Dreamwidth as a source of "too much traffic" in emergencies like that.

Bug 3656: Basic Boxes entry footer needs to clear
Category: Style System
Patch by: foxfirefey
Description: If you use the Basic Boxes style, you may have noticed that short entries where the icon is taller than the text content made the entries display funny. This is now fixed!

Bug 3658: QuickReply shifted to the right in ColorSide (jquery beta)
Category: Journal contents
Patch by: fu
Description: If you've turned on beta-testing and are using the ColorSide style, your QuickReplies did the Time Warp backwards. (They did no step to the left, but a jump to the right.) But with her hands on her hips, fu brought CSS in tight. And made it behave, so that QuickReplies stayed in place. The End.

Comments

[ninetydegrees]

Congrats metawidget and many thanks for the great tour, ursamajor! Your description of #3658 was my favorite. *wipes tear*

[ursamajor]

You're welcome! The reward for reading alllllll the way to the end. :D :D :D

[marahmarie]

Description: The "cut-tag" control module is supposed to show up in the sidebar if you enable it. For people using the Sunday Morning and Transmogrified styles, it was showing up near the header. Whoopsies. :)

It was? I thought it was simply not showing up at all, so I sent it to .my-journal .module-cuttagcontrols {display:none} so I wouldn't try to click around in an empty module anymore (on my journal - Transmog with custom CSS - the cut tag HTML for "no cut tags" was showing up in the correct module (but on every page, even ones with expanders, which was all wrong) - the expander images you click on were simply missing). :)