Code Tour, April 13-20, 2011

[jaciem]

Subtitle: fu been busy!

There are 26 bugs in this tour, two by allen, four by ninetydegrees, one by fu and kareila, and 19 by fu solo. Only four of these are backend, so lots of various changes we can see.

I think most of these went live in the most recent code push yesterday, but someone please correct me if I've got that wrong.



Bug 3620: credit card expiration in shop still has 2010 as default
Category: Payments
Patch by: ninetydegrees
Description: When making a credit card payment, 2010 was autofilled as the year. Now it says 2011. Even at four months late, DW is doing better than I am -- I wrote a date as 200111 yesterday.

Bug 645: OpenID login from navbar should return you to page you were viewing
Category: Misc UI/Frontend
Patch by: allen
Description: At 2 years and a couple weeks old, this bug wins the longevity prize! For many moons, logging in with your OpenID from the navbar took you someplace other than where you'd been. Now it will return you whence you came. Nifty!

Bug 3485: Make returnto work from the OpenID login page
Category: OpenID
Suggested by: matgb
Patch by: allen
Description: This one was a twofer fixed with the above (Bug 645). If OpenID users are directed to the login page, then once they've logged in, they will now be taken back whence they came instead of being sent to the welcome page.

Bug 3612: Brittle: Elegant Brown by rising
Category: Style System
Patch by: ninetydegrees
Description: 1 new Brittle theme by rising.

Bug 3623: Colorside themes with entry background colors look a bit awkward
Category: Style System
Patch by: fu
Description: Certain themes in Colorside had an issue where the entry content was displayed against the side of the color block instead of having a bit of a border when the entry background color was different than the page background color. Code was added to make the border addition automatic when entry background is different than page background. (Can be overriden on an individual theme basis if necessary.)

Bug 3609: Colorside: Sunnyside by aedifica
Category: Style System
Patch by: ninetydegrees
Description: 1 new Colorside theme by aedifica.

Bug 3611: Make sure the Cut Tag Controls module is in right section for each style
Category: Style System
Patch by: ninetydegrees
Description: Core2 was putting this module in a section that doesn't actually exist in certain styles (Transmo, Sunday Morning, and Skittlish Dreams). Now it is in section two in those styles, which does exist.

Bug 3624: update to jquery ui 1.8.11
Category: Misc UI/Frontend
Patch by: fu
Description: "assorted non-breaking improvements." So, I guess we replaced all the china with melamine?

Bug 3625: Automatically use minified version of the JS files when available
Category: Misc UI/Frontend
Patch by: fu
Description: It's Spring, minis are in! A "good enough for now" fix that may be revisited at a later date.

Bug 3094: age restriction settings don't show on site schemes
Category: Journal contents
Patch by: fu
Description: Entries set to either NSFW or 18+ were showing those icons on S2 pages, but not when viewed in a site scheme. Now it does. Good news for those of us who browse at work and those who monitor younguns' web browsing.

Bug 3142: "User's Current Theme" box scales poorly
Category: Site Layout/Navigation
Patch by: fu
Description: The contents of the "User's Current Theme" box on the "Select Style" page were not scaling well at smaller screen resolutions. Now it should scale properly. Speaking as a recent member of the Crappy Monitor Club, I appreciate this one!

Bug 2848: Make user tags in icon email notifications work
Category: Inbox/Notifications
Suggested by: cesy
Patch by: fu
Description: In the email notifications for new icon uploads, the credit "by exampleuser" was showing up as plain text. Now it will have the pretty little userhead next to it.

Bug 3606: /icons should have "site" as option in nav strip
Category: Style System
Patch by: fu
Description: /icons supports site style. Now it will say so in the navstrip when viewed in journal style.

Bug 3544: Poll creator swallows zeros
Category: Misc UI/Frontend
Patch by: fu
Description: When you create a poll, you can now have "0" as an answer. This seems helpful in case of polls asking how many zombie apocalypsi you would like to participate in.

Bug 3537: Move controllers over to get subpatterns from @_
Category: Routing/TT
Patch by: fu
Description: Um. Yes. So now you can use this:
my ( $opts, $a, $b, $c ) = @_;
instead of this:
my ( $opts ) = @_;
my $a = $opts->subpatterns->[0];
my $b = $opts->subpatterns->[1];
my $c = $opts->subpatterns->[2];.
Certainly seems more efficient. I imagine if you understand it, you're jumping for joy.

Bug 3515: redundancy on logout page; logout button not working
Category: Site Layout/Navigation
Patch by: fu
Description: This bug fixed a double log out -- both text and button -- on the /logout page. This bug fixed a double log out -- both text and button -- on the /logout page.

Bug 2715: remove unneeded third party modules
Category: Misc Backend
Patch by: fu and kareila
Description: Several unneeded third party modules, apparently used by nothing but theschwartz, were removed over the last five months.

Bug 3259: Show Selected Icon on Comment Preview Pages
Category: Site Layout/Navigation
Suggested by: strangesequitur
Patch by: fu
Description: The Comment Preview used to let you change a lot of things, but not your icon. It didn't even show you the icon you'd picked. Now it will show you what you've chosen and let you pick a different icon from dropdown or browse button. (And a big YAY! from me. I get my icons mixed up a lot!)

Bug 3029: Fix occasional incorrect "entry dated out of order without tickeh" errors
Category: Journal contents
Patch by: fu
Description: A patch from LJ that presumably does what it says on the box.

Bug 1861: Poll answer redirection in the same style
Category: Journal contents
Suggested by: distractionary
Patch by: fu
Description: The second oldest bug on our tour, this is one of my favs, although fu says its probably not needed as much with the AJAX poll submission thing, so I think I'm covered either way. When you answer a poll on a page loaded with ?style=mine or ?style=light, the page with the poll answers will appear in the same style once you vote.

Bug 3598: PM subject unreasonably large
Category: Inbox/Notifications
Patch by: fu
Description: This one caps the PM subject field at 255 characters, so you'll have to put your novel in the body of the message from now on.

Bug 2279: Tiny inefficiency in the content importer, remap_user_friend
Category: Importer
Patch by: fu
Description: As far as I can tell, fu's given this bit of code a makeover. It's now prettier and more efficient.

Bug 3630: Thread expander not working when files are concatenated
Category: Misc UI/Frontend
Patch by: fu
Description: Now the thread expander should work when files are concatenated.

Bug 3627: Anonymous poll counting doesn't match up when user skips a poll answer
Category: Misc Backend
Patch by: fu
Description: Some messing about with polls to ensure that anonymous voters who skip questions don't get conflated with subsequent anonymous voters who don't skip those questions; this so that each question has a correct count when the answers are viewed.

Bug 3632: texttool.pl dumptext puts /foo.tt.stringname into en.dat instead of /foo.tt.text
Category: Misc Backend
Patch by: fu
Description: Apparently the tool was putting its foo en.dat instead of where it should have been.

Bug 3626: Make "Presentation" the default tab when customizing
Category: Misc UI/Frontend
Patch by: fu
Description: When customizing your theme, you'll be taken to the Presentation tab by default instead of the Display tab.



Doing this tour is a nifty peek behind the curtain at the hard work going on back there. (Also a nice change of pace from writing training modules!)

Comments

[turlough]

I'm so happy about bug 3259, I've been wanting that forever!