Code tour, April 1-12, 2011

[pauamma]

As someday it may happen that a bug tour must be wrote,

Bug 3584: entry preview window needs <title> attribute
Category: Entry preview, Finding a needle in a haystack
Patch by: fu
Description: The entry preview page had no title, which made it hard to locate with many tabs open. Now it's easier, because you no longer have to guess it's the one that says "htt" in the tab bar.

Bug 3583: "filter to this entry" should include comment edit notifications
Category: Inbox/Notifications, Things that belong together, Bugs that were easier to fix than it looked at first
Patch by: fu
Description: The new "comment edited" notifications didn't show up when displaying all notifications for a single entry. Now they do.

Bug 3567: /data/edges fails for deleted accounts
Category: Circle/Relationships, Botsnacks from deleted accounts
Patch by: fu
Description: When trying to retrieve the circle data for deleted accounts (who they were reading and giving access to, who was reading them and giving them access) in a format suitable for automated tools, something would break. Now it no longer breaks. (But I'm not sure what it says because it isn't live yet.)

Bug 3586: We moved IRC servers
Category: IRC, Obsolete information is obsolete
Patch by: ninetydegrees
Description: Long ago, Dreamwidth had its own IRC server. When we moved to Freenode, we forgot to update one page on the site. Now it's current.

Bug 3591: note if a user has beta testing turned on
Category: Helping volunteers help users, Finding where things are broken
Patch by: fu
Description: Recently, we asked for help beta-testing work in progress. When If something breaks and the user reports it by opening a support request, it helps a lot to know whether the user was at the time beta-testing something that may be related. That way, we can either look in the right place (if it looks like a bug we didn't know about in new or old code) or quickly tell the user "we know it's broken in beta, please turn off beta if that's blocking you".

Bug 3592: make talkread use jquery as well
Category: Journal contents, Dragging code into the 21st century
Patch by: fu
Description: Another bit of old code finally reached mandatory retirement age. This one is about either reading comments or posting a new comment, not sure which. (Rule of thumb: if it's so old I don't remember what it does, it's reaaaaally old.)

Bug 3558: attach a note when purchasing paid time
Category: Payments, Adding messages to gifts
Patch by: kareila
Description: When buying paid time for a user, you'll be able to add a message when this goes live.

Bug 2882: Expand/Close all cut tags on a page
Category: Journal contents, Making repetitive tasks less tedious
Suggested by: axiom_of_stripe
Patch by: allen
Description: This will let you expand or collapse all cut tags on a page in one swell foop. Or perhaps it will let you add buttons to your style that do that. The all-knowing foxfirefey said "they'll need to use a style with modules", so I assume the latter, and maybe not all styles will work.


Bug 3593: Rendering of embedded Flash content broke recently in FF
Category: Browser Issues, Fixing things wot we broke.
Patch by: fu
Description: This fixes a bug in the HTML cleaner that we introduced while fixinf another one, and that prevented Flash applications from working correctly in Firefox.

Bug 3600: remove Inksome as import source
Category: Importer, Dead sites don't wear plaid
Patch by: denise
Description: Inksome is no longer up, so don't list it in the import sources.

Bug 3601: allow temporary suspends of new imports
Category: Importer, Being nice to LiveJournal.
Patch by: fu
Description: The importer's been much slower than usual, thanks to both the LiveJournal DDoS making it slow to transfer data to Dreamwidth, and to more users than normal requesting imports. The end result of the 3 patches on this bug lets users submit import requests, while allowing site operations people to pause import processing for specific sites.

Bug 3480: Comment titles shouldn't stick when switching which comment you respond to
Category: Commenting
Suggested by: steorra
Patch by: fu
Description: When you start replying to a comment that had a subject line, your reply will (by default) have that same subject line, prefixed with "Re:". If you then decide you meant to reply to another comment, that subject line would stick even if it has nothing to do with the new comment you're replying to. This bug will fix that.

Bug 3605: handle iframe tags that aren't wrapped in site-embed
Category: Journal contents, Embedded contents
Patch by: fu
Description: I'm not quite sure what this does, to be honest. I think it handles things more consistently between different ways of embedding videos, but for all I know, it may cause pink monkeys to fly out of your bellybutton when you watch a YouTube video on a full moon during a leap year. Or something.

Bug 3608: options in dropdowns in customize are randomly ordered
Category: S2 Backend, Style customization
Patch by: fu
Description: sense that sure instead options makes display to order in

Bug 3580: jquerify quick reply
Category: Comments, Dragging code into the 21st century
Patch by: fu
Description: More old code retired

Bug 3060: Investigate 'flags' field in userpic2 table
Category: Misc Backend, Userpics, What is this code for?
Patch by:
Description: Sometimes you stumble across stored data that doesn't seem to be used anywhere, and code that may or may not do unspeakable (and or pointless) things with that data. So you need to decide to get rid of the data, the code, or both. In this case, we kept the data because we'll use it for something else, and the code because it may help with that planned future use.

Bug 3599: Make sure floated content in entries on the latest page is cleared
Category: Misc UI/Frontend, HTML out of whack
Patch by: foxfirefey
Description: This fixes a display problem on the Latest Things page.

Bug 3439: Crossroads: 5 themes
Category: Style System, Moar bling
Patch by: ninetydegrees
Description: 5 new Crossroads themes by dancing_serpent

Bug 3440: Drifting: 2 themes
Category: Style System, Moar bling
Patch by: ninetydegrees
Description: 2 new Drifting themes by timeasmymeasure

Aaaaaand that's all for this tour. None of this is live, except for the importer-related changes..

Comments

[denise]

The importer-related things are live, as part of a special push, but nothing else.

[pauamma]

Fixed.

[azurelunatic]

The description of Bug 3608 illustrates the problem very nicely.

[musyc]

Agreed. And the coffee on my shirt agrees as well. (Dear self, add code tours to your list of post-types that must be read sans beverage.)

[pauamma]

You're welcome. :-)

[unixronin]

Awwwwwww....... and here I thought we were going to get a code tour in the style of Gilbert and Sullivan. :)

[pauamma]

Sorry. Maybe another time? I didn't have time enough to do a proper filk for it. :-(