poulpette: Stick-figure of a smiling head, raising heart pompoms. Bottom half says YAY!!! (Misc - devs = awesome)
poulpette ([personal profile] poulpette) wrote in [site community profile] dw_dev2011-03-31 02:14 am
Entry tags:

Code Tour, March 17, 2011 - March 31, 2011

Hello everyone, this is your weekly code tour!

This week we have 8 bugs resolved, with 5 patches by [personal profile] fu, and one each by [personal profile] exor674, [personal profile] yvi and [personal profile] ninetydegrees. All those patches are live since the last code push.

I would like to thank [staff profile] denise, [personal profile] exor674, [personal profile] foxfirefey and the other gentle folks of #dw for their help in clarifying some of the bugs for me.


Bug 3575: Importing of comments from big journals fails with truncated content
Category: Importer
Patch by: [personal profile] fu
Description: Sometimes, when the importer had to deal with large journals it tried to ask for more data than LJ could send at a time. LJ didn't like it and eventually timed out in the middle of the transfer, causing incomplete imports. [personal profile] fu made it so the importer tries to ask for less stuff at a time. That way the risk of LJ timing out on the importer is reduced.

Bug 3579: JQuerify control strip JS injection
Category: Style System
Patch by: [personal profile] fu
Description: Most styles use S2 to inject the nifty control strip above journal pages, but some don't have a function to do that. So [personal profile] fu wrote us a cool JQuery function to remedy to that sad, sad fact and now even those styles can print out the control strip.

Bug 3577: Beta tester mode for jQuery journal pages
Category: Misc Backend
Patch by: [personal profile] fu
Description: To make (future) development easier on the devs (as well as more consistent and less non-standard) Dreamwidth has decided to start using JQuery, a javascript library. Which means that existing javascript on the site has to be rewritten to comply with JQuery's standards. This patch creates a Beta status so that courageous users and devs can test those all those JQueryfied scripts. That way the lasts bugs hiding in the code can be caught before they are pushed to the entire site.

Bug 3565: alphabetize sysban types
Category: Site Administration
Patch by: [personal profile] exor674
Description: I'm not exactly sure what one does on the sysban page[1], save admin-y type actions, but according to [personal profile] exor674 the dropdown on that page was 'sorting' the options in some really strange arbitrary order (that might possibly depend on the phase of the moon or if Venus is in retrograde). And it really annoyed [staff profile] denise. Now it's all sorted in a nice, coherent, alphabetized order and things are easier to look for.

[1] [staff profile] denise sheds light on the purpose of the sysban page: the sysban is an admin utility that blocks people from accessing certain aspects of the site based on various criteria, in order to block abuse. The sysban page lets you view and manage sysbans.

Bug 3379: Trying to view a community entry posted by a suspended user gives improper error
Category: Communities
Patch by: [personal profile] yvi
Description: Before, when you were trying to view a community entry written by a suspended user the error message would tell you the entry was access restricted to the community's members.
[personal profile] yvi fixed things so that the error message given is the correct one.

Bug 3498: Customize Journal Style: separate and expand presentation, colors, fonts and images
Category: Style System
Suggested by: [personal profile] ninetydegrees
Patch by: [personal profile] ninetydegrees, with a little bit of help from [personal profile] fu
Description: Now that most of the styles offer lots of customization options, the Presentation section of the Customize Journal Style page was getting unwieldy. Now the font/image/text are sections all on their own, so you won't have to scroll past lost of other options to change one tiny thing.

Bug 3536: jQuerify comment management (screening, etc)
Category: Modernization
Patch by: [personal profile] fu
Description: This patch is part of the effort to modernize Dreamwidth's code base by using more unified javascript scripts, it ports the comments management to JQuery.

Bug 3582: Use of reserved words "for", "class" as keys causes JS to break in Safari
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: This patch makes sure that Safari doesn't interpret the word "for" and other reserved words used in JQuery files as something other than text when they are not intended to be javascript keywords. This way, nothing breaks and everyone is happy.
azurelunatic: Vivid pink Alaskan wild rose. (Default)

[personal profile] azurelunatic 2011-03-31 04:45 am (UTC)(link)
Thank you for a lovely tour!
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)

[personal profile] fu 2011-04-01 06:37 am (UTC)(link)
Thanks, and lovely explanations!