![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
Entry tags:
Code Tour: January 22, 2011 - February 5, 2011
Hallo, my fine feathered, furred, or hairless friends! I bring you a code tour.
I can not promise I will not start talking about all the sparkly colours; the sleep deprivation is kind of epic at this point and I am seriously contemplating doping up the pain (my fellow Dreamwidthians, I can tell you that your hip should be in its socket and when it is not, it is a thing of woe and agony).
But the sparkly colours will be pretty, I can assure you.
Bug 3404: Have a 'make another suggestion' link on the success page
Category: Misc UI/Frontend
Suggested by:![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
matgb
Patch by:kareila
Description:matgb suggested that we add a link to the submission success page for suggestions, so that people who have thought of multiple suggestions can easily go make another suggestions. kareila obliged and tossed in a link back to the community for good measure.
Bug 3397: Suggest an Improvement: enlarge the full description box
Category: Misc UI/Frontend
Suggested by:ninetydegrees
Patch by:kareila
Description:ninetydegrees requested we enlarge the text box size on for suggestion submissions. And kareila provided!
Bug 3410: warnings roundup for Jan 2011
Category: Misc Backend
Patch by:kareila
Description:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
karzilla strikes again, cleaning up warnings so that they're working properly. She does this a lot, as regular readers of code tours may've noticed.
Bug 3409: Refactor DW::SiteScheme / remove some duplicated cdoe
Category: Misc Backend
Patch by:exor674
Description: Dre took a hatchet to duplicated code and now the Dreamwidth codebase is a little bit more svelte bombshell and a little less eldritch horror.
Bug 2261: refactor sysban
Category: Modernization
Patch by:kareila
Description:karzilla, optimiser of code, sez SMASH! Backend code was refactored to be better, cleaner, and a source of green, renewable energy.
Bug 3413: need to include more metadata in journal atom feeds
Category: Feeds
Patch by:kareila
Description: Atom feeds were not consistently showing all metadata that the RSS feeds were. This is not good! Now things are consistent.
Bug 3062: Put FAQ highlighting CSS into site scheme
Category: Misc UI/Frontend
Patch by:fu
Description: When you search the FAQ, it highlights the term you search. The colour of the highlighting, yellow, had been hard-coded which worked not so well in light-on-dark site schemes. The hard-coded colours have been stripped and site scheme specific colours added to their CSS stylesheets.
Bug 3374: Warning in the logs for the interests search controller
Category: Misc Backend
Patch by:kareila
Description: There was a warning about something the interests search controller! It's been resolved? Further questions as to what actually happened should be directed to those amazing devs what speak Old God. Ia! Ia!
Bug 1446: Move /icons page into S2
Category: S2 Backend
Patch by:exor674
Description: This one is made of sparkly ponies and sunshine, y'all. So, at some point in the not-too-distant future, your icons page will show in your journal style, if you are using a core2 style (it won't ever work with core1, since the imported styles will not have any of the data need). This bug lays the groundwork for that by pulling the icons page into core2. Please note that as of yet, they have not written the styling for the icon pages of the various core2 styles, so even when this change pushes to the live site, nothing will change about the appearance of your icon page. But eventually, awesomeness will happen!
Bug 2331: Helpful text when there are no earlier entries
Category: Journal contents
Suggested by:afuna
Patch by:ninetydegrees and fu
Description: There are some limitations on how far back you can go with previous entries on your reading page or your recent entries page; this has been a source of confusion, so now we tell you what's up when you hit that limit and there are no more previous entries to view.
Bug 3424: Having the classes applied to the link instead of the surrounding list item in navlinks can limit styling
Category: Style System
Patch by:fu
Description: So, nesting properly is always fun. The way we were styling links in the navlinks module was applying the class only to the link itself, rather than list items surrounding them, which was limiting. Now it's the other way around, so the list item has the class, which catches the link as well.
Bug 3415: allow checkforupdates to hit db if timeupdate not in memcache
Category: Misc Backend
Patch by:kareila
Description: I quoteazurelunatic, because my brain parsed this bug as arghblarghleblarghle. So for a more coherent explanation: "The 'HEY ANY NEW ENTRIES ON MY RLIST' feature was running into a weird thing. Ordinarily, it asks if there are new entries, we check memcache to see what's what, and tell it. But if memcache comes up empty on that front, the program wanders sadly away with no information. Now it will be authorized to make inquiries of the actual database if memcache doesn't know."
Bug 2903: Repeat links to original articles at the bottom of every feed entry
Category: Feeds
Suggested by:aveleh
Patch by:foxfirefey
Description: Ataveleh's suggestion, incoming feeds now include the link to the originating article at the bottom of the entry as well as at the top.
Bug 2623: new feeds pulling in entries in reverse order
Category: Feeds
Patch by:kareila
Description: New feeds were pulling in entries such that they displayed oldest to newest, which does not make sense with Dreamwidth architecture. After some tussling with the code (bad code! no cookie!), this has been resolved.
Bug 3437: Improper format of time passed to BML::last_mod_time (warning in the logs)
Category: Misc Backend
Patch by:fu
Description: The system told us that time was being passed along in an incorrect format, so we fixed that.
Bug 3436: similar interest search doesn't support communities
Category: Search
Patch by:kareila
Description: Community interests were, at some point in the past, separated out from user's interest; unfortunately, the similar interests search was never told about the existence of the new table containing the community interests, and so they wouldn't show up. Now they will! (They're working on displaying the community interests that will now show up on the similar interests search in their own category; look for that at some point in a future code tour.)
Bug 3425: ljlib.pl should autodetect ARCH32
Category: Misc Backend
Patch by:fu and pauamma
Description: We had been manually flagging the architecture, but! Perl can automagically detect architecture! So now we let it do its thing, instead.
This magical mystery tour contained 17 bugs, with patches submitted byexor674, foxfirefey, fu, kareila, ninetydegrees, and pauamma.
As ever, we covered the code committed to the codebase, but changes will not show on the site until the next codepush.
I can not promise I will not start talking about all the sparkly colours; the sleep deprivation is kind of epic at this point and I am seriously contemplating doping up the pain (my fellow Dreamwidthians, I can tell you that your hip should be in its socket and when it is not, it is a thing of woe and agony).
But the sparkly colours will be pretty, I can assure you.
Bug 3404: Have a 'make another suggestion' link on the success page
Category: Misc UI/Frontend
Suggested by:
matgbPatch by:
kareilaDescription:
matgb suggested that we add a link to the submission success page for suggestions, so that people who have thought of multiple suggestions can easily go make another suggestions. kareila obliged and tossed in a link back to the community for good measure.Bug 3397: Suggest an Improvement: enlarge the full description box
Category: Misc UI/Frontend
Suggested by:
ninetydegreesPatch by:
kareilaDescription:
ninetydegrees requested we enlarge the text box size on for suggestion submissions. And kareila provided!Bug 3410: warnings roundup for Jan 2011
Category: Misc Backend
Patch by:
kareilaDescription:
karzilla strikes again, cleaning up warnings so that they're working properly. She does this a lot, as regular readers of code tours may've noticed.Bug 3409: Refactor DW::SiteScheme / remove some duplicated cdoe
Category: Misc Backend
Patch by:
exor674Description: Dre took a hatchet to duplicated code and now the Dreamwidth codebase is a little bit more svelte bombshell and a little less eldritch horror.
Bug 2261: refactor sysban
Category: Modernization
Patch by:
kareilaDescription:
karzilla, optimiser of code, sez SMASH! Backend code was refactored to be better, cleaner, and a source of green, renewable energy.Bug 3413: need to include more metadata in journal atom feeds
Category: Feeds
Patch by:
kareilaDescription: Atom feeds were not consistently showing all metadata that the RSS feeds were. This is not good! Now things are consistent.
Bug 3062: Put FAQ highlighting CSS into site scheme
Category: Misc UI/Frontend
Patch by:
fuDescription: When you search the FAQ, it highlights the term you search. The colour of the highlighting, yellow, had been hard-coded which worked not so well in light-on-dark site schemes. The hard-coded colours have been stripped and site scheme specific colours added to their CSS stylesheets.
Bug 3374: Warning in the logs for the interests search controller
Category: Misc Backend
Patch by:
kareilaDescription: There was a warning about something the interests search controller! It's been resolved? Further questions as to what actually happened should be directed to those amazing devs what speak Old God. Ia! Ia!
Bug 1446: Move /icons page into S2
Category: S2 Backend
Patch by:
exor674Description: This one is made of sparkly ponies and sunshine, y'all. So, at some point in the not-too-distant future, your icons page will show in your journal style, if you are using a core2 style (it won't ever work with core1, since the imported styles will not have any of the data need). This bug lays the groundwork for that by pulling the icons page into core2. Please note that as of yet, they have not written the styling for the icon pages of the various core2 styles, so even when this change pushes to the live site, nothing will change about the appearance of your icon page. But eventually, awesomeness will happen!
Bug 2331: Helpful text when there are no earlier entries
Category: Journal contents
Suggested by:
afunaPatch by:
ninetydegrees and fuDescription: There are some limitations on how far back you can go with previous entries on your reading page or your recent entries page; this has been a source of confusion, so now we tell you what's up when you hit that limit and there are no more previous entries to view.
Bug 3424: Having the classes applied to the link instead of the surrounding list item in navlinks can limit styling
Category: Style System
Patch by:
fuDescription: So, nesting properly is always fun. The way we were styling links in the navlinks module was applying the class only to the link itself, rather than list items surrounding them, which was limiting. Now it's the other way around, so the list item has the class, which catches the link as well.
Bug 3415: allow checkforupdates to hit db if timeupdate not in memcache
Category: Misc Backend
Patch by:
kareilaDescription: I quote
azurelunatic, because my brain parsed this bug as arghblarghleblarghle. So for a more coherent explanation: "The 'HEY ANY NEW ENTRIES ON MY RLIST' feature was running into a weird thing. Ordinarily, it asks if there are new entries, we check memcache to see what's what, and tell it. But if memcache comes up empty on that front, the program wanders sadly away with no information. Now it will be authorized to make inquiries of the actual database if memcache doesn't know."Bug 2903: Repeat links to original articles at the bottom of every feed entry
Category: Feeds
Suggested by:
avelehPatch by:
foxfirefeyDescription: At
aveleh's suggestion, incoming feeds now include the link to the originating article at the bottom of the entry as well as at the top.Bug 2623: new feeds pulling in entries in reverse order
Category: Feeds
Patch by:
kareilaDescription: New feeds were pulling in entries such that they displayed oldest to newest, which does not make sense with Dreamwidth architecture. After some tussling with the code (bad code! no cookie!), this has been resolved.
Bug 3437: Improper format of time passed to BML::last_mod_time (warning in the logs)
Category: Misc Backend
Patch by:
fuDescription: The system told us that time was being passed along in an incorrect format, so we fixed that.
Bug 3436: similar interest search doesn't support communities
Category: Search
Patch by:
kareilaDescription: Community interests were, at some point in the past, separated out from user's interest; unfortunately, the similar interests search was never told about the existence of the new table containing the community interests, and so they wouldn't show up. Now they will! (They're working on displaying the community interests that will now show up on the similar interests search in their own category; look for that at some point in a future code tour.)
Bug 3425: ljlib.pl should autodetect ARCH32
Category: Misc Backend
Patch by:
fu and pauammaDescription: We had been manually flagging the architecture, but! Perl can automagically detect architecture! So now we let it do its thing, instead.
This magical mystery tour contained 17 bugs, with patches submitted by
exor674, foxfirefey, fu, kareila, ninetydegrees, and pauamma.As ever, we covered the code committed to the codebase, but changes will not show on the site until the next codepush.
no subject
no subject