Code tour: 2010 December 02 to 2010 December 19

[azurelunatic]

Today I've got a great big bowl of pomegranate seeds that I don't have to share with anybody at all. And a bunch of squash cooking in my frying pan. Also a code tour, covering over two weeks, with 37 38 bugs. How's your day?


Bug 3258: Blockquote visibility
Category: Site Layout/Navigation, making things look nice
Suggested by: musyc
Patch by: ninetydegrees
Description: Ever wanted to know how other people get that spiffy indented block of text when quoting someone? <blockquote> is your new friend, in that case. Sadly, when you looked at that entry with the nicely formatted quote, the indent was sometimes very very shallow. This fixes that for site-schemed entries.

*throws some onions in the pan*

Bug 3337: Apply usercontent styling to inbox notifications
Category: Inbox/Notifications, making things look nice
Patch by: fu
Description: That same problem with indenting showed up in the inbox, and blockquotes actually weren't indented at all there. The beauty of Dreamwidth development includes how people do what they can on any given bug, and if it includes something that's not in their area of expertise, another developer can guide them through it, or take it up. fu took the inbox part of the blockquote problem.

Bug 3245: Investigate whether we still need anti-squatting message on dev servers
Category: Dreamhack maintenance
Patch by: fu
Description: There used to be a little message on developer servers: "Warning: This server is for development and testing only. Accounts are subject to frequent deletion. Don't use this machine for anything important." This is still true, but the warning isn't necessary any more. If some poor misguided soul did stumble across any developer's server, they wouldn't be able to make an account because they wouldn't have a working invite code. Invite codes from Dreamwidth won't work on a developer server, and invite codes from the developer's server won't work on Dreamwidth.

Bug 3290: Comment Notification Email Links
Category: Inbox/Notifications, making things do what they say on the label
Suggested by: theodosia21
Patch by: ninetydegrees
Description: There's a link in the emailed notifications that says it's for the comments, but it went to the top of the entry, instead of jumping to the comments section. The #comments anchor was added to the link down at the bottom of the notification with all the other comment viewing and management links. If you were depending on that link going to the top of the page, there is a link to just the entry at the very top of the notification, but if the lack of that link at the bottom cramps your style, let us know!

Bug 2474: Add non-existent interest from interest search
Category: Misc UI/Frontend, interests, making things easy
Suggested by: yvi
Patch by: yvi; congratulations on fulfilling your own suggestion! :D
Description: If you happen to be searching for some interest, like squash and onion curry (which, coincidentally, is what the thing in my frying pan is supposed to be when it grows up; it's going to be very exciting because I've never made curry before) which no one else already had, you got the message: "There are no users interested in squash and onion curry. If you are interested in this and would like to be added to this list, click here." "Click here" sent you back to your profile, where you could add the interest. Two problems: one, a plain "Click here", what? and two, why send you all the way back to the profile when you could just add the interest right there? This epic patch was five months and five submitted patches in the making.

Bug 2540: some tests need a replacement for /dev/t_00.bml
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: There was a really simple page that a couple of things on the back end used to test stuff on. That page went away, and no one really noticed until karzilla came rampaging through to find out why those tests were broken. Replacement page is now in place.

Bug 3217: remove "use vars" pragma from modules in cgi-bin
Category: Modernization, Misc Backend, the wrath of the code machete
Patch by: kareila
Description: Our code is being dragged kicking and screaming out of the Century of the Fruitbat, even when it's code that we didn't actually write.

I've also got butter in the frying pan, and there was bacon grease at first, but I think you could probably make this vegetarian, or even vegan if you used another oil.

Bug 3313: "Also Access To" list not in alphabetical order
Category: Misc UI/Frontend, making things make sense
Reported by: lone_lilly
Patch by: Erin of teamdestroyer
Description: All the other lists of users on the profile were in alphabetical order, except for the "Also Access To" list. Just a little thing, but still worth fixing!

Bug 3332: fix warnings in htdocs/manage/circle/add.bml
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: More back-end freakouts over things that shouldn't be causing freakouts. Fixed!

Bug 3308: warnings for undefined privarg in priv console command
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: Sometimes, it's "KARZILLA SMASH WARNINGS". Sometimes, it's "KARZILLA SMASH", by which of course is meant, "KARZILLA SMASH EVERYTHING". But if a computer's expecting something after the "SMASH", sometimes it gets confused and warnings happen anyway.

Bug 3292: Show 'display cross post links' on cross-posting summary page
Category: Crossposter, un-hiding helpful options
Suggested by: kyrielle
Patch by: Erin of teamdestroyer
Description: The 'display cross post links' setting was really hard to find. This puts it in a more convenient place to use (and find)!

Bug 3324: remove gratuitous shifts from Entry.pm
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: The code did not need to do that. Now it doesn't.

I like potato in my curry, so I sliced up some of that too. I hope this is going to be good.

Bug 3325: servicetype error not displayed on /manage/externalaccount
Category: Misc UI/Frontend, making things make sense
Patch by: kareila
Description: Usually you can't even get to the page where you set up a new external account to cross-post to if you're over your limit. But if you've done something like bookmark it, you might wind up there. So if you're there, it would make sense to give you an error saying that you've already got too many set up? Right? Now it will!

Bug 3339: remove broken add_edge call from htdocs/feeds/index.bml
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: There was some funky code after creating a new syndicated feed, but we're doing stuff differently now, so out it comes!

The frying pan is so full. I can barely stir it; I have to be really careful it doesn't slop out. Perhaps a different pot next time.

Bug 3326: avoid uninitialized warnings in LJ/Lang.pm
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: More stomping around to fix warning-related stuff on the back end.

Bug 3329: avoid uninitialized warnings in LJ/Keywords.pm
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: More of the same!

Bug 3323: avoid uninitialized warnings in ljtextutil.pl
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: More warning problems, more karzilla.

I just added coconut milk and the blocks of instant curry. I am pretty sure the instant curry is cheating, but this is my first time.

Bug 3330: avoid uninitialized warnings in LJ/Customize.pm
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: karzilla, warnings. Warnings, karzilla.

My curry has turned a really pretty color light yellow.

Bug 1747: Add "expired last month" to circle gifts in the shop
Category: Payments, making things make sense
Suggested by: cesy
Patch by: kareila
Description: The idea is, sometimes you want to give your friends a paid account, but you prefer to give it to someone who's going to have some use for it. While it wasn't practical to sort out "expired last month" from all the people in your circle who have ever had paid accounts, the people who have had paid accounts can certainly be sorted out from the people who have never had them.

Bug 3327: fix warning from LJ/S2.pm - don't needlessly de-re-reference hashrefs
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: More tromping through the code and getting rid of warnings.

The curry turns a darker color when I stir it. It's the color of the paste, not burned, good.

Bug 3344: Support table header is bordered... oddly.
Category: Misc UI/Frontend, making things look nice
Patch by: ninetydegrees
Description: The support board uses a table to organize all the stuff on it, with a header on top. The header on top suddenly developed a weird display issue. It turns out that one of them was being treated as a table header cell, and the others were being treated as a plain table cell with bold formatting. Woops.

The curry is smelling so, so good, but it doesn't quite look done yet.

Bug 3342: fix warning in LJ::EmbedModule::module_iframe_tag
Category: Misc Backend, the wrath of the code machete
Patch by: kareila
Description: More warnings, more fixing.

Curry needs rice. I need to make rice.

Bug 3192: Fluid Measure & ColorSide: 9 new themes by dancing_serpent
Category: Style System
Patch by: ninetydegrees
Description: New themes! Previews available linked from the submission entries:
http://dreamscapes.dreamwidth.org/49481.html
http://dreamscapes.dreamwidth.org/51245.html
http://dreamscapes.dreamwidth.org/51702.html

Bug 3333: Blanket & Nouveau Oleanders: 13 themes by dancing_serpent
Category: Style System
Patch by: ninetydegrees
Description: More new themes!
http://dreamscapes.dreamwidth.org/53750.html
http://dreamscapes.dreamwidth.org/53218.html

Bug 3059: Modular: Starry Night by cesy
Category: Style System
Patch by: ninetydegrees
Description: And another theme:
http://dreamscapes.dreamwidth.org/43277.html

Why do I only have short-grain rice?

Bug 3278: More informative error message when maximum tags is reached
Category: Tags, making things make sense
Suggested by: lorem_ipsum
Patch by: Erin of teamdestroyer
Description: There are only so many tags that can be set up for your journal. (It's a long story, going back to the LJ days, but basically even one person having a WHOLE lot of tags can make the site suck for everybody.) So everybody's got a tag limit, and while a lot of people will never reach it, some people will. Now, when you've accidentally tried to create more tags than you can have, it'll show you which tags are the new ones, so you can take off those ones.

Bug 2994: New Style: Paletteable by branchandroot
Category: Style System
Patch by: ninetydegrees
Description: A whole new style, Paletteable, with its default theme, Descending.
http://dreamscapes.dreamwidth.org/40189.html

Oh my, the curry smells good, and now it looks like proper curry.

Bug 3110: convert interests.bml to TT
Category: Routing/TT, interests, wrath of the code machete
Patch by: kareila
Description: Once upon a time, Brad Fitzpatrick wrote a language called BML, to help build webpages, because nothing else quite did what he wanted it to do. A decade later, there are other, more modern things (like Template Toolkit) that do it better.

I've got a little bowl of the curry, and a little fork, and I'm waiting for the rice, but the curry tastes sooooooo good. Very mild. Next time I may alter the proportions. That was a pretty big squash, and I used the whole thing.

Bug 3270: Extend "track all comments in this community" to non-members
Category: Inbox/Notifications, communities
Suggested by: cesy
Patch by: ninetydegrees
Description: If a community is premium-paid or seed, non-members may now track all comments (to publicly viewable entries). The bug has a bonus explanation in comments of how "caps" (account capabilities) are set on the back end so all of Dreamwidth's own clones can set up what their paid accounts will be like on their own very easily. [Thanks to somnolentblue for the catch on who gets it.]

Bug 834: prevent custom bio content from breaking the profile page
Category: Misc UI/Frontend, profile, things not being broken
Patch by: fu
Description: This is an old one! You can stick stuff in the bio section of the profile that makes the whole page funky. This should take care of several situations where bio content could break the page.

My rice is done!

Bug 3346: remove unused function LJ::create_extuser
Category: Misc Backend, wrath of the code machete
Patch by: kareila
Description: This bit originally created OpenID users, but there's a new thing that does that now. Out it goes!

Delightful curry over hot hot rice. Can my day get better?

Bug 3314: investigate datetime manipulation in talkread vs. talkpost
Category: Misc UI/Frontend, for certain values of "frontend"
Patch by: kareila
Description: The date/time on entries were handled differently based on 12 hour or 24 hour time, and whether the person viewing the entry is the owner or someone else. Now it's nice and consistent, with bonus warning-fixes.

Curry: so tasty. Even tastier when you've made it (mostly) yourself!

Bug 3341: silence "null operation" warning in DW::Request::Apache2
Category: Misc Backend; the wrath of the code-machete
Patch by: kareila
Description: Perhaps not such a good idea to ignore warnings if you don't know what they're about. Much better to track down the cause and fix it.

Bug 833: Styles: allow users to set custom date and time formats
Category: Style System
Patch by: ninetydegrees and foxfirefey
Description: S2's back end already allowed for some lovely variation in date formats. Now to pull that out where the average user can actually make use of it!

Bug 2890: Accepting closed community invite and adding to reading list doesn't add to default view
Category: Communities, reading filters
Patch by: fu
Description: The only way to get into a closed community is to be invited. When accepting the invitation, this is a common time to also watch the community. The code here didn't add the community to a Default subscription filter, if one was set up. Now it will.

Bug 3284: Funky Circles: refactor
Category: Style System, invisible changes are invisible; the wrath of the code-machete
Patch by: ninetydegrees
Description: Among the risks of growing as a developer -- growing as any sort of artisan or artist -- is looking back at one's early works and wondering, "What on Earth was I thinking when I did that?" Happily, one can refactor one's styles if one's in the mood to do so!

I think next time I make this curry, I'll include carrots. Celery would be nice too. Maybe even some meat.

Bug 3315: investigate references to nonexistent $u->friend_uids method
Category: Modernization, the wrath of the code-machete
Patch by: kareila
Description: Some old and nonexistent stuff, now updated, and/or removed.

Bug 2306: S2 background position assigned values reducing options
Category: Style System
Patch by: ninetydegrees
Description: CSS lets people move background images all over the place, up and down, side to side, by percentages and pixels as well as the top, bottom, left, right, and center (and all the permutations thereof) that S2 currently allows. This way, people using advanced customizations will be able to use the full power of CSS to move background images around, while not messing up stuff for everyone else set in the happy little Customize Journal Style: Images page.


And that's it! Thanks to everyone who contributed, the upcoming code push will have a few nice little things (this won't be live until it's been pushed; keep an eye on dw_maintenance and Twitter), and I've got leftover curry and rice to hold me for a few days!

Comments

[cesy]

Wow, lots of cool work going on there.

[delight]

I really appreciate both all the changes, and the updates on the cooking progress throughout the tour!

[somnolentblue]

Mmmm, curry. I am now hungry. :) (This? Is why I love code tours.)

I have a question about bug 3270. The description states, "If a community is paid, non-members may now track all comments (to publicly viewable entries)." However, I took a look at Bug 3270, and the conversation there looks like it's for seed and premium paid community accounts, not all paid community accounts. Will the track all feature for non-members work on all the paid communities or will it be restricted to seed and premium paid communities?

[azurelunatic]

You're absolutely right: it is for seed and premium paid communities. This was my oversight. *fixes*

[somnolentblue]

'Tis all good! I just wanted to double check before I told the comm I admin - let's hear it for Yuletide procrastination!

[matgb]

I kept getting distractamicated by the cooking notes and had to go back to reread the bugs. Several from dw_suggestions there, that's nice to see.

[marahmarie]

Yeah, me too! I was actually more interested in the curry and rice at times than I was in the bug fixes. Which, on top of everything else, made me feel slightly guilty for not paying more attention to the important part (which was the curry, right?).

If that was a test of some sort, then yep, I think I failed it. :)

[musyc]

I now have to explain to my family why I squeaked while "checking my mail" at dinner. Yay for blockquote indent! :)

[theodosia21]

Something I suggested was changed! *falls over in excitement* Thank you so much, ninetydegrees!

[ninetydegrees]

You're most welcome!

[kareila]

I was just thinking this morning that I wanted an Azz code tour for (insert winter holiday of choice).

Aaaaand now I'm hungry.

[afuna]

Aaaaand now I'm hungry.


You are not the only one!

[pauamma]

Best way to acknowledge your bugsquashing and curry favor with you? :-)

[fyreharper]

>.<

[pauamma]

*beams proudly*

[azurelunatic]

:D

I usually go for the Winter Solstice, myself.

I am happy to share!

[pauamma]

http://knivesfireandfun.blogspot.com/2010/12/seeking-perfection-aloo-gobi.html

[katarik]

... And now I am *starving* and THE STORES ARE CLOSED.

D:

[pauamma]

My work here is done. :-)

[katarik]

But why are the stores closed?

*shakes empty kitchen sadly*

[sraun]

Hmm, coconut curry. You might toss in some raisins or other dried fruit next time. My wife thinks cauliflower goes really well in curry (and I tend to agree with her).

[archangelbeth]

Your curry sounds so good. I wish I cooked! *sigh*

Also, thank you for the code tour!