Code Tour: 2010-11-18 to 2010-11-25

[cxcvi]

Good morning (assuming it is morning where you are... it's 5am here), and welcome to this week's code tour. My name is cxcvi, and I will be your guide for the next few minutes. This week, we have 17 bugs, with a good chunk of them addressing the backend of the site.


Bug 3241: gift_url not linkified in HTML birthday emails
Category: Inbox/Notifications
Patch by: kareila
Description: In the birthday notification e-mail, there wasn't a "click here to buy them a gift" link. This patch adds one.

Bug 3232: Cleared colors do not stick when using the customization wizard
Category: S2 Backend
Patch by: fu
Description: To quote fu: "You can set a color property to blank through the customization wizard, to make the background disappear from your layout. However, the next time you try to customize your journal, the color from its parent layers (layout, theme, etc) comes back, so you have to clear it again." Except now it stays cleared.

Bug 3175: Misc. Styles: 9 new themes by rising
Category: Style System
Patch by: ninetydegrees (themes by rising)
Description: 9 themes: 3 for ColorSide, 5 for Negatives, and 1 for Refried Tablet.

Bug 3282: Long keywords cause brokenness in userpic selector popup
Category: Misc UI/Frontend
Patch by: fu
Description: Quick fix for a browser-specific issue (Chrome on Windows). Makes the popup slightly wider (but not noticeably so).

Bug 3281: Warnings when viewing a profile with no user icon
Category: Misc Backend
Patch by: kareila
Description: Warnings are bad. Warnings that could happen quite a lot (and I suspect that there are quite a lot of accounts without any user icons) is very bad. Not trying to load things that don't exist, and loading a default image instead is good.

Bug 3262: Change Color of "apply layout" button text in celerity
Category: Site Layout/Navigation
Suggested by: faithofone
Patch by: ninetydegrees
Description: When using Celerity as your site skin, some of the buttons on the Custonize Journal Style page are almost unreadable. This patch makes them easier on the eyes.

Bug 3269: Stop maintainers from 'jumping' the moderation queue of a comm
Category: Communities
Suggested by: denise
Patch by: ninetydegrees
Description: Sometimes, community maintainers want to post to a moderated community without using their "this doesn't need moderating" special powers. They probably don't need (or want) to appear at the top of the moderation queue when doing this. So now they don't.

Bug 3073: Indication of successful comment posting, when locked out of an entry
Category: Journal contents
Patch by: fu
Description: When posting a comment using an account that you're not logged in as (usually because you're replying to a comment using the e-mail notification) you didn't get confirmation that the comment posted successfully, just that you're not able to see the entry. Now you get both.

Bug 3247: fix finduser display for account status
Category: Misc Backend
Patch by: kareila
Description: Account status was showing incorrectly in certain circumstances in a console command. This makes the output more accurate.

Bug 3248: create_url needs fragment after args
Category: Misc Backend
Patch by: exor674
Description: URLs were being written the wrong way around. The fragment (the part that begins with a #, for example: "#comments") should (and now does) appear at the very end.

Bug 3196: some poll votes send numerous repeat notifications
Category: Inbox/Notifications
Patch by: kareila
Description: For some unknown reason, polls were sending out an excessive number of notifications from polls. The fix is to only send notifications when the votes actually change.

Bug 3206: Warnings in cgi-bin/modperl.pl at Apache startup
Category: Misc Backend
Patch by: pauamma
Description: Warnings are bad. Catching edge cases is good. Making life easier for the devs is even better.

Bug 3159: create.bml.success.* strings missing from dw-free
Category: Misc UI/Frontend
Patch by: ninetydegrees
Description: It was noticed that some strings were missing from a file, that was used in user creation. It was then notice that the file is no longer actually used by anything (user creation is done in a different way now), so the old code was removed.

Bug 3252: weird warning in htdocs/tools/endpoints/esn_inbox.bml
Category: Misc Backend
Patch by: fu and kareila
Description: When not viewing in single-entry view, a warning is thrown because itemid is "undefined" (as a string value). A frontend fix to make this actually be a number, and a backend fix to handle non-numeric values, just in case.

Bug 3283: Support: missing href when viewing closed requests
Category: Misc UI/Frontend
Patch by: ninetydegrees
Description: In the support requests part of the site, the link back to showing open requests wasn't actually a link, due to some bad HTML. This has been fixed.

Bug 3199: Update FAQs to reflect rename changes from Bug 2317
Category: User documentation
Patch by: denise
Description: The FAQ page about account renames is now up-to-date about the recent changes to the renaming system.

Bug 2684: Segfault in Unicode::CheckUTF8, if we pass in a non-string to LJ::is_utf8
Category: Misc Backend
Patch by: exor674
Description: Another patch to make life easier for the devs, this time involving making a utility function work as it should do.