Code tour: 2010-11-10 to 2010-11-18

[foxfirefey]

Welcome to the Dreamwidth code tour! Today we have lots of code clean up and wee fixes, a couple of exciting code merges from LiveJournal, some new themes for Practicality.

Bug 3220: Remove all traces UserNewComment/UserNewEntry events
Category: Inbox/Notifications
Patch by: fu
Description: These events would let you track any comment or entry a user posted ANYWHERE. They weren't actually exposed anywhere--that is, you couldn't actually use them to track anybody this way. And chances are there wouldn't be any way to offer this to people without complicated confusing opt-ins, etc, lest it be creepy. So, out it goes!

Bug 2913: Tags starting with & and with a space handed incorrectly in latest things tag cloud
Category: Tags
Patch by: sophie
Description: Whoops! We now fix links for tags on the latest entries page if they start with the & character, which has a special meaning in URLs.

Bug 3222: Undocumented temporary config related to import
Category: Site Administration
Patch by: fu
Description: If you are using your own Dreamwidth site, you will need to configure it! This patch makes it so you'd know about two options involved with importing.

Bug 3221: Comment Imports sometimes blank
Category: Importer
Patch by: fu
Description: This is our attempt to fix some imports that had blank comments.

Bug 3224: Empty keyword breaks keyword mapping for users on dversion 9
Category: Journal contents
Patch by: fu
Description: You're not supposed to be able to have an empty keyword for an icon, but somehow some snuck through and it was breaking things. This makes the codebase pretend it's not there and only use real keywards.

Bug 3228: Argument "2010-03-28 06:43:29" isn't numeric in int shows up in logs intermittently
Category: Misc Backend
Patch by: fu
Description: We were passing in the date instead of the time stamp to icons being served, but it expected a timestamp (which is just a number). As a bonus, served icons will now have the correct last modified date.

Bug 3230: Warnings when viewing feeds, journals in site styles, journals with no styles
Category: Misc Backend
Patch by: fu
Description: More warning clean up! These warnings were showing when you viewed a journal without a "normal" style.

Bug 3231: Warnings when editing style properties using /customize/options
Category: Misc Backend
Patch by: fu
Description: Fewer warnings when customizing your style!

Bug 3234: Warning in the logs when viewing an entry with irreparable markup.
Category: Misc Backend
Patch by: fu
Description: Fewer warnings when cleaning up bad HTML!

Bug 3189: Make site schemes siteviews S2 layout have inheritable themes
Category: Site Layout/Navigation
Patch by: exor674
Description: exor674 did me a huge favor in my beleaguered and much belated quest for bug 168. Basically, this will let me do specific styling for the different site schemes, so that I can pretty up the site view for things like recent/tag/archive views.

Bug 3219: Practicality: 6 new themes by rising & timeasmymeasure
Category: Style System
Patch by: ninetydegrees
Description: We love having more themes!

Bug 3223: Reply form: no spacing between button labels and descriptive text
Category: Misc UI/Frontend
Patch by: ninetydegrees
Description: This tweaks the reply form so that there is consisting spacing and delineation between posting options and descriptions.

Bug 707: Add "poster" support to core2
Category: Style System
Patch by: LiveJournal, merged by sophie
Description: LiveJournal implemented this really nifty feature where you could filter entries in a community by who posted them! It was part of their open source codebase, so we've gratefully merged it into our code base and salute their work and skills.

Bug 3235: DW/SiteScheme/Local.pm fails t/use-strict.t
Category: Misc Backend
Patch by: kareila
Description: In our Dreamwidth Perl code, we always use something called "use strict" that helps catch simple errors and enforce good style. kareila found a file that wasn't using it and added it.

Bug 1585: Filter by multiple tags
Category: Tags
Suggested by: sky
Patch by: fu and kareila
Description: LiveJournal implemented this OTHER really nifty feature where you could filter entries by a combination of tags! That is, you'll be able to find entries that are tagged, say, both "pets" AND "food", instead of just entries that are tagged "pets" OR "food", like is possible currently. It was something we wanted to implement for a while, and when we looked into it, LJ had a good implementation and part of their open source codebase, so we merged it with the DW codebase. More thanks to the hard working LJ folks!

Bug 3236: Warnings when loading a comment/reply page in site skin
Category: Misc Backend
Patch by: fu
Description: Warnings. LESS OF THEM. It is a theme, this week.

Bug 3115: JS error "randomicon is null" when commenting anonymously
Category: Misc UI/Frontend
Patch by: fu
Description: Whoops! The random icon feature's Javascript didn't expect commenting anonymously, which broke it for some other things. Fix!

Bug 2909: Remember ?style=mine when moving between entries in a journal
Category: Misc UI/Frontend
Suggested by: torachan
Patch by: fu
Description: This is a suggestion implemented that makes it so if you're using next/previous on entries in a journal, if you are using ?style=mine, the links for next and previous will use ?style=mine too!

Bug 3238: Empty alt text for spacer images in talkread
Category: Misc UI/Frontend
Patch by: fu
Description: Some day, we will get rid of those spacer images, but until then, we'll put in empty alt text, which befits their purpose.

Bug 3239: Spacer images in inbox need alt text
Category: Misc UI/Frontend
Patch by: fu
Description: Just like the previous bug, spacer images need empty alt text.

Bug 2434: fix "view extended profile" link for OpenID users
Category: OpenID
Patch by: fu
Description: The extended profile link for OpenID users (on their profile) was broken! This fixes it.

Bug 2552: Close cut tag in moderation area wrong
Category: Communities
Patch by: fu
Description: If you have a moderated community, if somebody had an entry in the queue with cuts, the end cut would display as </lj-cut>, but it should be </cut>!

Bug 3240: Invisible text in community settings in Gradation site skins
Category: Communities
Patch by: ninetydegrees
Description: If you have a community you are managing, and you use the Gradation site skin, you may have noticed some awkwardly hard-coded colors making it hard or impossible to read certain things! This fixes that.

Comments

[musyc]

2909makes me happyyyyyyyyyyyy! One of those niggling frustrations of life, gone! :)

[sophie]

Whoops! We now fix links for tags on the latest entries page if they start with the & character, which has a special meaning in URLs.

Actually, it fixes any special character in tags from breaking the URL! For example, there were tags beginning "=" that weren't able to be clicked on - that's fixed here too. :)

[poulpette]

Which is totes awesome :D thank you sophie!

[sky]

!!!!

I actually... had no idea LJ'd implemented multiple tag filtering all that time ago until happening to see this code tour...

Aaaaah this is exciting!

[zaluzianskya]

omg, the LJ multiple-tag-filtering and filtering-by-poster! I was wondering if those would show up here.

Thanks!

[pauamma]

I try to keep track of LJ code changes that DW may want to import and open Bugzilla tickets (or in some cases, make suggestions) for them, but if you see something on LJ you'd like to have on DW, you should suggest it.

[poulpette]

bug 1585 is SHINY <3<3<3

[azurelunatic]

This whole code tour is full of happiness!

[sarken]

1585, woot! :D

[sophie]

By the way, in case anybody is wondering about the warning cleanups and why you weren't seeing them anyway - that's because the warnings being talked about here are internal warnings that were going to the error log on the server. :) And it's not that we were taking the warnings *themselves* out - just the causes of them. So it's a case of general code cleanup, not "We don't want to see these so we're ignoring them." :)

So the warning cleanups don't actually have any visible effect on the site itself, but it does make life for us devs a bit easier. :)

[alixtii]

Okay, thsnks. I was wondering that--I assumed you weren't simply removing useful and needed warnings for users, but the way itwas framed did make me wonder, and I'm not tech-savvy enough to have been able to have known what else it could have meant without being told.