Code Tour: 2010-11-04 to 2010-11-10

[truelove]

Hello, everyone! I come bearing a code tour. Also, snark. It seems nearly traditional.

We've got 17 bugs, including a patch for 4 new themes for Tranquility III behind this finely crafted cut.

Bug 3202: Entry preview shows the wrong user when browser autofills username/password
Category: Journal contents
Patch by: fu
Description: Weird things were happening with browser autofill. If you had two accounts and were logged into a secondary account and went to update, when you previewed the entry the browser autofill was sometimes filling in your primary account information, thus the preview showed you the update as being made with the wrong account. While it was actually posting to the correct account, this was confusing and bad.

Bug 3204: Set the site's default layout on the user explicitly when the user is created
Category: Unknown
Patch by: fu
Description: Recently, the default layout you are assigned on creation of a journal was changed. This should not have affected any extant journals, but the gremlins in the code decided that if you had never even visited the Customise Journal page, that it did. fu sent the gremlins packing so it won't happen again.

Bug 2195: Styles: standardize font options & header images options
Category: Style System
Patch by: ninetydegrees
Description: sage made a suggestion that font customisation options be available in all styles; this was deemed good and excellent as a notion -- hurrah standardisation! -- and lo, the brave ninetydegrees did battle with the various styles.

Bug 2982: Modular needs more heading variables set
Category: Style System
Patch by: ninetydegrees
Description: Ia! Ia! Or, there was styles/CSS voodoo. Or, there was a loophole in the CSS for fonts for Modular that meant they had to go in a explicitly specifiy default fonts for module headers in Modular.

Bug 2351: calendar link
Category: Journal contents
Patch by: Erin, of teamdestroyer
Description: ratcreature's suggestion that the link to the calendar take you to the current year for the sake of convenience of navigation of previous entries has been implemented by Erin of the magnificent teamdestroyer. Previously, it would take you to the latest year -- which, with future-dated posts, could be 2017 or 2050.

Bug 3203: Cannot change entry icon to default on edit
Category: Journal contents
Patch by: exor674
Description: Apparently, you couldn't change the icon on an entry to the journal's default icon when editing the entry. Now you can.

Bug 3181: cannot expand comments in IE7 using sitescheme or light format
Category: Browser Issues
Patch by: fu
Description: Comments wouldn't expand in IE in sitescheme and ?style=light; this changes the code so IE properly detects things and displays expanded comments now.

Bug 3213: Polls don't render '0' answers
Category: Misc UI/Frontend
Patch by: yvi
Description: yvi discovered that answers titled '0' in polls were not rendering -- the data was being tracked but the bars showed 0 length, as if no one had selected the option. So she filed a bug and fixed it!

Bug 3205: Warnings logged by cgi-bin/DW/Template/Filters.pm and cgi-bin/LJ/Lang.pm
Category: Routing/TT
Patch by: fu
Description: A couple of warnings were being thrown by the template system; this fixes them.

Bug 3214: Breaking out of Quickreply breaks style arguments
Category: Site Layout/Navigation
Patch by: fu
Description: Style arguments in urls (that's the ?style=X that will load a given entry, journal, or whatever in the specified style, be it yours or light or whatever) were getting pureed together unusably in certain circumstances. And now they don't.

Bug 3210: keyword mapping not showing up in memcache_view.
Category: Site Administration
Patch by: fu
Description: There was something with keywords and memcache and they apparently didn't have a diagnostic tool for the backend that they ought to have.

Bug 3182: DW/Controller/Admin.pm fails 00-compile.t
Category: Misc Backend
Patch by: kareila
Description: kareila does a lot of code modernisation and clean-up in the eldritch depths of the codebase. I fear and respect her bravery! Something down there was quietly failing tests; thanks to kareila and a tailored tutoring curriculum, it is now an A+ student and headed to the Ivy League.

Bug 3200: remove Section 9 from package LJ in User.pm
Category: Modernization
Patch by: kareila
Description: Stuff in the backend that could be done in different, better ways has been updated to do it in those different, better ways.

Bug 3212: Memcache clear tool
Category: Site Administration
Patch by: exor674
Description: This adds a tool for site administrators to be able to clear the memcache, which is occasionally a useful thing to do.

Bug 3218: LJ::Event::XPostSuccess->new has mislabelled variables
Category: Misc Backend
Patch by: kareila
Description: There were things labelled wrongly in the code. And mixing up your variables is a very bad thing.

Bug 3161: update @LJ::EVENT_TYPES to include all events
Category: Inbox/Notifications
Patch by: kareila
Description: A list of events for dev work did not actually have all of the events. And now it does!

Bug 3207: Tranquility III: 4 new themes by dancing_serpent & rising
Category: Style System
Patch by: ninetydegrees
Themes by: dancing_serpent and rising
Description: Themes! Four shiny new themes for Tranquility III for your delectation.

As ever, these will not be live until the next code push; if you want to know when everything goes up, you'll want to watch dw_maintenance.

Comments

[truelove]

Heh. You're welcome!

(I originally had thought stuff wasn't actually compiling at all? Pretty much your and fu's comments might as well have been in the language of the Elder Gods for that I deciphered out of them. omg, eldritch depths. You've my fear and respect, brave adventurer! *g*)