dw_dev | Code tour, 2010 September 15 to 2010 September 21

A code tour! Oh boy! 13 bugs this week, including eight new themes. Most of these are waiting on the next code push, but a few of them (like site text changes) are live now. This week we have patches from

kareila,

allen,

denise,

liv,

fu,

ninetydegrees, and

sarken. Thank you very much to all the contributors, patch and otherwise.

Bugs and other patches:

Bug 3016: Paginate sysban query results
Category: Site Administration, antispam, ToS, reducing site load
Patch by:

kareila
Suggested by:

azurelunatic and the entire antispam team
Description: There are approximately 4,294,967,296 (give or take a few billion) IP addresses that have spammed Dreamwidth over the course of its operation. It can take about ten minutes to load the page listing all the spamming IPs ever, and that's on a good connection with a fast computer. Breaking it down into pages makes things better for Dreamwidth (not having to serve up such a horrible page) and better for anyone who needs to use that page, say, to check on a spammer, or to change something.

Bug 943: crossposter edits set security to equal
Category: Crossposter
Patch by:

allen
Description: Scenario: your Dreamwidth account is public, but for whatever reason, you've set the default minimum security on your LiveJournal account to friends-only, and you're crossposting there. Then you realize you've made a typo. You edit your entry on the Dreamwidth account. The Dreamwidth entry is public. The LiveJournal mirror is edited too -- and suddenly it's public as well! If you didn't intend to edit the security, this is not good. After some discussion of the technical limitations,

allen and the crew decided that the least horrible way to handle it would be to allow you to set a minimum security on the crossposter -- so no matter what security the entry is on Dreamwidth's end, it's at least the minimum on the external site's end.
Sometimes if you fix one annoyance, another one pops up. This is yet another place where the computer ought to read your mind but somehow can't quite manage to. If you crosspost and have a minimum security set on an external site, think about your use of it -- if you mostly want to keep things locked but do find a lot of typos after you've posted, you'll probably want to set a minimum security on the crossposter. If you are going to be editing a lot of entries for the purpose of unlocking them on the other site, you'll probably want to leave things just as they are.

Bug 2955: Kill off Writer's Block
Category: Misc UI/Frontend, we're not LJ
Patch by:

denise
Description: We're not using the Writer's Block module, we don't plan to use it, and out it goes!

Bug 513: cleaning up userpics code
Category: Modernization, userpics, another

karzilla special
Patch by:

kareila
Description: Old code is old. New code is new.

kareila went into

karzilla mode and refactored the bejeezus out of that userpics code.

Bug 3070: Fix Core1 for backwards compatibility with layouts from LJ
Category: Style System, we're not LJ (but a lot of our users used to live there)
Patch by:

liv
Description: LJ changed some of the back end on their styles stuff. Dreamwidth keeps "Core 1" around, for the convenience of people who have old LJ styles and want to try and keep them. This change broke stuff when people were trying to import their styles. Since the fix was quick and easy (quicker and easier than helping people unbreak their styles), we updated to maintain that much compatibility.

denise remarked: "We should fix this one, since it's easy enough, but we'll have to take future options on a case by case basis."

Bug 2986: Styles: set base font size to 1em in styles and themes
Category: Style System, making things make sense, general readability
Patch by:

ninetydegrees
Description: This fusses about with the font sizing in Drifting to make things work better going forward. If your font size changes suddenly after the next code push and you have a Drifting theme, go back in and poke about at the font sizing options.

Bug 3004: Sunday Morning: hardcoded color for entry/comment action text
Category: Style System, making things make sense
Patch by:

ninetydegrees
Description: Cleaning up some hardcoded color that really didn't need to be in a style.

Bug 3051: fix t/parsefeed-atom-link2.t
Category: Misc Backend, syndication (inbound), another

karzilla special
Patch by:

kareila
Description: This fixes some tests (and refactors code) for some syndication back-end.

Bug 3075: Template Toolkit Plugin needs a js filter
Category: Routing/TT, enrolling Bobby Tables
Patch by:

fu
Description: Sometimes people put javascript in weird places that were never meant to accept javascript. Sometimes this can be bad.

Bug 3054: Context hover menu options do not make sense
Category: Misc UI/Frontend, making things make sense
Patch by:

denise
Noticed by:

cheyinka
Description:

foxfirefey reports: Currently it says "Show the contextual menu when you hover over: Icons" (good), "when you hover over: Userhead" (good), "when you hover over: Both" (good), "when you hover over: Never" (strange). Changed to "nothing" on the site now.

Bug 3074: Rename email text issues
Category: Misc UI/Frontend, making things make sense
Patch by:

fu
Description: There were some things sent out in various email notifications that didn't make as much sense as they could (hardcoded link to Dreamwidth, outdated information about community renames). Fixed.