dw_dev | Code tour, Aug 10

It is a code tour! You know the drill &c.

19 bugs and one theme this time. Biggest thing: renames.

None of these are live yet, so stay tuned to

dw_maintenance for code push updates.

Bug 2952: syn_merge console command should prevent merging a feed to itself
Category: Site Administration
Patch by:

fu
Description: Preventing infinite loops is always a good thing. This fix prevents one from occurring while doing synfeed cleanup.

Bug 2855: Remove references to AdLayout.pm
Category: Code cleanup
Patch by:

ninetydegrees
Description: This gets rid of references to style ad placement modules left over from LiveJournal's code.

Bug 2946: white-on-white text in NNWM2009 theme for Blanket layout
Category: Style System
Patch by:

ninetydegrees
Description: Style fix! This makes the Quick Reply text in the affected theme not be white-on-white so you can see the comment you're typing out.

Bug 2947: Blanket: entry text color not being applied
Category: Style System
Patch by:

ninetydegrees
Description: Minor style fix where entry text wasn't using the proper color in a particular theme.

Bug 216: Implement renames
Category: Major functionality
Patch by:

fu
Description: This is a big deal! As of the next code push, Dreamwidth will allow users to buy rename tokens so they can change their usernames.

Bug 2690: replace ljmood.pl with DW::Mood.pm
Category: Modernization
Patch by:

kareila
Description: This is mostly just changing namespaces (eliminating instances of "LJ" in the code and changing them to "DW") with a bit of refactoring the code for efficiency and also a few bug fixes.

Bug 2891: remove LJ::add_friend and LJ::remove_friend
Category: Modernization
Patch by:

kareila
Description: Since the WTF split means Dreamwidth has watching and access instead of simply friending, this removes some unneeded remnants of the friending system.

Bug 2793: Cleaning: make all layout.pm files look the same
Category: Style System
Patch by:

ninetydegrees
Description: Cleanup to make our code look pretty. Formatting stuffs.

Bug 2794: Brittle: implement two-columns-left layout
Category: Style System
Patch by:

ninetydegrees
Description: This adds additional customization options to Brittle.

Bug 2803: entries in Brittle layout force square userpics
Category: Style System
Patch by:

ninetydegrees
Description: This fixes a display issue for icons in Brittle.

Bug 2846: Customize: make 'Choose a Page Setup' available in Customize Style
Category: S2 Backend
Patch by:

ninetydegrees
Description: An interface change, this lets you change page setup (for example, choosing how many columns you want) from the Customize Style page as well (right now, it's on Select Journal Style).

Bug 2899: Make the names of post security levels consistent
Category: English-Stripping
Patch by:

ninetydegrees
Description: Here, some text that is hard-coded into the site has been turned into a variable, so that Site Copy can make changes to it all in one place (if needed).

Bug 2939: Funky Circles: correct some color settings not being applied
Category: Style System
Patch by:

ninetydegrees
Description: Just like the title says, it's a fix for some colors in Funky Circles not being correctly applied.

Bug 2842: If a user has opted out of PMs, remove "send message" from the hover menu
Category: Inbox/Notifications
Patch by:

yvi
Description: Another self-explanatory one, this is a bit of a logic fix for the hover menu.

Bug 2959: openids cannot select icons in ?mode=reply
Category: Journal contents
Patch by:

fu
Description: In the full Leave a Comment mode for entries (i.e. not QuickReply), openID users couldn't pick an icon. This fixes that.

Bug 2960: /latest displays <ol> and <ul> strangely
Category: Journal contents
Patch by:

fu
Description: In some siteschemes, the latest post page had problems with list tags. Fixed here.

Bug 2965: Tropospherical flashes of background color may be painful
Category: Accessibility
Patch by:

fu
Description: See the bug's description for more info about this one. Sometimes when a page took a while to render, the screen would flash a background color brightly, and this can cause issues for some people. Changing the default background color to something more muted fixes that.

Bug 2968: Warnings in logs from latest moods, when there aren't enough moods to fill the latest moods array
Category: Misc Backend
Patch by:

fu
Description: Mostly a backend thing, for the new Latest Moods tool, this prevents errors in logs in certain circumstances where the latest mood page doesn't have enough data.

Bug 2973: unknown string ".cluster.unknown" on /misc/whereami when clusters aren't set up on the installation
Category: Routing/TT
Patch by:

fu
Description: On installations that have no clusters (that would be very small sites with limited servers), a translation string on the "Which cluster am I on" page got lost (because of relative vs. absolute naming); this re-finds it.

Theme:
Bug 2073: Theme: Grey Days (Transmogrified)
Category: Style System
Theme by:

asenathwaite
Patch by:

dancing_serpent
Preview by:

ninetydegrees
Description: A gray theme for Transmogrified.