![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
Entry tags:
Code tour, 2010 July 23 to 2010 August 10
Hi. Been a while since the last code tour, so I'll skip the intro and dive right in. All of those should be live.
31 bugs, with patches by cpm (first patch), denise, exor674, fu, janinedog, kareila, mark, 900degrees (in alphabetical order)
Bug 2940: some users can't make payments
Category: Payments
Patch by:![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
fu
Description: Users who never had a paid account couldn't buy paid time. (And if you're thinking of egging chickens just because azurelunatic isn't writing this code tour, think again.)
Bug 1960: Long tags get truncated silently
Category: Tags, avoiding duplicates
Patch by:cpm
Description: This doesn't actually warn when a tag is truncated, despite the name. (That's a currently unassigned bug (hint hint).) Instead, it just trim trailing spaces after truncation, so if you had a "this is a very long tag" tag and add one "this is a very long tag made even longer but truncated just before made", you won't get both "this is a very long tag" and "this is a very long tag " in your tag list.
Bug 2926: entry preview doesn't have CSS for hiding "invisible" text
Category: Journal contents, S2 previews, <span style="display: none">fnord</span>
Patch by:kareila
Description: S2 entry previews used to show some text meant to be hidden. Now they don't.
Bug 165: Organize configs so that we can change them
Category: Site configuration, making developers' lives easier
Patch by:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
mark and janinedog
Description: This makes it easier to configure sites and share parts of configurations while keeping those parts that should be site-specific or hidden or remain that way across code upgrades. It's actually been live a loooong time, but the bug never got closed until now.
Bug 2802: Switch TheSchwartz-Worker-SendEmail to SixApart repo
Category: Notification emails
Patch by:mark
Description: A change LiveJournal made to software we share with them broke email because it depends on a change elsewhere we decided not to carry over for now. So instead, we're using the Six Apart version.
Bug 1930: Tropospherical cuts off large page elements without a scroll bar
Category: Misc UI/Frontend, not hiding part of large images.
Patch by:fu
Description: Per zarhooie: When viewing a large image, Tropo Red/Purple crops the image and don't provide a scroll bar so that the whole image can be seen. This is bad because the image is then unviewable and it also sucks for accessibility.
Bug 2747: Use external stylesheets by default for official styles
Category: Style System, making pages load faster
Patch by:fu
Description: This makes official styles share stylesheets instead of repeated them for each page sent to your browser. Thus, your browser no longer has to reload something that didn't change each time you refresh your reading page.
Bug 2924: sitefeeds style stylesheet not being applied
Category: S2 Backend
Patch by:fu
Description: This makes the journals for syndicated feeds display as intended.
Bug 2930: Switch around featured -- once more, with feeling
Category: Style System
Patch by:fu
Description: New featured/highlighted styles.
Bug 135: Gift certificate/credits system
Category: Dreamwidth points, shop
Patch by:mark
Description: This is another set of patches that's been live for a while, but no one remembered to close the bug.
Bug 2811: Upgrade Bugzilla from 3.6rc1 to latest stable
Category: Bug and feature tracking, things pauamma finds *bleep*ing annoying.
Patch by:mark
Description: When you made certain changes to a Bugzilla ticket (Bugzilla is what Dreamwidth to track bug reports, accepted suggestions, and more generally everything someone has to do to make the site better or just keep it running), you would get a blank status page, just as you would if a network or server problem kept your changes from getting through.
Bug 2912: Comments look odd in several styles
Category: Style System
Patch by:ninetydegrees
Description: This fixes display of collapsed comments in some styles.
Bug 2902: Add privacy warning to faq about forwarding email from your username@dreamwidth.org address
Category: User documentation, email addresses, privacy
Patch by:denise
Description: This doesn't actually change what the site does, it just adds a warning in a Dreamwidth FAQ for actions by email providers that may result in inadvertent breaches of privacy.
Bug 2122: tags miscounted for (old?) entries which specified custom security but selected no groups
Category: Tags
Patch by:kareila
Description: In some cases, tag counts might not match the actual number of entries with that tag. (That had been fixed some time ago for new entries, but problems remained for alread--posted entries in some cases.)
Bug 2656: finish migrating LJ::journal_base to $u->journal_base
Category: Modernization, moving code where it belongs
Patch by:kareila
Description: Dreamwidth code, meet the 21st century.
Bug 2657: migrate LJ::set_userprop to $u->set_prop
Category: Modernization, moving code where it belongs
Patch by:kareila
Description: Again
Bug 2674: category headers on manage/subscriptions/* no printed
Category: Notifications
Patch by:kareila
Description: Some notification category names weren't displayed properly (or at all) on subscription management pages. Now they are.
Bug 2754: refactor icon browser and related code
Category: Modernization, moving code where it belongs
Patch by:kareila
Description: More code being introduced to the 21st century.
Bug 2760: migrate LJ::update_user to $u->update_self
Category: Modernization, moving code where it belongs
Patch by:kareila
Description: Does she ever get tired of looking at old code?
Bug 2809: fix t/esn.t
Category: Notifications, tasty testy goodness
Patch by:kareila
Description: OK, she does, when she gets testy. (That is, when she makes automated tests work again. These are useful to prevent repeating the mistakes another developer made in the past.)
Bug 2810: fix t/esn-journalnewentry.t
Category: Notifications, tasty testy brainfood
Patch by:kareila
Description: More kareilaa testiness.
Bug 2844: fix ljconfig2db.pl
Category: Site admin, code documentation
Patch by:kareila
Description: Fixes one of the documentation tools we inherited from LiveJournal, which got inadvertently broken while cleaning out old site schemes.
Bug 2301: remove unnecessary privs
Category: Site Administration
Patch by:mark
Description: Privs are privileged access some users get to restricted functions, like modifying FAQs or site copy, checking users payment history, etc. A number of these restricted functions don't exist on Dreamwidth, but the corresponding privs still lingered in the database. This got rid of them.
Bug 2837: Redirect /tos to /legal/tos
Category: Usability, site documentation, DWIM
Patch by:ninetydegrees
Description: Some users expected (not unreasonably) that http://www.dreamwidth.org/tos would take them to Dreamwidth's Terms of Service. Now it does.
Bug 2841: Make /help redirect to /support
Category: Usability, site support, DWIM
Patch by:ninetydegrees
Description: Same as above, but for http://www.dreamwidth.org/help (and http://www.dreamwidth.org/help/) and the Dreamwidth support area
Bug 2845: Retitle "Reading" link for communities
Category: Communities, site documentation, eschewing obfuscation
Patch by:ninetydegrees
Description: Communities don't have reading lists, they have members lists.
Bug 2853: link "user icons" page from "manage userpics" page
Category: Icons, usability, site navigation
Patch by:ninetydegrees
Description: This adds a link to the "show all icons" page from the "manage your icons" page.
Bug 2888: Timestamp collapsed comments on journal styled pages
Category: Usability, journal contents, style system
Patch by:ninetydegrees
Description: When viewing an entry that has collapsed comments, the comment timestamps wouldn't be displayed in some cases. Now they're always displayed.
Bug 2919: When captcha is disabled for a page, the form cannot be submitted.
Category: CAPTCHAs, pest control
Patch by:fu
Description: CAPTCHAs are those "type the words you see/hear" things that are displayed on some pages to limit access by spambots and other pests. When disabled (not displayed) on a page, the user can't type anything, so the servers shouldn't reject the form because the field is absent.
Bug 2918: Mood of service toy json should not include nulls
Category: Latest feeds, aggregated data, user moods
Patch by:exor674
Description: In some cases, the "mood of service" toy would return incorrect data. Now it doesn't.
Bug 2941: Remove JournalFen as an import option or work around verification hang
Category: Importer, bypassing import problems
Patch by:exor674
Description: Some errors talking to external sites would cause the importer to stop working. Now it just abandons the attempt, just as it does for other unrecoverable errors.
There are no new themes in this code tour. There's also a security-related bug, but we're not discussing it, to give other sites time to update their code.
31 bugs, with patches by cpm (first patch), denise, exor674, fu, janinedog, kareila, mark, 900degrees (in alphabetical order)
Bug 2940: some users can't make payments
Category: Payments
Patch by:
fuDescription: Users who never had a paid account couldn't buy paid time. (And if you're thinking of egging chickens just because azurelunatic isn't writing this code tour, think again.)
Bug 1960: Long tags get truncated silently
Category: Tags, avoiding duplicates
Patch by:
cpmDescription: This doesn't actually warn when a tag is truncated, despite the name. (That's a currently unassigned bug (hint hint).) Instead, it just trim trailing spaces after truncation, so if you had a "this is a very long tag" tag and add one "this is a very long tag made even longer but truncated just before made", you won't get both "this is a very long tag" and "this is a very long tag " in your tag list.
Bug 2926: entry preview doesn't have CSS for hiding "invisible" text
Category: Journal contents, S2 previews, <span style="display: none">fnord</span>
Patch by:
kareilaDescription: S2 entry previews used to show some text meant to be hidden. Now they don't.
Bug 165: Organize configs so that we can change them
Category: Site configuration, making developers' lives easier
Patch by:
mark and janinedog Description: This makes it easier to configure sites and share parts of configurations while keeping those parts that should be site-specific or hidden or remain that way across code upgrades. It's actually been live a loooong time, but the bug never got closed until now.
Bug 2802: Switch TheSchwartz-Worker-SendEmail to SixApart repo
Category: Notification emails
Patch by:
markDescription: A change LiveJournal made to software we share with them broke email because it depends on a change elsewhere we decided not to carry over for now. So instead, we're using the Six Apart version.
Bug 1930: Tropospherical cuts off large page elements without a scroll bar
Category: Misc UI/Frontend, not hiding part of large images.
Patch by:
fuDescription: Per zarhooie: When viewing a large image, Tropo Red/Purple crops the image and don't provide a scroll bar so that the whole image can be seen. This is bad because the image is then unviewable and it also sucks for accessibility.
Bug 2747: Use external stylesheets by default for official styles
Category: Style System, making pages load faster
Patch by:
fuDescription: This makes official styles share stylesheets instead of repeated them for each page sent to your browser. Thus, your browser no longer has to reload something that didn't change each time you refresh your reading page.
Bug 2924: sitefeeds style stylesheet not being applied
Category: S2 Backend
Patch by:
fuDescription: This makes the journals for syndicated feeds display as intended.
Bug 2930: Switch around featured -- once more, with feeling
Category: Style System
Patch by:
fuDescription: New featured/highlighted styles.
Bug 135: Gift certificate/credits system
Category: Dreamwidth points, shop
Patch by:
markDescription: This is another set of patches that's been live for a while, but no one remembered to close the bug.
Bug 2811: Upgrade Bugzilla from 3.6rc1 to latest stable
Category: Bug and feature tracking, things pauamma finds *bleep*ing annoying.
Patch by:
markDescription: When you made certain changes to a Bugzilla ticket (Bugzilla is what Dreamwidth to track bug reports, accepted suggestions, and more generally everything someone has to do to make the site better or just keep it running), you would get a blank status page, just as you would if a network or server problem kept your changes from getting through.
Bug 2912: Comments look odd in several styles
Category: Style System
Patch by:
ninetydegreesDescription: This fixes display of collapsed comments in some styles.
Bug 2902: Add privacy warning to faq about forwarding email from your username@dreamwidth.org address
Category: User documentation, email addresses, privacy
Patch by:
deniseDescription: This doesn't actually change what the site does, it just adds a warning in a Dreamwidth FAQ for actions by email providers that may result in inadvertent breaches of privacy.
Bug 2122: tags miscounted for (old?) entries which specified custom security but selected no groups
Category: Tags
Patch by:
kareilaDescription: In some cases, tag counts might not match the actual number of entries with that tag. (That had been fixed some time ago for new entries, but problems remained for alread--posted entries in some cases.)
Bug 2656: finish migrating LJ::journal_base to $u->journal_base
Category: Modernization, moving code where it belongs
Patch by:
kareilaDescription: Dreamwidth code, meet the 21st century.
Bug 2657: migrate LJ::set_userprop to $u->set_prop
Category: Modernization, moving code where it belongs
Patch by:
kareilaDescription: Again
Bug 2674: category headers on manage/subscriptions/* no printed
Category: Notifications
Patch by:
kareilaDescription: Some notification category names weren't displayed properly (or at all) on subscription management pages. Now they are.
Bug 2754: refactor icon browser and related code
Category: Modernization, moving code where it belongs
Patch by:
kareilaDescription: More code being introduced to the 21st century.
Bug 2760: migrate LJ::update_user to $u->update_self
Category: Modernization, moving code where it belongs
Patch by:
kareilaDescription: Does she ever get tired of looking at old code?
Bug 2809: fix t/esn.t
Category: Notifications, tasty testy goodness
Patch by:
kareilaDescription: OK, she does, when she gets testy. (That is, when she makes automated tests work again. These are useful to prevent repeating the mistakes another developer made in the past.)
Bug 2810: fix t/esn-journalnewentry.t
Category: Notifications, tasty testy brainfood
Patch by:
kareilaDescription: More kareilaa testiness.
Bug 2844: fix ljconfig2db.pl
Category: Site admin, code documentation
Patch by:
kareilaDescription: Fixes one of the documentation tools we inherited from LiveJournal, which got inadvertently broken while cleaning out old site schemes.
Bug 2301: remove unnecessary privs
Category: Site Administration
Patch by:
markDescription: Privs are privileged access some users get to restricted functions, like modifying FAQs or site copy, checking users payment history, etc. A number of these restricted functions don't exist on Dreamwidth, but the corresponding privs still lingered in the database. This got rid of them.
Bug 2837: Redirect /tos to /legal/tos
Category: Usability, site documentation, DWIM
Patch by:
ninetydegreesDescription: Some users expected (not unreasonably) that http://www.dreamwidth.org/tos would take them to Dreamwidth's Terms of Service. Now it does.
Bug 2841: Make /help redirect to /support
Category: Usability, site support, DWIM
Patch by:
ninetydegreesDescription: Same as above, but for http://www.dreamwidth.org/help (and http://www.dreamwidth.org/help/) and the Dreamwidth support area
Bug 2845: Retitle "Reading" link for communities
Category: Communities, site documentation, eschewing obfuscation
Patch by:
ninetydegreesDescription: Communities don't have reading lists, they have members lists.
Bug 2853: link "user icons" page from "manage userpics" page
Category: Icons, usability, site navigation
Patch by:
ninetydegreesDescription: This adds a link to the "show all icons" page from the "manage your icons" page.
Bug 2888: Timestamp collapsed comments on journal styled pages
Category: Usability, journal contents, style system
Patch by:
ninetydegreesDescription: When viewing an entry that has collapsed comments, the comment timestamps wouldn't be displayed in some cases. Now they're always displayed.
Bug 2919: When captcha is disabled for a page, the form cannot be submitted.
Category: CAPTCHAs, pest control
Patch by:
fuDescription: CAPTCHAs are those "type the words you see/hear" things that are displayed on some pages to limit access by spambots and other pests. When disabled (not displayed) on a page, the user can't type anything, so the servers shouldn't reject the form because the field is absent.
Bug 2918: Mood of service toy json should not include nulls
Category: Latest feeds, aggregated data, user moods
Patch by:
exor674Description: In some cases, the "mood of service" toy would return incorrect data. Now it doesn't.
Bug 2941: Remove JournalFen as an import option or work around verification hang
Category: Importer, bypassing import problems
Patch by:
exor674Description: Some errors talking to external sites would cause the importer to stop working. Now it just abandons the attempt, just as it does for other unrecoverable errors.
There are no new themes in this code tour. There's also a security-related bug, but we're not discussing it, to give other sites time to update their code.
no subject
no subject
Not as long as there is still old code to look at! :D
no subject
One thing - for bug 2902, you linked to the wrong FAQ :) The one that got changed is this one (How does my Dreamwidth forwarding email address work?).
no subject
no subject
no subject