Entry tags:
Code tour: June 29, 2010 - July 06, 2010
This code tour is brought to you by me being bored in my lunch hour, and ![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
azurelunatic Twittering that Bejeweled was more fun than writing the code tour. Thanks to fu for writing the second half.
This week contains lots of code cleanup, which will enable us to do more cool stuff in the future, as well as helping new developers when they join us. There are 27 feature-and-bugfix bugs resolved this week, and 3 documentation bugs.
Stuff in this code tour won't be live until the next code push. See![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_maintenance for advance notice of scheduling, and @dreamwidth for up-to-the-minute information if stuff has gotten all weird.
And onward to the actual tour!
Bug 1813: Official styles should support placing icon right or left on entries and comments
Category: Style System, Making things awesome
Patch by:ninetydegrees
Description: Some styles had an option so you could choose which side the user icons showed. People liked it. We added it to more styles.
Bug 2289: Move /interface/s2 into DW::Routing
Category: APIs (RPC, XML, Flat), Code Cleanup
Patch by:fu
Description: This is part of the ongoing project to turn all our code from BML (old and bad) to TT (new and good). I don't really understand it, but it will make it easier for us to do shiny things in the future.
Bug 2580: Smarter Tag Tracking
Category: Inbox/Notifications, Usability
Patch by:fu
Description: If you hit the "Track" button while looking at an entry, and you tick tag tracking, you probably want to track one of the tags on that entry. This puts those at the top of the list, and then everything else below, rather than just giving you a huge list of all the person's tags.
Bug 2747: Use external stylesheets by default for official styles
Category: Style System, Making things faster
Patch by:fu
Description: This will make styles load faster, which is useful for people on slow connections.
Bug 2751: When using 24-hour time, viewer sees the literal text 'short_24' in core1 styles
Category: Style System, Backwards compatibility
Patch by:fu
Description: The new feature to let you choose whether you want 12-hour time or 24-hour time wasn't displaying properly on old customised styles. Now it will work.
Bug 2755: Margins/padding placed on .comment-title are duplicated
Category: Style System, Code Cleanup
Patch by:fu
Description: Development-server only issue. (We caught it early). Some of the CSS was doing the same thing twice, which could cause the comment titles to be misaligned. Now they don't.
Bug 2667: With save password off, xposter does not chal/resp the password on edit, only update
Category: Crossposter
Patch by: Allen Petersen
Description: If you chose the option to type in your password every time for the crossposter, rather than saving it, and then you edit a crossposted entry, it wasn't handling the password properly the second time. Now it will be both secure and usable all the time.
Bug 2702: cut expander and video placeholders don't interact well
Category: Misc UI/Frontend
Patch by: Allen Petersen
Description: If you put a video under a cut, and your friend also had video placeholders enabled, just in case people didn't use cuts, bad things happened. Now people can watch or avoid videos as they wish, without it breaking their reading page.
Bug 2456: sponsor a random active free community
Category: Site Administration, Shameless money-grubbing
Patch by:catness
Description: You can already sponsor a random active free user. Now it will work for communities, too.
Bug 2310: For XMLRPC, clear UTF8 flag from all strings, not just subject and event
Category: APIs (RPC, XML, Flat), Cross-site interoperability
Patch by: Codemerge by![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise and kareila, original patch for LJ by ![[livejournal.com profile]](https://www.dreamwidth.org/img/external/lj-userinfo.gif)
gariev
Description: There are lots of different ways of computers handling accented characters or non-Latin characters in other alphabets. When a client is connecting to the site, it helps if they use the same code as the servers. This patch prevents some potential misunderstandings.
Bug 2545: Remove unneeded djabberd line in multicvs.conf.
Category: Site Administration, Code Cleanup
Patch by:denise
Description: This was a left-over bit of code from LJTalk. We don't use LJTalk, and if we ever implement a DWTalk Jabber thingy, we'll do it in a different way, so this code has been ripped out.
Bug 2680: Document tag management
Category: User documentation
Patch by:denise
Description: We added a lot of new features, like tag merging and renaming. This is the FAQ for them.
Bug 2707: Create FAQ about "work as account option"
Category: User documentation
Patch by:denise
Description: There is a new FAQ, about managing communities using this option box.
Bug 2710: Need a FAQ about user icon descriptions
Category: User documentation, Accessibility
Patch by:denise
Description: There is another new FAQ, about good practice in writing alt text for your icons, so that it's helpful for users with screenreaders.
Bug 2746: Two Themes: Fresh Prose and Purple Haze (Modular)
Category: Style System, New shiny things
Patch by:dancing_serpent, Themes by timeasmymeasure
Description: New styles! Previews:
Bug 2512: ?mode=reply form doesn't have the icon browser
Category: Journal contents
Patch by:cesy
Description: Paid users have a "Browse" button on comments to be able to pick their icon from thumbnails in a pop-up window, but it was only showing up on the quick reply form, not on the usual comment reply form. This makes it show up on all comment forms for paid users.
Bug 1372: Excessive recursion detected and stopped
Category: Style System
Patch by:kareila
Description: There was a catch in the code for when you have a very deeply nested comment thread (more than 50 comments deep) that could cause things to fall over - it would just stop displaying it. Now the limit is increased so that long conversations can be displayed without killing the servers.
Bug 2112: Interest search returns incorrect results
Category: Misc Backend
Patch by:kareila
Description: There was a disparity for the allowed string lengths of interests; this fixes it :)
Bug 2749: AO3 showing up in the crosspost list (dev servers only)
Category: Crossposter
Patch by:kareila
Description: This just affected the dev servers, and hadn't been pushed live onto dreamwidth.org. When we added AO3 to the list of external sites (so that their favicon shows up properly), we had forgotten that this would also make them show up in the list of sites we can crosspost to. Oops! Since we can't actually crosspost to AO3, we took it out, and took steps to make sure that our list of sites we can crosspost to is always correct, even once we add new sites.
Bug 2005: Separate a few colour settings in Boxes and Borders
Category: Style System
Patch by:ninetydegrees
Description: The color settings for the nav module and the calendar used to rely on other settings; this separates them out so that customizing is more flexible.
Bug 2706: function FriendsPage::view_title() doesn't work properly
Category: Style System
Patch by:yvi
Description: There are several ways to filter your reading page: by subscription filter, by security level (if you have a paid account). This makes the current active filter visible in the page title.
Bug 1061: when user gives dropdown+custom moods together, crossposter writes the drop-down mood in the custom field
Category: Crossposter, Fairies in the code
Patch by: Allen Petersen
Description: It looks like we fixed this as part of something else! And only realized it now.
Bug 2383: Crossposting with custom mood does not post correct mood icon
Category: Crossposter, Fairies in the code
Patch by: Allen Petersen
Description: Same as above, it's been fixed all along *g*
Bug 2113: massclose support requests that are awaiting close
Category: Misc UI/Frontend
Patch by: LiveJournal, packaged for Dreamwidth bykareila
Description: This allows admins to quickly close and credit a slew of requests at a time, instead of needing to handle each one individually.
Bug 2739: provide user methods for check_rel usage
Category: Misc Backend, Code cleanup
Patch by:kareila
Description: Adds convenience functions to check whether someone is a moderator, an administrator, is banned, or can post to a journal. Also, now that we've centralized the logic, that's also made it possible for us to make community administrators automatically able to be in charge of the moderation queue. (Previously, community administrators had to also be moderators)
Bug 2740: more aggressive adoption of $u->equals
Category: Misc Backend, Code cleanup
Patch by:kareila
Description: We've been doing a bunch of code cleanup. This standardizes how we check whether two user objects are the same user or not.
Bug 2742: remove unused function LJ::load_log_props2multi
Category: Misc Backend, Code cleanup
Patch by:kareila
Description: According to the comments, this function should be removed once nothing uses it. There's nothing using it, therefore, we have removed it.
Bug 2743: clean up duplicated code for post display
Category: Misc Backend, Code cleanup
Patch by:kareila
Description: More code cleanup. In this case, the logic to display the metadata was duplicated across some five pages. Obviously not optimal. This consolidates all that code into one place.
Bug 1877: Create feed account page should have feed URL on it
Category: Misc UI/Frontend, Fairies in the code
Patch by:nobody
Description: I went to fix this, but it turns out that it had fixed itself in the meantime. I love it when that happens!
Bug 1401: "random userpic" option on comments & posts
Category: Misc UI/Frontend, Things to play with
Patch by:yvi
Description: This is kinda cute: when you post an entry, you'll be able to select a random icon (except for your default) with one click.
Clarification fromsophie: The way that reads to me is that when you use the feature, an icon other than your default will be used, but what really happens is that the "(default)" selection in the listbox is excluded from being chosen - the icon *itself* can still be selected because what it actually does is it selects a random icon keyword.
Bug 2012: use a tag list not a tag cloud on the subscription filter interface
Category: Misc UI/Frontend
Patch by:yvi
Description: This tweaks the display of the tags in the subscription filter interface so that they display as an alphabetically sorted list of tags with the number of uses beside them. Easier to scan the list to find a specific tag now!
Bug 2752: site scheme has empty 'crossposts' field in some cases
Category: Misc UI/Frontend, Calling attention to something that isn't there
Patch by:fu
Description: When an entry was crossposted, but the crosspost links were not chosen to be displayed, the site scheme pages displayed an empty "Crosspost:" label. This bug makes the label only show up if there's something to, you know, label.
azurelunatic Twittering that Bejeweled was more fun than writing the code tour. Thanks to fu for writing the second half.This week contains lots of code cleanup, which will enable us to do more cool stuff in the future, as well as helping new developers when they join us. There are 27 feature-and-bugfix bugs resolved this week, and 3 documentation bugs.
Stuff in this code tour won't be live until the next code push. See
dw_maintenance for advance notice of scheduling, and @dreamwidth for up-to-the-minute information if stuff has gotten all weird.And onward to the actual tour!
Bug 1813: Official styles should support placing icon right or left on entries and comments
Category: Style System, Making things awesome
Patch by:
ninetydegreesDescription: Some styles had an option so you could choose which side the user icons showed. People liked it. We added it to more styles.
Bug 2289: Move /interface/s2 into DW::Routing
Category: APIs (RPC, XML, Flat), Code Cleanup
Patch by:
fuDescription: This is part of the ongoing project to turn all our code from BML (old and bad) to TT (new and good). I don't really understand it, but it will make it easier for us to do shiny things in the future.
Bug 2580: Smarter Tag Tracking
Category: Inbox/Notifications, Usability
Patch by:
fuDescription: If you hit the "Track" button while looking at an entry, and you tick tag tracking, you probably want to track one of the tags on that entry. This puts those at the top of the list, and then everything else below, rather than just giving you a huge list of all the person's tags.
Bug 2747: Use external stylesheets by default for official styles
Category: Style System, Making things faster
Patch by:
fuDescription: This will make styles load faster, which is useful for people on slow connections.
Bug 2751: When using 24-hour time, viewer sees the literal text 'short_24' in core1 styles
Category: Style System, Backwards compatibility
Patch by:
fuDescription: The new feature to let you choose whether you want 12-hour time or 24-hour time wasn't displaying properly on old customised styles. Now it will work.
Bug 2755: Margins/padding placed on .comment-title are duplicated
Category: Style System, Code Cleanup
Patch by:
fuDescription: Development-server only issue. (We caught it early). Some of the CSS was doing the same thing twice, which could cause the comment titles to be misaligned. Now they don't.
Bug 2667: With save password off, xposter does not chal/resp the password on edit, only update
Category: Crossposter
Patch by: Allen Petersen
Description: If you chose the option to type in your password every time for the crossposter, rather than saving it, and then you edit a crossposted entry, it wasn't handling the password properly the second time. Now it will be both secure and usable all the time.
Bug 2702: cut expander and video placeholders don't interact well
Category: Misc UI/Frontend
Patch by: Allen Petersen
Description: If you put a video under a cut, and your friend also had video placeholders enabled, just in case people didn't use cuts, bad things happened. Now people can watch or avoid videos as they wish, without it breaking their reading page.
Bug 2456: sponsor a random active free community
Category: Site Administration, Shameless money-grubbing
Patch by:
catnessDescription: You can already sponsor a random active free user. Now it will work for communities, too.
Bug 2310: For XMLRPC, clear UTF8 flag from all strings, not just subject and event
Category: APIs (RPC, XML, Flat), Cross-site interoperability
Patch by: Codemerge by
denise and kareila, original patch for LJ by garievDescription: There are lots of different ways of computers handling accented characters or non-Latin characters in other alphabets. When a client is connecting to the site, it helps if they use the same code as the servers. This patch prevents some potential misunderstandings.
Bug 2545: Remove unneeded djabberd line in multicvs.conf.
Category: Site Administration, Code Cleanup
Patch by:
deniseDescription: This was a left-over bit of code from LJTalk. We don't use LJTalk, and if we ever implement a DWTalk Jabber thingy, we'll do it in a different way, so this code has been ripped out.
Bug 2680: Document tag management
Category: User documentation
Patch by:
deniseDescription: We added a lot of new features, like tag merging and renaming. This is the FAQ for them.
Bug 2707: Create FAQ about "work as account option"
Category: User documentation
Patch by:
deniseDescription: There is a new FAQ, about managing communities using this option box.
Bug 2710: Need a FAQ about user icon descriptions
Category: User documentation, Accessibility
Patch by:
deniseDescription: There is another new FAQ, about good practice in writing alt text for your icons, so that it's helpful for users with screenreaders.
Bug 2746: Two Themes: Fresh Prose and Purple Haze (Modular)
Category: Style System, New shiny things
Patch by:
dancing_serpent, Themes by timeasmymeasureDescription: New styles! Previews:
Bug 2512: ?mode=reply form doesn't have the icon browser
Category: Journal contents
Patch by:
cesyDescription: Paid users have a "Browse" button on comments to be able to pick their icon from thumbnails in a pop-up window, but it was only showing up on the quick reply form, not on the usual comment reply form. This makes it show up on all comment forms for paid users.
Bug 1372: Excessive recursion detected and stopped
Category: Style System
Patch by:
kareilaDescription: There was a catch in the code for when you have a very deeply nested comment thread (more than 50 comments deep) that could cause things to fall over - it would just stop displaying it. Now the limit is increased so that long conversations can be displayed without killing the servers.
Bug 2112: Interest search returns incorrect results
Category: Misc Backend
Patch by:
kareilaDescription: There was a disparity for the allowed string lengths of interests; this fixes it :)
Bug 2749: AO3 showing up in the crosspost list (dev servers only)
Category: Crossposter
Patch by:
kareilaDescription: This just affected the dev servers, and hadn't been pushed live onto dreamwidth.org. When we added AO3 to the list of external sites (so that their favicon shows up properly), we had forgotten that this would also make them show up in the list of sites we can crosspost to. Oops! Since we can't actually crosspost to AO3, we took it out, and took steps to make sure that our list of sites we can crosspost to is always correct, even once we add new sites.
Bug 2005: Separate a few colour settings in Boxes and Borders
Category: Style System
Patch by:
ninetydegreesDescription: The color settings for the nav module and the calendar used to rely on other settings; this separates them out so that customizing is more flexible.
Bug 2706: function FriendsPage::view_title() doesn't work properly
Category: Style System
Patch by:
yviDescription: There are several ways to filter your reading page: by subscription filter, by security level (if you have a paid account). This makes the current active filter visible in the page title.
Bug 1061: when user gives dropdown+custom moods together, crossposter writes the drop-down mood in the custom field
Category: Crossposter, Fairies in the code
Patch by: Allen Petersen
Description: It looks like we fixed this as part of something else! And only realized it now.
Bug 2383: Crossposting with custom mood does not post correct mood icon
Category: Crossposter, Fairies in the code
Patch by: Allen Petersen
Description: Same as above, it's been fixed all along *g*
Bug 2113: massclose support requests that are awaiting close
Category: Misc UI/Frontend
Patch by: LiveJournal, packaged for Dreamwidth by
kareilaDescription: This allows admins to quickly close and credit a slew of requests at a time, instead of needing to handle each one individually.
Bug 2739: provide user methods for check_rel usage
Category: Misc Backend, Code cleanup
Patch by:
kareilaDescription: Adds convenience functions to check whether someone is a moderator, an administrator, is banned, or can post to a journal. Also, now that we've centralized the logic, that's also made it possible for us to make community administrators automatically able to be in charge of the moderation queue. (Previously, community administrators had to also be moderators)
Bug 2740: more aggressive adoption of $u->equals
Category: Misc Backend, Code cleanup
Patch by:
kareilaDescription: We've been doing a bunch of code cleanup. This standardizes how we check whether two user objects are the same user or not.
Bug 2742: remove unused function LJ::load_log_props2multi
Category: Misc Backend, Code cleanup
Patch by:
kareilaDescription: According to the comments, this function should be removed once nothing uses it. There's nothing using it, therefore, we have removed it.
Bug 2743: clean up duplicated code for post display
Category: Misc Backend, Code cleanup
Patch by:
kareilaDescription: More code cleanup. In this case, the logic to display the metadata was duplicated across some five pages. Obviously not optimal. This consolidates all that code into one place.
Bug 1877: Create feed account page should have feed URL on it
Category: Misc UI/Frontend, Fairies in the code
Patch by:
nobodyDescription: I went to fix this, but it turns out that it had fixed itself in the meantime. I love it when that happens!
Bug 1401: "random userpic" option on comments & posts
Category: Misc UI/Frontend, Things to play with
Patch by:
yviDescription: This is kinda cute: when you post an entry, you'll be able to select a random icon (except for your default) with one click.
Clarification from
sophie: The way that reads to me is that when you use the feature, an icon other than your default will be used, but what really happens is that the "(default)" selection in the listbox is excluded from being chosen - the icon *itself* can still be selected because what it actually does is it selects a random icon keyword.Bug 2012: use a tag list not a tag cloud on the subscription filter interface
Category: Misc UI/Frontend
Patch by:
yviDescription: This tweaks the display of the tags in the subscription filter interface so that they display as an alphabetically sorted list of tags with the number of uses beside them. Easier to scan the list to find a specific tag now!
Bug 2752: site scheme has empty 'crossposts' field in some cases
Category: Misc UI/Frontend, Calling attention to something that isn't there
Patch by:
fuDescription: When an entry was crossposted, but the crosspost links were not chosen to be displayed, the site scheme pages displayed an empty "Crosspost:" label. This bug makes the label only show up if there's something to, you know, label.
no subject