Code Tour: 03/24 to 04/05

[foxfirefey]

Hello, Dreamwidth! Here is our code tour for all the tickets we've made patches for since 03/24.

Bug 971: OpenID icon displays poorly on standout boxes in tropo red
Category: Misc UI/Frontend
Patch by: zarhooie
Description: This is a quick tweak to make the OpenID icon stand out more in Tropospherical Red

Bug 2123: Make styling for the <q> tag consistent across all styles and site schemes
Category: Style System
Patch by: ninetydegrees
Description: The quote tag <q> now styles its contents to be italic in all styles and site schemes.

Bug 2156: Keyword search of icon in the icon popup box does not include Description
Category: Misc UI/Frontend
Patch by: foxfirefey
Description: So paid users have a browse icons interface they can use to select an icon from with visual help, but when you filter it as a search it doesn't search through your description alt text. This changes the Javascript to do that.

Bug 2169: draft saving does not include subject or metadata
Category: Journal contents
Patch by: grimsniffer
Description: This bug was mostly pushed a bit ago, but in the past week since the code push we made a couple bug fix changes to make sure it works with older stored drafts!

Bug 2195: customizable font options & headers
Category: Style System
Patch by: ninetydegrees
Description: This makes more font style and size options, similar to the ones in Modish, available across styles.

Bug 2333: Styles: Calendar or Archive but not both
Category: Style System
Patch by: Juliet Kemp
Description: We're trying to standardize on "Archive" terminology for viewing posts made in the past. This makes the link /archive from a user's journal, and /calendar redirects.

Bug 2335: Styles: redirect /tags to /tag
Category: Tags
Patch by: yvi
Description: This just redirects people who go to /tags to the /tag page, for convenience's sake.

Bug 2344: Default View/Default filters should be default when adding from hover menu
Category: Misc UI/Frontend
Patch by: fu
Description: I want to rub this commit all over myself, it feels that good. It makes sure that when we're subscribing to someone, the default view and access filters are automatically checked or added as appropriate. This will make sure people no longer have sad awkward realizations about why that new person they subscribed to using the hover menu isn't making any posts to their reading page (like meeee).

Bug 2367: One-click tool to delete all inactive subscriptions
Category: Inbox/Notifications
Patch by: yvi
Description: This lets somebody delete all their inactive subscriptions with a single button press, useful if you use a gazillion and run out of space.

Bug 2432: Clean Crossroads layout.s2 to remove superfluous code
Category: Style System
Patch by: ninetydegrees with a quick after-push fix by kareila
Description: Some of our styles code base is kind of messy looking with regards to whitespace. ninetydegrees has been diligently fixing these files.

Bug 2464: Move tools/commentcount to routing
Category: Misc Backend
Patch by: exor674
Description: BML was adding a newline to our commentcount images, which made them not render! This patch makes that image flee the tentacles of the BML system for the warm, cuddly embrace of the new routing system that's going to replace part of it, so that the images work again.

Bug 2466: icon factory not showing preview images
Category: Misc UI/Frontend
Patch by: fu
Description: This was all BML's fault and now the icon factory shows preview images again.

Bug 2467: Border around entry and comment icons in Lynx
Category: Misc UI/Frontend
Patch by: fu
Description: We made all the icons in site schemes link to the user's icon page, but this made them have a link border in the Lynx site scheme, so this patch fixes that.

Bug 2478: The QDB will need a new URL, maybe "qdb.dreamwidth.net"?
Category: Configuration
Patch by: mark
Description: LJ and DW both have IRC cultures! And the people like to preserve funny statements as quotes in a Quote Database, ie QDB. This change makes it so that Dreamwidth's IRC quotes aren't on the zhzh.org page anymore.

Bug 2480: Stepping Stones Chocolate needs different visited link color
Category: Style System
Patch by: ninetydegrees
Description: This makes sure the visited link color isn't the same as the background color for Stepping Stones' Chocolate and Dusky Rose themes.

Bug 2482: fix t/console-community.t
Category: Misc Backend
Patch by: kareila
Description: kareila has been rocking fixing some of our code tests lately. We want to get our tests into better shape--they help us figure out things are wrong before they affect people!

Bug 2483: fix t/talklib-mail-migrate.t
Category: Misc Backend
Patch by: kareila
Description: More test fixing!

Bug 2488: shop mistyping accounts added to cart
Category: Site Administration
Patch by: mark
Description: Accounts that are added to your cart are actually not staff! This fixes the problem and makes sure it's fixed for all the existing carts, too.

Bug 2497: Update featured styles for April 2010
Category: Style System
Patch by: fu
Description: Someday, we will be able to change the feature styles without making a patch and waiting for a code push. Today is not that day.

Bug 135: Gift certificate/credits system
Category: Site Administration
Patch by: mark
Description: This patch gives a new hook for credit card handling and gives the first round of implementing points!

Comments

[libitina]

Bug 2335 - thank you! I get this wrong all the time.

[par_avion]

Description: This just redirects people who go to /tags to the /tag page, for convenience's sake.

Oh thank god. You've made me a happy camper!

[poulpette]

Three cheers for bug 2335 \o/ this will solve one of my biggest silly mistakes. Thanks yvi!

[yvi]

Description: This is a quick tweak to make the OpenID icon stand out more in Tropospherical Red

Quick being relative :)

[I can remember helping Kat with that in summer last year :)]

draft saving does not include subject or metadata

\o/

This patch makes that image flee the tentacles of the BML system for the warm, cuddly embrace of the new routing system that's going to replace part of it

You can try to make it look cute all you want, we know it is also evil :P

[azurelunatic]

BML has tentacles. Of course.

And I actually had a full-on wailing hissyfit when I found out about the little "Default" problem.

[markmanching]

Octopus on BML? speaking of Bug 2478 the new QuoteDB Site says Nothing to see here. this is not moved the new domain yet? calling sophie here..

and another sneaky on dreamwidth.org/portal (as same on LJ) is blank?

[sophie]

Yeah, the QDB isn't on the new domain yet, but it's pointed to the right server. I just need to co-ordinate the move with the person responsible for hosting the LJ side of things. I'll get in touch with them today.

[denise]

We took out the portal, since it was very old and didn't work iin a lot of cases, and have been replacing it with things on the logged-in homepage!

[kareila]

DW removed the portal code and that link should return a 404. I'll open a bug for that; thanks for pointing it out.

[markmanching]

you're welcome denise and kareila for the feedback, and also sophie for the Bug 2478 thing.

*notes to self: planned to create bugzilla account*

PS Yay for the Feedback! \o/

[cesy]

Yay for shiny fixes. I am so happy about the tag/tags one.