This Week In Development: a code tour

[denise]

It's time for another Bugzilla Explained post, since people seemed to like the last one so much! It's been a month since the last one, which is about enough time for me to recover enough to be willing to go through all this effort again.

We had a record-setting week in development: we resolved 102 items this week, with 9 of them being invalid/duplicate/otherwise not needing a patch and 93 of them being bugfixes or new functionality. One bug was a security issue we decline to describe publicly, to give other sites running the LiveJournal code a chance to patch it.

This week, we welcome a record number of new contributors as well, which is another part of why I wanted to highlight all of our changes this week. Thank-you and welcome to alierak, av8rmike, syntheid, brownbetty dreamnestia, hotlevel4, invisionary, kfk2, sixbeforelunch, and ursamajor.

Come with me on a tour ...



Bug 113: Add preview button to faqedit.bml
Category: Administrative tools
Patch By: pauamma
Description: This patch adds a 'preview' for when a FAQ editor is changing the FAQ. (Right now, there isn't one -- you have to just proofread really carefully and then upload, verify, and quickly fix any mistakes.)

Bug 119: fix improper escaping on emailed private messages
Category: Frontend/bugfix
Patch by: kfk2 (New contributor, w00t!)
Description: Chalk up another one on the list of "things that always annoyed us" -- previously, if someone sent you a private message, the site would email you the text of that private message, but do so with extra escaping. That meant you would get things like &amp#39 instead of quote marks, making it hard to read in your email client. This patch fixes that, so now the emailed copy is human-readable.

Bug 155: Allow FAQs to be created without a FAQ category
Category: Administrative Tools
Patch By: pauamma
Description: This is an administrative/usability fix. On LJ, you can't create a FAQ that doesn't have a FAQ category -- you have to make it in a category and then edit it to have no category. This isn't much of a problem on LJ, since most of their FAQs are placed in a category, but on DW, we use FAQs without categories for our Guides. We put in this fix to avoid having to do an extra step.

Bug 258: Properly handle double-escaped userpic comments from data source in importer
Category: Import
Patch By: exor674
Description: If you've imported your userpics from your LJ account to your DW account, you might notice the presence of lots of messy escaped things, like &#39 and < and &gt, instead of the actual characters. This is because the data that we receive from LJ is double-escaped (and sometimes triple-escaped!), turning the characters into their escaped version. This patch fixes that, and allows the data to be served properly.

Bug 307: update LJ::SpellCheck to work in Apache2
Category: Backend Config
Change by: mark
Description: A few weeks ago, we updated the spellchecker to work on the newer version of Apache that Dreamwidth runs under. (Apache is the webserver that does all the work of showing your browser the site's pages.) The patch afuna wrote a few weeks ago got spellcheck working again, but we missed changing a config value on the actual live production site, so spellchecking still wasn't showing up. Mark made the appropriate config changes, and now it works!

Bug 315: When importing already-OpenID comments, indicate what service they were imported from
Category: Import
Patch by: exor674
Description: A while back, Desh raised a concern on the dw-discuss mailing list about importing OpenID comments -- under some circumstances, it would be possible for someone to create a local Dreamwidth install, manually edit the database to create comments attributed to someone else, and then import those comments into Dreamwidth. This is a pretty out-there scenario, but we put in something to guard against it anyway: now, when you import a comment that was made by an OpenID user on the remote site, instead of displaying "username.insanejournal.com", it'll display "username.insanejournal.com (from livejournal.com)".

Bug 330: Importer should bypass ESN, fire no notifications
Category: Import
Patch by: exor674
Description: "ESN" is the internal name for the notification system (it stands for event/subscription/notification -- we picked it up from LJ development and we just can't train ourselves out of calling it that). The importer behaved properly when it came to entries -- it wouldn't send out notifications for people importing entries if someone had subscribed to getting notifications of all entries to a journal -- but it did fire notifications for the "your friend has uploaded a new userpic", which we found out when Mark woke up one morning to find fifty-some "Denise has uploaded a new userpic!" emails. Now it doesn't do that anymore.

Bug 379: English-strip /inbox
Category: Cleanup
Patch by: ursamajor (New contributor, w00t!)
Description: This patch removes hardcoded text from the Inbox page and moves it into the translation system. (*makes ritual gestures of warding*)

Bug 386: list OpenID users in some order
Category: Frontend display
Patch by: afuna
Description: We fixed this a while back, but a subsequent change accidentally reverted it. This patch sorts OpenID users properly on the profile, so it uses the displayed name of the account (the username.somesite.com) instead of the internal/backend name of the account (the ext_NNN value).

Bug 391: Cleanup /manage/settings page
Category: Code cleanup
Patch by: denise
Description: This small backend patch removes references to settings packages that LJ uses but DW doesn't -- things like voice posting and payment history. (We'll have a payment history display, but since LJ's payment system isn't Open Source, we have to write our own.) Nothing user-facing, but it makes things cleaner.

Bug 446: Verify that bad-password checking is implemented & enabled
Category: Security
Patch by: janinedog
Description: The problem of account breakins is critical for any service to handle, and as part of our attempt to minimize the chance of journal hijacking, we require our users to choose strong passwords. This change implements the strong-password checking -- it requires users to select a strong password on account creation, and nags anyone with an insecure password (set before this change) to change it. (A bug with this change was causing everyone to get the your-password's-insecure message; we apologize.)

Bug 448: /directorysearch returns errors
Category: Backend
Patches by: janinedog and afuna
Description: These patches update the search directory to take into account our split of the "friend" function, as well as defining a maximum number of results possible. (It's exactly half of our work to get the search directory working again -- the other half's not done yet.)

Bug 452: lag in profile update when joining/leaving comms
Category: Backend
Patch by: janinedog
Description: In order to improve site performance, we use a program known as "memcached" (for "memory cacheing daemon") that Brad developed for LJ. It saves frequently-accessed information in memory (fast), instead of requiring every request to hit the database (slow). We were experimentally trying a design where community membership was cached for up to half an hour -- which would gain us a considerable performance boost -- but it proved to be too confusing to users in practice, so this patch removes it.

Bug 481: LJ chokes on user tags in our feeds
Category: Interoperability
Patch by: afuna
Description: So, anyone who's been following a feed of a Dreamwidth journal on LJ or IJ or any other LJ-based site has probably noticed that usernames do weird things -- any usage of the <lj user> tag results in output that contains stray escaped HTML. Last week we fixed the root problem for what was causing that on our side; this week, we've changed the HTML in our outgoing feeds so that other sites won't trip the bug.

Bug 493: Need to distinguish between visible/screened comments
Category: Frontend/usability
Patch by: juliet
Description: This patch does two things: 1). Changes the header color of screened comments so that it's more visually distinct (since all of our headers are shades of grey, it was confusing); 2). Fixes a glitch that LJ has, in which both the "screen" and "unscreen" icons had the same alt text, making it impossible for a screenreader user or someone in a text-based browser to tell whether a comment was screened or not.

Bug 494: Branding page
Category: Policy
Patch by: denise
Description: In which I prove once again why I am the Suit! This patch begins our work of documenting our policy; it creates the Using Dreamwidth's Brand page, intended for authors of client programs and owners/operators of sites running Dreamwidth code; it explains under what circumstances someone can use our trademarks and service marks. (I know that that very few of our policy pages that I'm adding are linked anywhere as of yet -- that's part of a wider bug I'm working on.)

Bug 521: Userpics will not import in certain valid cases
Category: Import
Patch by: exor674, based on initial work by ryan
Description: This fixes a bug when someone was trying to import exactly the same number of icons as they have icon slots available. Because the default userpic was imported first, the importer would think that there wasn't enough room -- it was double-counting the default icon.

Bug 526: Use memcache and process cache for mood themes
Category: Backend/codemerge
Patch by: LiveJournal development
Description: This merges in a bugfix from LiveJournal to use memcache information for mood themes.

Bug 531: Slight glitch on /customize/advanced/styles before any data is saved
Category: Frontend bugfix
Patch by: exor674
Description: Fixes a glitch where creating and saving a new style would error in certain (obscure) circumstances.

Bug 537: Tropo CSS in universal style sheets
Category: Frontend/CSS
Patch by: branchandroot
Description: This fixes a few cases where we'd accidentally put styling for our sitescheme Tropospherical Red (which is not Open Source, as it's our default identity) into universal style sheets that can be used by any Dreamwidth-based site. This makes it easier for people to create other site schemes for us, and makes it easier for people running sites based on Dreamwidth code to develop their own default visual identity.

Bug 539: Remove last.fm music detection
Category: Code cleanup
Patch by: pauamma
Description: The last.fm music detection -- the utility that talks to last.fm and pulls what music you're listening to -- was broken on DW, because last.fm requires you to have registered an account with them before they'll let you use their backend interface. Since we're philosophically against putting things into our codebase that requires people running DW code to set up accounts with other services (as much as possible; our human-tests require it, but that's about it), because we were a little hesitant about some of the aspects of last.fm's terms of use, and because last.fm requires you to jump through hoops we'd rather not jump through, we made the decision to remove this feature entirely. We're sorry to see it go, and we'll look for an alternate way of implementing it, but as it stood we couldn't in all good conscience use it.

Bug 540: Tropo: HTML editor text is too small
Category: Frontend/CSS
Patch by: afuna
Description: People using Firefox probably noticed this one: the text on the Update page was being rendered in Flyspeck 6. This patch fixes that for Firefox users, at the cost of making things slightly more large for users of other browsers -- but we decided it was better to go too large than too small.

Bug 542: Inconsistent title/subtitle format
Category: Frontend/Cleanup
Patch by: ysobel
Description: In a bunch of places, pages were being remarkably inconsistent in how they handled window titles vs. the title that appears on the page, and there were some cases where things were double-printing, and in general it was all a sloppy mess. This patch fixes up a bunch of the ones we were able to find, and we'll keep fixing more as we notice them.

Bug 555 Clear up language on /manage/circle/add.bml
Category: Frontend/cleanup
Patch by: ysobel
Description: All of the /manage/circle pages are pretty temporary -- we're going to go through and redesign them with a close eye to usability and making the reading/granting access split really, really clear -- but in the meantime, this patch fixes a bug where the text would read the same ("Modify $user's status in your circle?") even if you didn't already have a relationship with that user. Now, if you're adding someone for the first time, it says "Add $user to your circle?" instead.

Bug 562: Add more meta links
Category: Styles (backend)
Patch by: afuna
Description: This patch adds some more information into the headers of all user-space pages (journal, archive, tags page, etc), to increase our compliance with standards.

Bug 567: Imported tags not properly counted on tag list/tag page
Category: Import
Patch by: afuna
Description: This patch made afuna my favorite person for at least a whole day, because this was annoying the snot out of me. When you imported your journal from another service, the tags would import properly on the entries themselves, but they wouldn't appear on your tag list, in your tag sidebar, or on your tag page until you did some magic voodoo. Afuna tracked down the problem to being styles-related and fixed it.

Bug 569: Add 'beta' to DW logo during beta phase
Category: Frontend
Patch by: denise
Description: In order to make it clearer to people that we're still in beta and that they should expect some small glitches here and there, we decided to add 'beta' to our logo. We'll switch back to the 'regular' DW logo when we decide that we're reasonably mature -- when we move from open beta to "site launch".

Bug 570: Add "last updated" time to profiles
Category: Frontend
Patch by: phoenix
Description: This patch adds basic information about when an account last updated to the profile. It does so in a non-specific fashion -- it will say, for instance, "last updated today", or "last updated today", instead of a specific time someone last updated.

Bug 572: Add profile link back to Read menu
Category: Frontend
Patch by: denise
Description: So, when I did the card sort exercise that helped me design our menu structure -- which I still need to post about -- 'Profile' (as in, your profile) was one of the menu items. As we worked, I realized that I'd like to have an Inbox link in the menus as well as in the quicklinks above the menus themselves, so I replaced Profile with Inbox -- after all, how often do you look at your own profile? (And I thought everyone knew that you could get to your profile by clicking the user-head icon next to your username, also in the quicklinks.) Well, it turns out that a). people do want to view their profile pretty regularly, and b). enough people didn't know that the user-head icon was a link to the profile, so we put it back in.

Bug 573: Re-add contextual popups
Category: Frontend/bugfix
Patch by: janinedog
Description: When we split "friends" into two concepts ("I read you" vs. "I want you to be able to read my locked posts"), it broke the contextual hover menu, which is the little thing that pops up when you mouse over the userhead icon, giving you useful links. This patch fixes that so it'll work again. (You can still turn it off, just like you can on LJ.)

Bug 575: Remove the beta warning from /openid
Category: Frontend
Patch by: syntheid (New contributor, w00t!)
Description: You can see what we removed on LJ's OpenID page -- a warning that OpenID client support is in beta and not fully-featured yet. Well, that notice has been there since the day LJ introduced OpenID support, and we've done a lot of work in cleaning up our OpenID client support, to the point where we felt justified in removing the beta notice. That isn't to say that we're perfect yet, and we'll continue to improve it, but we're pretty comfortable in calling it a version 1.0 by now.

Bug 576: Pass username to /allpics.bml.nopics.text.other2
Category: Frontend/language cleanup
Patch by: dreamnestia (New contributor, w00t!)
Description: The workings of the translation system, which is what governs the text that appears on the site, are strange, arcane, and mysterious. This week we did a lot of cleanup in terms of passing data to the translation system in the proper ways, so the site copy team can make messages and text even clearer. Previously, the message if someone didn't have any icons would be "This user has not uploaded any userpics"; now it's "$username has not uploaded any userpics".

Bug 577: Hard-code hex colour code translation strings in /community/moderate.bml
Category: Frontend/language cleanup
Patch by: brownbetty (New contributor, w00t!)
Description: More translation-system cleanup. In this case, for some strange, arcane, and mysterious reason, the translation strings included the color codes, which they shouldn't -- that should remain in the program file itself. Now it is fixed!

Bug 578: Remove bml from /changepassword.bml.forcechange
Category: Frontend/language cleanup
Patch by: denise
Description: Yet more cleaning up things that shouldn't be in translation strings, but should be in the program files instead.

Bug 579: Remove /syn/index.bml.promo.text
Category: Frontend/language cleanup
Patch by: denise
Description: Even more cleanup of the translation system, in this case removing a translation string that isn't used anymore.

Bug 583: Add Twitter and Delicious fields to the profile
Category: Frontend enhancement
Patch by: denise
Description: This patch allows users to add their Twitter and Delicious usernames to their profiles, and will auto-link to their accounts on those services. We have plans to change things so that you'll be able to easily add any social network to your profile, but until then, Twitter and Delicious are so commonly used that we wanted to get support for them in quickly.

Bug 584: Pass edit profile url to /changeemail.bml.error.lj_domain
Category: Frontend/language cleanup
Patch by: denise
Description: Yet more cleanup of the translation system, allowing something to be linked that wasn't linked before.

Bug 585: Add JF to temporary importer frontend
Category: Frontend enhancement
Patch by: denise
Description: By the time we launch, the journal import feature will have a nice, pretty frontend that explains what it is and how to use it, and it will include a nice, pretty list of all the sites that we've tested and verified. This patch added JournalFen to the list of importable sites, to allow us to test it. (Verdict: it mostly works!)

Bug 588: Adapt Lynx scheme to handle logged in/logged out views
Category: Frontend enhancement
Patch by: denise
Description: The Lynx site scheme, which handles pages if someone has chosen ?format=light as well as being very useful for people who use screenreaders or other assistive technology, previously didn't show any indication whether a user was logged in or logged out, and if logged in, what username was logged in. Now it does! Thanks to rb and the dw-accessibility list for bringing the lack to my attention.

Bug 590: Editing profile page doesn't print out errors
Category: Frontend/bugfix
Patch by: afuna
Description: One of our beta testers ran into this one! If you tried editing your profile and hit an error for any reason, it wouldn't print you the error; it would just show you a blank page. This fixes it to print the error, at least.

Bug 591: Update LICENSE file in dw-free
Category: Code cleanup
Patch by: denise
Description: This patch significantly clarifies the licensing of our software, including the addition of the dual-licensing option (GPL and Artistic) for code we wrote entirely ourselves and updating the copyright information for the files we forked from LJ.

Bug 595: Importer's remap_lj_user regex is incorrectly greedy
Category: Import
Patch by: alierak (New contributor, w00t!)
Description: This fixes a situation where the importer would munch on parts of your entry if you had a <lj-cut> tag with a <lj user> tag afterwards.

Bug 599: Remove ability to flag other people's content as adult
Category: Code cleanup
Patch by: janinedog
Description: You ever have that thing where you're all chugging along, working as a group, and finally, finally someone says, "Hey, did you do that thing?" and everyone looks at everyone else and says "...But I thought you were doing the thing!" Yeah, that's what happened here. We'd always intended to remove the ability for other people to flag your content as needing administrator review, because we thought it was creepy and intrusive. However, thanks to some config setup and some styles stuff, the option itself wasn't displaying, so we all thought we'd already removed it. Oops. janinedog finally went and did the thing.

Bug 600: Comment notifications still use ext_NNN construction
Category: Frontend/cleanup
Patch by: kfk2
Description: This fixes another instance of people being shown the internal username of ext_### for OpenID accounts, instead of the displayed username (username.somesite.com), in comment notification emails.

Bug 601: Missing spaces in cgi/talklib.pl
Category: Codemerge
Patch by: LiveJournal development
Description: This merges in a fix from LJ to add a missing space to what gets displayed to the user when commenting.

Bug 603: openid access to locked posts on certain views
Category: Frontend/bugfix
Patch by: afuna
Description: We figured out that there was an issue with OpenID users being able to see locked posts on any view other than the Recent Entries page (so, on day, month, year, tag, or calendar pages). This fixes it to pass the proper access/authentication information.

Bug 605: Invite code page should refresh with "just sent" code on bottom of list, not top
Category: Frontend/usability
Patch by: afuna
Description: Yeah, so, this one bit me a couple of times this week; I accidentally sent the same invite code to multiple people. Multiple times. (Oops.) The usability glitch in that case was that after you send an invite code, the page returned to your code list with the code you'd just sent as the top option, so it was really easy to just re-send that code if you weren't paying enough attention. This patch fixes that to automatically select the first "good" (ie, unsent) code.

Bug 607: RTE poll creation busted
Category: Frontend/bugfix
Patch by: hotlevel4 (New contributor, w00t!)
Description: The poll creator in the rich text editor was busted; while looking at it, afuna and hotlevel4 realized that the problem was with two required files being called with the wrong URLs. This patch fixes that!

Bug 609: create.bml popups are cut off
Category: Frontend/bugfix
Patch by: juliet
Description: Our new "create an account" workflow -- which is awfully sexy -- has little tooltips on the side of the fields you have to fill out; not actual popups in the sense of "new browser window", but in the sense of "context-sensitive help information". I noticed that they were cut off very weirdly in both Safari and Firefox on my Mac; juliet and janinedog tracked it down to an issue with default font size, after fixing it for the Mac made it horribly broken under Windows. They managed to get it working, though!

Bug 610: More sensible defaults/limits for poll creator
Category: Frontend/usability
Patch by: rho
Description: So, anyone who's made a poll on LJ has probably run into the limits imposed by the automatic poll creator -- 15 questions per poll, 15 items per poll question, that kind of thing -- and had to do complex workarounds. Turns out -- even I had forgotten this -- that those limits are enforced by the poll creator, not by the actual backend code that creates the polls; if you wrote your poll code by hand, you could bypass those limits. This patch makes the limits in the poll creator match up with the limits in the backend code, so as not to artificially limit things.

Bug 614: Communities don't have passwords
Category: Codemerge
Patch by: LiveJournal development
Description: This patch from LJ's code updates the logic for checking passwords in certain circumstances to reflect that communities don't have passwords anymore.

Bug 615: Recent Comments page displays absurd error message
Category: Frontend/bugfix
Patch by: denise
Description: When using the Recent Comments page, Paid, Premium Paid, and Seed Account users would get a rather ridiculous error: "Your account is only permitted to see the latest 100/150 entries, not the full limit of 50." This was put in there to let free accounts know that they could upgrade and see more comments there, but there were two problems: one, we'd upgraded the limits in the account configuration files, but not in the site-wide defaults file, and two, the logic to check whether to print that message only checked whether the account's capability level was equal to the site-wide default, not equal to or greater than. As quirkily charming as the error message was, we fixed it.

Bug 617: 'Account type' link references unrelated FAQ
Category: Frontend/bugfix
Patch by: ysobel
Description: On the Support pages, when you're viewing a specific support request, the top of the page shows a bunch of information about that user's account, and the 'Account Type' header links to a FAQ explaining the different account types. Except the FAQ link was hardcoded using LJ's FAQ numbers, so in actuality, it led to a completely different FAQ. We assumed that volunteers looking at the support board will know what our account types are, so we just removed the link rather than fixing it, so other sites using our code won't run into the same problem.

Bug 619: Negatives sidebar is pushed to the bottom when fonts are too large / window sizes are too small
Category: Frontend/styles
Patch by: av8rmike (New contributor, w00t!)
Description: Negatives, the white-on-black style that's currently showing on most journals, had an issue where the sidebar was being improperly pushed down to beneath the journal contents. Now it doesn't do that!

Bug 622: Negatives header overlaps the navstrip
Category: Frontend/styles
Patch by: afuna
Description: Negatives had an issue where the navstrip (if you had it on) would overlap the top of the style itself. Now it doesn't!

Bug 624: Remove created date from profile for OpenID users
Category: Frontend/usability
Patch by: denise
Description: As people have started using Dreamwidth with their OpenID accounts, more and more people are noticing that the "created" date on their profile doesn't match the date they first logged into the site with OpenID. This is because when someone imports their comments from another site, an OpenID user is created for everyone who commented, so that the original commenter can still have control over that comment. We'll be documenting that, but since it's not immediately obvious to someone that this is the case, we decided instead to just remove the created date for OpenID identity accounts to prevent some of the confusion.

Bug 625: Add confirm email link to navstrip
Category: Frontend/usability
Patch by: rho
Description: If you haven't confirmed your email address (what LJ calls "validating" it), the navstrip will now show you a reminder to do so.

Bug 626: switching users on /update has an LJ image
Category: Frontend/cleanup
Patch by: denise
Description: If you were on update.bml while logged out, or hit the "work as other user" option, the image that would appear was the LJ-pencil-and-swoosh. We switched it to use our Dreamwidth swirly-D no-userpic image instead.

Bug 628 Add links to /openid/
Category: Cleanup
Patch by: denise
Description: This is a small change to pass more information to our translation system, letting the site copy team rewrite the page to include useful links. (I will also note, just in the interests of making fun of myself in front of thousands of people, that on my first attempt at this patch, I had the two links precisely backwards, so that the text for one was linking to the link for the other.)

Bug 629: Add 'track user' to the navstrip
Category: Frontend/usability
Patch by: invisionary (New contributor, w00t!)
Description: This patch adds a "track user" link to the navstrip, making it easier for people who want to receive notifications when someone updates -- previously, when viewing someone's journal, you had to click through to their profile and select the "track" icon, while now you can do it right from the navstrip. This continues our quest to make the navstrip useful and helpful!

Bug 631: Disable directory listing for /img
Category: Backend/cleanup
Patch by: owl
Description: This patch puts a blank index.html file in the images directory, preventing automated spiders from indexing all of our images.

Bug 633: change navstrip link for accounts with whom you have a relationship
Category: Frontend/usability
Patch by: invisionary
Description: And continuing on that theme, this patch changes the link that's shown to you while viewing the journal of someone with whom you already have a relationship. Previously, it would lead to the Manage Circle page (which lets you add and remove people in bulk); now, it links directly to the page which lets you manage your relationship with that particular user.

Bug 634: Quickreply comment box should include Preview button
Category: Frontend/usability
Patch by: allen
Description: And with this, allen earned the title of Everyone's Favorite Person for the weekend. This patch adds the "preview" button directly to the inline comment reply form -- no more having to hit three separate links or buttons just to preview your comment!

Bug 636: Negatives lacks a window title
Category: Frontend/styles
Patch by: av8rmike
Description: Negatives, the currently-default style, didn't have a window title set when viewing any journal page. Now it does.

Bug 637: Negatives defined text for properties should be removed, to fall back to core
Category: Frontend/styles
Patch by: av8rmike
Description: This patch takes some things out of the individual style and moves them to the code that's available to all styles, to improve our cross-style standardization. (Our end goal with all of this is to eventually have all options and behavior common to all styles, so you don't have to make the choice between functionality and aesthetics.)

Bug 639: Standardise show=Y link to show=F
Category: Frontend/usability
Patch by: rho
Description: So, a lot of people don't know that on LJ, you can stick ?show=Y to the end of your friends page URL, and it will only show you syndicated feeds -- it's a filter that's built into the system. (?show=P is for personal accounts, and ?show=C is community accounts, and they stack; you can do ?show=CY for comms & feeds, for instance.) A while back, we aliased ?show=F to ?show=Y; the Y is for 'sYndicated account', since the letter S was already taken. Since Dreamwidth calls those accounts "feed accounts" and not "syndicated accounts" we switched it over to make ?show=F also work; this patch changes it so that any time the system offers you that option, such as /manage/circle/filter.bml and the navstrip, uses ?show=F instead.

Bug 641: Add search box to faq.bml
Category: Frontend/usability
Patch by: rho
Description: Replaces the "click here to search the FAQ" link with an actual search box, thus minimizing the steps a user needs to take to search the FAQ.

Bug 643: IE6 doesn't display inline-block properly (negatives)
Category: Frontend/styles
Patch by: afuna
Description: This changes the Negatives style's code to function better in IE6.

Bug 644: fix html syntax errors for comments in core2
Category Frontend/styles
Patch by: aveleh
Description: This patch cleans up the HTML that our style system outputs, in order to make it more error-free/standards-compliant.

Bug 646: Use $c->print_poster() in Negatives
Category: Frontend/styles
Patch by: aveleh
Description: This is deep voodoo. Really. Then again, I think the entire styles system is deep voodoo, which is part of what the Styles team is trying to fix! This changes the way the Negatives style displays information about who has made a comment, in order to standardize across styles.

Bug 648 This user has no journal; they have an OpenID.
Category: Frontend/display
Patch by: denise
Description: It's hard to get to the URL for an OpenID user's (non-existent) journal; you have to manually construct the URL. But if you do -- for instance, http://ext-1.dreamwidth.org -- it used to give you an unhelpful error message of "This user has no journal." This patch clears that up a little, and displays the user's OpenID URL in a clickable fashion so people can follow it.

Bug 649: summary links in the sidebar do not bring you to the entry (negatives)
Category: Frontend/styles
Patch by: av8rmike
Description: Fixes a problem where the mini-page-summary in the sidebar of the Negatives style didn't bring you to the entry.

Bug 650: Navstrip login box tops out at 17 character username
Category: Cleanup
Patch by: sixbeforelunch
Description: When we updated our username length limit to 25 characters (from LJ's 15), we forgot to change the text input size on the navigation strip's login widget. This patch makes the form accept the right-sized usernames.

Bug 654: Set default core to core2 in config.pl
Category: Backend/configuration
Patch by: exor674
Description: Fixes an issue with the site config files to make them explicitly use the newer version of our style system, instead of assuming it as default. This fixes an issue where people with the undefined config were getting errors.

Bug 655: Prevent errors when tracking using AJAX
Category: Codemerge
Patch by: LiveJournal development
Description: A merge of a LiveJournal bugfix to fix an issue with the Javascript being served.

Bug 657: Ensure title functions are complete in core2
Category: Style system
Patch by: aveleh
Description: Extends the core styles functionality to clean up some shortcomings in how a page has its title set.

Bug 660: Rename module groups in core
Category: Style system
Patch by: aveleh
Description: Changes the names of some of the backend functions in the style system to be more human-readable.

Bug 662: Rename module groups in Negatives
Category: Frontend/styles
Patch by: aveleh
Description: Uses the updated names for those functions in the Negatives style.

Bug 666 don't allow OpenID users to use /manage/circle/invites.bml
Category: Frontend/usability
Patch by: denise
Description: Continues our efforts to tailor what OpenID accounts get shown -- our philosophy is that if an OpenID user can't do something, we shouldn't taunt them with the option. Since OpenID accounts won't ever be able to give out invite codes -- we'll work out some way for them to request invites for themselves down the line, but we'll never be giving them codes to hand out to others -- they don't need this page. This patch also changes the "request more invites when you've used up all of yours" function so it doesn't show to OpenID users, for the same reason.

Bug 667: <ul> showing without bullet points on faq.bml and faqbrowse.bml
Category: Frontend/usability
Patch by: denise
Description: The CSS we're using to strip styling from all HTML tags allows us much better cross-browser compatability. However, it has the nasty side effect of stripping a lot of styling that we'd prefer it not strip. This explicitly adds some of it back in.

Bug 668: remove orphaned strings from community/settings.bml
Category: Cleanup
Patch by: denise
Description: Our poor site copy team has to deal with the fact that all the text they have available to them to look over and update is also populated with a whole bunch of text strings that just aren't referenced anywhere anymore. (This week, mark checked in a fix that would help identify strings that weren't being used, and the number of strings that needed rewriting suddenly dropped like a rock from about 6000 to about 3000. That's how bad it is in there.) This patch removes some of the ones that are explicitly not being used anymore.

Bug 669: remove editinfo.bml.text
Category: Cleanup
Patch by: denise
Description: More cleanup of unused strings.

Bug 670: Add link to official comms FAQ to site map
Category: Frontend/usability
Patch by: rho
Description: Our site map had a few of our official communities on it, but the full list is in the FAQ. This patch adds a link to that FAQ, so people can find all of them if they want.

Bug 674: Enable safe search filtering
Category: Frontend
Patch by: janinedog
Description: This patch makes it possible for people to filter content that the content owner marked 18+ out of search results. (To reassure people who are new to how content flagging works on DW: it's always going to be a user option, with no penalties for using it or failing to use it, but people can use it as a courtesy to others and apply the filters to filter out the majority of the content if they want.)

Bug 676: simple changes to improve site scheme
Category: Frontend/usability
Patch by: nova
Description: This fixes a few minor problems with the default site scheme, Tropospherical Red: it adds some extra spacing, and changes the color of the swirls in the menu to make them more visible when the menu item is selected.

Bug 682: stray 'livejournal' in rte tooltips
Category: Cleanup
Patch by: rho
Description: This patch fixes a few stray instances of 'LiveJournal' hard-coded into the site, specifically in the rich-text editor on the Update page.

Bug 683: string::replace doesn't work with anything not [a-zA-Z0-9]
Category: Styles backend
Patch by: exor674
Description: This changes some of the mysterious backend guts of the style system, making it easier for people who know what they're doing (which isn't me) to make styles do cool and nifty things.

Bug 687: Manual of style conformity for diversity statement
Category: Cleanup
Patch by: rho
Description: This patch makes some changes to the diversity statement to bring it more in line with the manual of style we're using for all site text.

Bug 688: Clean up /openid/approve.bml
Category: Cleanup
Patch by: rho
Description: This patch does some cleanup to remove text strings that aren't being used, clean up the style of some strings that are, and pass the page some more information so it can remove hardcoded instances of "LiveJournal" and replace it automatically with the site name.

Bug 699: Make the can_* edge methods return error messages and add can_leave
Category: Backend
Patch by: janinedog
Description: This is part of the work we needed to do in order to re-enable the contextual hover menu (the little thing that pops up when you mouse over the userhead icon, giving you useful links). Janine needed some extra functions in order to make that work again, so this patch adds them.

Bug 704: Pass sitename to lostinfo.bml.lostpassword.text
Category: Cleanup
Patch by: rho
Description: More work to pass more information to the translation system, allowing our site copy team to write more useful instructions.

Bug 705: Pass username to /edittags.bml.users
Category: Cleanup
Patch by: ysobel
Description: More work to pass more information to the translation system, allowing our site copy team to write more useful instructions.

Comments

[(Anonymous)]

i want to join!!