Code Tour, March 17-23

[ursamajor]

I AM A CODE TOUR - I mean, hi, I'm ursamajor, and I'll be your Code Tour Guide this week! We've got 11 bugs resolved this week, three of which are the results of afuna banging away at the crossposter. \o/

Bug 2325: Subscription by tag not working
Category: Misc UI/Frontend
Patch by: afuna
Description: cadged from denise: If you subscribed to someone, and made a reading filter containing only that person's posts tagged foo, and then they posted an entry with that tag, in some cases that entry wasn't showing up on the filtered read page. Now, it will! // Things I did not know about this before that I do now, Reaction Shot From IRC: ursamajor: oho! ... wait, you can make a reading filter that contains ONLY THAT PERSON'S POSTS TAGGED FOO?! // Yes, you can, though this aspect of reading filters is a paid account feature (not sure if it's regular or premium). Posting over to dwrocks as soon as I post this!

Bug 2235: Celerity displays exampleuser.dreamwidth.org/icons with odd spacing
Category: Misc UI/Frontend
Patch by: afuna
Description: Thanks to our robot overlords, we now have better targeting for whitespace around images - now, only userpics get whitespace, and userheads aren't trying to run away from their usernames any longer.

Bug 2436: In customization wizard, custom theme layers don't show the x-column layout options
Category: Style System
Patch by: afuna
Description: Previously, if you'd created a custom theme layer, you wouldn't be able to switch the number of columns there, even if the layout layer supported it. Now, you can!

Bug 2442: Add some styling for the .comments-message class
Category: Style System
Patch by: afuna, with prep by yvi
Description: Child of Bug 11! Because of what yvi coded for last week's tour, this let afuna add some styling to the comments-message class, to make error or status messages in the comments area feel visually consistent with the rest of that area.

Bug 1859: Change "Recent Entries" title when viewing by tag
Category: Journal Contents
Patch by: hotlevel4
Description: When looking at tag pages in a given journal, the title now says "Entries tagged with [tag1], [tag2], etc" instead of just "Recent Entries." Shiny happymaking!

Bug 2302: 'Review invite history' errors without a user
Category: Site Administration
Patch by: afuna
Description: Make admin/invites/review.bml more user-friendly by adding a form to select a username if one wasn't provided in the address, or if the username was invalid.

Bug 2437: Crosspost enabled by default + no password saved, silently prevents posting to communities
Category: Journal Contents
Patch by: afuna
Description: Crosspost Password Bugfix #1: Skip unnecessary password check for crosspostee site (such as LJ or IJ) when posting to a community. Things I never noticed before: that you couldn't crosspost to a community journal. <disclaimer>My usage of Dreamwidth may not reflect many peoples' usage of Dreamwidth.</disclaimer>

Bug 2438: Unnecessary check for password when crossposting for all accounts is disabled
Category: Crossposter
Patch by: afuna
Description: Crosspost Password Bugfix #2: don't check for a password for a crosspostee site if crossposting is disabled, as it's unnecessary. Love that "spurious" was used in the changelog description. \o/

Bug 2443: X-poster 'remember password' doesn't remember
Category: Crossposter
Patch by: afuna
Description: Crosspost Password Bugfix #3: used to be that passwords weren't getting remembered properly for crossposting if you'd initially entered them at /manage/settings/?cat=othersites; now they are. Hooray, less typing!

Bug 2444: Apostrophes in the translation string prevents the tag deletion confirmation from popping up
Category: Tags
Patch by: afuna
Description: Naughty apostrophes making things complicated; "escape" the translation string so that tags with apostrophes can be deleted properly.

Bug 2452: Point docs.dreamwidth.net to 'hack box
Category: Configuration
Patch by: exor674 did the heavy lifting, with assists by sophie and mark for implementation
Description: Docs gets its own subdomain at http://docs.dreamwidth.net . It's growing up! *emotear*

Comments

[afuna]

Whooo codetour. Thank you ursamajor! (And have fun with the reading filters *G*)

[feathertail]

Wow, you've been busy. ^.^ I hope you've been having fun with it!

[afuna]

Oh I have! *grin* It's pretty fun fixing up things and creating new features from scratch, too!

[cesy]

Yay for 1859. Wasn't that a suggestions one?
Yay for 2437, too. That'll reduce the support requests on it.

[allen]

I think that all three of afuna's crossposter fixes were for bugs introduced by me. :(

[denise]

Bugs in your code are a natural side effect of doing cool shit. Bug-free code means you're not taking enough risks and doing enough awesome things. *nods firmly*

[turlough]

userheads aren't trying to run away from their usernames any longer

*snicker*

[sophie]

Oh, btw, because I just noticed this:

Yes, you can, though this aspect of reading filters is a paid account feature (not sure if it's regular or premium).

All paid accounts, whether regular or premium, get access to exactly the same features. The only difference is the limits. So if such advanced reading filters had any limits on them, premium paid users would get more of these reading filters than regular ones would, but they'd both have the feature.

But there is no limit on this one, so. :D

[baggyeyes]

Description: Child of Bug 11!

You mean they're procreating?

[allchildren]

lol late but omg 2235! That was my support complaint! DREAMWIDTH, SOLVING ALL MY PROBLEMS! Thanks guys. :D