Code tour: February 3, 2010 to February 22

[yvi]

Welcome to this and last weeks code tour. During the last three weeks, 23 bugs were marked as resolved. 6 of these were suggested by users in dw_suggestions, but we also have assorted bugfixed, style adjustments and crazy backend stuff.

These 23 resolved bugs were brought to you by 11 developers: 7 by denise, another 7 by afuna, 2 by exor674, 2 by yvi, 1 by allen, 1 by ninetydegrees, 1 by grimsniffer, 1 by hotlevel4, 1 by mark, 1 by zvi, and 1 by zarhooie

Follow me behind the curtain to see what lies behind...

Bug 1152: Transmogrified, Drifting don't use reading page title correctly
Category: Style System
Patch by: ninetydegrees
Description: Some more style fixes, as two of the styles did not display the title you can set for your reading page. Now they do.

Bug 1746: Ability to opt-out of account creation community promo
Category: Registration
Patch by: afuna
Description: When users create a new account from an invite code, they may be shown communities the person they got invited from is in. Now community moderators will have the option (under the Settings->Privacy tab) to opt out of this.

Bug 2052: Refried Tablet + Themes
Category: Style System
Patch by: zvi and zarhooie
Description: New style! Well, no, actually not. Refried Tablet has been around for a few weeks, but now we could finally close the bug since zarhooie made previews for the themes.

Bug 2069: single IP query for spam sysbans
Category: Misc Backend
Patch by: afuna
Description: Making antispam measures be less annoying - as I understand it, when the antispam team wanted info on one IP they had banned, they had to load the whole page. Until now.

Bug 2120: make filter=0 work on reading pages
Category: Misc UI/Frontend
Patch by: yvi
Description: People who have a "default" or "default view" subscription filter defined had no possibility to see all their subscriptions via the filter=0 option. After the next code push, this should work.

Bug 2151: add parent link to comments in inbox
Category: Inbox/Notifications
Patch by: denise
Description: One from dw_suggestions! When looking at comments in the Inbox, you now also get the handy "Parent comment" link.

Bug 2169: draft saving does not include subject or metadata
Category: Journal contents
Patch by: grimsniffer
Description: And another idea from dw_suggestions. Previously, the draft saving that Dreamwidth does when you start, but don't post an entr onl saved the entry text. Now all the data (text, subject) and the metadata (tags, mood, etc.) gets saved.

Bug 2178: change how links are formatted in comments made by OpenID users
Category: Journal contents
Patch by: denise
Description: A partial migration from dw_suggestions, this will stop links from OpenID commentors being make 'non-clickable' if (and only if) the OpenID user has validated their account and has been given access by the user.

Bug 2222: Ordered and unordered lists not displaying correctly in sitescheme
Category: Misc UI/Frontend
Patch by: afuna
Description: This bug was reported in Support. The siteschemes were not displaying lists correctly. Don't ask me any further :)

Bug 2226: Segmentation Faults on Ubuntu 9.10
Category: Misc UI/Frontend
Patch by: Allen Petersen
Description: One for the devs: DW installations on Ubuntu 9.10 were throwing segmentation faults. That's not so convenient.

Bug 2228: remove legacy scripts from bin/upgrading/
Category: Misc Backend
Patch by: denise
Description: Code cleanup - we were carrying around a few unused scripts.

Bug 2269: Split out relevant portions of DW::Shop::Item::Account into a base DW::Shop::Item
Category: Misc Backend
Patch by: afuna
Description: This is... um, object-orienting some stuff, I think. It's shiny because it makes other things easier!

Bug 2282: Remove Apache2-specificness from DW::Routing and friends
Category: Misc Backend
Patch by: exor674
Description: I DON'T EVEN KNOW! From #dw:

[21:00]	Yvi	is anyone needed for a codetour? i need something to occupy myself with...
[21:01]	rahaeli	ooh, yes!
[21:01]	* rahaeli	gets you a list
[21:02]	rahaeli	http://tinyurl.com/yj54n4t
...
[21:05]	exor674	Yvi: have fun with teh two of mine!
[21:05]	Yvi>	the day I will be able to summarize exor674's patches is far into the future
...
[21:07]	rahaeli	"this does something that will be really cool when it's done, i'm sure."
[21:09]	V_PauAmma_V	"Therse patch give me a headache. I'm sure' that's not what they're for, though."

Bug 2307: remove insecure password reset option
Category: Misc Backend
Patch by: denise
Description: removing legacy code that wasn't in use anymore.

Bug 2308: Missing string for /pubkey error message when PGP isn't configured
Category: English-Stripping
Patch by: afuna
Description: Ouups, wrong string reference.

Bug 2313: DW::Request::Standard
Category: Misc Backend
Patch by: exor674
Description: I like you, Dre, but I will never be able to do your patches justice in a codetour. It's scary stuff that will make other stuff shiny and non-scary.

Bug 2314: Wrong translation string when there's no user to suggest
Category: Invite codes
Patch by: afuna (who forgot to assign herself *tststs*)
Description: The string is called ".suggest.none". The code said ".suggest.done". Ouups and fixed.

Bug 2321: Support Google Checkout
Category: Misc Backend
Patch by: mark
Description: We can has Google Checkout!

Bug 2323: move /translate to /admin/translate
Category: Misc UI/Frontend
Patch by: denise
Description: Moving stuff around behind the scenes so that it makes sense.

Bug 2340: Add "last updated" to Circle Gifts
Category: Site Administration
Patch by: denise
Description: From dw_suggestions, people wanted information when someone had last updated their journal on the Circle Gifts page.

Bug 2346: Add a link to "someone you invited creates an account" subscription to the Invite Someone page
Category: Invite codes
Patch by: denise
Description: And even more from dw_suggestions. Invite Someone now gets a link to the notifications page where you can set the "Someone I invited creates a new journal" notification.

Bug 2368: Allow community moderators to add note when accepting a post
Category: Communities
Patch by: yvi
Description: dw_suggestions again. Know how community moderators can add a little note when they reject a post from the moderation queue? They can do that when accepting a post now, as well. For example for "please add a cut when you can" or "YAY!".

Bug 2402: Change separator for all inbox notifications to | instead of a space
Category: Inbox/Notifications
Patch by: hotlevel4
Description: Does what it says on the tin: Changing the separator in the inbox from " " to "|"

And that was it, see you again really soon. Don't forget to cheer on your developers ;)

Comments

[zarhooie]

This was my first Review+ thing! WHOO.

[ninetydegrees]

(Psst! Two typos in #2052; now → news; previes → previews)

\o/ for #2368 and #2340. Thank you, Yvi! Thank you, Denise!

[azurelunatic]

That's exactly what it's for, on the antispam thing. The page takes about 2-3 minutes to load on a modern-but-not-exactly-high-horsepower machine. I dread what would happen if I loaded it on the 2004 laptop.

[msilverstar]

2368 is great!

[jumpuphigh]

I love reading this stuff - even if I don't always understand it.

[feathertail]

Yay for our developers! ^.^

(Also those are some really funny descriptions there.)

[cesy]

Yay codetour! Lots of shiny fixes this week. Do we know when they're all going live?

[afuna]

Alas, I have no idea when the next code push is.

[denise]

The next codepush shouldn't be longer than a week or two, really. We tend to wait until we have big things available or a buildup of small ones, and we don't like to go too long between them.

[turlough]

Bug 2151: add parent link to comments in inbox

It would be really nifty to have this as one of the links in the comment mail too...

[denise]

Suggest it!! I'm behind on the suggestions queue, but I think that'd go over well.

(Those emails haven't really been redone in *years*.)

[turlough]

I just realised, is the link 2151 talks about to the start of the thread as it is in LJ's emails or is it to "just" the parent of the comment in question? I sort of took it for granted that it would be the first but now I'm not so sure any longer. I can definitely see there being a demand for both (though personally I prefer the first).

[denise]

Just the parent, not the top-of-thread; we could do both, but it's starting to get a little crowded there.

[turlough]

Hmmmm, right now DW's got three links in the email and LJ's got four. (I'm talking about the plain text mail btw, I've no idea what the HTMLified ones look like.) Adding both a start-of-thread and a parent link would mean five links. That is a bit crowded, yes. I think I need to think more on this.

[baggyeyes]

Bug 2269: Split out relevant portions of DW::Shop::Item::Account into a base DW::Shop::Item
Category: Misc Backend
Patch by: [personal profile] afuna
Description: This is... um, object-orienting some stuff, I think. It's shiny because it makes other things easier!


This is why you're cool, yvi!!!!

Man, I'm dopey. Sorry, yvi.

You too, afuna, zarhooie!

[yvi]

Heh, thank you :)

[peoppenheimer]

Yay devs! Thank you! *\o/*

And thanks, Yvi, for making time to write this up when you are in the midst of finishing something so important. (Or should I be scolding you instead?)