Code Tour: 15 December - 4 January

[denise]

It's been a few weeks -- we took off some time for the holidays -- but DW development is back full steam ahead. This code tour catches up everything that's been committed since the last one, mid-December.

This edition we welcome grimsniffer, with his first commit. Welcome, Aram, and thank you so much for joining us!



Bug 48: Respect lj-cut in the Inbox, as a user-defined parameter
Category: Bugfix
Patch by: afuna
Description: The prior fix for this bug introduced another bug, which caused email notifications of news posts not to go out (on the 12/7 newspost). This was the fix.

Bug 627: user-tag /manage/circle/add.bml
Category: Usability
Patch by: yvi
Description: The page you get when prompted to modify a user's status in your circle didn't use a <user name> tag, even though it looked like it did, so you didn't get the benefits of linkage. Now you do.

Bug 748: circle updates in inbox url should have 'friendplus' removed
Category: Cleanup
Patch by: seven
Description: Changes the inbox URLs to remove the 'friend' terminology. DREAMWIDTH HAS NO FRIENDS. Um, I mean ...

Bug 878: Inbox has tropo-red colours hard-coded
Category: Cleanup
Patch by: foxfirefey
Description: This patch fixes up the inbox so that a) 'All' is no longer highlighted no matter what view you've selected; b) the colors aren't hardcoded but change properly with whatever site scheme you've selected; c) more things get rid of 'friends'; d) everything is using the right translation strings.

Bug 898: rename user layer to wizard layer
Category: Cleanup
Patch by: draigwen
Description: This fixes the style system backend so that the 'user' layer is actually called the 'wizard' layer, which will fix up a LOT of confusion about what it is and what it does.

Bug 964: Viewing entries by security level uses friends instead of access
Category: Cleanup
Patch by: novalis
Description: Makes http://exampleusername.dreamwidth.org/security/access work. (/security/friends still works, as do the other privacy options -- /security/private, /security/public -- but this way people can use DW-native terminology if they want.)

Bug 1145: don't-email-comments setting should still email replies to your comments
Category: Bugfix
Patch by: afuna
Description: Fu gets my 'favorite bugfix' award of this code tour: there was a bug that made it so that if you had 'don't email me comments' set on an entry, and then make a comment, you don't get replies to that comment emailed to you. This is contrary to old behavior on LJ, where it does email comments to you, and I like the old behavior better, so we changed it!

Bug 1255: Some settings text too dark in Gradation
Category: Display fix
Patch by: foxfirefey
Description: General bugfix for the Gradation Vertical sitescheme, where certain things in the Settings pages were unreadable.

Bug 1440: Make dw-free work alone
Category: Backend
Patch by: exor674
Description: So, we have two main code branches, dw-free and dw-nonfree. dw-free is intended for everyone to be able to use; dw-nonfree is our site-specific branding pages and the like. We don't license dw-nonfree for general use, but a bug was preventing people from using dw-free alone without the dw-nonfree files, so this patch fixes it so that people can use dw-free to run a Dreamwidth daughter site without getting errors.

Bug 1517: Add date to shop receipts
Category: Businessy stuff
Patch by: foxfirefey
Description: This adds the order date and the delivery date to the emailed receipt you get when you place a paid time order.

Bug 1879: Option to add a reason when editing comments
Category: Nifty site tricks
Patch by: afuna
Description: Many people have noticed this one already, and have been gleefully playing with it! This lets you specify a reason why you're editing the comment when you make the edit, which will then display after the comment's been edited along with the date and time.

Bug 1966: "last maintainer" warning shows up for all maintainers, not just last
Category: Bugfix
Patch by: denise
Description: We don't let the last maintainer leave a community unless the comm's deleted, and we warn them that if they do they won't be able to get it back. The error was being printed to any maintainer and not just the last maintainer; this fixes that so it's only the last maintainer who gets the message.

Bug 1986: Manage Comments page: elements unnecessarily printed when not a personal account
Category: Cleanup
Patch by: denise
Description: This refactors the Manage Comments page so the code is more readable, as well as changing around what elements of the page are shown to personal accounts vs. communities vs. OpenID users so that it logically only shows the sections of the page that apply.

Bug 2054: Template Toolkit / Routing System
Category: Backend
Patch by: exor674
Description: Hoo-boy. This is a huge sweeping project that exor674's been working on for a while. Basically: Dreamwidth uses a templating language called BML to generate all of our pages, since when Brad was writing LJ there was no generally-available templating system. BML is very very old now, though, and hasn't been under development for a while, and it's only used on LJ (and Dreamwidth) so people aren't familiar with it. This makes it a barrier to development entry, even if it weren't, um, difficult to learn and manage. So, we're slowly converting the site to use Template Toolkit, a more modern templating system.

Bug 2117: More accurate nav strip reading page filter drop down behavior
Category: Cleanup
Patch by: yvi
Description: This makes the drop-down box on the navstrip accurately reflect reality if you have a Default View for your reading list.

Bug 2176: Ban page should accept OpenID url account name as account to ban
Category: Cleanup, usability
Patch by: foxfirefey
Description: This lets the banning-a-user interface (http://www.dreamwidth.org/manage/banusers) work with the OpenID display name (the person's URL) as well as with the backend version of the OpenID account identifier.

Bug 2202: Add help link to site scheme footers
Category: Usability
Patch by: denise
Description: This duplicates the Help link from the top section of site-schemed pages to the footer as well, so people can find it in multiple places.

Bug 2203: Paid time gift promotion
Category: Businessy stuff
Patch by: mark
Description: The backend for our holiday paid time promotion.

Bug 2208: Uploading oversized image from URL fails with bad error
Category: Bugfix
Patch by: grimsniffer
Description: This fixes up some error messages when you try to upload a wrongly-sized image from a URL (uploading from your hard drive was working right, but not the URL version). It also cleans up some of the text involved.

Bug 2209: Create Userpic page named wrongly
Category: Cleanup
Patch by: gchick
Description: This changes some of the pages involving icons to properly call them icons (our word), not userpics (LJ's word).

Bug 2221: Smart quotes not displaying on RSS feeds
Category: Bugfix
Patch by: alierak
Description: I really, seriously have no idea how alierak managed to figure this out, but: this patch will fix the odd characters that've been appearing in RSS feeds since our last code push!

Bug 2238: Gradation Vertical Support unreadable or not dark schemed
Category: Display bugfix
Patch by: foxfirefey
Description: More display fixes for Gradation Vertical, this time the Support area.

Bug 2240: Non-existent FAQ throws error
Category: Bugfix
Patch by: foxfirefey
Description: If you tried to go to a FAQ that didn't exist, the page would die a death of doom. This ressurrects it and has it give you a nice friendly "this FAQ doesn't exist" error instead.

Bug 2246: Move cgi-bin/ljhooks.pl to LJ::Hooks module
Category: Backend cleanup
Patch by: mark
Description: Occasionally Mark gets completely fed up with things in the code being in the wrong places by modern coding standards, then spends an afternoon tearing through and moving them. This was one of those days.

Bug 2247: Remove ljlib-local.pl and dw-nonfree.pl
Category: Backend cleanup
Patch by: mark
Description: Occasionally, Mark gets completely fed up with old and unnecessary files being in the code repository, too, then spends an afternoon tearing through and removing them. This was one of those days.

Bug 2249: Convert htdocs/pubkey.bml to TT
Bug 2251: Convert htdocs/about.bml to TT
Category: Backend cleanup
Patch by: mark
Description: Beginning the long slow process of moving pages to use the new templating system.

Comments

[cesy]

That's a lot of fixes. Also, much yay for 2221.

[afuna]

So much <333 for 2221 and 2054(plus related).

ETA: Though I could have sworn that 1145, the dont-email-comments thing was inherited from LJ! I remember the code I touched looked vaguely like old code. The more you know... :-)

ETA2: 1879, reason to edit comments, it's not very obvious, but it also shows up in the "edited a comment" email notification, just before the new comment text *g*

[the_shoshanna]

Changes the inbox URLs to remove the 'friend' terminology. DREAMWIDTH HAS NO FRIENDS. Um, I mean ...

♥ ♥ ♥ ♥ ♥

[alierak]

Re 2221, I just knew :) (actually I'd done all the necessary homework back in April for bug 640). Sorry, I should've caught it sooner, but I hadn't looked at bugzilla in a while. I've added it to my RSS reader now but can't figure out how to get an authenticated feed in order to see security bugs...

[denise]

I stand in awe, really. *G*

(I alas do not have an answer for the authenticated thingum. Although you can subscribe to new-bugs-by-email...)

Micro history;

[pauamma]

There was a rash of similar errors on LJ a few years ago, and they got the collective name "double-UTF errors".

[turlough]

Bug 1879: Option to add a reason when editing comments

I keep forgetting about this and then I feel a bit silly because I want to edit the comment again so I can enter why I did the first change...

Bug 2054: Template Toolkit / Routing System

Will this mean that the .bml file-name ending will disappear too? I'm kind of attached to it :-)

[denise]

It already has! The .bml URLs will work still, for backwards compatability, but throughout the site the 'official' version is the one without .bml on the end. (http://www.dreamwidth.org/update for instance).

[turlough]

Bye, bye .bml ending, I'll miss you!!

[trinity_clare]

Bug 898: rename user layer to wizard layer

YES THIS THANK YOU. That was the single biggest barrier to me learning how to make layouts back in the day.