Code Tour: 1 December - 7 December

[zarhooie]

Hey kids! It's time for another thrilling installment of the Dreamwidth Code Tour! My name is Kat, and I will be your guide on this wild adventure through developer-land! Please keep your hands and feet inside the ride and feel free to feed the developers!

This week, we have 20 patches, from afuna (10 patches), 2 each from yvi and wyntarvox, and one each from gchick, exor674, allen, ysobel and ninetydegrees. There was also one theme submission patch for 3 themes by ninetydegrees.

Under the cut: A bunch of code, some pretty sweet descriptions and two illustrative images.



First, the images! The following image is a pie graph of the patch numbers displayed above:



And this is a graph of the theme submission numbers as displayed above:


And now, TOUR!

Bug 378: Dynamic inbox count in menu
Category: User Interface
Patch by: afuna
Description: Prior to this most recent codepush, the Inbox count wouldn't update dynamically (without reloading the page) if you received new notifications or deleted old ones. This patch changes that behavior and makes it more awesome.

Bug 419: Auto-click 'from URL/file' radio buttons when user inputs URL or browses for file
Category: User Interface, Logic: We Has It
Patch by: allen
Description: When uploading an icon via URL, the little radio button next to Upload from URL wouldn't automatically tick. Similarly, if someone deleted the URL and instead chose an icon to upload from file, the Upload from File radio button wouldn't automatically tick. This patch makes this happen. This patch is my favorite patch from the entire week because this has been bothering me for YEARS. Years, people. That's a long time.

Bug 491: selecting/deselecting colors when adding to circle
Category: User Interface, Colors Good
Patch by: wyntarvox
Description: Time was that if a user tickied the box (that's a technical term) for 'select colors' on the add user page, changed the colors, had a crisis of faith and deselected the box without changing the colors back, the user used to be added with the colors that were picked and then decided against. Times change, and this patch makes that behavior not happen anymore.

Bug 716: Invite a Friend page does not allow links to hosted journals
Category: User Interface, Weird Little Bugs
Patch by: exor674
Description: It used to be that if you tried to include a link to an in-site journal when inviting another user and the url had a trailing / , it would fail with a confusing error. This patch fixes that problem.

Bug 1336: add dropdown for journaltype filter to navstrip on network page
Category: User Interface
Patch by: denise with special guest afuna
Description: This patch adds the journal type arguments (?show=P, ?show=C, and so on) to the navigation strip on the network page.

Bug 1430: "Previous entries" links shown unnecessarily when number of entries available is exactly the number of entries currently shown
Category: Sensible Interface, Why Dreamwidth Rocks, Logic: We Has It
Patch by: LLiveJournal, adapted for use by Dreamwidth by the fabulous ysobel
Description: This one has a story! From the 'Zilla log:
denise: I just saw a post about that bug in lj_dev back in 2002 and Brad (AN: The founder of LiveJournal.com) said he didn't care. *G*
afuna: I filed a support request for this back on LJ (soooo long ago). Mart (AN: A LiveJournal developer Back In The Day) said he didn't care!
denise: Clearly, the time has come to care!
This patch causes the "back" navigation link to not display on a journal if it is the final page able to be displayed.

Bug 1574: "Last active entries" module
Category: Styles, NEET STUFFS
Patch by: yvi
Description: This patch adds a module to journals and communities that displays entries that have had comments posted recently. This feature is expected to be helpful for communities which sometimes get comments on older entries.

Bug 1802: Get crossposting info on entryprops.bml
Category: Support Tools
Patch by: afuna
Description: This is my second-favorite patch this time around because it is something I asked for. There is a tool that shows entry properties for troubleshooting by senior Support staff, such as the date posted, if the entry is backdated and so on (not journal text though). It had a space for crossposting information, but it wasn't displaying properly. This patch fixes that, and boy am I happy! YAY!!

Bug 2001: Open up s2id viewing capabilities
Category: Styles
Patch by: afuna
Description: This patch allows anyone to use the s2id capability to view their journal in another style or to view someone else's journal in their own style. Fer'ex, I can use this to view Afuna's journal in my style or to view my journal in Afuna's style. Afuna is quite stylish, you seee...

Bug 2013: OPML file should special case feeds accounts
Category: Feeds
Patch by: afuna
Description: This patch changes the OPML file for feeds to give the URL of the RSS feed that Dreamwidth is subscribing to rather than the URL of the Dreamwidth feed itself.

Bug 2066: When previewing a theme for your current layout, user layer is applied
Category: Styles, Voodoo
Patch by: afuna
Description: When I started to try and write the description for this, my eyes glazed over because I Do Not Do Styles. Thus, a guest description from the fabulous afuna: We no longer apply custom (non-auto-generated) user layers, when previewing styles. This should catch some strange instances of "crossed wires" several layout authors have run into while previewing their designs.

Bug 2084: User tags slow to show up in RTE when switching between HTML and RTE
Category: User Interface
Patch by: afuna
Description: Basically, the site needed to check whether the user you were trying to link to actually existed every time. This information is now stored locally so it is more easily accessible and thus loads faster.

Bug 2089: Memcache gives off warnings when trying to load a nonexistent style
Category: Styles
Patch by: afuna
Description: This is a bitty patch entitled "patch which gets rid of things that annoy me in the logs." It gets rid of warnings when trying to load styles which do not exist.

Bug 2090: News module widget should respect cuts
Category: User Interface, Logic: We Has It
Patch by: username
Description: In sort, the News widget on the logged-in Dreamwidth homepage did not respect the cut in entries to dw_news. This patch fixes this and brings that widget in line with the philisophy of the Tear Deer (long hand for tl;dr which is shorthand for Too Long; Don't Read). Not that you shouldn't read the dw_news posts! Uh... next bug. >_>

Bug 2109: Remove "Only show themes available to me" from interface
Category: Styles, Logic: We Has It
Patch by: gchick
Description: Some LiveJournal styles are restricted to a certain subset of users (fer'ex, paid users or those who have cryllic services enabled). Dreamwidth doesn't deny use of styles to any user, so this "feature" has been removed.

Bug 2116: filter=0 is not added to skip links
Category: User Interface
Patch by: yvi
Description: When you skip back on your reading list, the filter argument was not added. It is now.

Bug 2128: Themes: 3 themes (Brittle)
Category: Styles (Themes)
Patch by: ninetydegrees
Description: Three new themes for the Brittle style! They are named Soft Blue, Soft Green and Old Roses. I think they're very nice!

Bug 2130: Brittle.pm and brittle/themes.s2: reorder themes in alphabetical order
Category: Styles, Alphabets "R" Good
Patch by: ninetydegrees
Description: The NNWM2009 theme was out of alphabetical order. This patch puts it where it belongs!

Bug 2134: Some pages erroring out if you try to access them when logged out
Category: User Interface, voodoo
Patch by: username
Description: Some pages were erroring if you viewed them when logged out after some circumstances. This patch makes them work all nice and shiny-like!

Bug 2137: no notifications sent when email addresses are identical
Category: Notifications, Logic: We Has It
Patch by: wyntarvox
Description: When a comment was posted, there was a bit of code that checked the email address of the commenter against the email address of the person who replied to them. If the email addresses were the same, then no notification was sent out. This has been updated to check the usernames against each other instead of the email addresses.

Now that you are done with this, you should swing on over to dw_support_training and take a look at sporky_rat's first ever weekly bug tour! It's pretty sweet, I gotta say.

That's it for me! Wear your seatbelt, brush your teeth and be sure to turn in next week for another thrilling installment of Dreamwidth Code Tour!

-Kat

Comments

[mark]

Thank you for doing this!

[zarhooie]

Yep, no worries!

[zarhooie]

For anyone who is interested, I used this neet site to make the graphs. :)

[sixbeforelunch]

I love thew new last active entries feature, though I'm going to have to play around in my css to get it to look pretty. ;)

[yvi]

afuna leading again, huh?

No, this is not a competition. Nada. Nein. Never. Nothing to see here, move along.

[zarhooie]

Patch more!

[yvi]

Maybe I should pay a ghostpatcher.

[zarhooie]

You could probably pay afuna. :P

[zarhooie]

Also, we MISS YOU in IRC. Come back!

[alixtii]

Excellent code tour. I really loved the descriptions this week.

[dreamwriteremmy]

Just for future reference: It's Teal Deer ♥

Figured we should put that out there. ♥ Awesome code tour otherwise!

~Dreamers
dreamwriteremmy/thedreamersunited

[zarhooie]

Ooh, thanks for the heads up! I'll be sure to try and remember that. :)

[nostariel]

I'm also pretty sure it stands for Too Long; Didn't Read, which would make more sense given that it was originally used as a snarky response to long posts.

The rest of the code tour is fab, though. The category descriptions are adorkable, and I love the little story about 1430 (2002!).

[susanreads]

I love your category descriptions.

[zarhooie]

Awww bless! I was exhausted when I started and it just got weirder. The graphs were a last minute addition about 5 minutes before I posted this... and I'd wanted to go to bed three hours previous.

[sporky_rat]

I know that feeling! I felt like that when I was doing the bug tour.

[msilverstar]

ooo can now do next and previous on a filter? cool! does this work for tags too?