Code tour, 11/23-11/30

[yvi]

Welcome to this week's code tour. My name is yvi and I am not as witty as azurelunatic, but I hope I'll still get you all excited about these patches anyway.

The last week saw 17 bugs marked RESOLVED FIXED, with contributions by afuna, afuna, afuna, afuna, wyntarvox, wyntarvox, wyntarvox,...

Oh, a few of us others also got a few patches in :) allen, yvi, juliet, mark, and ninetydegrees

Bug 53: Userpic keyword renaming
Category: Misc UI/Frontend
Patch by: allen
Description: This enhancement request has been with Dreamwidth for a while now and is now finally ready for you to use. This implements functionality to rename icon keywords so that old entries still show the correct icon despite the keyword change instead of falling back to the default keyowrd.

Bug 491: selecting/deselecting colors when adding to circle
Category: Misc UI/Frontend
Patch by: afuna
Description: In the process of subscribing to a user, you can choose to assign custom colors to that user's entries on your reading list. This fixes a bug where if you selected colors, but then deselected the option to use custom colors for the users, the colors would still be shown.

Bug 496: set up RTE to use the cross-site tags
Category: Misc UI/Frontend
Patch by: afuna
Description: You can now make the nifty user tags to external sites (like afuna) with the rich text editor as well. Afuna is a braver person than I am for braving the RTE code.

Bug 1586: Add dynamic time options to the Post Entry page
Category: Journal contents
Patch by: wyntarvox
Description: This one is from dw_suggestions, suggested by ysobel. The update page now has a button where you can update the time of your entry, so if you want the time to reflect when you finished an entry instead of when you started an entry, this can now be done with one click.

Bug 1589: "Maintainer only" posting security in communities
Category: Communities
Patch by: afuna
Description: Based on something posted to dw_suggestions (and I think it might have been me saying that), posts maintainers make to communities can now be set to 'maintainer only', which is kind-of equivalent to the private setting in personal journals. The posts can only be seen by maintainers of that community.

Bug 1623: tag editing fails silently in comms with restricted permissions
Category: Tags
Patch by: afuna
Description: There are several restrictions maintainers can put on editing tags in communities: not adding tags to entries, not deleting tags from entries, and not adding new tags. Up until this patch, a user was not shown an error when they tried editing tags, but didn't have permission to do so. Now you will know.

Bug 1979: Inbox actions do not work well with single entry view
Category: Inbox/Notifications
Patch by: afuna
Description: The inbox has a 'single entry view', where you only see messages related to one entry. However, that was quite buggy, with the Delete All and Mark All Read buttons not working and other things. These issues are now fixed.

Bug 1989: Manage Comments page: 'Manage Comment Settings' link without ?authas
Category: Misc UI/Frontend
Patch by: yvi
Description: Minor bugfix where the recent comments page, when you were working as a community, was redirecting you to the setting page without leaving you in the 'working as a community' mode.

Bug 2037: change alt text for userhead icons
Category: Misc UI/Frontend
Patch by: juliet
Description: The alt text of the userhead icons were not very helpful - for example: [info - community] shoes or [info - livejournal.com] kink_bigbang or [info - personal] havocthecat (yes, I just garbbed random links off my reading list). They have now been changed to more sensible text, like [comm profile], [livejournal.com profile] or [user profile] for accessibility.

Bug 2079: Remove LJ::M::* files, unused
Category: Misc Backend
Patch by: mark
Description: Code-cleanup, removing unused files.

Bug 2093: If profile display is Mutual, Also Has Access From displays deleted accounts in default profile
Category: Misc UI/Frontend
Patch by: yvi
Description: Deleted user names are not shown in the normal profile view for sections out of control of the user (well, except for banning), like "subscribed from". This was missed for "Also Has Access From".

Bug 2119: Reading page uses journal-wide adult content setting for displaying NSFW/18+ icons
Category: Style System
Patch by: wyntarvox
Description: Ouups, another bug I am responsible for. The reading page should of course use the adult content settings of the journal an entry was posted in for the NSFW/18+ icons instead of the settings for the journal we are viewing the reading page of.

Bug 2121: remove LJ::can_view
Category: Misc Backend
Patch by: mark
Description: 1 Two functions, both alike in dignity, 2 In fair cgi-bin, where we lay our scene, 3 From ancient code break to new mutiny 4 Where redundant functionality makes civil objects-oriented-programming unclean.
Code cleanup.

New styles

I never really have much to say about these, because I always just use the most functional white-on-black layout can find :) Sorry I am so bad at this, if a Styles-person wants to describe them or link to previews (I have no idea where to find that out) in the comments, I'd be very happy.

Bug 1903: Theme: Clean Sheets (Modish)
Category: Style System
Patch by: wyntarvox
Description: Pretty theme for Modish

Bug 1906: Theme: Go (Drifting)
Category: Style System
Patch by: wyntarvox
Description: Pretty theme in green for Drifting

Bug 2095: Theme: 10 themes (Transmogrified)
Category: Style System
Patch by: wyntarvox
Description: 10 pretty color themes for Transmogrified

Bug 2128: Themes: 3 themes (Brittle)
Category: Style System
Patch by: ninetydegrees
Description: And three pretty themes for Brittle

Comments

[cesy]

Much yay for 53, 1586 and 1623.

[gchick]

53!

Aside from being cool and needed, I also have a ridiculous fondness for low-numbered bugs. Yay!

[wyntarvox]

The last week saw 17 bugs marked RESOLVED FIXED, with contributions by [info - personal] afuna, [info - personal] afuna, [info - personal] afuna, [info - personal] afuna, [info - personal] wyntarvox, [info - personal] wyntarvox, [info - personal] wyntarvox,...

Haha! My first thought reading this was "I think yvi has mis-copy/pasted..."

Some neat stuff this week!

[turlough]

Bug 53 makes me so excited! It's something I've been dreaming of having since back when I first got my journal on LJ.

[denise]

Additional bugs resolved between then and the end of the day!

Bug 2084: User tags slow to show up in RTE when switching between HTML and RTE
Category: Backend
Patch by: afuna
Description: Adds caching for user tags in the RTE, which makes switching back and forth from rich text to HTML editing faster if you have a bunch of user tags in the post.

Bug 2089: Memcache gives off warnings when trying to load a nonexistent style
Category: Backend
Patch by: afuna
Description: Fix memcache errors when you try to use a ?s2id= argument where the ID specified doesn't exist.

Bug 2066: When previewing a theme for your current layout, user layer is applied
Category: Style system
Patch by: afuna
Description: When you preview a style, the system applies your user layer (any auto-generated customizations) to the preview, but when you then apply that style to your journal, an new user layer is generated, thus making the preview and the end results not match up. This changes it so that the two match, by not using the user layer on preview.

Bug 2013: OPML file should special case feeds accounts
Category: Interoperability
Patch by: afuna
Description: The OPML file -- a list of the URLs of all the accounts you subscribe to, for putting into your favorite feed reader if you'd like to duplicate your reading list elsewhere -- was including the Dreamwidth version of feed accounts, rather than the original location of the feed. This changes it so it uses the original (offsite) syndicated account instead, for efficiency's sake.

[matgb]

Definitely liking the last two there--the user layer thing was something that I'd noticed but not twigged as for cause when I was last playing around, and OPML exporting might be useful if I try a feedreader again (so used to friends/reading pages, readers just don't work for me).

[afuna]

Heee! (And I love your description of Bug 2121 :-))

[msilverstar]

Adding screenshots of the new styles would be great, it would give them lots more visibility and tempt us to play with them.

[trinity_clare]

It's stuff like the description for 2121 that makes me love you guys. :D

[kaizoku]

1 Two functions, both alike in dignity, 2 In fair cgi-bin, where we lay our scene, 3 From ancient code break to new mutiny 4 Where redundant functionality makes civil objects-oriented-programming unclean.

Hee.

[lanterne_rouee]

where is the 'single entry view' for the inbox and/or how do you use it?

sorry if it's meant to be obvious, but i've been looking at mine and clicking on things and i don't see it. lol

thanks!

[afuna]

Each comment notification in the inbox contains a link beside the subject saying "filter to this entry". If you click that, you filter to only other comments made to that entry.

(Hope this helps *g*)

[yvi]

You bunneh'ed me :'(

[afuna]

Bunneh bunneh bunneh :-D

(You'll get me next time!)

[lanterne_rouee]

ohhhhhhh! :D i like it! i'm so glad i asked. lol

thank you very much!

[afuna]

You're welcome! \o/

[yvi]

Your inbox should have "filter to this entry" links whenever you got a notification for a comment.

[lanterne_rouee]

thank you, too! :D