Code tour: 2009 11 03 to 2009 11 09

[azurelunatic]

We have 43 bugs fixed this week, two as side effects of other bugfixes. There is some brilliant teamwork and collaboration down in here. There are several lovely new themes. I have, experimentally, put the new themes in a separate section from the rest of the patches, so they'll be easy to find and check out for those who just can't get enough.

afuna is in the lead with 13 contributions this week. She has started (i)NaPaWriMo? or NaNoNOTWriMo? or something ... whatever you call it, she's heading for 30 bugs patched in November. Care to join her? mark and ninetydegrees are tied for second with 8 each.

Below, there are contributions by mark, afuna, exor674, kareila, yvi, wyntarvox, denise, forthwritten, ninetydegrees, kaigou, dancing_serpent, cimorene, zvi, cesy, gchick, and special guest appearances by
carynb, who resolved a bug that also fixed one of these bugs back in August, and gariev, who wrote a patch on LiveJournal that was adapted to life on Dreamwidth and brought in.


Bug 431: Deploy Puppet for configuration management
Category: Server Configuration Management
Resolved by: mark
Description: Puppet is a handy little program that makes a system administrator's life much, much easier by automating server setup and administration to a very flexible and configurable degree. mark has it set up in a way that will serve for the time being, although it will be set up to do more things in the future.

Bug 1183: Tags module on Tags page ignores tags limit
Category: Styles
Patch by: afuna
Description: It turns out that saying "only my top five used tags should show in my journal style" and the tags page, which shows all the tags, didn't mix very well, and the style showed the whole kit and kaboodle on just that page. Tricky! But that's fixed now.

Bug 2039: Javascript error in Safari when inbox count updates
Category: The Inbox vs. the Browser
Patch by: afuna
Description: There was an error caused by having more than one 'Mark All Read' button, but only in Safari. Fixed!

Bug 2035: Search fails if any of the entries found has no non-html content.
Category: Search
Patch by: exor674
Description: If you had an entry with just an image, or just a YouTube video (like many of the fine entries at earwormhole), or anything that didn't have some form of text in the entry, and a search turned that entry up, the search would fail miserably with a rather alarming error.

Bug 1670: create function for creating s2 entry objects
Category: Styles
Patches by: mark, afuna, kareila, yvi, and wyntarvox
Description: The code that built the display of the entries in S2 was ugly and inefficient. WIND THEM UP AND WATCH THEM GO.

Bug 2056: Make talkscreen.bml and talkmulti.bml translate when called as endpoints
Category: Comments
Patch by: gariev, and wrapped up neatly for Dreamwidth by denise
Description: This fixes some obnoxious little error messages when using the JavaScript comment screening/unscreening buttons.

Bug 1776: interests / keywords cleanup
Category: Musicals Interests
Patch by: kareila
Description: The vague version: "backend changes in order to optimize our database table design." The version that I get after squinting at the notes for a bit: This cleans up some interests back-end, which is also some keywords back-end, and was something getting in the way of vgifts. (Ooo! Exciting! One step closer to the commit-and-ditch pony coming to a Dreamwidth profile near you!)

Bug 1235: Login through https://www.dreamwidth.org/login.bml with "bind to IP" option doesn't stay logged in
Category: Login
Resolved by: mark
Description: A particular combination of login settings would log you out instead of keeping you logged in.

Bug 1375: Wrong ip address on email-changed email
Category: Email notifications
Gnarly reconfiguration by: mark
Description: An internal IP address, not the actual IP address of the person making the email change, was being sent out with email notifications.

Bug 1935: branch s2 repository from code.sixapart.com
Category: Styles (S2), code independence
Patch by: mark
Description: Dreamwidth doesn't want to depend on external code repositories. It turned out that some of the code we needed for S2 styles to work was still synchronized with code.sixapart.com. Now we can make changes to the S2 back end without having them get blown away at the next synchronization.

Bug 2079: Remove LJ::M::* files, unused
Category: Backend
Patch by: mark
Description: Removing some unused files.

Bug 2055: Website name in Skittlish style looks like plain sidebar text
Category: Styles
Patch by: ninetydegrees
All the work by Standing by and cheering by: kaigou
Review by: wyntarvox
All the work by: afuna
Description: Nice formatting for the website name in the style Skittlish.

Bug 497: standardize custom color options between /add and /edit
Category: Circle (Subscription) Management
Patch by: bug 492: carynb (two bugs with one patch!)
Description: When you're adding a subscription to your reading page, you can set a custom color for them! You can also change that color later. The two color picking bits didn't match each other. Now they do.

Bug 2038: Brittle NNWM, color entry text and color entry background need to be explicitly set
Category: Styles
Patch by: zvi
Description: Blockquote text was illegible in this style and theme. Now all the colors are set properly, so you no longer have to switch to ?style=mine or highlight the quoted bits.

Bug 153: Add a link on comments that goes to the root of the thread
Category: Comments
Patch by: afuna
Description: When you're reading that big long comment thread, perhaps because someone sent you a link to a comment halfway down it, sometimes you want to go right back to the comment that started this particular conversation. The "Thread from start" link does just what it says.

Bug 921: importer not rewriting user tags in subjects for cross-site
Category: Entry display
Patch by: exor674
Description: When you imported entries from another site with usernames in the subject, the usernames weren't accounting for the fact that they were from the other site. There's still work being done on other parts of this issue, but the importer part of it is finished.

Bug 1998: Warning when deleting OpenIDs
Category: Account management: OpenID
Patch by: yvi
Description: If you delete your OpenID account, then you don't have access to the account that controls your imported comments. Just so you know. (This warns people about that.)

Bug 2003: Note which of your comments have replies on Manage Comments
Category: Comments
Patch by: yvi
Description: Gosh, it would sure be nice to know, when looking at http://www.dreamwidth.org/tools/recent_comments#posted, which of your comments have replies to them! But just look at the cunning little asterisks that tell you that!

Bug 2061: remove Vox specialcasing
Category: We're not LJ
Patch by: afuna
Munitions from: denise
Description: Getting rid of legacy Six Apart code that treated Vox in some sort of unspecified special way.

Bug 2063: remove var/devdata/ directory
Category: We're not LJ
Patch by: denise
Evil laugh by: bradfitz (D: "The sad thing is, I recognized it just by the sound.")
Description: There was a voice post testing file lurking in this directory. No voice posts = no need for voice post testing files.

Bug 1980: post from email post-security:access setting
Category: Email post!
Patch by: kareila
Description: Post-by-email is being brought into compliance with the "access", not "friends" terminology.

Bug 865: configure pubkey support
Category: PGP support
Modules installed by: mark
Description: If you'd like to share your PGP public key, you should be able to now. If you have any problems with this, please file a support request with details so we can take a look!

Bug 1070: raw stats data file is missing
Category: Statistics
Cron job set by: mark
Description: http://www.dreamwidth.org/stats/stats.txt is now right where it's supposed to be.

Bug 2017: Add yet more classes to the basic style
Category: Styles backend
Patch by: ninetydegrees
Description: This is going to make writing CSS easier for styles and themes people. More classes to play with! It's column-related, that's all I know.

Bug 1751: Make style wizard save user layer properties in alphabetical order
Category: Styles
Patch by: afuna
Description: Ever tried to work with user layer properties manually after the style wizard has had done with it? Now it will leave things nicely alphabetized in its wake, like a good wizard should.

Bug 1755: Make comment count images specify size
Category: Crossposter
Patch by: afuna
Description: The comment images in the crossposter made people reading it on other sites cross, because the comment count images didn't specify their size. This fixes that.

Bug 48: Respect lj-cut in the Inbox, as a user-defined parameter
Category: Inbox, Обе́щанного три го́да ждут.
Patch by: afuna
Description: There's a display setting for cut tags in the inbox: http://www.dreamwidth.org/manage/settings/?cat=display (or, well, there will be once the code push happens).

Bug 378: Dynamic inbox count in menu
Category: Inbox
Patch by: afuna
Description: The count of inbox messages as displayed in the site headers updates dynamically according to the actual messages in the inbox.

Bug 157: XML-RPC doesn't work correctly in LJ - please fix it in Dreamwidth!
Category: Data responses
Patch by: afuna
Description: When retrieving data on friends circle, a username that's all numeric gets sent back as an integer, not a string. Woops. (Legacy bad behaviour inherited from LJ.)

Bug 1411: fix checking of whether or not comments are disabled on local entry for xpost
Category: Crossposting
Patch by: afuna
Description: The crosspost footer should correctly reflect whether comments on the Dreamwidth entry are enabled or disabled (and not tell people to go comment on an entry with its comments turned off).

Bug 2033: autoclose unclosed <cut> tag in xposted entries before xpost footer is added
Category: Crossposting
Patch by: afuna
Description: denise was tired of remembering to close her <cut> tags so the crosspost footer would show.

Bug 451: remove schools system
Category: We're not LJ
Munitions by: denise
Description: LJ's schools system is not for us.

Bug 2060: remove pingback skeleton
Category: We're not LJ
Munitions by: denise
Description: We will eventually have pingback, but we're not using LJ's implementation.

Bug 2064: remove old doc file
Category: We're not LJ
Munitions by: denise
Description: Getting rid of more unneeded files.

Bug 1529: S2 page summary module needs more stylability
Category: Styles
Patch by: ninetydegrees
Description: CSS classes so styles/themes people can style the page summary.

Bug 1743: update.bml shows pingback options if logged out
Category: Weird General Behavior
Patch by: bug 2060
Description: Pingback options were showing up in a really, really weird place. Since we won't be using LJ's implementation of pingback anyway, this got fixed when that was removed.

Bug 1970: Negatives: add two-column-left option
Category: Styles
Patch by: ninetydegrees
Description: More options for the Negatives style

Bug 2076: Celerity: some text unreadable (white on very light background)
Category: Site schemes
Patch by: ninetydegrees
Description: There were some unreadable bits in Celerity.

Bug 2044: Shop: Fractional currency values show incorrectly
Category: Making things look tidy
Patch by: gchick
Description: Trailing zeroes weren't displaying in the shop, so a price of, say, $17.50 would show as $17.5 -- no difference in price, but obnoxious to look at.


Bug 1918: Theme: Fresh Blue (Tranquility III)
Category: Styles
Theme by: forthwritten
Preview by: ninetydegrees
Description: A bright but not offensively cheerful blue theme for Tranquility III.

Bug 2057: Theme: Pale Jewels (Transmogrified)
Category: Styles
Theme by: dancing_serpent
Patch by: ninetydegrees
Description: A restful grey and periwinkle theme for Transmogrified.

Bug 2058: Theme: Muted Seashore (Fluid Measure)
Category: Styles
Theme by: cimorene
Patch by: ninetydegrees
Description: A sea-green and sand colored theme for Fluid Measure.

Bug 1938: Theme: Light on Dark (Bases)
Category: Styles
Theme by: cesy
Patch by: ninetydegrees
Description: A restful black backround with white text and royal purple and grey detailing, for Bases.

Comments

[yvi]

Category: We're not LJ

*looks around*

We're n...

Oh damn.

And I still want my commit-and-ditch pony for 1670.

But just look at the cunning little asterisks that tell you that!

* is a cunning little asterisk! I mean, it comes from a German keyboard!

Gosh, denise sure likes to rip things out, doesn't she?

[azurelunatic]

*halo*

[yvi]

It's so cute!

[denise]

FIRE IN THE HOLE

[kaigou]

I confess, I get the biggest kick out of the fact that there's actually a category called "We're not LJ."

[azurelunatic]

For certain values of "actually" -- it's mostly in my pointy little head, and I don't believe it's in Bugzilla. It was, however, the common theme between all those. :D

[whobutdrew]

Your icon made me groan and roll my eyes.

This is mostly due to the fact that it is UnGodlyEarly:45am, and I am therefore crotchety. Any other given hour of the day, I would likely be laughing.

Carry on.

[phoenix]

cunning little asterisk! smart idea, nifty feature!

Lots of good stuff in here (like the autoclosing cut tag in crossposts! \o/). Hurray devs.

[niqaeli]

<3.

That heart is directed at Dreamwidth and you both equally. *g*

[azurelunatic]

:D

[susanreads]

Hurrah for bug 153! (which I have seen in the wild) also, bug 48!

Are the preview-redirect links on the new themes a new thing? It makes seeing whether I'll want to change my style a lot easier.

[afuna]

Nope, they've been there a while. They're the same thing that's used to create previews from http://www.dreamwidth.org/customize/, actually!

[susanreads]

I've seen them there, but I thought code tours and changelog-digest only had links to the code.

I can spend entirely too long looking at pretty themes; I've had to make a list of layouts I don't like so I remember not to bother with them.

[afuna]

Aha! Yeah, in general, they aren't included. This is the first time, IIRC (partly it's because most of the time, when they do code tours, the theme isn't live on the site yet, so nothing to link to).

[azurelunatic]

I see it's one of the features shared with LJ, and since I don't remember seeing it go in, that probably means it's been around for quite a while.

I think it's probably that it's just a bit of a fuss to put them in a code tour and perhaps no one else thought of it before in a code tour (I don't know for sure, as I don't often pay attention to theme releases after I have one I like; I'm pretty sure it gets used in serious style/theme areas), but I was complaining in IRC about not being able to link directly to a theme in the customize area, and thought linking to the preview worth the effort.

[susanreads]

Thank you! (I've got one I like now but I still look at new ones)

[zarhooie]

Category: Server Configuration Management
Resolved by: [info - staff] mark
Description: Puppet is a handy little program

Yeah, so I was reading this and my brain condensed "Mark" and "Puppet" together, so I guess that Our Fearless Coder is a Muppet?

[baggyeyes]

Muppet is a handy little programmer.

[baggyeyes]

I really like 1938 - Light on Dark (Bases). When I stop switching my theme around, I'll probably use that one.

Lots and lots of bugs! \o/ I'm in awe of all of you.

[not_a_sniglet]

Yeeee for several of these!!! Also thank you Azz for actually describing the themes. \O

We generally don't know what themes look like and we loved that very very much! <3333

Also, *Stole bradfitz 's evil laugh file.

And "We're not LJ" should be put into Zilla

[azurelunatic]

You're welcome! I was thinking of you when I described them, because it's a very visual thing and every little bit helps. You also inspired a suggestion, because I discovered that there aren't descriptions in the customize area.