Code Tour, 10/28-11/2

[denise]

37 bugs resolved this week, 30 fixed and the rest duplicate/invalid/etc. Let us go on a tour together!

(Side note: We resolved 137 bugs in October, for a grand total of exactly 1500 bugs resolved so far. YAY. You guys rock.)

afuna, meanwhile, deserves a shoutout for rocking the house this week, with 9 patches, followed by kareila and ninetydegrees with four each. Thanks, guys -- we really appreciate it.



Bug 2043: featured - first week of november
Category: Styles
Patch by: afuna
Description: This patch updates the Featured Styles for the month of November.

Bug 2042: ">>" and "<<" buttons on Manage Access Filters page are inaccessible
Category: Accessibility
Patch by: denise
Description: The Manage Filters page used ">>" and "<<" to represent "add to filter" and "remove from filter", which was useless for people who used screenreaders (many of whom have turned the speaking of punctuation off, and many of whom didn't have the visual picture of the two boxes to help). This patch changes the labels to include the text "Add" and "Remove".

Bug 2041: remove discount footnote
Category: Money
Patch by: denise
Description: The initial six-month discount expired 1 November, so this patch removes the text on http://www.dreamwidth.org/shop that says the prices go up after 1 Nov.

Bug 2039: Javascript error in Safari when inbox count updates
Category: Bugfix
Patch by: afuna
Description: This fixes a Javascript error with the dynamically updating inbox count in the site menus, which will be forthcoming in another patch.

Bug 2035: Search fails if any of the entries found has no non-html content
Category: Bugfix
Patch by: exor674
Description: This fixes a bug where if any of the entries returned by searching had only an embed, only an image, etc, the entire search would fail. Good catch, Dre!

Bug 2034: in comment form, comment browser button is styled and shouldn't be
Category: Display bugfix
Patch by: afuna
Description: This was driving me nuts: in the QuickReply comment form, the "Browse" button to browse your userpics was colored to match the site scheme you were using, while the "Quote" button wasn't. Rather than styling the Quote button, we removed the styling from the Browse button, so that site schemes that would be low-contrast against button colors would still be legible.

Bug 2031: Community account management page includes missing community icon file
Category: Display bugfix
Patch by: denise
Description: Last code push, I removed a bunch of unused icons; one of them actually turned out to be less unused than I thought it was. This switches the community management page to use the new-style icon instead of the old-style LJ community head icon. (And if you spot any LJ-style icons being used elsewhere that squeaked through, please let us know.)

Bug 2023: Sort Base Layouts by Layout Name
Category: Styles
Patch by: afuna
Description: A dw_suggestions entry: this patch changes it so that the "by base layout" option in the Select Style page sorts alpha by layout name, not alpha by theme name.

Bug 2022: Add link to Circle Gifts from the Shop
Category: Money
Patch by: ninetydegrees
Description: Another dw_suggestions entry, this adds a link to the Circle Gifts page to the front page of the Shop.

Bug 2019: Specify who posted News posts in the email notification
Category: Notifications
Patch by: denise
Description: Another dw_suggestions entry. This patch changes the notification for the "Dreamwidth has posted an official notice" so that instead of reading "there is a new announcement in dw_news", it will read "denise/mark made a new announcement in dw_news". Since we write our weekly updates with such a personal touch, it'll be easier for those who get their notices via email. (This patch is also notable for being one where it took me an hour to figure out where to make the change, five minutes to make the change itself, and then three hours to try to test it. Sigh.)

Bug 2004: Include title of entry in comment notifications in Inbox
Category: Notifications
Patch by: afuna
Description: Another dw_suggestions entry! (We had a really good run on suggestions this week.) This adds the title of the entry to the inbox notification, so it no longer says "an entry" but uses the actual entry title.

Bug 1995: change some caps in configs
Category: Site config
Patch by: mark
Description: A bunch of people already found my dw_docs entry requesting documentation of this, but keep an eye on dw_news later tonight for details. *g*

Bug 1988: Tie community to admin promo codes
Category: Admin
Patch by: mark
Description: We have a way to create 'bulk use' invite codes, for conferences and other promotions. This adds support to associate an account to each promo code: if it's a community, the creation process will suggest that the user adds that community, while if it's a user, the creation process will suggest that user's communities.

Bug 1987: Make the codesharing community more obvious on the front page
Category: Admin
Patch by: foxfirefey
Description: After last week's dw_news discussion about invite codes, one of the things that came out of the feedback was that it was hard to find the dw_codesharing community if you didn't already know about it. This patch adds a link to the logged-out homepage, so visitors will be more able to find it.

Bug 1984: Manage Comments page: extra 'latest' in toolbars
Category: Bugfix
Patch by: ninetydegrees
Description: This fixes the Manage Comments page to get rid of a stray word that crept in. It's also ninetydegrees's first non-styles-related patch, so congrats!

Bug 1983: Manage Comments page: missing anchor in Latest Posted toolbar
Category: Bugfix
Patch by: ninetydegrees
Description: This patch fixes a missing HTML anchor in the Manage Comments page, which would cause you to lose your place when flipping back and forth between the 10/25/etc views.

Bug 1982: DW::Worker::SynSuck error
Category: Backend
Patch by: kareila
Description: This fixes a backend error (a required module wasn't being properly loaded) that was filling up the admin logs and pushing out other errors.

Bug 1981: suggestion page has two closing form tags
Category: Display bugfix
Patch by: yvi
Description: Hoo-boy, did this take us forever to figure out! This fixes an HTML error on the Submit a Suggestion page that was preventing spellcheck/preview from working in some browsers.

Bug 1980: post from email post-security:access setting
Category: Cleanup
Patch by: kareila
Description: Fixes up the post-by-email process to recognize 'access' as a security level as well as 'friends', since we don't have friends.

Bug 1976: Funky Circles: fix display of sidebar modules
Category: Styles display bugfix
Patch by: ninetydegrees
Description: Fixes a problem with the sidebar calendar being cut off in Firefox.

Bug 1975: Navigation search form looks wonky on /tools/search
Category: Display bugfix
Patch by: kareila
Description: Fixes an overeager CSS definition that was causing the site search box in the various site schemes to be mis-aligned on the Search page.

Bug 1939: remove unused images from htdocs/img
Category: Cleanup
Patch by: denise
Description: I did this a few weeks ago, but just closed the bug this week: this removed a bunch of images from our source repository that weren't being referenced anywhere. (And let me tell you, some of them haven't been used on LJ for years. It was a fun blast from the past in some cases!)

Bug 1776: interests/keywords cleanup
Category: Cleanup
Patches by: kareila
Description: This is another long-standing bug that had a lot (a LOT) of work done on it, and is now finished! It's a herculean effort by kareila to clean up a bunch of methods that handle setting and accessing keywords (like for userpics) and interests.

Bug 1570: replying to comments from inbox doesn't work in internet explorer
Category: Bugfix
Patch by: afuna
Description: This fixes a JavaScript error that was causing the inbox comment reply function to fail in IE.

Bug 1492: modify manage/subscriptions/comments.bml to also include entry, not just comment thread
Category: Usability
Patch by: afuna
Description: This corrects the subscription interface so that when you try to subscribe to an individual comment, it gives you the option to subscribe to the thread (existing behavior) and the option to subscribe to all comments to the entry.

Bug 1487: Wrong username when trying to track journals from your readpage with the ajax-y track button
Category: Bugfix
Patch by: wyntarvox
Description: This fixes a bug where if you tried to track someone's journal using the inline JavaScript popup from your reading page, you'd get the option to track yourself (or whoever owns the reading page), not the person you were trying to track. (Good catch, Wyn!)

Bug 1183: Tags module on Tags page ignores tags limit
Category: Bugfix
Patch by: afuna
Description: This fixes the tag module in layouts so that it properly respects the limit of tags to show, if you've set that.

Bug 995: Tweaks and suggestions for Core 2 Testing
Category: Styles
Patches by: aveleh
Description: This is another old bug that we finally called 'done' this week; it was the tracking bug for all of the changes we wanted to make to the Tabula Rasa layout to be most useful for designers. (Big thanks go to branchandroot for all of her help and feedback.)

Bug 303: faqcat system needs a frontend
Category: Admin
Patch by: wyntarvox
Description: I think you guys might start to understand how much the various admin people on both LJ and DW deserve canonization when I tell you that this patch is designed to add in a frontend for the system used to move FAQ categories around, and that previously, the only way to move a FAQ category was to go to the console and type a command to move each category up or down on the list. One at a time. I wish I were making this up. Bless Wyn for giving us a frontend!

Bug 153: Add a link on comments that goes to the root of the thread
Category: Usability
Patch by: afuna
Description: Rocking out the old bugs, this adds a link to the ultimate parent comment (the root of the comment thread) to comments, allowing you to go back to where the conversation started pretty easily.

Comments

[afuna]

Well, someone did!

:x

(Come to the dark side. We have... access lists?)

[yvi]

Oh, you meant D's description *looks sheepish* I commented before reading the whole entry :)

[baggyeyes]

Access porn.

Marty let Jim access him...

Lynn helped Anna access her...