Assigned-bugs hackathon!

[denise]

I checked tonight, and we've got 571 open bugs. That's a lot! 146 of them are assigned with no patch, and if we could make some inroads on that number, we'd be able to knock down the total open number a hell of a lot.

So, here's my hackathon challenge! If you've got assigned bugs, let's do whatever we can this week to get that number down. I'll start; I have 8 bugs assigned to me without a patch, and while some of them are waiting on other things to get resolved first, some of them are things I've just been putting off because I don't know exactly how to do them or was running into problems.

I've already yelled for help on what I'm stuck on, so I'll turn to y'all: what can I help you with on stuff you're stuck on? And if not me, who else can help you? A bunch of the existing assigned stuff is really complex, so let's all work together and see how much we can improve things.

Ideally, I'd like to get that "open" number down below 500 by Sunday night, and double ideally, the "all unassigned" number (currently at 386) down under 300.

*salutes you all*

Comments

[cesy]

Will roughly the right Javascript be on the Edit Tags page, or will I need to write new stuff?

[denise]

I'll tell you a secret: I don't understand half of what I'm doing either, I just cut and paste from the other code. ;)

[yati]

I have one bug assigned to me (1924), but that already has a patch and is waiting review. I think I might be able to do 1813, but I haven't really looked at it closely.

My skill set is limited to S2 and CSS, and I can make sense of bits of Perl (small bits!); any suggestions on what I could tackle next?

[ninetydegrees]

XD That's how I learned S2 and it "only" took me two years so who knows?

[denise]

These are all the styles bugs, so you have a bunch to choose from! There's big and small in there.

[yvi]

Is there a reason you are not using an array? Because with that, you could just use split to get the first ten items. I am not sure how it works with hashes.

[yati]

Yep, I have that under my saved searches, and the unassigned ones all look scary to me! *sheepish*

I'll take another look and see if they look more doable this time around.

[yvi]

*facepalm* a) I meant splice

b) Or you can probably use splice on values %$tags.

my @10first = splice ( values %$tags , 0 , 10 ) or something like that.

[cesy]

*has a look*
(You can search for effort-minor unassigned, but that includes many that aren't actually very minor.)

http://bugs.dwscoalition.org/show_bug.cgi?id=1888 looks like it might be okay.
http://bugs.dwscoalition.org/show_bug.cgi?id=1862 is theoretically straightforward.
http://bugs.dwscoalition.org/show_bug.cgi?id=1886 would mean a bit of delving into S2, but people can help you if you get stuck.
http://bugs.dwscoalition.org/show_bug.cgi?id=1845 is a bigger Styles one, if you're up for it.
http://bugs.dwscoalition.org/show_bug.cgi?id=1841 should be straightforward Perl copy/paste, if you want to try it.
http://bugs.dwscoalition.org/show_bug.cgi?id=1813 would need a bit more styles knowledge - how good are you with S2?

If you're looking for things to do, the other easy beginning things are writing specs, and commenting on other people's. (Look for the needs-spec? flag in Bugzilla.) Also, yvi did an explanation of how to review patches here, which is a good way of getting to know the system without actually needing to understand Perl.

[pauamma]

Something like:

$out .= LJ::ehtml(join ', ', sort { $a cmp $b } map { $_->{name} } (values %$tags)[0..9]);

if you want the first 10 without sorting, or:

$out .= LJ::ehtml(join ', ', (sort { $a cmp $b } map { $_->{name} } values %$tags)[0..9]);

if you want the first 10 sorted by the name field.

(Also, added the missing comparison function to your sort, assuming you want string ordering. Adjust as needed.)

[denise]

FYI, I totally guess on the effort, so if anyone thinks that I've misguessed it, feel free to change it! I never mind.

[yvi]

http://bugs.dwscoalition.org/show_bug.cgi?id=168 is evil. Anyone got any ideas on how to make the preview happen? The code is confusing me because I can't seem to find out how update.bml calls the preview. Or maybe I see it, but just don't understand.

[pauamma]

I thought 405 was for all strings, not just FAQs? Or are you speaking of another redesign? (Which I agree badly needs doing too, but maybe unrelated or only loosely related?)

[cesy]

168 does look evil, but I guess you meant 1685 ;)

[yati]

I'm pretty ok with S2, actually. 1882, 1862 and 1886 all look like something I should at least try! Hmm. 1813 seems like something I could do, but would need time since it looks like it needs separate fixes for all the layouts.

[yvi]

Ouups. New link: http://bugs.dwscoalition.org/show_bug.cgi?id=1685

[janinedog]

My assigned bugs:

http://bugs.dwscoalition.org/show_bug.cgi?id=712

This is something that's been sitting for a long time because I want to work on it with Mark. It's going to require lots of effort to make everything work once the CSS files are switched around, I'm pretty sure.

http://bugs.dwscoalition.org/show_bug.cgi?id=1526

Uh...I thought this was just waiting commit, but now I see I actually should make a patch to tropo-red for it. Oops. I can do that.

http://bugs.dwscoalition.org/show_bug.cgi?id=1692

Yeah, I need to redo the patch here. I will! I just keep forgetting.

[afuna]

Basically, update.bml uses JS to submit the form /preview/entry.bml, which opens in a new window.

But I'm thinking now... maybe what you want is something like how the comment preview does it, instead of how entry preview does it.

Comment preview: no javascript; you submit the form as a preview, run cleanhtml and whatever formatting and print it out above; print the original form again below.

[cesy]

I am looking forward to 1692. More inter-site stuff is good.

[yvi]

Hmmm, yes, that sounds like it would make more sense. No JS is alwas good and as far as I can see, the comment spellchecking is also easier?

[afuna]

Yeah, it's not as persnickety as a JS implementation would be, I think. Also likely to work for more browsers *g*

[afuna]

Hmmm. I'm not sure, TBH! The main difference between edit tags and the tag cloud is that edit tags uses the select form element. So I think you could base your approach on it, but if it's using an onchange handler , you'll need to make sure to be using an onclick.

(I haven't looked closely at the implementation)

[jadelennox]

ironically, when I picked up the latest but I did, it was because I wanted something small so that I could get back into the swing of things and finish my bigger accessibility bugs. And in my new bug turned into this whole story about hooks and got much bigger.

I will set myself a goal of getting at least one of them submitted this weekend. Some of the accessibility things are just too big-picture and overwhelmed me. I might just need some handholding in IRC. Maybe if rb is feeling up to it I can ask for some cheerleading.

[cesy]

*helps cheerlead*
Accessibility is good. Which ones are you working on?

[yvi]

Hmmm, turning out to be not that easy :/ There's LJ::Talk->make_preview , but it needs a talkurl.

I am wondering whether what faqedit does might be a good idea.