Code tour, Sep 1 - Sep 8

[yvi]

Good morning/day/afternoon/evening/night Dreamwidth! My name is Yvi and I will be your week's tour guide. This week was a slow-ish week with 17 bugs getting RESOLVED FIXED. But we have some shiny in there, so follow me. Most of these are not yet live on the site.

Bug 166: implement watch groups
Category: Misc Backend
Patch by: mark
Description: Yes, this patch implements the alpha version of watch groups. With the next codepush, you will be able to test this new-from-the-ground-up implementation of reading filters.

Bug 178: implement admin/impersonate.bml as dw-free
Category: Site Administration
Patch by: afuna
Description: Livejournal has a feature where site admins can log in as a user to troubleshoot is something is really wrong. This feature is in Livejournal's non-open source part, so we had to implement it ourselves. Don't worry, this isn't going to be regularly (or even often, I suppose) used and any instance of it being used will be logged.

Bug 197:Drop tables adopt and adoptlast, which aren't use anywhere in the code
Category: Misc Backend
Patch by: kareila
Description: We are doing a lot of cleanup and this removed a lot of unused tables from the database.

Bug 1448: Add style for sitescheme-wrapped views to replace views handled in S2
Category: Style System
Patch by: exor674
Description: I cannot say I understand this with confidence, but I think it lays the foundation for rendering sitescheme pages in S2.

Bug 1610: birthday sort order needs fixing
Category: Misc Backend
Patch by: kareila
Description: The birthday order on the homepage was shown incorrectly. This is now fixed.

Bug 1614: Layout: Sunday Morning
Category: Style System
Patch by: afuna
Description: New layout by revolutions

Bug 1616: Lacks function to return a list of sorted trust groups
Category: Misc Backend
Patch by: kareila
Description: There were some problems with returning the trust groups the way the user sorted them on their filter setup page. After a few patches, that is now fixed.

Bug 1635: get_proxy call is not safe if xmlrpc call failed
Category: Crossposter
Patch by: exor674
Description: Um. This does something. In the code. With the crossposter. That failed before. *handwaves and <3 exor674*

Bug 1661: Themes: Basic Boxes, ColorSide, Stepping Stones, Modish
Category: Style System
Patch by: afuna
Description: Lots and lots of themes for our existing layouts by branchandroot.

Bug 1708: Basic Boxes calendar row collapses
Category: Style system
Patch by: kareila
Description: Bugfix that fixes the height of calendar rows in Basic Boxes.

Bug 1717: Userhead malaligned when selecting style
Category: Misc UI/Frontend
Patch by: kareila
Description: The userhead alignment was off on http://www.dreamwidth.org/customize/ when working as a community. It now aligns better.

Bug 1730: Theme selector scales poorly
Category: Style System
Patch by: afuna
Description: When changing the text size, the style selector began to 'hide' the buttons under the preview images. afuna forced it to behave.

Bug 1731: Layout: Bases
Category: Style System
Patch by: afuna
Description: New layout by sven.

Bug 1732: Themes: Pumpkin Juice, Cotton Candy Dust, Lime Cherry, Earth and Sky, Manila Envelope
Category: Style System
Patch by: afuna
Description: Themes for existing layouts by zvi.

Bug 1740: remove support for legacy dversions
Category: Misc Backend
Patch by: kareila
Description: Parts of the code were still supporting very old versions of the LJ database. We are now only supporting from dversion 8 onwards, which is where DW branched off. If people migrate from LJ code to DW code, they will now first need to use the latest LJ code. At least that's how I understand this.

Bug 1741: Read page can breakc when viewing it while logged out
Category: Misc UI/Frontend
Patch by: afuna
Description: The reading page of DW users was not loading when the person viewing it was logged out and one or more posts on the reading page had screened comments. This fix is already live to the best of my knowledge.

Bug 1758: /admin/misc/runoffpoll.bml can be removed
Category: Misc Backend
Patch by: kareila
Description: an unused BML page for run-off polls, as they were used in the LJ elections. Since we don't have that, we don't need to retain this page.

Comments

[afuna]

It's funny, but we have lots more commits than what showed up here. However, they won't show up in the code tour, because they're ongoing meta-bugs (e.g., the work to clean up tests, where everything is getting dumped onto that one bug *g*)

[yvi]

*nods* That also means that we have only four of the people who had patches accepted in this code tour.

We are working, people! We are just doing very strange code cleanup :)

[afuna]

*grins* Yes!

(Which will ensure less bugs in the future *____*)

[owl]

Hurrah for refactoring!

[owl]

I could have sworn I remembered deleting runoffpoll.bml months and months ago. Perhaps just talked about it in channel...

[afuna]

There was a bug where it was brought up, but the patch to delete it was never done there *g*

[owl]

I think I had a patch for it when I was doing cleanup in /admin, but obviously it never got committed :)

[afuna]

Oops. Oh dear. I hope that no other similar patches suffered that fate.

[owl]

I was doing a lot of stuff for that bug, so I think I may have left it till its own ticket got opened and then forgotten about it *oops*

[cesy]

1448 is apparently needed for things like having /icons be viewable in different styles, and /profile in your style, and things like /tags in a sitescheme/light style. So that will be shiny when it's all working.

I found nitpicky holes in the watch groups already, of course, but that's because it's still in alpha. Watch groups are very exciting.

tl;dr - shiny!

[the_shoshanna]

Yes, this patch implements the alpha version of watch groups.

Eeee!

[nozdormu]

Awesome job guys.

I do hope the userinfo HTML thingie gets fixed ASAP though.

[cesy]

Which bug is that?

[nozdormu]

I'm not sure on any numbers but If you look at the userinfos, normal HTML coding doesnt work. I used the exact same layout code from my Insanejournal(malygos) though different picture and you'll see what I mean if you compare what the layout is supposed to look like(on insanejournal/livejournal) and what it looks like on here.

[cesy]

Ah, do you mean this known issue in the FAQs?

You could try changing the HTML, given what the FAQ says about CSS. For instance, change
<td bgcolor="#ffffff"><font color="#002BCA" family="Arial" size="1"><small>The Spellweaver</small></font></td>
to be
<td style="background-color: #ffffff; color: #002BCA; font-family: Arial; font-size: small;">The Spellweaver</td>

If you're still having trouble, either ask the person who made the code to update it to modern tags that aren't deprecated, or just reply here and I can try and fix the rest.

[nozdormu]

hmm...I'll copy/paste and see what it does. :O

[nozdormu]

Doesnt seem like it did anything and the profile maker doesnt frequent LJ much anymore so getting in contact with her might be difficult. If you could fix it, it'd be awesome. The code on IJ is the same(save for what I copy/pasted) as the one here. So I guess just edit this one so it appears normally. From there I can probably fix it on my communities and such.

[cesy]

Hmm. If that doesn't fix it, I'm not sure what will. Maybe try opening a Support request? What I said should have fixed that bit of text, even if it didn't fix any of the rest.

[turlough]

Reading filters, yay!!

Description: Um. This does something. In the code. With the crossposter. That failed before.

*giggles*

[baggyeyes]

Description: Um. This does something. In the code. With the crossposter. That failed before.

I vote yvi as Code Tour writer based on the above. I understood this perfectly.

[yvi]

And how could anyone not get that from my description! It was perfectly clear, after all.

[exor674]

Heh, my fixes are either scary complex huge, or one or two lines and "... huh?"

[mark]

Yes! You are our resident "not afraid of anything, willing to dig around in the darkest corners of anything to make it work" coder. I'm so happy you decided to be a part of Dreamwidth.

[baggyeyes]

Exactly!