dw_dev | Code tour: 2017-05-01 to 2017-10-28 (whoops)

Warm welcomes to

akpdw!

These fixes are not yet live, but will be included in the next code push.

Issue 1886: weird FAQ rendering issue (pull request)
Category:
Patch by:

pinterface
Description: Helpfully, the FAQ pages were styled so that if you tried to include an unordered list (bulletpoints) in a FAQ, it would always display as an ordered (numbered) list. This was mildly exasperating, made FAQs slightly more confusing, and was as it turns out straightforward to fix. Hurrah!

Issue 2156: When uploading images, display most recent upload at top (pull request)
Category: File/image hosting
Patch by:

rshatch
Description: Just like the icon management and upload page, the page for uploading images to Dreamwidth's image hosting service will show the most recently uploaded at the top, not the bottom, for easier editing and management!

Issue 2157: converting OpenID pages, part 2 (pull request)
Category:
Patch by:

kareila
Description: Back in the days of LiveJournal, the pages you actually interacted with were largely coded in BML ("Best Markup Language" or "Brad Markup Language", depending on whether or not you were asking Brad). When LJ launched, this was pretty great! However, the codebase is now old enough to vote, technology has matured, and Dreamwidth is very slowly replacing BML with more modern page architecture. This is another couple of steps down that particular winding garden path.

Issue 2159: some themes need adjusting for journal title now being a link (pull request)
Category:
Patch by:

kareila
Description: Some CSS styling was being applied in a way that looked super odd in a small number of styles! Now it looks less odd and more like what you might... expect to happen.

Issue 2166: [#2166] Escape \@s instead of turning them into [Unknown site tag] tags (pull request)
Category:
Patch by:

josh-berry
Description: Dreamwidth has, for some time, permitted the use of Markdown for formatting entries! Dreamwidth has a bunch of its own custom HTML, which lets you produce things like

kaberett straightforwardly and easily! In DW-flavoured Markdown, "@kaberett" gives you...

kaberett. Which is brilliant, and handy, up until you compose a post using Markdown, in which you want to talk about @-replies and @-replying. At which point Dreamwidth, in the way of all code that tries deperately to be helpful and mostly ends up looking like an overeager and incompetent golden retriever puppy, decides that you're talking about the Dreamwidth users _replies and _replying, and there wasn't any way to gently inform DW that that isn't quite what you meant. Going forwards, you'll be able to discuss @-reply without accidentally roping poor _reply into the conversation by escaping the @: "\@-reply" will show up in your post not as "_reply" but as "@-reply", like you wanted all along.

Issue 2170: search all language directories for deadphrase files (pull request)
Category:
Patch by:

kareila
Description: Backend tidy-up! Because of the charming eccentricities of Dreamwidth's translation system, at least some of the time it's a good idea to add text strings that are no longer in use (because they had a typo, or the world changed enough that they needed rewriting, or...) get added to deadphrases.dat, a graveyard of sorts that helps the codebase work out whether it needs to double-check that it's saying the right thing to people. Only there's... more than one phrase graveyard, and the codebase was only consulting the inhabitants list of one of those graveyards. Now it will make sure that all residents are accounted for.

Issue 2171: whitelist embeds from NoiseTrade (pull request)
Category:
Patch by:

kaberett
Description: For security reasons, only certain types of embedded media are allowed on Dreamwidth. Once a site's been checked and cleared, it gets added to a whitelist and media embeds from it Just Work, in theory. In theory, this is a nice simple task that people new to the Dreamwidth codebase can do to familiarise themselves with how everything works. In practice I've been doing volunteer dev work for this site for about five years, this is the first whitelisting bug I've ever tackled, and I found it inexplicably difficult. WHO KNOWS. Maybe the fix will even work!

Issue 2172: missing space in text string about discretion-advised communities (pull request)
Category:
Patch by:

kaberett
Description: Exactly what it says on the tin: there was a missing space in a string. I was trying to remember how my Dreamwidth development environment worked after A Bit Of A Break, so trying this seemed like a good idea... and now, when you try to view a discretion-advised community, there's correct punctuation.

Issue 2174: see_request should only print media usage for personal accounts (pull request)
Category:
Patch by:

kareila
Description: ... because OpenID accounts can't use Dreamwidth's image hosting. Or, to back up slightly more usefully: see_request is a bit of code that handles (some of) what people see when they go to look at Support Requests: along with information about which beta features someone's opted into, volunteers get information about how much of their image storage allowance the person asking the question has used up, which can really streamline the troubleshooting process! However, as OpenID accounts can't use Dreamwidth's image hosting, there's no point taking up an extra line of screen space on requests submitted from OpenID accounts. So the code's been modified so that... it won't.

Issue 2178: Add next/previous entry shortcuts to reading/entry pages (pull request)
Category:
Patch by:

akpdw
Description: OKAY SO THIS ONE IS EXCITING. Post code-push, if you opt in, you'll be able to swipe to next and previous entries on Entry, Reading and Recent pages, using either a touchscreen or a mouse! Again, you will have to opt in via your site settings, this is not going to sneak up on you all at once! (This won't work unless you have Javascript enabled.)

Issue 2179: Check whether IP::Country::Fast is still needed (pull request)
Category:
Patch by:

pinterface
Description: No. It wasn't. Now it isn't in the code any more. (It was used by LiveJournal when Dreamwidth forked, for the Writer's Block feature, but that isn't actually very relevant!)

Issue 2184: Update user profile Delicious link (pull request)
Category:
Patch by:

kaberett
Description: ... because del.icio.us moved where they lived on the Internet and it's nice when links to your pages on external services work automatically! They will, again, soon.

Issue 2220: Add S3 support to BlobStore (pull request)
Category:
Patch by:

zorkian
Description: This is Arcane Backend Magic to do with Dreamwidth's image hosting, and it is beyond my ken.

Issue 2224: Don't proxy RSS images (pull request)
Category:
Patch by:

zorkian
Description: Did you know you can get an RSS feed of your Dreamwidth posts? You can get an RSS feed of your Dreamwidth posts! But: these days, Dreamwidth can only be accessed over HTTPS, not (the less secure) HTTP. Which is great for a lot of reasons, but means that images posted using an HTTP source get fed through an image proxy, to make sure they don't contain malware or what-have-you. Which is also great! But... not quite so useful or relevant when where the images are going to end up is displayed on an arbitrary external site: it won't work very well, and it's unnecessary. Going forward, it won't happen.

Issue 2225: Advertise http://openid.net/signon/1.1 via Yadis (pull request)
Category:
Patch by:

alierak
Description: If you are using version 1.1 of something it is polite not to tell the entire world that you're using version 1.0. It's also a good idea to remove code that lets people decide to use actively insecure options. Here,

alierak neatly addresses both of those related problems at once!

Issue 2229: Handle image proxy links with URL parameters
Category:
Patch by:
Description: You may or may not be aware of the fact that you can filter, for example,

dw_suggestions to view only the posts I've made! The URL to get to that has a "?poster=kaberett" lump on the end. That lump is URL parameters, and lets specify... a whole variety of things, depending on what you've got around to defining. Which is great, until you have options stuck on the end of an image at an HTTP URL that somebody's trying to post to Dreamwidth, so (see above) it gets fed through Dreamwidth's image proxy, which Does Not Cope. Turns out this is a configurable option that can be tweaked live, so images are already showing up in