Code tour, 8/24-8/31

[foxfirefey]

Hellooooo Dreamwidth! I'll be your code tour guide this week. We set the status on 15 bugs this week to FIXED, and all of those patches are live due to pushes from the server move.

Bug 671: Remove journal link from notification for being circled by openid users
Category: UI/Frontend
Patch by: wyntarvox
Description: This fix removes the journal link from the notification of being circled by OpenID users; since OpenID accounts can't post, there's no reason to have it there.

Bug 706: Comment headers should indicate if a comment is screened
Category: UI/Frontend
Patch by: yvi
Description: This is a little thing to make it easier to tell if a comment is screened without squinting at an icon, or relying on a journal's style.

Bug 724: Deal with "lj" in opt_ljcut_disable_* options
Category: Cleanup
Patch by: kareila
Description: We're trying to remove "LJ" from as many places in the code we can; this is part of that process.

Bug 1354: clean up cgi-bin/LJ/User.pm
Category: Bugfix
Patch by: kareila
Description: This patch fixed an instance where a function would only work with a user instance, when it also needed to work with hashes.

Bug 1525: privilege function cleanup
Category: Code cleanup
Patch by: kareila
Description: This is another instance of us trying to clean up the code; we're moving from a function LJ::check_priv() to a more object oriented oriented $remote->has_priv().

Bug 1532: remove pre-clustering support
Category: Code cleanup
Patch by: gchick
Description: We don't have any URLs that are on pre-clustered code, so we're killing the function LJ::get_newids that updates those old URLs.

Bug 1600: Calendar in Drifting Blue sometimes loads strangely
Category: Styles bugfix
Patch by: av8rmike
Description: This is a CSS fix to keep Drifting Blue's calendar from being wonky.

Bug 1648: FAQ preview escapes HTML
Category: Site admin
Patch by: yvi
Description: This helps the people making the FAQs; previously, they would escape HTML instead of interpreting it, so the people previewing a FAQ before they saved couldn't actually know what it would look like.

Bug 1655: Theme: Blasted Sands
Category: Styles
Patch by: piranha
Description: Blasted Sands is a new color theme for Negatives and piranha made a preview image for it!

Bug 1664: Theme: Golden Ticket, Subtle Almond, Black or White, White or Black (Transmogrified)
Category: Styles
Patch by: piranha
Description: These are new color themes for Transmogrified; the patch adds the preview images for them.

Bug 1688: Layout: Blanket
Category: Styles
Patch by: afuna
Description: afuna made this patch for this new layout by sforzinda, and piranha made the preview image for it.

Bug 1707: Basic Boxes Green has two color_module_titles
Category: Styles bugfix
Patch by: kareila
Description: This just removes an extraneous duplicate property line.

Bug 1709: Basic Boxes Eggplant
Category: Styles
Patch by: kareila and piranha
Description: This is an alternative theme for Basic Boxes by kareila with a preview image by piranha

Bug 1715: Errors in Stepping Stones layout
Category: Styles bugfix
Patch by: afuna
Description: Some minor tweaks for the Stepping Stones layout--a footer color setting, and margins for modules.

Bug 1733: /admin/sysban doesn't work
Category: Bugfix
Patch by: exor674
Description: Whoops! This patch fixed a bug to let the admin sysban page work again.

Comments

[afuna]

Quick note: The new layout, Blanket, is in the featured list. You can see all the new themes with http://www.dreamwidth.org/customize/?cat=all.

And we have several more new layouts, awaiting another set of eyes to go over them before we commit, but they should be coming soon!