dw_dev | Code tour, 26th June

Code touuuuuuuuuuuuuuuuur. Welcome to

dteklavya, a first-time contributor! Everybody hang onto your hats, because there ain't no getting offa this train! (Clearly I have been playing too much FF7 lately. I blame

denise.)

Issue 1355: OpenID logins from providers that use HTTPS URLs are broken (pull request)
Category:
Patch by:

kareila
Description: We did some magic with an OpenID module upgrade, and one of the argument formats changed. This wraps it in the expected shibboleths, so now you can login with OpenID again.

Issue 1381: Proxy causes system to run out of file descriptors when left running too long
Category:
Patch by:

afuna
Description: We switched to using HTTPS to serve images. The proxy had a couple of glitches - this was one of them. It's been rebuilt to do the right thing, and should be functional RIGHT NOW!

Issue 1402: Status field on support history page less useful than it might be (pull request)
Category:
Patch by:

me-and
Description: So there's a page that shows all of your support requests. It used to only say "open" or "closed". Given that our support requests have a couple more status fields than that, it might be a nifty idea to show them.

Issue 1443: Restore beta update page strings (pull request)
Category:
Patch by:

me-and
Description: Whoops! We were a bit overzealous with the code machete. This restores some things that are still being used.

Issue 1447: ProcessSub failing with least helpful error message ever
Category: Back-end
Patch by:

zorkian
Description: A module needed to be upgraded! And lo, so did it come to be, and cryptic error messages vanished.

Issue 1451: Site Options faqcat's faqs have gone missing (pull request)
Category:
Patch by:

afuna
Description: Nifty things - the FAQ pages now use TT! Unfortunately, one of our category keywords was the same as a reserved variable name in TT. Category variable names have now been moved to a place where they won't get confused.

Issue 1452: HTTPS proxy failing after code push
Category:
Patch by:

zorkian
Description: We switched to using HTTPS to serve images. The proxy had a couple of glitches - this was one of them. It's been rebuilt to do the right thing, and should be functional RIGHT NOW! (welcome to deja vu! Two issues with the same underlying root thing. :)

Issue 1453: site search over-escaping characters (pull request)
Category:
Patch by:

kareila
Description: We used to use BML. BML had to be told to escape characters. Now we use TT! It does the escaping automagically, but we hadn't removed the manual escape, so things were happening twice when they oughtn't.

Issue 1456: RTE lists user sites multiple times in user link dropdown (pull request)
Category:
Patch by:

afuna
Description: A consequence of the new code that provides "short" site names - we were populating the dropdown with one entry for both the full name AND each of the short descriptors. Now it should only display once per site.

Issue 1468: let LJ::OpenID use the paranoid user agent on dev servers (pull request)
Category:
Patch by:

kareila
Description: Part of the reason that Issue 1355 made it to production was that our Dreamhack servers were using a different configuration than the live ones. This fix removes special-casing for dev servers, so they should behave like live.

Issue 1473: fix failing tests (pull request)
Category:
Patch by:

kareila
Description: Short sitenames are awesome! This tells the test suites about their existence so that they don't pitch a wobbly.

Issue 1478: Blank space missing after comma in credit module (pull request)
Category:
Patch by:

dteklavya
Description: WELCOME TO DTEKLAVYA! This is a tiny-but-awesome styles fix for the credit module.

Issue 1480: Beta Update page: new "use current time" preference persists when editing entries (pull request)
Category:
Patch by:

kaberett
Description: So, when I implemented the sticky ticky for the last code push, I didn't consider what it being sticky would do to editing entries. Since most people usually don't want to use the current time for an entry they're editing, this fix makes it so that the edit page defults to untickied. (The box still exists, so if you want to, you can! It's just not the default.)

Issue 1481: "ContextualPopup-trigger" class added to icon URLs from non-DW sites (pull request)
Category:
Patch by:

afuna
Description: A while back we changed the URL that DW userpics are accessed through, but kept the old style for backwards-compatibility (and also not asking users to change all of their old userpic URLs in entries/comments!) There was a bit of magic to show the hover menu on userpics with both URL styles. Alas, the site was trying to apply "old" styling to userpic links from other sites (especially LJ/IJ), and falling over as a result. Now it will only try to do magic on Dreamwidth-based userpics.

Issue 1483: compass compile errors on Unicode chars (pull request)
Category:
Patch by:

kareila
Description: We like UTF-8! Some of our files contain actual UTF-8 characters, which was causing slight issues if a dev environment variable was set to something not UTF-8 based. The files with the Unicode characters now specifially have a "hey this file has Unicode!" header at the top of the file to make the compiler do the Right Thing.

Issue 1488: new and exciting Perl warning in Apache log on dreamhacks after upgrade (pull request)
Category:
Patch by:

kareila
Description: We upgraded...something (I'm not sure whether it was Perl or Apache. Possibly both!) and it revealed a slight bug in the way we were using an iterator. The new version not only doesn't throw errors, it's also cleaner code! Win.

Issue 1491: Add GitHub to user profile page (pull request)
Category:
Patch by:

me-and
Description: So you have a Github account! And you'd like to tell people about it on your Dreamwidth profile? NOW YOU CAN.

Issue 1492: Use obvious Markdown file extension for README (pull request)
Category:
Patch by:

me-and
Description: We don't use the "master" branch (for Historical Reasons), and there's a README file on Github that explains why. It didn't have a filetype associated, though, so Github wasn't parsing the file with Markdown syntax. Now it will.

Issue 1498: Refactor text on beta features page (pull request)
Category:
Patch by:

kareila
Description: The TT-ization continues! This time it's for the text strings that are about our Various And Sundry beta feature options. :)

19 total issues resolved
Contributors:

afuna,

dteklavya,

kaberett,

kareila,

me-and,

zorkian

Flat | Top-Level Comments Only

CODE TOUUUUUUUUUUUUUUR

(said, a la The Middleman, like ART CRAAAAAAAAAAWL)

Clearly I have been playing too much FF7 lately. I blame denise.

I regret nothing. :D

Thanks for the code tour!

Just finished playthrough of the main game, working on gearing up for Emerald WEAPON. Punching the Abomination in the face with Tifa may have been involved. ;D