Code tour, 8/4-8/10

[denise]

This week we resolved 43 bugs, all of which were resolved FIXED. One's a security issue, which we decline to specify so other sites can have a chance to take the patch first. Welcome this week to new contributors carynb, badgerbag, and chemicallace.

None of these patches will be live until the next code push.



Bug 164: investigate LJ::EventLogSink, remove?
Category: Cleanup
Patch by: denise
Description: This patch removes old/unused code for the purpose of reducing the amount of cruft in the codebase.

Bug 199: Remove TxtLJ backend
Category: Cleanup
Patch by: denise and kareila
Description: TxtLJ, the function to interact with the site via SMS shortcode, is something that we don't have because maintaining a SMS shortcode is complicated and expensive to set up, not to mention expensive on a monthly basis. It's highly unlikely we'll be able to support it anytime soon, so this patch removes the code that allows for it so we don't have to keep updating stuff that we can't really test.

Bug 211: Random Account Sponsorship/Paid Account Fairy
Category: Shameless money grubbing
Patch by: janinedog
Description: This patch allows people to make payments to us without a particular user in mind. The system will then select a random active free user to receive the payment. (You'll also be able to opt out of receiving payments in the Privacy tab of the Account Settings page.)

Bug 421: fix gmail threading on comment emails
Category: Notifications
Patch by: janinedog
Description: This patch adds the journal name and the entry number into the subject of comment notification emails in the hopes that it will make GMail thread notifications properly.

Bug 492: color previews on /manage/circle/add
Category: Usability
Patch by: carynb
Description: This fixes the color-picker on the Manage Circle page to function properly, and is carynb's first patch! Congratulations, and thank you!

Bug 548: Webserver error logs
Category: Cleanup
Patch by: kareila
Description: Fixes more errors that show in the webserver logs but don't cause problems on the site itself.

Bug 632: Provide a "contact us if you can't use this" string under all CAPTCHAs
Category: Accessibility
Patch by: wychwood
Description: Captchas -- the "prove you're a human" test -- are necessary for spam control, but they're an accessibility nightmare for people who have any kind of different setup or problems processing visual or audio noise. This patch makes it so wherever there's a captcha, there's also a message that people who have trouble solving captchas for any reason should contact us and we can see what we can do to make alternate arrangements.

Bug 721: Change lj- headers for email posting to site-agnostic forms
Category: Cleanup
Patch by: kareila
Description: This changes the lj-userpic, lj-tags, lj-mood, lj-music, lj-comments, and lj-security headers for use when posting by email to post-userpic, post-tags, post-mood, post-music, post-comments, and post-security. The old form will still work for backwards compatability and for crossposting-via-email to multiple sites.

Bug 790: overhaul manage/circle/edit (part one)
Category: Usability/redesign
Patch by: ysobel
Description: This is the first half of an absolutely awesome redesign of the Manage Circle page, in which the page gets a major facelift to be more modern and sleek-looking. (Also, get rid of the REALLY BRIGHT red and green, because, yes.) Special note: this page is now 1000% more usable by screenreaders and associated technology, because oh my did that page need some help.

Bug 952: crossposter: importing crossposted entries
Category: Interoperability
Patch by: exor674
Description: This patch integrates the importer and crossposter so that entries that were crossposted aren't reimported later if an import is run again.

Bug 970: site-embed == tribbles
Category: Bugfix
Patch by: kaisa
Description: This fixes a bug with the site-embed tag that was causing multiple extra lines to be added every time you edited a post with an embed tag.

Bug 1163: crossposting messages change in inbox if external site is deleted
Category: Bugfix
Patch by: kareila
Description: This patch fixes up the inbox so that error messages for no-longer-set-up crosspost accounts aren't a jumble of code.

Bug 1234: Overeager offer to delete old S2 layers owned by system
Category: Site administration
Patch by: kaisa
Description: This patch fixes up the script that a site admin uses to upgrade the site's code.

Bug 1379: strip unused functions from .pms in cgi-bin
Category: Cleanup
Patch by: denise
Description: This strips unused code out of the backend functions that run the site.

Bug 1398: Link Manage Tags page from Manage Communities page
Category: Usability
Patch by: badgerbag
Description: Adds a link to the manage tags page on the manage communities page. Also, this is badgerbag's first commit! Congratulations and thank you!

Bug 1412: S2 needs a layout credit module
Category: Styles backend
Patch by: afuna
Description: This adds an author credit module to S2, so that we can credit people who are making pretty styles for us.

Bug 1432: Tabula Rasa 2-col-right, 3-col-right broken in IE7
Category: Styles
Patch by: afuna
Description: This patch changes the CSS in the Tabula Rasa theme so that it works properly in IE7.

Bug 1458: Contrast on Transmogrified footer insufficient
Category: Styles
Patch by: chemicallace
Description: This fixes up the CSS for the Transmogrified layout to make the footer a little easier to read.

Bug 1528: English-strip inbox/compose.bml
Category: Site text cleanup
Patch by: chemicallace
Description: This patch English-strips the Compose Private Message page in the inbox so other sites running the Dreamwidth code can translate it if they want. It's also chemicallace's first commit -- congratulations and thank you!

Bug 1530: S2 page summary module doesn't show threaded comments
Category: Styles backend
Patch by: kareila
Description: This adds the comment count to the summary module that appears in the sidebar of various journal layouts.

Bug 1533: Sysban query page (for talk_ip_test and perhaps others) suddenly lacking save button
Category: Display bugfix
Patch by: denise
Description: This patch tweaks the display of one of the admin pages so that the save button (which had crept off the side of the page) is visible again.

Bug 1542: remove unused files from htdocs/stc
Category: Cleanup
Patch by: kareila
Description: This removes more unused code, in this case a bunch of various CSS files that aren't used anywhere on the site.

Bug 1544: tropo site menus out of alignment
Category: Bugfix
Patch by: kareila
Description: This fixes a problem with the HTML used to render the mood list page, which was causing the site menus to scoot over by about a full em width.

Bug 1545: Instance of "Friends" when using incorrect reading page URL syntax
Category: Bugfix
Patch by: chemicallace
Description: This changes the error message that shows if you use the wrong URL syntax to view your reading page to get rid of references to 'friends'.

Bug 1548: remove HostedComments
Category: Cleanup
Patch by: denise
Description: Removes more unused code. (I don't think I actually coded anything this week, just removed a lot of unused stuff...)

Bug 1550: remove LJ::Widget::StyleAlwaysMine and associated code
Category: Cleanup
Patch by: denise
Description: More code cleanup!

Bug 1552: fix "can't call method is_locked" error on login.bml
Category: Bugfix
Patch by: denise
Description: Okay, I lied, I did fix a few bugs. This one's a fix for a bug we introduced last week when updating some code to use more modern references: if the account you were trying to log into didn't exist, it would error.

Bug 1554: remove secret question support
Category: Cleanup
Patch by: yvi
Description: Secret question support wasn't fully integrated in the code (we branched just as it was being introduced, I believe, and we never finished picking up the code) and introduces as much of a security problem as it's intended to fix, so this patch removes it.

Bug 1555: remove horrible old siteschemes
Category: Cleanup
Patch by: denise
Description: More cleanup! This gets rid of three really horrible old siteschemes (from, like 1999 or so). They weren't selectable, so you'll never know the difference.

Bug 1558: Sample invite code distribution broken
Category: Bugfix
Patch by: kareila
Description: This patch fixes the method for distributing invite codes (which I broke last week with my patch to modernize various code references -- kareila spent a lot of time this week cleaning up after me, oops!)

Bug 1560: make RSS feeds for specific tags more discoverable
Category: Usability
Patch by: kareila
Description: This adds in links for a few more syndicated feeds in each journal -- the tag feed already existed, but only a few people knew about it!

Bug 1562: Upgrade Bugzilla to 3.4.1
Category: Admin
Work by: mark
Description: This ticket was to upgrade our version of Bugzilla to the most recent version released.

Bug 1564: Layout: Basic Boxes Green
Bug 1565: Layout: Modish Scarlet
Bug 1566: Layout: ColorSide Nadeshiko
Bug 1567: Layout: Boxes and Borders Gray
Bug 1568: Layout: Stepping Stones Purple
Category: Styles
Patch by: afuna based on work by branchandroot
Description: These patches add new styles that will be available for use with the next code push!

Bug 1569: Navbar uses inconsistent URL for read page
Category: Bugfix
Patch by: kareila
Description: This fixes a problem where the navstrip was using "read" in some places and "read/" in others, causing some browsers to treat them as two separate pages for the sake of counting up most-frequently-accessed pages.

Bug 1583: Modify Layout of Page to Edit Linkslist
Category: Display
Patch by: wychwood
Description: This patch widens the box for specifying the priority of links on the links list so people can see the full number if they input more than 2 digits.

Bug 1591: add link to discussion entry into autoposted suggestions text
Category: Usability
Patch by: yvi
Description: This modifies the Suggestions generator so that the Bugzilla posting contains a link back to the original suggestion.

Bug 1592: AJAX-y stuff broken
Category: Bugfix
Patch by: afuna
Description: In another case of people having to clean up after me this week, this fixes some problems with the customization area that I accidentally introduced while I was removing the .bml from the end of links on the site.

Bug 1595: Entry management icons can push quick reply div to the right
Category: Styles bugfix
Patch by: afuna
Description: This fixes a CSS problem that was causing some layouts to display the comment area incorrectly positioned.

Bug 1597: change class method calls to user method calls for ajax_auth_token
Category: Cleanup
Patch by: kareila
Description: This patch updates some backend code to call the right functions.

Comments

[yvi]

I am not sure whether to give this week's 'most wanted' award to afuna for the styles or to janinedog for the comment threading and paid account fairy.

Sorry, you two will have to share!

And \o/ for three new babydevs!

[afuna]

The styles award should more properly go to branchandroot, who did all the hard work. I just did a bit of wiring around the edges!

(Yay styles! Yay comment threading! Yay PAF! Yay new contributors \o/)

[yvi]

I saw the code. 'A bit of wiring around the edges' looks differently :)

*gives special award to branchandroot

[pantswarrior]

Gmail comment threading thing is AWESOME. I already wished I could make the kink meme I'm archiving move over here due to the comment character limits, but this makes me want to just club them over the head and drag them.

[helens78]

1555 cracked me up. I remember a horrible old sitescheme that looked like notepaper from back then, but I don't know what the other schemes would be!

[afuna]

http://www.dreamwidth.org/?usescheme=woais
http://www.dreamwidth.org/?usescheme=opalcat
http://www.dreamwidth.org/?usescheme=bluewhite

for your viewing pleasure :)

[helens78]

Oh, wow, "woais" is one I don't remember at all! But "opalcat" is what was around when I first started using the site, and then "bluewhite" -- I know it must have been around for a good long while before we got Dystopia, but I barely remember it. :)

[denise]

Side note: bluewhite is the scheme that's default for other sites using the LJ code, so you may have seen it on other LJ clone sites. (JF uses a version of it with only slight color shifts, for instance, and IJ used something very similar until recently.)

[helens78]

*was trying to avoid mentioning JF and its use of ancient stuff, but did remember that* ^_^

IJ's siteschemes are pretty great nowadays, for which I'm very grateful! I'm not there much anymore, but it's nice to have good siteschemes to work with. I'm still happiest with Celerity, though. *clings to it*