kaberett: A sleeping koalasheep (Avatar: the Last Airbender), with the dreamwidth logo above. (dreamkoalasheep)
kaberett ([personal profile] kaberett) wrote in [site community profile] dw_dev2015-06-25 11:21 am
Entry tags:

Code tour, 15 March 2015 - 23 June 2015

... GET ON THE CODE BUS.

This is batch the first of code tours for the code push coming toniiiiiiiiight.

Batch the second, of everything everyone at OSBridge has written since I started this one, coming up shortly...

Issue 660: updating landing page for screened comments
Category:
Patch by: [github.com profile] fhocutt
Description: This fixes two issues with the landing page after posting a screened comment, Issue 658 and Issue 659. What this means: link text (for viewing the new comment) has been made more descriptive (and thus more accessible to screen readers), and text describing who can see the screened comment has been made clearer.

Issue 683: Add 'Seamless' style by timeasmymeasure (pull request)
Category:
Patch by: [github.com profile] momijizukamori, [personal profile] timeasmymeasure
Description: A base style plus one colour theme, by [personal profile] timeasmymeasure!

Issue 688: Add new themes for Summertime style by ketsu (pull request)
Category:
Patch by: [github.com profile] momijizukamori, [personal profile] phidari
Description: A new theme for Summertime, by [personal profile] phidari!

Issue 693: Create nice month view for siteviews
Category:
Patch by: [github.com profile] momijizukamori
Description: We're in the process of getting rid of all the pages using BML (proper old-style markup) and replacing them with something newer and shinier. This was the last remaining view that could be styled by a journal, where the site-style view used BML. It is no more!

Issue 772: a few highly user-unfriendly error messages in talkpost_do.bml (pull request)
Category:
Patch by: [github.com profile] kareila
Description: If you were really unlucky and you were creating an OpenID account, you'd run into some extremely technical and extremely opaque error messages that were of no use to man or beast. These have been rephrased to make more sense.

Issue 786: Feeds won't accept HTTPS URLs (pull request)
Category:
Patch by: [github.com profile] anall
Description: WE BRIBED DRE WITH CUPCAKES AND SHE FIXED THIS FOR ME. Feed accounts pointing at an https url wouldn't work. Dre's changed how Dreamwidth pulls in content from feed accounts, and this now works! bruce_schneier_feed will update again, the Feeds support category will be less full of wailing and gnashing of teeth, and the Dre will be full of cupcakes. ALL SHALL REJOICE.

Issue 923: $r->connection->remote_ip removed on Apache 2.4 (pull request)
Category:
Patch by: [github.com profile] anall
Description: Having updated Apache it was necessary to update a few parts of the code where a deprecated construct was used. There isn't backwards compatibility but everything is now up-to-date and working.

Issue 945: track multiple email addresses on emailed-in support requests (pull request)
Category:
Patch by: [github.com profile] pauamma
Description: If you e-mail in a support request, get a response, forward the response on to a friend, and your friend replies with more information... then a reply from support will go only to you and not to your friend. This isn't ideal! So for e-mailed in support requests (and only e-mailed in support requests), every time someone responds using proper auth codes their e-mail gets recorded, and all future responses get sent to all associated e-mail addresses in turn.

Issue 1079: Investigate/remove dead code in views/multisearch.tt and cgi-bin/DW/Controller/Search/Multisearch.pm (pull request)
Category:
Patch by: [github.com profile] me-and
Description: There was redundant code! There is no longer redundant code. It has been removed with extreme prejudice using the code machete. Hurrah.

Issue 1080: treat - and _ interchangeably in forwarding email addresses (pull request)
Category:
Patch by: [github.com profile] pauamma
Description: Some account levels come with @dreamwidth.org addresses. user-name@dreamwidth.org and user_name@dreamwidth.org are now treated interchangeably, where previously user_name@ worked and user-name did not (and this was understandably confusing!).

Issue 1096: Code tour tool
Category:
Patch by: [github.com profile] afuna
Description: When Bugzilla was how issues were tracked, we had a code tour tool that generated a template for the tour given start and end dates. When the move to Github Issues happened, for a while no code tours occurred because we had no similar tool. NOW WE DO and consequently code tours have got easier again HURRAH.

Issue 1217: Fix even more tests. (pull request)
Category:
Patch by: [github.com profile] anall
Description: I asked Dre how to describe this. Dre says "black magic", and also "it makes things easier for developers."

Issue 1219: t/atom-post.t is broken (pull request)
Category:
Patch by: [github.com profile] kareila
Description: This only really affects developers: some config options were tweaked so as to provide the output expected by automated tests, so running tests in dev environments now works.

Issue 1220: t/post.t is broken (pull request)
Category:
Patch by: [github.com profile] kareila
Description: This is another one that only really affects developers, but if you want the details: remote users are no longer permitted to post to an alternate personal account while logged in, so now the tests for that functionality are failing. This is deliberate, so failing tests aren't helpful, so they've been removed.

Issue 1229: Allow "Use the time when entry is posted" to be set as default (pull request)
Category: New Post Entry Page
Patch by: [github.com profile] woggy
Description: Via [site community profile] dw_suggestions. Given that the option to use the time when the entry was posted (rather than the time when the post started being composed) exists, it'd be nice if users could set that as the default. So now if you check "Use time when entry is posted", that'll get remembered and it'll be checked next time you load up the create entries page.

Issue 1231: Make the landing page after you post an entry be more useful (pull request)
Category:
Patch by: [github.com profile] woggy
Description: Again via [site community profile] dw_suggestions! When you get told that you've successfully posted an entry, you're given some information. Woggy's increased the amount of information you're given: in addition to being informed that the entry's posted, you'll now also be given the post security level and the entry's subject, whether you're using the current create entries page or the new beta.

Issue 1232: Add a link to view the message to the "Message sent" page (pull request)
Category:
Patch by: [github.com profile] woggy
Description: Again via [site community profile] dw_suggestions! When informed that you've successfully sent a message, you'll now be given a link to view the message you've just sent (just like when you've successfully made a post, you're given a link to view the entry).

Issue 1279: banning a user does not remove them from your profile (pull request)
Category:
Patch by: [github.com profile] kaberett
Description: If you've banned a user, their name will no longer appear on your profile regardless of whether you are in one another's circles (subscriptions or access granted in either direction).

Issue 1284: convert journal search page from BML to TT (pull request)
Category: BML Conversion
Patch by: [github.com profile] kareila
Description: As mentioned, one of the ongoing projects is to replace old-style BML with more modern and flexible code. This is another page down!

Issue 1292: Don't sandbox iframes (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Sandboxing iframes - making it so that if they catch fire, they can't set everything else on fire - is nice in principle, but in practice if you're overzealous about the extent of sandboxing you end up with an environment in which nothing at all can grow; if you will, an enormous parking lot as firebreak for the tiny useless fire that used to be a bush in its centre. Specifically, the sandboxing was so enthusiastic that embeds that should have worked (particularly embeds containing plugins, like old youtube videos) didn't; rather than add an enormous list of exceptions, the whole lot's been torn out.

Issue 1293: Handle redirects from no ending slash -> ending slash (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Some site URLs didn't work with a trailing slash at the end, but it wasn't immediately obvious to users (without going digging in directory structure) why some URLs did and some didn't. This adds redirects, so regardless of whether you type in an ending slash Things Just Magically Work.

Issue 1294: ?mode=reply has discrepancies in HTML cleaning (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Replying from an entry page versus replying from the ?mode=reply page (opening up the reply link in a separate window, so you have only the comment you're replying to and the reply box displayed) gave access to different sets of usable HTML tags. This was a sad, sad time, and has now been rectified - the same HTML is available everywhere.

Issue 1295: Use indexOf instead of startsWith for browser compatibility (pull request)
Category:
Patch by: [github.com profile] afuna
Description: This is Javascript. More browsers know what to do with indexOf than startsWith - it's more commonly supported - so this change makes display work better. Specifically, it means that tagnav arrows stay where they ought to be!

Issue 1298: HTML cleaner should autoclose table tags (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Table row and table column tags weren't getting autoclosed if you forgot to, when HTML was cleaned up before posting. This could lead to some funky display issues, but is now fixed!

Issue 1301: Fix t/clean-* tests to account for changes to tag closing (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Another one that mostly affects developers! Tests are a good way to make sure that code changes don't break everything. Changing how tags close mean that the desired behaviour has changed, which means that the behaviour expected by tests should change.

Issue 1302: Close self-closing tags that aren't valid self-closing (pull request)
Category:
Patch by: [github.com profile] afuna
Description: If you're writing a bulleted or numbered list, the tag <li /> creates a list item (bullet or number) and then closes itself automatically. However, if you write <em /> to get italic text, that doesn't have an obvious place to close itself and indeed can't close itself - so browsers just interpret it as an opening tag. This change makes sure that if an HTML tag has been written to close itself but isn't actually capable of doing so, the HTML cleaner spots this and makes sure it doesn't eat the rest of the page in a mess of eternal italic.

Issue 1303: investigate report of wandering tagnav element (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Some tagnav elements didn't stay where they were told to, but went off on merry adventures across the page. They have now been nailed to the metaphorical floor and will behave better in future.

Issue 1304: Create Entries beta: Custom filters doesn't work in lynx site skin, posts entry privately (pull request) (nonfree pull request)
Category:
Patch by: [github.com profile] afuna
Description: It's nice to let people use their custom access filters when posting, even if they're using the lynx site skin and the Create Entries beta page! And now they can. Or will be, when this goes live.

Issue 1307: fix HTML tags being mismatched after doing LJ::html_trim (pull request)
Category:
Patch by: [github.com profile] afuna
Description: More fun and games with the HTML cleaner! Some tags don't need closing, but attempting to make sure all open tags were closed ended up in some cases with a stack of closing tags that were entirely surplus to requirements. This means mismatched HTML tags get handled much better when tidying up.

Issue 1311: Strip views/admin/capedit.tt, fix filename in header comment (pull request)
Category:
Patch by: [github.com profile] pauamma
Description: Displayed text on Dreamwidth is a sprawling eldritch horror. Static text shouldn't be hardcoded into the page; it should be slightly abstracted for better maintainability and much greater ease should translations be required. That's now true for this page, and a typo in a comment in the code has also been corrected.

Issue 1313: hovering over icons posted in comments/entries no longer triggers ctxpopup (pull request)
Category:
Patch by: [github.com profile] afuna
Description: The format of the URL for icons changed. However, icons linked to via old-style URLs should still display the contextual hover menu if the user has that option enabled; this fix makes sure that's the case, because more information is better information.

Issue 1314: spam report on D&P account causes error (pull request)
Category:
Patch by: [github.com profile] kareila
Description: Spam reports are useful! Spam reports make the site more pleasant and spammers less happy. We care about spam reports even if they were left by accounts that have subsequently been deleted and purged. The spam-whackers can now make use of this information, rather than being faced with a thorny and impassable hedge of errors, should someone make a report and then delete-and-purge their journal before it can be dealt with. And thus! The land was free(r) of spam.

Issue 1315: spamreports by IP does not recognize IPv6 IPs (pull request)
Category:
Patch by: [github.com profile] kareila
Description: IPv6 (as opposed to IPv4) has rolled out enough at this stage - it's shiny and new - that spam is starting to roll in with IPv6 IP addresses. Unfortunately, the page for managing spam reports was set up in such a way that IPv6 IP addresses were considered not to exist, which made dealing with IPv6 spammers... tricksy. But lo, the code has been updated, and now the spam whackers can whack away to their hearts' content.

Issue 1316: Finish stripping views/admin/rename.tt (pull request)
Category:
Patch by: [github.com profile] pauamma
Description: Like #1312, sometimes the way static text works on the site is a sprawling horror that needs siphoning off into its own enclosure. More of its own enclosure happened here, with appropriate exercise equipment and adequately robust fencing.

Issue 1323: break LJ/User.pm into submodules
Category:
Patch by: [github.com profile] kareila
Description: User.pm is a chunk of code that deals with how user accounts are generated, and most of their other attributes. Consequently it is an enormous pile of misc that's nearly ten thousand lines long, which is definitely long enough to require a table of contents and some organisation imposed on top of the sort of the cumulative pile of things that were good ideas at the time. Kareila kindly made that happen, and it's now much friendlier to navigate and get to know.

Issue 1326: move user methods and functions into submodules (pull request)
Category:
Patch by: [github.com profile] kareila
Description: More refactoring to make Things To Do With Users easier to get one's head around and generally tidier and more manageable!

Issue 1332: add title text for the tagnav image (pull request)
Category:
Patch by: [github.com profile] me-and
Description: Images should have title text that describe them either on hover or if images are disabled or unavailable for whatever reason. The tagnav image didn't initially have a text description; now it does.

Issue 1340: convert-to-points system does not distinguish between "hasn't been 30 days since last conversion" and "not enough time to convert" (pull request)
Category:
Patch by: [github.com profile] kareila
Description: Dreamwidth Points are the currency with which one buys paid time, icon slots, rename tokens, and so on. It's also possible to convert paid time back to points, in the event that you decided you wanted to spend them on something else. However, there's a couple of situations in which that's not an option: if it's less than thirty days since you last converted time to points, or you've less than thirty days of paid time left on your account. These situations are importantly and relevantly distinct, but alas the error message you received was the same in both cases... until this fix.

Issue 1342: Mood themes aren't https (pull request)
Category: HTTPS Everywhere v2
Patch by: [github.com profile] anall
Description: DW is in the process of switching over to using HTTPS everywhere! This means that mood theme images need to be HTTPS-hosted in order not to break HTTPS-everywhere on reading pages. This does that.

Issue 1343: Beta update: sticky entry getting unstickied when edited (pull request)
Category:
Patch by: [github.com profile] woggy
Description: This one only affected users who have opted in to the new Create Entries beta and who were editing a sticky post and had hidden the module that contains the "make entry sticky" checkbox. Because! Prior to Woggy's intervention, the absence of a check box was interpreted as the box being unchecked, so editing a sticky entry with the module hidden resulted in the entry no longer being sticky without you telling it to, which was unfortunate!

Issue 1344: Fix Google Docs spreadsheet embeds (pull request)
Category:
Patch by: [github.com profile] me-and
Description: It's possible to embed lots of different manner of item: youtube videos, vines, and so on. But sometimes you want to embed a GoogleDoc, and sometimes what you want to embed is a spreadsheet, and that now works with all URLs that point at any given document that Google will accept.

Issue 1345: "Insert" button to insert image on RTE no longer exists (pull request)
Category:
Patch by: [github.com profile] kareila
Description: The Rich Text Editor update page allows you to insert images. Until relatively recently, there was an "Insert" button on this, and then it accidentally disappeared. It was still possible to insert images using the RTE - you had to hit enter - but this was unclear and unintuitive, and so the button has been restored to all its former glory.

Issue 1346: Planet Caravan style: gap between bottom of entry userpics and border
Category:
Patch by: [github.com profile] momijizukamori
Description: The switch to HTML5 appears to have caused some oddities with whitespace in styles. Momiji got rid of the excess whitespace in Planet Caravan style.

Issue 1349: fix issues with test config (pull request)
Category:
Patch by: [github.com profile] kareila
Description: Another one that's only really relevant to developers! There were a few minor warnings kicked up when a new test environment was rolled out; this makes those go away by making the default config behave as the tests expect.

Issue 1350: Fix some tests (pull request)
Category:
Patch by: [github.com profile] kareila
Description: ... and more or less the same is true of what's going on here. Some tests weren't behaving as intended; now they are. Again, this is only of relevance to developers.

Issue 1353: Unable to edit image properties in certain RTE use cases
Category:
Patch by:
Description: If you copied and pasted an image into the Rich Text Editor, you couldn't use the image properties pop-up to edit things like the alt text - which is not what was intended! Full fuctionality has now been restored.

Issue 1358: remove ecphash code (pull request)
Category:
Patch by: [github.com profile] kareila
Description: There was some dead code that was no longer used and therefore no longer needed to exist (to do with submitting comments via forms from HTML e-mails, which Dreamwidth... doesn't use). The code machete was applied. WE WILL DINE WELL TONIGHT.

Issue 1360: FAQ 199 needs update for multiple sticky
Category:
Patch by:
Description: FAQ update! Dreamwidth introduced the ability to have multiple sticky posts; the feature update meant documentation describing it was needed. And lo, documentation was provided.

Issue 1363: tagnav memory doesn't handle special-characters (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Navigating using the tagnav links is intended to 'remember' which tag you had selected, so that you can flip easily through a series of posts with given tag regardless of what else they're tagged with. However, when the tag in question contained e.g. spaces, asterisks or square brackets, the new page did not remember the tag selection and it had to be reselected: tedious and time-consuming. That's now easier!

Issue 1366: Narrow down the range of the cuttag selector (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Sometimes you copy-paste text that contains CSS designating something a cut-tag, if for example you're copying text having expanded a cut tag inline. It's for the best if this doesn't end up accidentally breaking whereever you paste it, so this reduces the amount of text affected.

Issue 1372: Remove extra underlines from tag list module in Tectonic (pull request)
Category:
Patch by: [github.com profile] momijizukamori
Description: Porting custom CSS originally designed for LJ requires having a think about what effect changes the Dreamwidth codebase has made might have on the style. Hierarchical lists did not play nice; Momiji made things prettier.

Issue 1381: Proxy causes system to run out of file descriptors when left running too long (pull request)
Category:
Patch by: [github.com profile] afuna
Description: Under some slightly obscure circumstances, images linked to from entries wouldn't display. Now they do!

Issue 1384: Have a more descriptive UTF-8 error (pull request)
Category:
Patch by: [github.com profile] me-and
Description: There's been a recent spate of people having problems with odd character encoding issues when trying to update, and the site's been giving them slightly incomprehensible errors to do with UTF-8. The error text's now been updated with a suggested fix, to make it easier for people to fix the problem themselves without having to go via Support.

Issue 1385: PALIMG files don't go under https (pull request)
Category: HTTPS Everywhere v1
Patch by: [github.com profile] afuna
Description: PALIMG files are images that can be recoloured on the fly to suit site scheme and what have you - they're used in the control strip and in a few layouts. As discussed elsetour, Dreamwidth is aiming for HTTPS everywhere, and as things were set up that wasn't an option for this type of file. BUT NOW IT IS and they are, HURRAH.

Issue 1389: if given a proxy URL for an image, find entries the image it's proxying appear in (pull request)
Category:
Patch by: [github.com profile] afuna
Description: This one's useful for DMCA requests and the like, mostly from the admin side of things. If a takedown request is sent in, it's helpful to be able to find everywhere on the site the image in question appears.

Issue 1390: if given a proxy URL for an image, need to be able to remove the image at that URL from the proxy
Category:
Patch by:
Description: ... and this is related. Having found all copies of the image (via the Dreamwidth proxy), stop acting as a proxy for traffic through to it!

Issue 1391: Remove extra whitespace below icons caused by HTML5 (pull request) (nonfree pull request)
Category:
Patch by: [github.com profile] momijizukamori
Description: ... is exactly like the fix for Planet Caravan, above. Hurrah for prettier styles!

Issue 1398: Admin Console Reference missing CSS styling (pull request) (nonfree pull request)
Category:
Patch by: [github.com profile] me-and
Description: Dreamwidth has an admin console that permits you to carry out various actions (banning and unbanning, in most cases; plus a bunch of more esoteric commands). The necessary commands are listed in the Admin Console Reference, understandably enough, and for many years it was the case that each command in the reference guide was styled so as to indicate visually whether you, the user, were permitted to execute it. Because of reasons the styling got lost; it's now been reintroduced for greater clarity.

Issue 1400: Ban and Unban Accounts page undiscoverable
Category:
Patch by: [github.com profile] kaberett
Description: Tracking down the page via which you could ban and unban accounts (and view the list of users you'd banned) was something of an undertaking; it's now additionally linked to from the Manage Circle page!

Issue 1407: siteskins.blueshift.alt contains typo (pull request)
Category:
Patch by: [github.com profile] kaberett
Description: There was a typo in a description of a site scheme usable on Dreamhacks. There is no longer that specific typo in the description of that site scheme!

Issue 1414: (Bug 1046) Convert Support High Scores Page to TT (pull request)
Category:
Patch by: [github.com profile] hotlevel4
Description: This is another getting-rid-of-BML fix! Newer, shinier Support High Scores page (listing who's helped how much with support requests).

Issue 1415: Fix alignment issues in the entry actions (pull request)
Category:
Patch by: [github.com profile] afuna
Description: The set of buttons for add a memory/edit an entry/link to an entry/reply to an entry were not, in all cases, properly aligned. Now they will be!

Issue 1417: Add shorter sitename options to username tag (pull request)
Category:
Patch by: [github.com profile] kaberett
Description: The <user name=""> tag just got shorter to use! In addition to site="http://livejournal.com" (for example), you can now use common abbreviations (in the case of LJ, site="lj" and site="livejournal" now work). The same's true for deadjournal, insanejournal, and so on -- updated documentation coming soon...

Issue 1420: More fixes for overlaying cgi-bin (pull request)
Category:
Patch by: [github.com profile] anall
Description: This tidies up back-end code to make everything more maintainable and better-organised.


Contributors (first-time starred, and welcome to them!): [github.com profile] afuna, [github.com profile] anall, [github.com profile] fhocutt, [github.com profile] hotlevel4, [github.com profile] kaberett, [github.com profile] kareila, [personal profile] phidari, [github.com profile] me-and*, [github.com profile] momijizukamori, [github.com profile] pauamma, [personal profile] timeasmymeasure, [github.com profile] woggy

... AND NOW TO THE SECOND ROUND.
ghoti: fish jumping out of bowl (Default)

[personal profile] ghoti 2015-06-25 06:47 pm (UTC)(link)
*cheers for 1315*
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2015-06-26 12:58 am (UTC)(link)
1229, the bikeshed has two colors! XD
erika: (Default)

[personal profile] erika 2015-06-26 02:50 pm (UTC)(link)
Pretty sure 1343 hit me. Yay woggy!
brainwane: My smiling face in front of a brick wall, May 2015. (Default)

[personal profile] brainwane 2015-06-27 02:25 pm (UTC)(link)
Thanks for the Allow "Use the time when entry is posted" to be set as default improvement - I bet I will benefit from this!
brainwane: The last page of the zine (cat)

HTTPS yay!

[personal profile] brainwane 2015-06-27 02:26 pm (UTC)(link)
I am so so grateful to y'all for the work you are doing to help me feel safe interacting with Dreamwidth when I'm on unsecure wifi networks. I appreciate it thoroughly; thank you.
turlough: art of Party Poison making heart-heands ((mcr art) *heart*)

[personal profile] turlough 2015-06-27 05:37 pm (UTC)(link)
So much love for 1229!!!
marahmarie: Sheep go to heaven, goats go to hell (Default)

[personal profile] marahmarie 2015-06-28 04:15 pm (UTC)(link)
Cheers for Issue 1415!

Outside of long comment threads over-narrowing this was the second-hardest issue for me to deal with from a styling perspective. I managed to subdue the issue (pretty much) using CSS edits (after spending literally years trying to figure out exactly what those edits should be) so hopefully this will uh, align things much better from now on.