Code tour for July 13 - August 10 2014

[azurelunatic]

This tour is a group effort. Thanks to kareila for rounding up and coding all the issue links! I provided the descriptions.

Here we have a lot of fixes for styles issues, and a lot of stuff from fu! This is a more prompt release than some, because everybody was really anxious to get some of the mobile wonkiness introduced with the last update fixed in this one. We also have stuff from denise, mark, hotlevel4, and exor674.

This code tour is live: the code push entry is over in dw_maintenance as usual.


Issue #790:
Make Bases automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: When Bases notices you have a "smaller" screen, it should now make sure that the entry takes up the full width, rather than cramming menus and stuff in alongside.

Issue #789:
Make Abstractia automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Also Abstractia.

Issue #787:
Number of items skipped in search results no longer displayed

Fix by: fu
Description: Fixing a bug where a site search wouldn't say which page of results it was on.

Issue #843:
add more labels to the issue tracker

Fix by: fu
Description: Administrivia related to the Dreamwidth developers' move to Github. If you're currently a developer, want to get back into Dreamwidth development, or are interested in trying it out, you can wander over and take a look through the labels to find unclaimed bugs that are most wanted, likely to be beginner-friendly, or both!

Issue #832:
Remove module-jump-link

Fix by: fu
Description: People have spoken: on most styles, the "jump to modules" link just gets in the way. (It's still around on the Mobility style.) If you miss it, let us know (dw_maintenance is probably the best place), but the guess is that most people won't miss it.

Issue #836:
Turn off IE9 compatibility mode so that media queries work

Fix by: fu
Description: IE9 started acting funky and refusing to display the sidebar in some cases. fu has put the kibosh on the funk, allowing the sidebar to resume its rightful place.

Issue #837:
LJ::format_mail doesn't parse @username as markdown

Fix by: fu
Description: In case you like to email in entries but can never remember how to make usernames work, you should now be able to say, for example, @fu and get fu.

Issue #841:
Too large images and embeds on mobile break out of entry

Fix by: fu
Description: Big image. Little screen. Broken page. We should handle this better now, by trying to detect when a big image and little screen run afoul of each other on the reading page, and force the image down to the width of the entry. Let us know if this gets weird.

Issue #838:
use generate_medium_media_query()

Fix by: fu
Description: One of the component steps of helping to handle stuff sensibly on small, medium, and large screens.

Issue #868:
Option to disable mobile view on a per-device basis

Fix by: fu
Description: If mobile view screws everything up on your iPod, you can turn it off there, without affecting the Android which you have logged in to the same account, which needs mobile view in order for everything to not be terrible. Or the other way around.

Issue #834:
background color to all comments

Fix by: fu
Description: So despite everyone's best efforts, sometimes the comment text spills out of where it's supposed to be and tramples over the flower beds rest of the journal background. And when the rest of the journal background is nearly the same color as the text, it becomes hilariously unreadable, and select-to-read doesn't work half as well on mobile, which (coincidentally) is where most of these shenanigans happen. This should make the comment-area background color do what it's supposed to do a little better.

Issue #882:
For the Bold: icon overlaps poster on collapse

Fix by: fu
Description: Don't you just hate it when threads collapse and suddenly the userpic gets way too friendly with the username?

Issue #884:
Motion: background not fixed-position

Fix by: fu
Description: Sometimes the background image should stay where you put it, darn it!

Issue #886:
Planet Caravan: icon overlaps title on collapse

Fix by: fu
Description: Don't you just hate it when the icon and the title get a little too friendly when the comment thread collapses?

Issue #887:
Planet Caravan: comment footer is fixed height

Fix by: fu
Description: The comment footer shouldn't take up excessive numbers of lines on big screens, nor should everything crowd into each other on small screens. Can we fix it? YES WE CAN!

Issue #883:
Modular: icon overlaps date on collapse

Fix by: fu
Description: Again with the icons going places they shouldn't when comments collapse.

Issue #879:
Drifting: journal title wraps poorly

Fix by: fu
Description: Even if your journal title is long, it should play nicely.

Issue #877:
Ciel: add rounded borders to .comment

Fix by: fu
Description: This fixes a bug where the comment field was intended to display with rounded borders, but actually didn't. Result: Ciel, now with rounded borders on the comments!

Issue #889:
Bases: .comment needs background

Fix by: fu
Description: If there's a text color, there should be a background color to go with it.

Issue #891:
Strata: entry footer is fixed height

Fix by: fu
Description: Flexible height footers handle different page sizes better.

Issue #890:
Strata: .comment needs background

Fix by: fu
Description: More background colors!

Issue #892:
Tectonic: one-column mode doesn't wrap modules

Fix by: fu
Description: Another day, another chunk of text that's decided to crawl off the edge of a small screen instead of wrapping around like the programmers intended.

Issue #861:
Create Entries beta: preview-after-poll either doesn't keep or doesn't display community name

Fix by: fu
Description: Sometimes a person wants to post a poll. Sometimes a person wants to post a poll to a community! Sometimes, even, that person would like to preview the poll. In the preview, it would make sense to show what community you've already picked... right?

Issue #830:
empty "next steps" after comm creation

Fix by: fu
Description: At some point, the back-end stuff that happened after someone created a community changed a little, and nobody noticed it. Now the information that was supposed to show up at that point should again.

Issue #822:
misspelling in /admin/capedit

Fix by: hotlevel4
Description: Most people are never poking around in the very back admin pages. So when there's a typo there, there is a very small set of people available to notice it and report it.

Issue #796:
Make Skittlish Dreams automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Another mobile-friendly style adjustment.

Issue #795:
Make Negatives automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Yes, a whole chunk of mobile-friendly style adjustments.

Issue #794:
Make Easyread automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: And another...

Issue #817:
Investigate breakpoint of layouts

Fix by: fu
Description: This one is a big one. After a whole lot of people said (and quite politely, too!) things amounting to "hey, your big plan to make mobile better? Made things worse for me, actually." Developers chatted about it, and the consensus was that there are basically three sizes of screen: large, medium, and small. So we're going to try to react sensibly to all three general sizes of screen.

Issue #793:
Make Drifting automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Back to specific-style screen size fixes.

Issue #792:
Make Brittle automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Brittle style name, but flexible design. ;)

Issue #791:
Make Blanket automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Another...

Issue #785:
Don't add subject back when editing a comment without a subject

Fix by: fu
Description: Comment subjects are lovely! Except, of course, when the subject of the comment above you doesn't apply to your comment, you don't feel like thinking up a new subject, and then you realize you made a typo and edit the comment -- and pop, there goes the subject line again. Requiring you to edit it again, if you missed it. But no more! Hooray!

Issue #777:
support notification emails don't include type of answer

Fix by: fu
Description: This one is for support folks who get support notification emails. It helps to know what sort of thing that notification was about: was it a message to fellow support folks, or was it the answer sent to the user?

Issue #22:
add a .gitattributes

Fix by: fu
Description: This was originally brought up in 2012. Now that we're using Github instead of Bugzilla, it has shown up again. This addition to the cross-operating system line endings war tries to make it irrelevant what operating system each developer is using. (If you've never heard of the cross-operating system line endings war, it can be summed up with the following quote: "The nice thing about standards is that you have so many to choose from." Tanenbaum was talking about networks when he said that, but it applies fairly globally.) (On a personal note, since I did my last code tour, I have switched from Notepad to Notepad++, which handles word wrap line endings vs. deliberate line endings so much better omg.)

Issue #714:
expand-all doesn't expand screened comments

Fix by: fu
Description: If you can see the screened comments, then "expand all" should work on those screened comments.

Issue #916:
add pinterest to usertag and profile

Fix by: denise
Description: Why debate about adding pinterest to be able to use <user name="" site="pinterest.com"> and list it on the profile, when denise could just implement it instead?

Issue #913:
IS_DEV_SERVER check on /admin/statushistory results in hella misleading behavior

Fix by: denise
Description: This problem basically only affected people trying to hack on the /admin/statushistory page (such as people resolving issue #857, below). I endorse D's use of "hella" in this context.

Issue #857:
add statushistory logging to new 'note' console command

Fix by: denise
Description: So while we were off at Open Source Bridge, D made a little treat for the spamwhackers: a "are you SURE you want to suspend this user??" note, for those users who get frequently reported but who are actually totes legit. Use of that tool should be logged in statushistory.

Issue #670:
/file/edit gives error message in unknown circumstances

Fix by: fu
Description: So basically when a couple people were testing something that wasn't ready for primetime, we must have hit like F5 or something, which resulted in some ghost entries in a specific back-end table. After a lot of banging on it, Fu tracked down the table and the problem, and now if you had problems loading http://www.dreamwidth.org/file/edit before, you should be able to! There may have been like five of us, including me. In related news, if you've been emailing images into your journal, and wanted to tweak the permissions, that's where you go to tweak them.

Issue #690:
Make DW-hosted image URLs track renamed-with-redirect accounts

Fix by: fu
Description: If someone with Dreamwidth-hosted images renamed their account, the images would break because they were at the same place with the new journal name, but the entries were still pointing to the image saved with the old username. This fixes that, so you don't have to go back through various entries to edit them anymore if you rename. Unless you're looking to eradicate all traces of your old name, in which case more power to you, and swift editing.

Issue #920:
"Last Used" does not update on http://www.dreamwidth.org/oauth/

Fix by: exor674
Description: exor674 does a lot of mostly unsung hard work on the back end, on places most users will never see. She's been working on a lot of oauth back-end. Oauth is one of those services that lets various applications do things without you having to give them your password. This is one more step closer to having various applications being able to do that for Dreamwidth. This particular step will let you see when any given application last accessed your account (in case there was any question, or you were curious). Currently there's nothing interesting on the page, but someday there might be!

Issue dw-nonfree#74:
Remove some auto-tags, given the issues redesign

Fix by: fu
Description: Everybody stand back. fu is on the job. Related to issue #843: now that the tags we're using in Github are different, that means the regular expression that automagically tags things needs to take that into account.

Issue dw-nonfree#65:
Make Sunday Morning automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Return of the one-column styling!

Issue dw-nonfree#66:
Make Transmogrified automatically fall back to one-column styling on smaller screens

Fix by: fu
Description: Another!

Issue #(none):
Fix for minimal set of system-installed libraries

Fix by: exor674
Description: A common programming problem is when you've got a whole whopping list of libraries that the code might use, but it's so hard to track down which of them are there because the programmer was being optimistic, which used to be in use but have been moved away from, and which are actually required. This marks the currently required libraries as required, as a favor to future developers. (Now, if we can just keep that up to date...)

Issue #(none):
Only add current status to the list of labels if we have the status

Fix by: fu
Description: The script automagically labeling new Github issues claimed it wanted the status of the issue. Son, we live in a world that has APIs, and those APIs are coded by real programmers. Those APIs have the luxury of not knowing what we know. And the existence of null tags, while grotesque and incomprehensible to that API... fu had neither the time nor the inclination to deal with the problems caused by sending a null tag to the API, so she made sure the script didn't do that.

Issue #(none):
Insert JS-injected control strip to the *top* of the page

Fix by: fu
Description: It gives the CSS a lot less work to do when the thing that appears at the top of the page on the site is also at the top of the page in the code.

Issue #(none):
Check in business stats

Fix by: mark
Description: Mark, who is by some arguments the most Interesting Man in the World, likes to live dangerously. This checks in some business statistics code that D's been looking at.

Issue #(none):
Turn off autocomplete on the date

Fix by: fu
Description: There have been some instances of the same date being used over and over again for new entries. Our best guess is browser autocomplete. So since there is very little reason for browser autocomplete to be used on a field meant to represent the current date (as one cannot step into the same river twice), we're compelling the browser to stop letting that field autocomplete. If that was happening to you, see if it's still happening (and you may need to clean out some cached stuff from the autocomplete settings).

Comments

[liv]

Sorry to be that person but: you've left out my patches from this code tour:
Issue #839:
Expose breakpoint variables in wizard, and the same for non-free layouts.

I'm saying this partly because I am vain and want to see my patches in the code tour, but mainly because this is a fix that quite a lot of people have been asking for: the ability to completely turn off any sort of re-scaling of pages for smaller screens. #868 allows turning off the responsive stuff for a particular device, but my patch allows it for a particular layout. As well as turning it off you can keep it but change the definition of what counts as a "small" screen.

[exor674]

Don't be afraid to be that person! We're still in a weird state of flux with these where our automatic generation tool hasn't been updated yet -- and humans are not perfect!

[denise]

It wasn't included because the issue wasn't closed -- it'll be included in the code tour that comes after it is. (We don't run the code tour off commits, we run the code tour off closed issues. Only way to keep track without losing stuff.)

[batrachian]

YAY I CAN READ DREAMWIDTH ON MY PHONE AGAIN! :D :D :D

Don't know which of these bugs fixed my particular use case, but y'all rock.

Minor quibble, though, as I'm writing this; the Subject and Message boxes for a reply are overflowing out of the column area. They're not stretching the layout or page any, but it does look...marginally messy.

[larissa]

#785: bless you. It was the littlest thing but it was a huge pet peeve of mine and I'm so thrilled to see it fixed. Thank you!