Code Tour 8th January - 1st March, part 3

[foxfirefey]

Incoming delayed but FINALLY here! Read Part 1 and Part 2 if you haven't so you can get to--

Part 3: 31 more bugs!

Bug 2873: Styles: add new one-column mode to allow modules to go either above or below entries
Category: Style System
Suggested by: ninetydegrees
Patch by: ninetyd
Description: The results of this bug have been in effect for a while; it adds a layout mode with one column that has module areas above and below entries. In the customize area, you can find this option on applicable layouts (the majority with a 1 column mode) as "1 Column (modules at top and bottom; no sidebar)".

Bug 2629: Misc. Layouts: hard-coded font faces into the CSS
Category: Style System
Patch by: ninetyd
Description: Some styles had fonts that couldn't be modified in the wizard. ninetyd went through most of these, fixed the problem, and opened another bug for the remaining incident.

Bug 3398: Styles: add option to customize side margins in all styles
Category: Style System
Suggested by: ninetydegrees
Patch by: ninetyd
Description: This bug adds a wizard option to customize side margins in a bunch of styles, and we opened bugs for the remaining styles and closed this one.

Bug 3481: Add web counter function to core2 styles
Category: Style System
Suggested by: rydra_wong
Patch by: denise
Description: We noted that instead of adding a web counter, people can add HTML content into web counter functions. So instead of changing any code, we made this FAQ.

Bug 1033: Implement simple way to post pictures via email
Category: Misc Backend
Patch by: mark
Description: This bug has been implemented for a while, and there's a lot of work left to do, but the site now does what it says on this bug's tin, so it could be closed.

Bug 3362: include documentation about prepaid cards
Category: User documentation
Patch by: denise
Description: Prepaid cards can be tricky to make purchases with; we made a FAQ explaining what we know about them.

Bug 3133: Implement incremental indexing for search
Category: Search
Patch by: mark
Description: So, we made some efficiency improvements to site search a couple months of them, and one of them was to make it so that new content got indexed every fifteen minutes or so. It's a lot more efficient than reindexing everything each pass! That solved this bug, but we only closed it during our big sweep!

Bug 4289: New Style: Abstractia by chiming
Category: Style System
Patch by: chiming
Description: Abstractia is a layout that's been on the site for a long while now! The bug was open to collect any bugs to fix for it, but we haven't seen any in a year, so it's safe to close this and open up new bugs if they found.

Bug 714: MX record for *.hack.dreamwidth.net
Category: Configuration
Patch by: mark
Description: The dreamhacks needed a proper mail service record!

Bug 2026: Sorting styles by date added.
Category: Style System
Suggested by: jaeger
Patch by: none
Description: We figure the "Newest" category for styles fulfills this need at the moment.

Bug 1632: 32bit support
Category: APIs: RPC/XML/Flat
Patch by: Frank Precissi and others
Description: Dreamwidth is optimized for 64bit systems, but some people would like to run the codebase on 32bit servers. A patch a long time ago addressed some of these issues, and no more have been reported for a while, so we're closing the bug. Any additional problems running it on 32bit servers will need a new bug!

Bug 1504: Profiles with lots of subscribers don't load
Category: Misc UI/Frontend
Patch by: mark
Description: This had been tweaked a long time ago--some profiles, such as say dw_news have SO many subscribers the system chokes and dies if it has to load them all on the profile page. So, we have a listing of accounts that don't list all subscribers. The bug was open for English stripping, but we decided that we're not going to focus much on difficult English stripping until someone is actually trying to make a completely translated service.

Bug 911: Sidebar covers up the entry when there is wide entry content
Category: Style System
Patch by: av8rmike
Description: So, some styles had a problem where wide entry content (such as a huge honking image) would get covered up by the sidebar. That's not necessarily wrong, but we made sure the content went over the sidebar in Negatives and Transmogrified. This happened ages ago, and no new complaints have happened about the subject, so if other layouts need fixing new bugs will need to be opened for them.

Bug 4669: Support FAQ dropdown not showing categories
Category: Support
Patch by: exor674
Description: At some point, we broke something in the support form and categories didn't show up anymore in the dropdown for FAQs.

Bug 4422: Customize: reorder some options
Category: Style System
Patch by: ninetyd
Description: This is an older bug--it involved a lot of option reordering for the style wizard, to put things in better sections and more understandable orders.

Bug 4398: Style journal views and enable style=site as an option in settings, and add it to the navigation strip on pages it is not on
Category: Style System
Patch by: foxfirefey
Description: So, this bug has some work done to make a lot of journal views work in site views. It still needs some work done, and then it was going to go up in the nav bar, but I neglected it for way to long and so the bug got closed during the big review and it was determined putting the switch option in the nav bar would be too much clutter, which is kind of embarrassing but a good lesson in not leaving things alone for too long!

Bug 4335: Convert all admin pages from BML to TT
Category: Misc Backend
Patch by: foxfirefey
Description: So, this bug was a pretty big meta bug. TOO BIG. Instead of having one big huge overarching bug, the ideal is to have smaller bugs for each section of the conversion.

Bug 4315: optimize viewing entries with large # of comments
Category: Misc Backend
Patch by: allen
Description: So, way back when, comments were very inefficient, or at least not as efficient as they should be for such a high load part of the site. allen, mark and fu put their heads together and allen did some magic to make things more efficient!

Bug 4224: QuickReply box is displayed using incorrect CSS
Category: Misc UI/Frontend
Patch by: sophie
Description: This bug did some work on fixing QuickReply CSS to work better; it's mostly been finished and any new problems can have their own bugs opened, and so we closed it as part of our great closening.

Bug 4201: ability to "claim" your OpenID and update imported posts/comments as coming from your DW account
Category: OpenID
Patch by: mark
Description: This is totally a feature now (claim YOUR OpenID!), and the last needed step had a new bug (Bug 4929) opened for it!

Bug 316: Implement Latest Posts feed
Category: APIs: RPC/XML/Flat
Patch by: mark
Description: This is the bug that gave us the latest page, where recent public posts go by! It's been long enough that it can be closed, and enhancements and other features for the Latest page can go into new bugs!

Bug 4672: "Transfer shop points" sounds awkward
Category: Payments
Patch by: denise
Description: "Transfer" is a bit more, er, clinical than using "send", so we rephrased.

Bug 4748: Bases: new themes
Category: Style System
Patch by: ninetyd and rising
Description: Four new themes for Bases by rising!

Bug 3472: "Back to Top" title link should be included in all Dreamwidth styles by default.
Category: Style System
Suggested by: marahmarie
Patch by: ninetyd and kunzite
Description: Part of the standardization march; some styles didn't include a back to top link by default, but we put them in.

Bug 4908: redirect after using admin/faq/faqcat goes to .bml version of page
Category: Site Administration
Patch by: denise
Description: A wee little fix! We're moving away from .bml and part of that is not having .bml on the ends of our URLs. denise found out that some admin pages forwarded to the .bml and fixed it just because she could.

Bug 4229: New Style: Motion by wiring
Category: Style System
Patch by: momijizukamori and syntheid
Description: WordPress in older versions has a very popular theme called Motion, and this is a translation of it to work with our Style System!

Bug 4937: Database: visited links not getting hover colors in entries
Category: Style System
Patch by: ninetyd
Description: ninetyd is really good about catching the little details. In Database, she noticed that visited links weren't changing to the hover color on hover. A little switching of lines in CSS was enough to fix that!

Bug 4845: subscribing to a comm gives incorrect text on the confirmation screen
Category: Communities
Patch by: ninetyd
Description: You can't give a community access to protected entries. That meant that the confirmation screen on subscribing to a community was giving wrong directions. There's now a short version of that text snippet for situations like these.

Bug 1867: Subscription Filters: create a module to display them as links
Category: Style System
Suggested by: ninetydegrees
Patch by: denise and foxfirefey
Description: The first part of this bug was done by denise and added a module on the home page. The second part was done by foxfirefey and added a module for the style system! The style module is optional. If you have public filters, it shows them to other users in this module. NOTE: This means people using a style with this module on your journal will be able to see any public filters you have, even if you don't have the module on your journal style.

Bug 4897: add hook for credit card checkout to include where charge will come from
Category: Frontend
Patch by: denise
Description: Hooks are places where people who run Dreamwidth code can add in their own custom things to happen in certain places. We added a hook for the credit card checkout for our own use: we now have a message reminding folks that if they are using someone else's credit card, to make sure and get their permission first. This is because denise keeps getting awkward angry phone calls from parents who don't know why this charge has showed up on their credit card statement!

Comments

[matgb]

#1867 Can we now make filters public then? Last I looked all mine were private and the option to change them wasn't there but I might have been looking at the wrong place.

[foxfirefey]

Yes you can! Go to the subscription filter page:

http://www.dreamwidth.org/manage/subscriptions/filters

Select a filter and look for Options for "Default"--this will let you specify the publicity and order of your filters! It could use a better UI, but that would be a much better project than the simple exposing of backend options that existed that I did.

[matgb]

Excellent, either that's relatively new or I completely missed it before, I like-the UI needs some work but it does the job. Danke.

[kaberett]

yaaaaaaaaaay thx xx

[jewelfox]

#1867 When will we be able to add this module to our styles? This is something I've been wanting and was thinking I'd have to use Custom Text for.

EDIT: Is it because I don't have any filters yet?

[azurelunatic]

A lot of filter stuff is *completely broken* if no filters exist. Like the tag-permissions thing, iirc.

[ninetydegrees]

This is not live yet. See this entry about the next code push to know when it'll be for you.

Edit: and yes, you will need to have subscription filters for the module to be displayed as there are checks in place to make sure empty modules aren't.

[owl]

So, this bug was a pretty big meta bug. TOO BIG.

GIANT BUG O' DOOOOOM!