patch review guidelines

[kareila]

My initial revision of Dev Reviewing Guidelines is up on the wiki. Check it over and see if it looks good.

Please consider being a code reviewer! It's way easier to test code than it is to write it, but for some reason we always seem to have a backlog of unreviewed patches sitting around. If patches go through peer review, that reduces the workload of the handful of developers with commit access.

Comments

[exor674]

"Make sure the commit flag on the patch is set to '?' so that it shows up in the queue of commit requests."

Sometimes the patch maker will make a patch intentionally w/o commit?, so the reviewer shouldn't set it

Reviewing patches

[cesy]

There are some very cool things sitting in the queue for review, but most of them I don't understand enough to be confident reviewing. Is there a way of doing a "looks okay on preliminary review, but someone who knows more than me should probably check it"?